Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4532/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 05:05:06 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/bXz7b4QjYLLHkvhc7 : SUCCESS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:49:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8695/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:48:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4532/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:48:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9874/ (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:45:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/696/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5898/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:45:00 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5939/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6138/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:45:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5917/
 (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6499/ (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:45:04 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Shiva Jahangiri (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#2).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
3 files changed, 306 insertions(+), 208 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1190/
 (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:45:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/857/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:57 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1284/
 (15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:45:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6288/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:51 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3925/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:52 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11408/ (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:59 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6080/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:52 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1095/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:51 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5835/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Wed, 12 Jun 2019 04:44:51 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8694/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 23:18:31 +
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-2458) Compilation exception when if_null(), if_missing(), if_missing_or_null() are provided with certain kinds of arguments

2019-06-11 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861565#comment-16861565
 ] 

ASF subversion and git services commented on ASTERIXDB-2458:


Commit 01423da8a2c006706a89e21e852799eae33d35ef in asterixdb's branch 
refs/heads/master from Ali Alsuliman
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=01423da ]

[ASTERIXDB-2458][COMP] Fix min/max functions with group by

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
In a sort-group-by operator, an aggregate function has a merging
aggregate function that will be used when merging the run files
if they were generated. The merging aggregate function of the local
min/max aggregate function should be different from the merging
aggregate function of the global min/max. For local min/max, the
merging aggregate function should propagate system_null if the
aggregation is system_null. Also, the global min/max should handle
finishPartial() different from finish(). finishPartial()
should not output NULL if the aggregation is system_null since the
aggregation is still going on.

- added functions to be intermediate steps for local aggregation.
- implemented logic for finishPartial()
- added test cases for strict_min/max with group by

Change-Id: Ie0551b091b9adbbbd51158dbd36124a7184bdce0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3434
Contrib: Jenkins 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Ali Alsuliman 
Reviewed-by: Dmitry Lychagin 


> Compilation exception when if_null(), if_missing(), if_missing_or_null() are 
> provided with certain kinds of arguments
> -
>
> Key: ASTERIXDB-2458
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2458
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: FUN - Functions
>Affects Versions: 0.9.3
>Reporter: Ali Alsuliman
>Assignee: Ali Alsuliman
>Priority: Major
> Fix For: 0.9.4.2
>
>
> if_null(), if_missing(), if_missing_or_null() would throw compilation 
> exception for certain kinds of arguments. One example is if_null(int, 
> record). The cause is related to trying to cast the arguments to the type 
> that the function wants to return.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4531/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:26:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has submitted this change and it was merged. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..

[NO ISSUE][FUN] Remove unused scalar aggregates

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove unused function definitions for scalar global/local
  aggregate functions
- Cleanup testcases for avg function
- Removed unused testcases

Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3429
Contrib: Jenkins 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Tested-by: Dmitry Lychagin 
Reviewed-by: Ali Alsuliman 
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.3.query.sqlpp
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_01/avg_empty_01.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_01/avg_empty_01.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_01/avg_empty_01.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_02/avg_empty_02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.4.query.sqlpp
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_nu.2.update.sqlpp
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.1.ddl.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.2.update.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32_null/avg_int32_null.1.ddl.sqlpp
M 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4531/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:09:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/zywNpUScjU5HBfm28 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:09:34 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8694/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:07:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5897/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5834/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6287/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:28 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5916/
 (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3924/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/856/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5938/ 
(5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6079/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:30 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1283/
 (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1094/ (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1189/
 (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11407/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6137/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9873/ (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:24 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6498/ (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: Ic6b80f7...

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin Change-Id: 
Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/695/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 22:05:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 21:53:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5: Verified+1


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 21:03:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5: Contrib+1

Analytics Compatibility Tests Successful
https://cbjenkins.page.link/VayLFMY635XX2AgVA : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 20:56:33 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8693/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 19:19:56 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4530/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:23:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5: -Contrib

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/Wm4MYfy7QWfZNHyv8 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:11:50 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4530/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:09:28 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6286/ 
(12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1282/
 (15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6136/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:19 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6497/ (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5896/ 
(11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9872/ (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:25 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8693/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:07:20 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5833/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Dmitry Lychagin (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3429

to look at the new patch set (#5).

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..

[NO ISSUE][FUN] Remove unused scalar aggregates

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove unused function definitions for scalar global/local
  aggregate functions
- Cleanup testcases for avg function
- Removed unused testcases

Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double/avg_double.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.3.query.sqlpp
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_double_null/avg_double_null.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_01/avg_empty_01.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_01/avg_empty_01.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_01/avg_empty_01.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_empty_02/avg_empty_02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float/avg_float.4.query.sqlpp
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_nu.2.update.sqlpp
R 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.1.ddl.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.2.update.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_float_null/avg_float_null.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16/avg_int16.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int16_null/avg_int16_null.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.2.update.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.3.query.sqlpp
C 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32/avg_int32.4.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32_null/avg_int32_null.1.ddl.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/avg_int32_null/avg_int32_null.2.update.sqlpp
M 

Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1093/ (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1188/
 (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:02 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3923/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11406/ (10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/855/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:09 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/694/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5915/
 (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:04 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6078/
 (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:05 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unused scalar aggregates

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3429 )

Change subject: [NO ISSUE][FUN] Remove unused scalar aggregates
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5937/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3429
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c1274876c884f16bcbee0e3f7aaba4d91b271ce
Gerrit-Change-Number: 3429
Gerrit-PatchSet: 5
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:06:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java:

https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@160
PS7, Line 160: // Validity of arguments
Do we have this behavior (only accepting whole numbers) for casting floating 
point to integer in other functions as well ?


https://asterix-gerrit.ics.uci.edu/#/c/3433/7/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java@169
PS7, Line 169: switch (valueTypeTag) {
Would it make sense to fold this in (i.e. set roundingDigit to 0 and run the 
code in line 207)?



--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 11 Jun 2019 15:47:38 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Hussain Towaileb (Code Review)
Hussain Towaileb has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7: Code-Review+1


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Hussain Towaileb 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 12:55:14 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8692/ 
: SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 12:53:46 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4529/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 12:01:25 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/k9NmoommCtEwWyx96 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:45:23 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4529/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:44:31 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/693/ 
(7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5936/ 
(5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/854/ 
(9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:13 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5895/ 
(6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:08 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5914/
 (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:12 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/1092/ (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:18 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6135/ 
(10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9871/ (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:17 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6496/ (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:21 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1187/
 (14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:22 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6285/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:24 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8692/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:42:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1281/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:26 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3922/ 
(3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:06 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/6077/
 (4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:07 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11405/ (2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:06 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5832/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:41:06 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Hussain Towaileb (Code Review)
Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3433

to look at the new patch set (#7).

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..

[ASTERIXDB-2584][FUN] Support rounding digit for round()

- user model changes: yes
  - user can pass optional 2nd argument to round() function
  to specify the digit to round to.
- storage format changes: no
- interface changes: no

Details:
- Added new descriptor for 2-arguments version of round().
- Converted evaluator class to named class, now used  by both
round() descriptors.
- Added test cases for 2-arguments version and invalid cases.

Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round10_with_digit_double/round10_with_digit_double.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round11_invalid/round11_invalid.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round5_with_digit_int8/round5_with_digit_int8.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round6_with_digit_int16/round6_with_digit_int16.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round7_with_digit_int32/round7_with_digit_int32.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round8_with_digit_int64/round8_with_digit_int64.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/numeric/round9_with_digit_float/round9_with_digit_float.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round10_with_digit_double/round10_with_digit_double.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round11_invalid/round11_invalid.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round5_with_digit_int8/round5_with_digit_int8.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round6_with_digit_int16/round6_with_digit_int16.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round7_with_digit_int32/round6_with_digit_int16.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round8_with_digit_int64/round8_with_digit_int64.1.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/round9_with_digit_float/round9_with_digit_float.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
A 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/NumericRoundFunctionTypeComputer.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundDescriptor.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundEvaluator.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/NumericRoundWithRoundDigitDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java
21 files changed, 685 insertions(+), 107 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/33/3433/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1280/
 (16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 6
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:21:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 6:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/HXpF2BYzPADXrD7d6 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 6
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:20:22 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 5:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/4aHLEYnyGwvWgY82A : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:17:15 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6284/ 
(8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 6
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:42 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6134/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 6
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN Support rounding digit for round()
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11403/ (13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 5
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:10 +
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2584][FUN] Support rounding digit for round()

2019-06-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3433 )

Change subject: [ASTERIXDB-2584][FUN] Support rounding digit for round()
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3921/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3433
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdde2745e8bc440556e45ed07262eb33327f842b
Gerrit-Change-Number: 3433
Gerrit-PatchSet: 6
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Tue, 11 Jun 2019 11:13:37 +
Gerrit-HasComments: No


  1   2   >