Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3459

to look at the new patch set (#5).

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

user model changes: no
storage format changes: no
interface changes: no

Details:

Separated buffer pool of hash table and hash join buffer managers
and added assertions and a few test cases to fix runtime bugs related
to hybrid hash join memory management.

Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FramePoolBackedFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/ISimpleFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
12 files changed, 1,036 insertions(+), 399 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/3459/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/3459
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
Gerrit-Change-Number: 3459
Gerrit-PatchSet: 5
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has removed Ali Alsuliman from this change.  ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Removed reviewer Ali Alsuliman.
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 14
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has abandoned this change. ( 
https://asterix-gerrit.ics.uci.edu/3435 )

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Abandoned
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 14
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3459

to look at the new patch set (#4).

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

user model changes: no
storage format changes: no
interface changes: no

Details:

Separated buffer pool of hash table and hash join buffer managers
and added assertions and a few test cases to fix runtime bugs related
to hybrid hash join memory management.

Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FramePoolBackedFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/ISimpleFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
12 files changed, 1,036 insertions(+), 399 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/3459/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/3459
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
Gerrit-Change-Number: 3459
Gerrit-PatchSet: 4
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3459

to look at the new patch set (#3).

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

The following commits from your working branch will be included:

commit 4bbf660a169713880791aba70c5885d8643f9a72
Author: Shiva 
Date:   Fri Jun 21 15:51:32 2019 -0700

[NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FramePoolBackedFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/ISimpleFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
12 files changed, 1,017 insertions(+), 398 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/3459/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3459
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
Gerrit-Change-Number: 3459
Gerrit-PatchSet: 3
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3459

to look at the new patch set (#2).

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

The following commits from your working branch will be included:

commit 4bbf660a169713880791aba70c5885d8643f9a72
Author: Shiva 
Date:   Fri Jun 21 15:51:32 2019 -0700

[NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/FramePoolBackedFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/ISimpleFrameBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
12 files changed, 1,017 insertions(+), 398 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/59/3459/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3459
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I22e71e57fce648a15e3d32759d9fb2cb9961d301
Gerrit-Change-Number: 3459
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has abandoned this change. ( 
https://asterix-gerrit.ics.uci.edu/3458 )

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..


Abandoned
--
To view, visit https://asterix-gerrit.ics.uci.edu/3458
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I9170efc1031f13fb3ec5ce7933ad49f181c63eab
Gerrit-Change-Number: 3458
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager and P...

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has abandoned this change. ( 
https://asterix-gerrit.ics.uci.edu/3421 )

Change subject: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager 
and PartitionsManager
..


Abandoned
--
To view, visit https://asterix-gerrit.ics.uci.edu/3421
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3f6d011f8af256b290cc28a04a412bcbd005920a
Gerrit-Change-Number: 3421
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has abandoned this change. ( 
https://asterix-gerrit.ics.uci.edu/3422 )

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..


Abandoned
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 16
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2577][RT]Save One frame per spilled partitions in hybrid h...

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has abandoned this change. ( 
https://asterix-gerrit.ics.uci.edu/3412 )

Change subject: [ASTERIXDB-2577][RT]Save One frame per spilled partitions in 
hybrid hash join
..


Abandoned
--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 8
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#14).

Change subject: [NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[NO ISSUE][RT][ASTERIX-2581]Refactoring OptimizedHybridHashJoin

user model changes: no
storage format changes: no
interface changes: no

Details:

Separated buffer pool of hash table and hash join buffer managers
and added test cases to fix runtime bugs related to hybrid hash join
memory management.

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
10 files changed, 972 insertions(+), 398 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/14
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 14
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#13).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[NO ISSUE][RT] Hybrid Hash Join refactoring

user model changes: no
storage format changes: no
interface changes: no

Details:

Separated buffer pool of hash table and hash join buffer managers
and added test cases to fix runtime bugs related to hybrid hash join
memory management.

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
10 files changed, 972 insertions(+), 398 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/13
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 13
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#12).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[NO ISSUE][RT] Hybrid Hash Join refactoring

user model changes: no
storage format changes: no
interface changes: no

Details:

Separated buffer pool of hash table and hash join buffer managers
and added test cases to fix runtime bugs related to hybrid hash join
memory management.

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
10 files changed, 968 insertions(+), 398 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/12
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 12
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#11).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[NO ISSUE][RT] Hybrid Hash Join refactoring

user model changes: no
storage format changes: no
interface changes: no

Details:

Separated buffer pool of hash table and hash join buffer managers
and added test cases to fix runtime bugs related to hybrid hash join
memory management.

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
10 files changed, 967 insertions(+), 398 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/11
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 11
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#10).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
10 files changed, 854 insertions(+), 399 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/10
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 10
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#9).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
9 files changed, 857 insertions(+), 396 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/9
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 9
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#8).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
9 files changed, 855 insertions(+), 394 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/8
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 8
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#7).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
9 files changed, 845 insertions(+), 394 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#6).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinTest.java
11 files changed, 822 insertions(+), 392 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#5).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/DeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IDeallocatableFramePool.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
7 files changed, 557 insertions(+), 385 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 5
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#4).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
3 files changed, 462 insertions(+), 334 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 4
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#3).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
3 files changed, 462 insertions(+), 334 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 3
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3435

to look at the new patch set (#2).

Change subject: [ASTERIX-2581]Refactoring OptimizedHybridHashJoin
..

[ASTERIX-2581]Refactoring OptimizedHybridHashJoin

Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
3 files changed, 306 insertions(+), 208 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/35/3435/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3435
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6b80f7256de968bbf1fe016e826c9bc7c0fd0f4
Gerrit-Change-Number: 3435
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#16).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartition.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionTest.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
7 files changed, 799 insertions(+), 214 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/16
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 16
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#15).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartition.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionTest.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
7 files changed, 798 insertions(+), 219 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/15
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 15
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#14).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartition.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
6 files changed, 572 insertions(+), 219 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/14
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 14
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#13).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartition.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
6 files changed, 572 insertions(+), 219 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/13
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 13
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#12).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartition.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
6 files changed, 572 insertions(+), 219 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/12
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 12
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#11).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
M hyracks-fullstack/hyracks/hyracks-dataflow-std/pom.xml
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartition.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
6 files changed, 554 insertions(+), 213 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/11
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 11
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#10).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
4 files changed, 305 insertions(+), 90 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/10
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 10
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#9).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
4 files changed, 305 insertions(+), 90 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 9
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2577][RT]Save One frame per spilled partitions in hybrid h...

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Till Westmann, Ali Alsuliman, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3412

to look at the new patch set (#8).

Change subject: [ASTERIXDB-2577][RT]Save One frame per spilled partitions in 
hybrid hash join
..

[ASTERIXDB-2577][RT]Save One frame per spilled partitions in hybrid hash join

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

During making space for hash join, we should make sure
there is one frame for each spilled partition before
starting the probe phase.

Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
1 file changed, 11 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/3412/8
--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 8
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager and P...

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3421 )

Change subject: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager 
and PartitionsManager
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3421/1//COMMIT_MSG
Commit Message:

https://asterix-gerrit.ics.uci.edu/#/c/3421/1//COMMIT_MSG@7
PS1, Line 7: Refactoring
> Let's avoid using continuous tense for the commit message and - if this is
Thanks. This change will get replaced by 
(https://asterix-gerrit.ics.uci.edu/#/c/3422/) to be done step by step and get 
tested.



--
To view, visit https://asterix-gerrit.ics.uci.edu/3421
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f6d011f8af256b290cc28a04a412bcbd005920a
Gerrit-Change-Number: 3421
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 04 Jun 2019 00:09:56 +
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2577][RT]One frame per spilled partitions

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3412 )

Change subject: [ASTERIXDB-2577][RT]One frame per spilled partitions
..


Patch Set 7:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG
Commit Message:

https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG@7
PS5, Line 7: [ASTERIXDB-2577]
> Please add a component (I think [RT] would be the right one here) following
Thanks. Added.


https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG@14
PS5, Line 14:
: During making space for hash join, we should make sure
: there is one frame for each spilled partition before
: starting the probe phase.
:
> If we have an issue in JIRA, it is better to describe the problem in JIRA a
Got it. Modified accordingly.


https://asterix-gerrit.ics.uci.edu/#/c/3412/5//COMMIT_MSG@18
PS5, Line 18:
> fixes?
Yes.Sorry.



--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Tue, 04 Jun 2019 00:08:09 +
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2577][RT]One frame per spilled partitions

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Till Westmann, Ali Alsuliman, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3412

to look at the new patch set (#6).

Change subject: [ASTERIXDB-2577][RT]One frame per spilled partitions
..

[ASTERIXDB-2577][RT]One frame per spilled partitions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

During making space for hash join, we should make sure
there is one frame for each spilled partition before
starting the probe phase.

Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
1 file changed, 11 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/3412/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3422 )

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..


Patch Set 8:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3422/4//COMMIT_MSG
Commit Message:

https://asterix-gerrit.ics.uci.edu/#/c/3422/4//COMMIT_MSG@7
PS4, Line 7: IXDB-2
> Let's avoid using continuous tense for the commute messages.
Got it. Thanks!


https://asterix-gerrit.ics.uci.edu/#/c/3422/4//COMMIT_MSG@7
PS4, Line 7: [ASTE
> If there's a JIRA issue for this, if'd be better to add this issue to this
Thanks. Sorry, it was not ready for the code review. I opened up the issue in 
Jira. It is still in progress.



--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 8
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Mon, 03 Jun 2019 23:58:27 +
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2581] Refactor hybrid hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#8).

Change subject: [ASTERIXDB-2581] Refactor hybrid hash join
..

[ASTERIXDB-2581] Refactor hybrid hash join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
4 files changed, 305 insertions(+), 90 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 8
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2581] Refactoring Optimized Hybrid Hash Join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#7).

Change subject: [ASTERIXDB-2581] Refactoring Optimized Hybrid Hash Join
..

[ASTERIXDB-2581] Refactoring Optimized Hybrid Hash Join

Currently the whole logic for optimized hybrid hash join
is implemented in two classes of OptimizedHybridHashJoin
and OptimizedHybridHashJoinOperatorDescriptor with no
unit test. This change will refactor these two classes
by dividing them to smaller modules and unit testing them.

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManagerTest.java
4 files changed, 305 insertions(+), 90 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 7
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Step1-Making partitionManager for hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#6).

Change subject: Step1-Making partitionManager for hash join
..

Step1-Making partitionManager for hash join

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
3 files changed, 155 insertions(+), 80 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Step1-Making partitionManager for hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Till Westmann, Jenkins, 

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#5).

Change subject: Step1-Making partitionManager for hash join
..

Step1-Making partitionManager for hash join

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
3 files changed, 153 insertions(+), 80 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 5
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Step1-Making partitionManager for hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#4).

Change subject: Step1-Making partitionManager for hash join
..

Step1-Making partitionManager for hash join

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
2 files changed, 71 insertions(+), 25 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 4
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Step1-Making partitionManager for hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#3).

Change subject: Step1-Making partitionManager for hash join
..

Step1-Making partitionManager for hash join

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
2 files changed, 71 insertions(+), 25 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 3
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Step1-Making partitionManager for hash join

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Ali Alsuliman, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3422

to look at the new patch set (#2).

Change subject: Step1-Making partitionManager for hash join
..

Step1-Making partitionManager for hash join

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
2 files changed, 70 insertions(+), 25 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3422
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
Gerrit-Change-Number: 3422
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Step1-Making partitionManager for hash join

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3422


Change subject: Step1-Making partitionManager for hash join
..

Step1-Making partitionManager for hash join

Change-Id: I7a5609f6709efa427769da33c3a3b93233984fd8
---
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
2 files changed, 69 insertions(+), 25 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/22/3422/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionManager.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionManager.java
new file mode 100644
index 000..59d90d6
--- /dev/null
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionManager.java
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hyracks.dataflow.std.join;
+
+import java.util.BitSet;
+
+public class HashJoinPartitionManager {
+
+private final BitSet spilledStatus; //0=resident, 1=spilled
+
+public HashJoinPartitionManager(int numOfPartitions) {
+this.spilledStatus = new BitSet(numOfPartitions);
+}
+
+public BitSet getSpilledStatus() {
+return spilledStatus;
+}
+
+public void setSpilledStatus(int pid) {
+if (pid >= 0 && pid <= spilledStatus.length()) {
+spilledStatus.set(pid);
+}
+}
+
+public void clearSpilledStatus() {
+spilledStatus.clear();
+}
+}
diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
index c78e0dc..e50b19a 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
@@ -56,6 +56,7 @@

 // Used for special probe BigObject which can not be held into the Join 
memory
 private FrameTupleAppender bigProbeFrameAppender;
+private HashJoinPartitionManager partitionManager;

 public enum SIDE {
 BUILD,
@@ -81,7 +82,6 @@
 private final boolean isLeftOuter;
 private final IMissingWriter[] nonMatchWriters;

-private final BitSet spilledStatus; //0=resident, 1=spilled
 private final int numOfPartitions;
 private final int memSizeInFrames;
 private InMemoryHashJoin inMemJoiner; //Used for joining resident 
partitions
@@ -108,6 +108,7 @@
 String probeRelName, String buildRelName, ITuplePairComparator 
comparator, RecordDescriptor probeRd,
 RecordDescriptor buildRd, ITuplePartitionComputer probeHpc, 
ITuplePartitionComputer buildHpc,
 IPredicateEvaluator predEval, boolean isLeftOuter, 
IMissingWriterFactory[] nullWriterFactories1) {
+this.partitionManager = new HashJoinPartitionManager(numOfPartitions);
 this.ctx = ctx;
 this.memSizeInFrames = memSizeInFrames;
 this.buildRd = buildRd;
@@ -129,8 +130,6 @@
 this.isLeftOuter = isLeftOuter;
 this.isReversed = false;

-this.spilledStatus = new BitSet(numOfPartitions);
-
 this.nonMatchWriters = isLeftOuter ? new 
IMissingWriter[nullWriterFactories1.length] : null;
 if (isLeftOuter) {
 for (int i = 0; i < nullWriterFactories1.length; i++) {
@@ -142,11 +141,11 @@
 public void initBuild() throws HyracksDataException {
 framePool = new DeallocatableFramePool(ctx, memSizeInFrames * 
ctx.getInitialFrameSize());
 bufferManagerForHashTable = new 

Change in asterixdb[master]: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager and P...

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3421


Change subject: Refactoring OptimizedHybrishHashJoin Introduced RunfilesManager 
and PartitionsManager
..

Refactoring OptimizedHybrishHashJoin
Introduced RunfilesManager and PartitionsManager

Change-Id: I3f6d011f8af256b290cc28a04a412bcbd005920a
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
A 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinRunFilesManager.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
6 files changed, 334 insertions(+), 206 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/21/3421/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
index 6c08be2..a435919 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/IPartitionedTupleBufferManager.java
@@ -113,4 +113,12 @@
  */
 void clearPartition(int partition) throws HyracksDataException;

+/**
+ * Flushes the particular partition {@code pid} to {@code writer} and
+ * clears it.
+ * @param pid
+ * @throws HyracksDataException
+ */
+void flushAndClearPartition(int pid, IFrameWriter writer) throws 
HyracksDataException;
+
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
index 4578c2e..a11eab5 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/VPartitionTupleBufferManager.java
@@ -125,6 +125,12 @@
 }

 @Override
+public void flushAndClearPartition(int pid, IFrameWriter writer) throws 
HyracksDataException {
+flushPartition(pid, writer);
+clearPartition(pid);
+}
+
+@Override
 public boolean insertTuple(int partition, byte[] byteArray, int[] 
fieldEndOffsets, int start, int size,
 TuplePointer pointer) throws HyracksDataException {
 int actualSize = calculateActualSize(fieldEndOffsets, size);
diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
new file mode 100644
index 000..f05f986
--- /dev/null
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/HashJoinPartitionsManager.java
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hyracks.dataflow.std.join;
+
+import java.util.Arrays;
+import java.util.BitSet;
+
+import org.apache.hyracks.api.exceptions.HyracksDataException;
+
+public class 

Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3412

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2577]One frame per spilled partitions
..

[ASTERIXDB-2577]One frame per spilled partitions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
During the probe phase there should be one frame per each
spilled partition otherwise the whole memory may be used
to store in memory partitions. In this case, every record
that is matching with a spilled partition from build phase
will be flushed directly to the disk. This change will fix
this issue by making sure that when we spill a partition or
read a partition back during making space for hash table, we
consider that 1 frame for the corresponding partition.

Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
1 file changed, 11 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/3412/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 5
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3412

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2577]One frame per spilled partitions
..

[ASTERIXDB-2577]One frame per spilled partitions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
During the probe phase there should be one frame per each
spilled partition otherwise the whole memory may be used
to store in memory partitions. In this case, every record
that is matching with a spilled partition from build phase
will be flushed directly to the disk. This change will fix
this issue by making sure that when we spill a partition or
read a partition back during making space for hash table, we
consider that 1 frame for the corresponding partition.

Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
1 file changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/3412/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 4
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3412

to look at the new patch set (#3).

Change subject: [ASTERIXDB-2577]One frame per spilled partitions
..

[ASTERIXDB-2577]One frame per spilled partitions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
During the probe phase there should be one frame per each
spilled partition otherwise the whole memory may be used
to store in memory partitions. In this case, every record
that is matching with a spilled partition from build phase
will be flushed directly to the disk. This change will fix
this issue by making sure that when we spill a partition or
read a partition back during making space for hash table, we
consider that 1 frame for the corresponding partition.

Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
1 file changed, 11 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/3412/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 3
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2577] One frame per spilled partitions

[Shiva Jahangiri (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3412

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2577] One frame per spilled partitions
..

[ASTERIXDB-2577] One frame per spilled partitions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
During the probe phase there should be one frame per each
spilled partition otherwise the whole memory may be used
to store in memory partitions. In this case, every record
that is matching with a spilled partition from build phase
will be flushed directly to the disk. This change will fix
this issue by making sure that when we spill a partition or
read a partition back during making space for hash table, we
consider that 1 frame for the corresponding partition.

Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
1 file changed, 13 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/3412/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/3412
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
Gerrit-Change-Number: 3412
Gerrit-PatchSet: 2
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [ASTERIXDB-2577]One frame per spilled partitions

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3412


Change subject: [ASTERIXDB-2577]One frame per spilled partitions
..

[ASTERIXDB-2577]One frame per spilled partitions

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
During the probe phase there should be one frame per each
spilled partition otherwise the whole memory may be used
to store in memory partitions. In this case, every record
that is matching with a spilled partition from build phase
will be flushed directly to the disk. This change will fix
this issue by making sure that when we spill a partition or
read a partition back during making space for hash table, we
consider that 1 frame for the corresponding partition.

Change-Id: I84ca0ea9d894ad4be0798d725ea5acdbcef0048c
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
1 file changed, 13 insertions(+), 4 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/3412/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
index c78e0dc..ff61368 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
@@ -310,7 +310,8 @@
 long hashTableSizeDecrease =
 
-SerializableHashTable.calculateByteSizeDeltaForTableSizeChange(inMemTupCount,
 -buildPSizeInTups[pidToSpill], frameSize);
-freeSpace = freeSpace + 
bufferManager.getPhysicalSize(pidToSpill) + hashTableSizeDecrease;
+// -1 because we need to keep one frame for each spilled 
partition.
+freeSpace = freeSpace + 
bufferManager.getPhysicalSize(pidToSpill) + hashTableSizeDecrease - 1;
 inMemTupCount -= buildPSizeInTups[pidToSpill];
 spillPartition(pidToSpill);
 closeBuildPartition(pidToSpill);
@@ -334,7 +335,8 @@
 long expectedHashTableSizeDecrease =
 
-SerializableHashTable.calculateByteSizeDeltaForTableSizeChange(inMemTupCount,
 -numberOfTuplesToBeSpilled, frameSize);
-freeSpace = freeSpace + spaceToBeReturned + 
expectedHashTableSizeDecrease;
+// -1 because we need to keep one frame for each spilled 
partition.
+freeSpace = freeSpace + spaceToBeReturned + 
expectedHashTableSizeDecrease - 1;
 // Adjusts the hash table size
 inMemTupCount -= numberOfTuplesToBeSpilled;
 if (freeSpace >= 0) {
@@ -358,10 +360,15 @@
 }
 long expectedHashTableByteSizeIncrease = SerializableHashTable
 .calculateByteSizeDeltaForTableSizeChange(inMemTupCount, 
buildPSizeInTups[pid], frameSize);
-freeSpace = freeSpace - bufferManager.getPhysicalSize(pid) - 
expectedHashTableByteSizeIncrease;
+// +1 because we need to keep one frame for each spilled 
partition, but when that partition is read back in
+// we can release its one frame.
+freeSpace = freeSpace - bufferManager.getPhysicalSize(pid) - 
expectedHashTableByteSizeIncrease + 1;
 inMemTupCount += buildPSizeInTups[pid];
 // Adjusts the hash table size
 hashTableByteSizeForInMemTuples += 
expectedHashTableByteSizeIncrease;
+}
+if (memSizeInFrames * ctx.getInitialFrameSize() - freeSpace < 
spilledStatus.cardinality()) {
+throw new HyracksDataException("After build finishes, there should 
be at least one frame for each spilled partition.");
 }

 return inMemTupCount;
@@ -383,8 +390,10 @@
 continue;
 }
 // We put minus since the method returns a negative value to 
represent a newly reclaimed space.
+// -1 because we need to keep one frame for each spilled partition.
 spaceAfterSpill = currentFreeSpace + 
bufferManager.getPhysicalSize(p) + (-SerializableHashTable
-
.calculateByteSizeDeltaForTableSizeChange(currentInMemTupCount, 
-buildPSizeInTups[p], frameSize));
+
.calculateByteSizeDeltaForTableSizeChange(currentInMemTupCount, 
-buildPSizeInTups[p], frameSize))
+- 1;
 if (spaceAfterSpill == 0) {
 // Found the perfect one. Just returns this partition.
 

Change in asterixdb[master]: [NO ISSUE] Changed the minimum number of partitions in optimized hybr...

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Till Westmann, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3350

to look at the new patch set (#6).

Change subject: [NO ISSUE] Changed the minimum number of partitions in 
optimized hybrid hash join - user model changes: no - storage format changes : 
no - interface changes: no
..

[NO ISSUE] Changed the minimum number of partitions in optimized hybrid hash 
join
- user model changes: no
- storage format changes : no
- interface changes: no

Details:
As asterixdb currently does not have statistics, the formula for calculating 
the number of partitions for hybrid hash join does not give an accurate answer. 
Also, the minimum number of the partitions to make is set to 2. However, in 
case of having a big build relation, we may end up with 2 big partitions which 
can cause several rounds of recursions. Simulations showed that setting 20 as 
the minimum number of partitions can save more data in the memory and reduce 
the rounds of recursions as each partition now holds less amount of data.

Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/PreferToSpillFullyOccupiedFramePolicy.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoin.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
3 files changed, 30 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/50/3350/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/3350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
Gerrit-Change-Number: 3350
Gerrit-PatchSet: 6
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE] Changed the minimum number of partitions in optimized hybr...

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Till Westmann, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3350

to look at the new patch set (#5).

Change subject: [NO ISSUE] Changed the minimum number of partitions in 
optimized hybrid hash join - user model changes: no - storage format changes : 
no - interface changes: no
..

[NO ISSUE] Changed the minimum number of partitions in optimized hybrid hash 
join
- user model changes: no
- storage format changes : no
- interface changes: no

Details:
As asterixdb currently does not have statistics, the formula for calculating 
the number of partitions for hybrid hash join does not give an accurate answer. 
Also, the minimum number of the partitions to make is set to 2. However, in 
case of having a big build relation, we may end up with 2 big partitions which 
can cause several rounds of recursions. Simulations showed that setting 20 as 
the minimum number of partitions can save more data in the memory and reduce 
the rounds of recursions as each partition now holds less amount of data.

Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/PreferToSpillFullyOccupiedFramePolicy.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
2 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/50/3350/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/3350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
Gerrit-Change-Number: 3350
Gerrit-PatchSet: 5
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE] Changed the minimum number of partitions in optimized hybr...

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Till Westmann, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3350

to look at the new patch set (#4).

Change subject: [NO ISSUE] Changed the minimum number of partitions in 
optimized hybrid hash join - user model changes: no - storage format changes : 
no - interface changes: no
..

[NO ISSUE] Changed the minimum number of partitions in optimized hybrid hash 
join
- user model changes: no
- storage format changes : no
- interface changes: no

Details:
As asterixdb currently does not have statistics, the formula for calculating 
the number of partitions for hybrid hash join does not give an accurate answer. 
Also, the minimum number of the partitions to make is set to 2. However, in 
case of having a big build relation, we may end up with 2 big partitions which 
can cause several rounds of recursions. Simulations showed that setting 20 as 
the minimum number of partitions can save more data in the memory and reduce 
the rounds of recursions as each partition now holds less amount of data.

Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/buffermanager/PreferToSpillFullyOccupiedFramePolicy.java
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
2 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/50/3350/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/3350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
Gerrit-Change-Number: 3350
Gerrit-PatchSet: 4
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE] Changed the minimum number of partitions in optimized hybr...

[Shiva Jahangiri (Code Review)]

Hello Anon. E. Moose (1000171), Till Westmann, Jenkins,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/3350

to look at the new patch set (#3).

Change subject: [NO ISSUE] Changed the minimum number of partitions in 
optimized hybrid hash join - user model changes: no - storage format changes : 
no - interface changes: no
..

[NO ISSUE] Changed the minimum number of partitions in optimized hybrid hash 
join
- user model changes: no
- storage format changes : no
- interface changes: no

Details:
As asterixdb currently does not have statistics, the formula for calculating 
the number of partitions for hybrid hash join does not give an accurate answer. 
Also, the minimum number of the partitions to make is set to 2. However, in 
case of having a big build relation, we may end up with 2 big partitions which 
can cause several rounds of recursions. Simulations showed that setting 20 as 
the minimum number of partitions can save more data in the memory and reduce 
the rounds of recursions as each partition now holds less amount of data.

Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
1 file changed, 5 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/50/3350/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/3350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
Gerrit-Change-Number: 3350
Gerrit-PatchSet: 3
Gerrit-Owner: Shiva Jahangiri 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [NO ISSUE] Changed the minimum number of partitions in optimized hybr...

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3350


Change subject: [NO ISSUE] Changed the minimum number of partitions in 
optimized hybrid hash join - user model changes: no - storage format changes : 
no - interface changes: no
..

[NO ISSUE] Changed the minimum number of partitions in optimized hybrid hash 
join
- user model changes: no
- storage format changes : no
- interface changes: no

Details:
As asterixdb currently does not have statistics, the formula for calculating 
the number of partitions for hybrid hash join does not give an accurate answer. 
Also, the minimum number of the partitions to make is set to 2. However, in 
case of having a big build relation, we may end up with 2 big partitions which 
can cause several rounds of recursions. Simulations showed that setting 20 as 
the minimum number of partitions can save more data in the memory and reduce 
the rounds of recursions as each partition now holds less amount of data.

Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/50/3350/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
index 403c492..4acbd50 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
@@ -202,7 +202,7 @@
 private int getNumberOfPartitions(int memorySize, int buildSize, double 
factor, int nPartitions)
 throws HyracksDataException {
 int numberOfPartitions = 0;
-if (memorySize <= 2) {
+if (memorySize <= 20) {
 throw new HyracksDataException("Not enough memory is available for 
Hybrid Hash Join.");
 }
 if (memorySize > buildSize * factor) {
@@ -210,13 +210,13 @@
 // We set 2 (not 1) to avoid a corner case where the only 
partition may be spilled to the disk.
 // This may happen since this formula doesn't consider the hash 
table size. If this is the case,
 // we will do a nested loop join after some iterations. But, this 
is not effective.
-return 2;
+return 20;
 }
 numberOfPartitions = (int) (Math.ceil((buildSize * factor / 
nPartitions - memorySize) / (memorySize - 1)));
-numberOfPartitions = Math.max(2, numberOfPartitions);
+numberOfPartitions = Math.max(20, numberOfPartitions);
 if (numberOfPartitions > memorySize) {
 numberOfPartitions = (int) Math.ceil(Math.sqrt(buildSize * factor 
/ nPartitions));
-return Math.max(2, Math.min(numberOfPartitions, memorySize));
+return Math.max(20, Math.min(numberOfPartitions, memorySize));
 }
 return numberOfPartitions;
 }

--
To view, visit https://asterix-gerrit.ics.uci.edu/3350
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a92acbe43761121e9851a4f792f561d71eb9f61
Gerrit-Change-Number: 3350
Gerrit-PatchSet: 1
Gerrit-Owner: Shiva Jahangiri 

Change in asterixdb[master]: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2299/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java:

PS4, Line 399: if (replicateOperator.getOutputMaterializationFlags()[i]) {
 : return true;
 : }
> Shouldn't this if statement be inside the for loop?
I see, you need it to be outside if the previous if statement breaks. I guess I 
am not sure why we have this check (outputs.get(i).getValue() == op), and not 
only check for materlializationFlag?the same way that we do in 
AbstratcReplicateOperator, isBlocker method.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2299
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic715c5733621e27049677f44e1ddaa0dd2c71baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2299/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java:

PS4, Line 399: if (replicateOperator.getOutputMaterializationFlags()[i]) {
 : return true;
 : }
Shouldn't this if statement be inside the for loop?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2299
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic715c5733621e27049677f44e1ddaa0dd2c71baf
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2299/3//COMMIT_MSG
Commit Message:

PS3, Line 22: The current algorithm used to generate stages
:   does not consider Replicate/Split operators
:   as blocking operators. This could results
:   in over estimation since multiple stages
:   might be combined as a single stage.
Replicate should make a new stage(similar to group by and order), but split 
should not. None of them has memory budget.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2299
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic715c5733621e27049677f44e1ddaa0dd2c71baf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [ASTERIXDB-2263][RT] Use Plan Stages To Estimate Resources
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2299/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/resource/PlanStagesGenerator.java:

PS3, Line 346: case ORDER:
Based on the discussion that I had with Mike and my own tests, Replicate 
operator makes a new stage but does not have any memory.It also has one input 
and multiple outputs.As a such, I think in here we can have a case for 
replicate too, which adds it to the pendingBlockingOperators but no changes in 
memory calculation is needed as it does not need any memory.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2299
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic715c5733621e27049677f44e1ddaa0dd2c71baf
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2199][COMP] Fix PushFieldAccessRule for nested pa...

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [ASTERIXDB-2199][COMP] Fix PushFieldAccessRule for nested 
partitioning keys
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2246/5/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java:

PS5, Line 180: if (partitioningKey.size() != fieldExpr.size()) {
 : continue;
 : }
 : for (int j = 0; j < partitioningKey.size(); j++) {
 : if 
(!partitioningKey.get(j).equals(fieldExpr.get(j))) {
 : break;
 : }
 : if (j == partitioningKey.size() - 1) {
 : return i;
 : }
 : }
Doesn't partitioningKey.equals(fieldExpr) 
work?(https://stackoverflow.com/questions/1075656/simple-way-to-find-if-two-different-lists-contain-exactly-the-same-elements)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2246
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I874c1fd15719b6bdeb7b0913fbafc04a58d32ed4
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Ildar Absalyamov 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 28:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1885/27/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java:

Line 38: public static  void printPlan(ILogicalPlan plan,
> MAJOR SonarQube violation:
Done


Line 38: public static  void printPlan(ILogicalPlan plan,
> +1
Done


Line 38: public static  void printPlan(ILogicalPlan plan,
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 28
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 24:

(8 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> Right, that's all fine, but I don't see how it follows from what the sonarq
Oh I see. Right. Changed it.


Line 116: private static final String oplan = "Optimized logical plan";
> I cannot change it cause this is what we write in 
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/24/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> MAJOR SonarQube violation:
Done


Line 116: private static final String oplan = "Optimized logical plan";
> MAJOR SonarQube violation:
Done


PS24, Line 235: printPlanJson
> It seems that PlanPrettyPrinter should only need 1 method printPlan(...) th
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/24/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:

PS24, Line 68: String id = "";
> I think that this should not be needed anymore.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/24/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java:

PS24, Line 91: printPlan
> If we make printOperator and printPlan non-static methods, I think that we 
It has to be static to be able to use static method reference in 
PlanPrettyPrinter.


https://asterix-gerrit.ics.uci.edu/#/c/1885/24/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java:

PS24, Line 27: interface
> I'm not sure if we still need/use this interface, if printOperator and prin
It was my first time using static method reference, but as far as I checked 
java was complaining that it needs the interface and I made it. Not sure if 
there is a better way for it. I made apply to throw exception. Thank you :)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 24
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 22:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> Wait, what? We write the variable name?
in line 161, we are printing the plan name that is either "Logical plan" or 
"Optimized logical plan" to the web interface and I needed to know which plan 
it is (logical/optimized logical) so I can set the correct class name in . 
what I was doing previously was: "Logical plan".equalsIgnoreCare(planName) 
which in a code review there was a suggestion to make this string finalized.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 22
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 23:

(30 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

Line 64: fmtString =
> MAJOR SonarQube violation:
Done


Line 64: fmtString =
> +1
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> +1
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> +1
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


Line 65: (fmtString.equalsIgnoreCase("JSON") || 
fmtString.equalsIgnoreCase("CLEAN_JSON"))
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

Line 115: private static final String lplan = "Logical plan";
> +1
I cannot change it cause this is what we write in 


Line 116: private static final String oplan = "Optimized logical plan";
> +1
I cannot change it cause this is what we write in 


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:

PS23, Line 68: private
> remove?
Done


PS23, Line 73: setId
> remove?
Done


PS23, Line 77: getId
> remove?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java:

PS22, Line 26: import org.apache.commons.lang3.mutable.Mutable;
> Can you revert this file? It's not part of the change, really.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java:

PS23, Line 26: import
> revert file?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java:

Line 24: import org.apache.commons.lang3.mutable.Mutable;
> Same here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/23/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java:

PS23, Line 24: apache
> revert file?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/22/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java:

Line 97: private Stack prefix;
> MAJOR SonarQube violation:
Done


Line 118: stringPrefix = (stringPrefix.isEmpty()) ? 
val.toString() : stringPrefix + "." + val.toString();
> MAJOR SonarQube violation:
Done


Line 118:   

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 17:

(30 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1885/16//COMMIT_MSG
Commit Message:

PS16, Line 7:  / formatted JSON
> remove this?
But I am still supporting formatted json on the UI...


PS16, Line 15: , and clean-json.
> remove this?
But I am still supporting formatted json on the UI...


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

PS16, Line 163: generat
> Fix the comment and move it to the constructor it applies to.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

PS16, Line 162: intln("" + planName 
> If we use these strings to trigger a specific behavior, we should have then
Changed them to private static final String in this file.


Line 173: }
> Remove the empty line?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

Line 21: import static 
org.apache.asterix.api.http.server.ServletConstants.HYRACKS_CONNECTION_ATTR;
> remove the empty line?
Done


PS16, Line 109: 
> Could this be done inside PlanFormat.get? I.e. could we just pass the reque
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java:

PS16, Line 113: FORMAT("format"),
> remove this?
Done


PS16, Line 165: String host;
  : String path;
> can these be removed?
Done


PS16, Line 237: 
  : SessionConfig.OutputFormat format 
> make this a single line?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:

Line 21: import static 
org.apache.asterix.api.http.server.ServletConstants.HYRACKS_CONNECTION_ATTR;
> remove the empty line?
Done


PS16, Line 97: 
> Same question as before.
Done


Line 100: format = OutputFormat.CSV;
> +1
Done


PS16, Line 126: // If it's JSON or ADM, check for the "wrapper-array" flag. 
Default is
  : // "true" for JSON and "false" for ADM. (Not a
> make this a single line?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java:

Line 94: public void compile(boolean optimize, boolean 
printRewrittenExpressions, boolean printLogicalPlan,
> +1
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java:

PS16, Line 67: =
> This formatting seems inconsistent with the one above.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java:

PS16, Line 63: 
> Fix the formatting for the file?
Done


PS16, Line 231: 
  : 
> remove the empty lines here as well?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:

PS16, Line 68: id = "";
> Should this be a property of the Operator or a property of the plan generat
This should be part of operator so we can find replication, after each plan I 
reset the operators.


Line 87: 
> remove this empty line?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/16/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java:

Line 27: import 

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 15:

(16 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

PS15, Line 57: JSON,
 : CLEAN_JSON,
> Is there a difference between JSON and CLEAN_JSON? Do we need both?
Only at UI they are different. Removed CLEAN_JSON from here.


Line 60: };
> Could we add a method
Done


PS15, Line 130: SessionConfig
> Could we add backwards-compatible constructors that default to the STRING f
Done


PS15, Line 152: SessionConfig
> ... and here?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

PS15, Line 237: resetOperatorID
> Why Do we need to reset an operatorId here?
We have to reset it otherwise if the same operator is used in optimized logical 
plan, it uses the id set from logical plan. So I reset it after each plan.


https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

PS15, Line 103: optimizedPlanFormat
> Should we call this "optimized-plan-format" as well?
I discussed with Mike about this, and the decision was to have one global 
setting for both plans.


PS15, Line 114: try {
  : planFormat = PlanFormat.valueOf(plan);
  : } catch (IllegalArgumentException e) {
  : LOGGER.log(Level.INFO, plan + ": unsupported 
plan-format, using " + PlanFormat.CLEAN_JSON + " instead", e);
  : // Default output format
  : planFormat = PlanFormat.CLEAN_JSON;
  : }
> Use the proposed method for PlanFormat here?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:

PS15, Line 116: request.getParameter("plan-format")
> Reuse variable "plan" here?
Done


PS15, Line 115: try {
  : if (request.getParameter("plan-format") != null) {
  : planFormat = 
PlanFormat.valueOf(request.getParameter("plan-format"));
  : }
  : } catch (IllegalArgumentException e) {
  : LOGGER.log(Level.INFO, plan + ": unsupported 
plan-format, using " + PlanFormat.CLEAN_JSON + " instead", e);
  : // Default plan format
  : planFormat = PlanFormat.CLEAN_JSON;
  : }
> Use the proposed method for PlanFormat here?
Done


PS15, Line 125: request.getParameter("optimizedPlanFormat")
> Reuse variable "opPlan" here?
This part has been removed as part of a global setting for both plans.


https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java:

PS15, Line 40: 
 : 
> Remove empty lines at the end of the file?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/15/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:

PS15, Line 68: operatorID
> Why do we need an operator id? What does it represent?
OperatorID is used to help with understanding the replication. When the same 
operatorID happens in the plan we are using replication.


PS15, Line 206: 
> Something went wrong with the indentation here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/15/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java:

PS15, Line 98: Override
> Reformat the file?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/15/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
File 

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 14:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1885/14/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:

Line 96: 
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1885
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: shi...@uci.edu
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Shiva Jahangiri 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON

[Shiva Jahangiri (Code Review)]

Shiva Jahangiri has posted comments on this change.

Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..


Patch Set 9:

(19 comments)

addressed comments

https://asterix-gerrit.ics.uci.edu/#/c/1885/9//COMMIT_MSG
Commit Message:

PS9, Line 7: SITE
> SITE is the component for the the website at http://asterixdb.apache.org/, 
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:

Line 45: public enum OutputFormat {
> It seems that this is not formatted according to our project rules:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/pom.xml
File asterixdb/asterix-app/pom.xml:

PS9, Line 284: 2.8.4
> We should provide a version here, as the version is provided in the asterix
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:

PS9, Line 117: private
> Please check the formatting here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

Line 123: planFormat = PlanFormat.valueOf(plan);
> Hm, this seems like it'd be good to fix somehow.
Done


Line 127: planFormat = PlanFormat.CLEAN_JSON;
> CRITICAL SonarQube violation:
Done


Line 130: opPlanFormat = PlanFormat.valueOf(opPlan);
> CRITICAL SonarQube violation:
Done


Line 135: opPlanFormat = PlanFormat.CLEAN_JSON;
> CRITICAL SonarQube violation:
Done


PS9, Line 178: IStatementExecutor
> Please check the formatting here.
Done


PS9, Line 197: protected
> Please check the formatting here.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java:

PS9, Line 256: TODO
> Could you file an issue for this?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:

PS9, Line 112: format
> Please check the formatting in this file.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java:

PS9, Line 113: IStatementExecutor
> Please check the formatting in this file.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java:

PS9, Line 61: 
> Seems like this is more or less the same as its optimized counterpart sans 
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java:

PS9, Line 197: boolean firstPlan = false;
> Whats this about?
Removed. This was only looking at the first plan before. Now it can handle 
multiple plans


PS9, Line 211: final JsonParser parser = new 
ObjectMapper().getJsonFactory().createJsonParser(objectActual);
 : while (parser.nextToken() != null) {
 : }
> So you just want to check if it's a valid JSON object?
Yes, cause I am not changing the plan, I just change it to json.


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:

PS9, Line 50: UNPARTITIONED
> Please check the formatting in this file.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java:

PS9, Line 28: import
> As there are no functional changes is this file, it should be reverted to i
Done