[jira] [Commented] (ASTERIXDB-2664) Add Unit Tests for RunFileWriter and RunFileReader

2020-03-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050484#comment-17050484
 ] 

ASF subversion and git services commented on ASTERIXDB-2664:


Commit 7f9e19004c955b96484db20502e7f6a219db76d4 in asterixdb's branch 
refs/heads/master from Caleb Herbel
[ https://gitbox.apache.org/repos/asf?p=asterixdb.git;h=7f9e190 ]

[ASTERIXDB-2664][TEST] Add Run File Test

- user model changes: no
- storage format changes: no
- interface changes: no

details:
-added Run File Test

Change-Id: I856f699d04642eb95fdb89c8dfed2a689bb2eeaa
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/4743
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Dmitry Lychagin 


> Add Unit Tests for RunFileWriter and RunFileReader
> --
>
> Key: ASTERIXDB-2664
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2664
> Project: Apache AsterixDB
>  Issue Type: Test
>  Components: TEST - Test Framework
>Reporter: Preston Carman
>Assignee: Preston Carman
>Priority: Trivial
>
> The RunFileWriter and RunFileReader classes do not have unit tests. I found 
> this out by trying to convert these classes to use DirectIO. Presumably they 
> are tested by existing queries these are not unit tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ASTERIXDB-2664) Add Unit Tests for RunFileWriter and RunFileReader

2020-02-24 Thread Caleb Herbel (Jira)


[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044118#comment-17044118
 ] 

Caleb Herbel commented on ASTERIXDB-2664:
-

I have a unit test for the RunFileWriter and RunFileReader that I have been 
working with. I can submit it for you soon. 

> Add Unit Tests for RunFileWriter and RunFileReader
> --
>
> Key: ASTERIXDB-2664
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2664
> Project: Apache AsterixDB
>  Issue Type: Test
>  Components: TEST - Test Framework
>Reporter: Preston Carman
>Assignee: Preston Carman
>Priority: Trivial
>
> The RunFileWriter and RunFileReader classes do not have unit tests. I found 
> this out by trying to convert these classes to use DirectIO. Presumably they 
> are tested by existing queries these are not unit tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)