Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-31 Thread Luo Chen (Code Review) 
Luo Chen has submitted this change and it was merged.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


[ASTERIXDB-2133] Fix unncessary binary search in GroupFrameAccessor

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- GroupFrameAccessor holds a list of frames from a run during the merge
step of merge sort. However, everytime we access a tuple, it performs
binary search to get the physical tuple index. This patch fixes this
by remembering the last accessed frame. It is expected that tuples
are accessed sequentially (since it's the merge step), which greatly
reduces binary searches

Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2079
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Ian Maxon 
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
1 file changed, 18 insertions(+), 11 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; ; Verified
  Ian Maxon: Looks good to me, approved



diff --git 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
index cac50e7..bf61435 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
@@ -57,10 +57,13 @@
 private final RecordDescriptor recordDescriptor;
 private final int minFrameSize;
 private final FrameTupleAccessor frameTupleAccessor;
-private int lastTupleIndex;
 private int lastFrameId;
+// the start tuple index of the last accessed frame (inclusive)
+private int lastFrameStart;
+// the end tuple index of the last accessed frame (exclusive)
+private int lastFrameEnd;
 private ByteBuffer buffer;
-private List innerFrameInfos;
+private final List innerFrameInfos;
 
 public GroupFrameAccessor(int minFrameSize, RecordDescriptor 
recordDescriptor) {
 this.minFrameSize = minFrameSize;
@@ -127,8 +130,9 @@
 @Override
 public void reset(ByteBuffer buffer) {
 this.buffer = buffer;
-this.lastTupleIndex = -1;
 this.lastFrameId = -1;
+this.lastFrameStart = -1;
+this.lastFrameEnd = -1;
 parseGroupedBuffer(0, buffer.limit());
 }
 
@@ -153,12 +157,13 @@
 
 private int resetSubTupleAccessor(int tupleIndex) {
 assert tupleIndex < getTupleCount();
-if (innerFrameInfos.size() == 1) {
-return tupleIndex;
+if (tupleIndex >= lastFrameStart && tupleIndex < lastFrameEnd) {
+// a special optimization path
+// since GroupFrameAccessor is used by merge, it is expected that 
tuples are accessed sequentially
+// thus, if tuple still fit into the last frame, we do not need to 
perform binary search
+return tupleIndex - lastFrameStart;
 }
-if (tupleIndex == lastTupleIndex) {
-return lastFrameId > 0 ? lastTupleIndex - 
innerFrameInfos.get(lastFrameId - 1).tupleCount : lastTupleIndex;
-}
+// we perform binary search to get the frame Id
 int subFrameId = Collections.binarySearch(innerFrameInfos, tupleIndex);
 if (subFrameId >= 0) {
 subFrameId++;
@@ -166,9 +171,11 @@
 subFrameId = -subFrameId - 1;
 }
 frameTupleAccessor.reset(buffer, 
innerFrameInfos.get(subFrameId).start, innerFrameInfos.get(subFrameId).length);
-lastTupleIndex = tupleIndex;
 lastFrameId = subFrameId;
-return lastFrameId > 0 ? lastTupleIndex - 
innerFrameInfos.get(lastFrameId - 1).tupleCount : lastTupleIndex;
+lastFrameStart = lastFrameId > 0 ? innerFrameInfos.get(lastFrameId - 
1).tupleCount : 0;
+lastFrameEnd = innerFrameInfos.get(lastFrameId).tupleCount;
+
+return tupleIndex - lastFrameStart;
 }
 
-}
+}
\ No newline at end of file

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-31 Thread Ian Maxon (Code Review) 
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4388/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4388/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4383/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2016/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2016/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4383/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2032/ 
(10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2219/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2000/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6876/ (6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1939/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1324/ 
(3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Luo Chen (Code Review) 
Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2079

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..

[ASTERIXDB-2133] Fix unncessary binary search in GroupFrameAccessor

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- GroupFrameAccessor holds a list of frames from a run during the merge
step of merge sort. However, everytime we access a tuple, it performs
binary search to get the physical tuple index. This patch fixes this
by remembering the last accessed frame. It is expected that tuples
are accessed sequentially (since it's the merge step), which greatly
reduces binary searches

Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
1 file changed, 18 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/79/2079/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5380/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Luo Chen (Code Review) 
Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2079/3/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java:

PS3, Line 174: ubFrameId;
> Wait, why isn't this tupleCount-1?
start is inclusive, but end is exclusive (see line 158). I'll put a comment on 
them.


PS3, Line 176: meEnd = innerFrameInfos.get(lastFrameId).tupleCount;
> This ternary could be assigned to a variable rather than being repeated, co
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1334/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1660/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-27 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1332/ 
(7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-26 Thread Ian Maxon (Code Review) 
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

(2 comments)

Seems like a solid idea, since we already optimize for same-tuple access, why 
not optimize for same-frame access. Couple questions though.

https://asterix-gerrit.ics.uci.edu/#/c/2079/3/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java:

PS3, Line 174: innerFrameInfos.get(lastFrameId).tupleCount;
Wait, why isn't this tupleCount-1?


PS3, Line 176: lastFrameId > 0 ? tupleIndex - innerFrameInfos.get(lastFrameId - 
1).tupleCount
This ternary could be assigned to a variable rather than being repeated, 
couldn't it?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4326/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful Build 2799
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1980/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1980/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4326/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2161/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1977/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-22 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1941/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-21 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1272/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-21 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1601/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-21 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1273/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-21 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5321/ (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-21 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1880/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-21 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6817/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-21 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1264/ 
(1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Luo Chen (Code Review) 
Luo Chen has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

> Cool stuff, do you see improved sort speeds with more memory with
 > this improvement?

 > Cool stuff, do you see improved sort speeds with more memory with
 > this improvement?

Hi Ian, some experiment results can be found at 
https://drive.google.com/file/d/0B43D7FK4h0PiM0dWdXQzeDhyLXM/view?usp=sharing.

But this only fixes the merge phase. The sort phase is still not cache/memory 
efficient, which is a future project to improve...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Luo Chen 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Ian Maxon (Code Review) 
Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Cool stuff, do you see improved sort speeds with more memory with this 
improvement?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4301/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-18 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4301/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4298/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: Contrib+1

Analytics Compatibility Tests Successful Build 2779
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4298/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4294/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1961/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1961/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4294/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2134/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1950/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1914/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Luo Chen (Code Review) 
Luo Chen has uploaded a new patch set (#2).

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..

[ASTERIXDB-2133] Fix unncessary binary search in GroupFrameAccessor

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- GroupFrameAccessor holds a list of frames from a run during the merge
step of merge sort. However, everytime we access a tuple, it performs
binary search to get the physical tuple index. This patch fixes this
by remembering the last accessed frame. It is expected that tuples
are accessed sequentially (since it's the merge step), which greatly
reduces binary searches

Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
---
M 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/util/GroupFrameAccessor.java
1 file changed, 17 insertions(+), 11 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/79/2079/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1236/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1573/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6789/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5293/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1244/
 (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1852/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1243/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2133] Fix unncessary binary search in GroupFrameA...

2017-10-17 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2133] Fix unncessary binary search in 
GroupFrameAccessor
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1245/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2079
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a1b19ad47f6b1dda4bd5c417932e4c9ba36a714
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No