Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Dmitry Lychagin has submitted this change and it was merged. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. [ASTERIXDB-2307][COMP] Incorrect result with quantified expression - user model changes: no - storage format changes: no - interface changes: no Details: - Fixed incorrect result with EVERY quantified expression when its condition returns NULL/MISSING Change-Id: I9e282071c87a9551829c31af43909970d307e417 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2441 Sonar-Qube: JenkinsTested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins Reviewed-by: Taewoo Kim --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.4.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.4.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 8 files changed, 149 insertions(+), 3 deletions(-) Approvals: Anon. E. Moose #1000171: Taewoo Kim: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java index 8b072c7..2b7adc1 100644 --- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java +++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java @@ -84,6 +84,7 @@ import org.apache.asterix.metadata.entities.InternalDatasetDetails; import org.apache.asterix.metadata.functions.ExternalFunctionCompilerUtil; import org.apache.asterix.metadata.utils.DatasetUtil; +import org.apache.asterix.om.base.ABoolean; import org.apache.asterix.om.base.AInt64; import org.apache.asterix.om.base.AString; import org.apache.asterix.om.constants.AsterixConstantValue; @@ -1087,10 +1088,17 @@ fAgg = BuiltinFunctions.makeAggregateFunctionExpression(BuiltinFunctions.NON_EMPTY_STREAM, new ArrayList<>()); } else { // EVERY -List satExprList = new ArrayList<>(1); -satExprList.add(new MutableObject<>(eo2.first)); +List ifMissingOrNullArgs = new ArrayList<>(2); +ifMissingOrNullArgs.add(new MutableObject<>(eo2.first)); +ifMissingOrNullArgs +.add(new MutableObject<>(new ConstantExpression(new AsterixConstantValue(ABoolean.FALSE; + +List notArgs = new ArrayList<>(1); +notArgs.add(new MutableObject<>(new ScalarFunctionCallExpression( + FunctionUtil.getFunctionInfo(BuiltinFunctions.IF_MISSING_OR_NULL), ifMissingOrNullArgs))); + s = new SelectOperator(new MutableObject<>(new ScalarFunctionCallExpression( - FunctionUtil.getFunctionInfo(AlgebricksBuiltinFunctions.NOT), satExprList)), false, null); + FunctionUtil.getFunctionInfo(AlgebricksBuiltinFunctions.NOT), notArgs)), false, null); s.getInputs().add(eo2.second); fAgg = BuiltinFunctions.makeAggregateFunctionExpression(BuiltinFunctions.EMPTY_STREAM, new ArrayList<>()); } diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp new file mode 100644 index 000..bded8c0 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Will add comments in a follow up change -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Taewoo Kim has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Code-Review+2 LGTM! Only one minor comment: it would be wonderful if you could put a comment regarding how EVERY SATISFIES works. -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5813/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2810/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2810/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3385/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3361/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3628/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5813/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/ArnSgr : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2900/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/t4tj5c : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3433/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2887/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8359/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/909/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2862/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2813/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6852/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3119/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5809/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: -Integration-Tests Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5809/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5797/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2803/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2803/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3375/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3351/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3617/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5797/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/PcuZX6 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/Byxh92 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2798/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6837/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Dmitry Lychagin has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2441 Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. [ASTERIXDB-2307][COMP] Incorrect result with quantified expression - user model changes: no - storage format changes: no - interface changes: no Details: - Fixed incorrect result with EVERY quantified expression when its condition returns NULL/MISSING Change-Id: I9e282071c87a9551829c31af43909970d307e417 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.4.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.4.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 8 files changed, 149 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/41/2441/1 diff --git a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java index 8b072c7..2b7adc1 100644 --- a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java +++ b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java @@ -84,6 +84,7 @@ import org.apache.asterix.metadata.entities.InternalDatasetDetails; import org.apache.asterix.metadata.functions.ExternalFunctionCompilerUtil; import org.apache.asterix.metadata.utils.DatasetUtil; +import org.apache.asterix.om.base.ABoolean; import org.apache.asterix.om.base.AInt64; import org.apache.asterix.om.base.AString; import org.apache.asterix.om.constants.AsterixConstantValue; @@ -1087,10 +1088,17 @@ fAgg = BuiltinFunctions.makeAggregateFunctionExpression(BuiltinFunctions.NON_EMPTY_STREAM, new ArrayList<>()); } else { // EVERY -ListsatExprList = new ArrayList<>(1); -satExprList.add(new MutableObject<>(eo2.first)); +List ifMissingOrNullArgs = new ArrayList<>(2); +ifMissingOrNullArgs.add(new MutableObject<>(eo2.first)); +ifMissingOrNullArgs +.add(new MutableObject<>(new ConstantExpression(new AsterixConstantValue(ABoolean.FALSE; + +List notArgs = new ArrayList<>(1); +notArgs.add(new MutableObject<>(new ScalarFunctionCallExpression( + FunctionUtil.getFunctionInfo(BuiltinFunctions.IF_MISSING_OR_NULL), ifMissingOrNullArgs))); + s = new SelectOperator(new MutableObject<>(new ScalarFunctionCallExpression( - FunctionUtil.getFunctionInfo(AlgebricksBuiltinFunctions.NOT), satExprList)), false, null); + FunctionUtil.getFunctionInfo(AlgebricksBuiltinFunctions.NOT), notArgs)), false, null); s.getInputs().add(eo2.second); fAgg = BuiltinFunctions.makeAggregateFunctionExpression(BuiltinFunctions.EMPTY_STREAM, new ArrayList<>()); } diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp new file mode 100644 index 000..bded8c0 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/quantifiers/query-ASTERIXDB-2307/query-ASTERIXDB-2307.1.ddl.sqlpp @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2847/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2872/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2885/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3418/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/894/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8344/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2307][COMP] Incorrect result with quantified expr...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2307][COMP] Incorrect result with quantified expression .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3104/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2441 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e282071c87a9551829c31af43909970d307e417 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry LychaginGerrit-Reviewer: Jenkins Gerrit-HasComments: No