Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Luo Chen has submitted this change and it was merged. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples - user model changes: no - storage format changes: no - interface changes: no Details: - The current locking protocol is not correct when there are bad tuples, e.g., duplicates. When locking fails, the write must push partial frames so that the previous acquired locks are released. However, if there are bad tuples in the frame, after bad tuples are removed from the frame, the state of pushed partial frames will be completely lost. Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3003 Reviewed-by: Xikui Wang Sonar-Qube: Jenkins Tested-by: Jenkins Integration-Tests: Jenkins Reviewed-by: Murtadha Hubail --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Anon. E. Moose #1000171: Xikui Wang: Looks good to me, but someone else must approve Jenkins: Verified; No violations found; Verified Murtadha Hubail: Looks good to me, approved diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java index 1401c0a..5e4b5a1 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java @@ -80,6 +80,10 @@ @Override public void open() throws HyracksDataException { +i = 0; +currentTupleIdx = 0; +lastFlushedTupleIdx = 0; +flushedPartialTuples = false; accessor = new FrameTupleAccessor(inputRecDesc); writeBuffer = new VSizeFrame(ctx); appender = new FrameTupleAppender(writeBuffer); @@ -109,10 +113,6 @@ @Override public void nextFrame(ByteBuffer buffer) throws HyracksDataException { -currentTupleIdx = 0; -lastFlushedTupleIdx = 0; -flushedPartialTuples = false; - accessor.reset(buffer); ILSMIndexAccessor lsmAccessor = (ILSMIndexAccessor) indexAccessor; int tupleCount = accessor.getTupleCount(); @@ -164,6 +164,9 @@ FrameUtils.flushFrame(writeBuffer.getBuffer(), writer); } i = 0; +currentTupleIdx = 0; +lastFlushedTupleIdx = 0; +flushedPartialTuples = false; } /** -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7462/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/70/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4978/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5022/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7462/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/66/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5205/ (9/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2647/ (8/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4857/ (7/7) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4636/ (5/5) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4547/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8584/ (4/4) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10117/ (3/3) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4603/ (2/2) -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4639/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/VDXKEB : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/DS8mVL : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Luo Chen has uploaded a new patch set (#2). Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples - user model changes: no - storage format changes: no - interface changes: no Details: - The current locking protocol is not correct when there are bad tuples, e.g., duplicates. When locking fails, the write must push partial frames so that the previous acquired locks are released. However, if there are bad tuples in the frame, after bad tuples are removed from the frame, the state of pushed partial frames will be completely lost. Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/03/3003/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/q9r5gx : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Xikui Wang Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples
Luo Chen has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/3003 Change subject: [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples .. [ASTERIXDB-2467][STO] Fix locking protocol with bad tuples - user model changes: no - storage format changes: no - interface changes: no Details: - The current locking protocol is not correct when there are bad tuples, e.g., duplicates. When locking fails, the write must push partial frames so that the previous acquired locks are released. However, if there are bad tuples in the frame, after bad tuples are removed from the frame, the state of pushed partial frames will be completely lost. Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/03/3003/1 diff --git a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java index 1401c0a..18dac60 100644 --- a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java +++ b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/LSMInsertDeleteOperatorNodePushable.java @@ -109,10 +109,6 @@ @Override public void nextFrame(ByteBuffer buffer) throws HyracksDataException { -currentTupleIdx = 0; -lastFlushedTupleIdx = 0; -flushedPartialTuples = false; - accessor.reset(buffer); ILSMIndexAccessor lsmAccessor = (ILSMIndexAccessor) indexAccessor; int tupleCount = accessor.getTupleCount(); @@ -164,6 +160,9 @@ FrameUtils.flushFrame(writeBuffer.getBuffer(), writer); } i = 0; +currentTupleIdx = 0; +lastFlushedTupleIdx = 0; +flushedPartialTuples = false; } /** -- To view, visit https://asterix-gerrit.ics.uci.edu/3003 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I86baa1f21ef7390777c8e2b0ce226095528e7f18 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen