Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Xikui Wang has submitted this change and it was merged.
Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
..
[ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
- user model changes: no
- storage format changes: no
- interface changes: no
LET is not necessary for applying functions to data feeds. We could
inline the function calls when constructing the pipeline query.
Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3072
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
Contrib: Jenkins
Reviewed-by: Dmitry Lychagin
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.1.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.2.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.3.lib.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.4.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.5.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/udf_filter_on_feed/udf_filter_on_feed.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/validate-default-library/validate-default-library.1.adm
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFactory.java
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFunction.java
M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml
11 files changed, 240 insertions(+), 16 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Dmitry Lychagin: Looks good to me, approved
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
index 593d7ce..d22e929 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
@@ -184,8 +184,8 @@
argExprs.add(new LiteralExpr(new IntegerLiteral((Integer)
arg)));
} else if (arg instanceof String) {
argExprs.add(new LiteralExpr(new StringLiteral((String) arg)));
-} else if (arg instanceof VariableExpr) {
-argExprs.add((VariableExpr) arg);
+} else if (arg instanceof Expression) {
+argExprs.add((Expression) arg);
}
}
return argExprs;
@@ -216,25 +216,16 @@
whereClause = new WhereClause(whereClauseQuery.getBody());
}
-// TODO: This can be the place to add select predicate for ingestion
// Attaching functions
-int varIdx = 1;
-VariableExpr previousVarExpr = fromTermLeftExpr;
-ArrayList letClauses = new ArrayList<>();
-for (FunctionSignature funcSig : feedConnection.getAppliedFunctions())
{
-VarIdentifier intermediateVar = SqlppVariableUtil
-
.toInternalVariableIdentifier(FEED_DATAFLOW_INTERMEIDATE_VAL_PREFIX +
String.valueOf(varIdx));
-VariableExpr intermediateVarExpr = new
VariableExpr(intermediateVar);
-CallExpr functionCallExpr = new CallExpr(funcSig,
addArgs(previousVarExpr));
-previousVarExpr = intermediateVarExpr;
-LetClause letClause = new LetClause(intermediateVarExpr,
functionCallExpr);
-letClauses.add(letClause);
-varIdx++;
+Expression previousVarExpr = fromTermLeftExpr;
+for (FunctionSignature functionSignature :
feedConnection.getAppliedFunctions()) {
+CallExpr functionCallExpr = new CallExpr(functionSignature,
addArgs(previousVarExpr));
+previousVarExpr = functionCallExpr;
}
// Constructing select clause
SelectElement selectElement = new SelectElement(previousVarExpr);
SelectClause selectClause = new SelectClause(selectElement, null,
false);
-SelectBlock selectBlock = new SelectBlock(selectClause, fromClause,
letClauses, whereClause, null, null, null);
+SelectBlock selectBlock = new SelectBlock(selectClause, fromClause,
null, whereClause, null, null, null);
SelectSetOperation selectSetOperation = new SelectSetOperation(new
SetOperationInput(selectBlock, null), null);
SelectExpression body
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/18xBfx : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3856/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7694/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3856/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/53/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5210/ (14/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/281/ (13/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2880/ (8/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5440/ (10/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/V3tsmn : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4877/ (12/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7694/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/34/ (9/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5254/ (4/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4836/ (2/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/288/ (6/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10352/ (5/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5091/ (11/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4870/ (3/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8819/ (7/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4782/ (1/14) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3072 to look at the new patch set (#3). Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds - user model changes: no - storage format changes: no - interface changes: no LET is not necessary for applying functions to data feeds. We could inline the function calls when constructing the pipeline query. Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.3.lib.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.4.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/udf_filter_on_feed/udf_filter_on_feed.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/validate-default-library/validate-default-library.1.adm A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFactory.java A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFunction.java M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml 11 files changed, 240 insertions(+), 16 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/72/3072/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/mqnGHt : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: -Contrib Analytics Compatibility Compilation Successful https://goo.gl/z4SQzT : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/fytNhr : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: (1 comment) BAD tests failed, you probably need to rebase https://asterix-gerrit.ics.uci.edu/#/c/3072/2//COMMIT_MSG Commit Message: PS2, Line 14: incline should be "inline" -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7657/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3845/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3845/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5172/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/25/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5051/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7657/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4830/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4835/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/zxXPCs : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2840/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4796/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5400/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8779/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/3072 to look at the new patch set (#2). Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds - user model changes: no - storage format changes: no - interface changes: no LET is not necessary for applying functions to data feeds. We could incline the function calls when constructing the pipeline query. Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.3.lib.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.4.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.5.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/udf_filter_on_feed/udf_filter_on_feed.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/validate-default-library/validate-default-library.1.adm A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFactory.java A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFunction.java M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml 11 files changed, 240 insertions(+), 16 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/72/3072/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/247/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/252/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10312/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5216/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4741/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5171/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/24/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/246/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4834/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7656/ -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5215/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2839/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/5PNgQi : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5050/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4740/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5399/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/251/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Xikui Wang has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3072
Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
..
[ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
- user model changes: no
- storage format changes: no
- interface changes: no
LET is not necessary for applying functions to data feeds. We could
incline the function calls when constructing the pipeline query.
Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.1.ddl.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.2.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.3.lib.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.4.update.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/udf_filter_on_feed/udf_filter_on_feed.5.query.sqlpp
A
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/udf_filter_on_feed/udf_filter_on_feed.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/external-library/validate-default-library/validate-default-library.1.adm
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFactory.java
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/WordInListFunction.java
M asterixdb/asterix-external-data/src/test/resources/library_descriptor.xml
11 files changed, 251 insertions(+), 15 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/72/3072/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
index 593d7ce..1049e66 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/utils/FeedOperations.java
@@ -184,8 +184,8 @@
argExprs.add(new LiteralExpr(new IntegerLiteral((Integer)
arg)));
} else if (arg instanceof String) {
argExprs.add(new LiteralExpr(new StringLiteral((String) arg)));
-} else if (arg instanceof VariableExpr) {
-argExprs.add((VariableExpr) arg);
+} else if (arg instanceof Expression) {
+argExprs.add((Expression) arg);
}
}
return argExprs;
@@ -216,25 +216,28 @@
whereClause = new WhereClause(whereClauseQuery.getBody());
}
-// TODO: This can be the place to add select predicate for ingestion
// Attaching functions
int varIdx = 1;
-VariableExpr previousVarExpr = fromTermLeftExpr;
-ArrayList letClauses = new ArrayList<>();
-for (FunctionSignature funcSig : feedConnection.getAppliedFunctions())
{
-VarIdentifier intermediateVar = SqlppVariableUtil
-
.toInternalVariableIdentifier(FEED_DATAFLOW_INTERMEIDATE_VAL_PREFIX +
String.valueOf(varIdx));
-VariableExpr intermediateVarExpr = new
VariableExpr(intermediateVar);
-CallExpr functionCallExpr = new CallExpr(funcSig,
addArgs(previousVarExpr));
-previousVarExpr = intermediateVarExpr;
-LetClause letClause = new LetClause(intermediateVarExpr,
functionCallExpr);
-letClauses.add(letClause);
-varIdx++;
+Expression previousVarExpr = fromTermLeftExpr;
+for (FunctionSignature functionSignature :
feedConnection.getAppliedFunctions()) {
+CallExpr functionCallExpr = new CallExpr(functionSignature,
addArgs(previousVarExpr));
+previousVarExpr = functionCallExpr;
}
+//ArrayList letClauses = new ArrayList<>();
+//for (FunctionSignature funcSig :
feedConnection.getAppliedFunctions()) {
+//VarIdentifier intermediateVar = SqlppVariableUtil
+//
.toInternalVariableIdentifier(FEED_DATAFLOW_INTERMEIDATE_VAL_PREFIX +
String.valueOf(varIdx));
+//VariableExpr intermediateVarExpr = new
VariableExpr(intermediateVar);
+//CallExpr functionCallExpr = new CallExpr(funcSig,
addArgs(previousVarExpr));
+//previousVarExpr = intermediateVarExpr;
+//LetClause letClause = new LetClause(intermediateVarExpr,
functionCallExpr);
+//letClauses.add(letClause);
+//
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8778/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4829/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10311/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2495][ING] Avoid LET in applying functions to feeds .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4795/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/3072 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65842f9ac84891b363d7e0a02425258d0df794e7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
