Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-07 Thread AsterixDB Code Review
>From Ritik Raj :

Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail 
Alkowaileet.
Ritik Raj has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 5:

(11 comments)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/77b23966_d0589932
PS5, Line 9: no
> yes
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/74f72964_ed62412a
PS5, Line 14: - Added storage config to set max mergable component size.
: - Add storage config to set max mergable component size.
> Duplicate. […]
Done


File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/5d4279ba_2d835a5e
PS5, Line 169: ConcurrentSizeBoundMergePolicy
> fix to match the class name
Done


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/b03e336f_6d569f9d
PS5, Line 73: STORAGE_MERGED_DISKCOMPONENT_MAX_SIZE
> Call it STORAGE_MAX_COMPONENT_SIZE and rename accordingly
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/d82c32c4_c280f5b3
PS5, Line 73: 1 * 1024 * 1024 * 1024L
> Use StorageUtil. […]
Done


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/d23f15b3_75a4228d
PS5, Line 42: maxResultantComponentSize
> just call it maxComponentSize
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/50a875b1_17b74adf
PS5, Line 118: isCountOfMergableRangeExceeding
> Can we just reuse getMergableComponentsIndex and check the returned range 
> instead of this if it is u […]
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/c49c05c4_f2f74c3e
PS5, Line 206: // can the merge of two components can produce a larger 
component w.r.t size
 : // size(mergedComponent) > size(comp1) + 
size(comp2) ?
 : // A possible case, two components with 
significant difference in the
 : // schema of data, will this let to increase the 
component size as we have to compensate for the
 : // null values, but this increase will be in few 
bytes. should we consider this possibility ?
> remove this
Done


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/47909376_e0853320
PS5, Line 236: getPossibleMergableComponentIndex
> maybe we can refactor this with getMergableComponentsIndex by passing 
> minMergeComponentCount as Int. […]
yeah actually we can, setting min value to 2, implying choosing any possible 
mergeable component as low as 2 components.


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/4d6a4364_a90eebeb
PS5, Line 40: max-merged-diskcomponent-size
> rename
Done


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/355d72f2_d5c81d7c
PS5, Line 68: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.MAX_COMPONENT_COUNT,
 "30");
: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.MIN_MERGE_COMPONENT_COUNT,
 "3");
: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.MAX_MERGE_COMPONENT_COUNT,
 "10");
: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.SIZE_RATIO,
 "1.2");
> do we still need to keep these?
Not needed for the new policy. but should we remove the default values from the 
ConcurrentMergePolicy as may be needed when we want to switch back to it? 
anyway removing this we can look back into git.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 5
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Ritik Raj 
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Attention: Murtadha Hubail 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Attention: Wail Alkowaileet
Gerrit-Comment-Date: Tue, 07 May 2024 18:13:26 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Murtadha Hubail 

Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-06 Thread AsterixDB Code Review
>From Murtadha Hubail :

Attention is currently required from: Ali Alsuliman, Ritik Raj, Wail 
Alkowaileet.
Murtadha Hubail has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 5:

(12 comments)

Commit Message:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/768891b6_48ab765e
PS5, Line 9: no
yes


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/bdafddbe_1aebb3b8
PS5, Line 14: - Added storage config to set max mergable component size.
: - Add storage config to set max mergable component size.
Duplicate. Remove one


File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/9fcb15e9_df499207
PS5, Line 169: ConcurrentSizeBoundMergePolicy
fix to match the class name


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/fac627da_41e292ff
PS5, Line 73: 1 * 1024 * 1024 * 1024L
Use StorageUtil.getIntSizeInBytes(


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/e72ab8b8_9fc007f3
PS5, Line 73: STORAGE_MERGED_DISKCOMPONENT_MAX_SIZE
Call it STORAGE_MAX_COMPONENT_SIZE and rename accordingly


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/655799e2_e454b7b9
PS5, Line 42: maxResultantComponentSize
just call it maxComponentSize


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/97f5bd54_fce248c1
PS5, Line 118: isCountOfMergableRangeExceeding
Can we just reuse getMergableComponentsIndex and check the returned range 
instead of this if it is using the same logic?


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/cdc45029_6f04b073
PS5, Line 182: getMergableComponentsIndex
The variable names currently make the logic hard to follow. Can we breakdown 
this to smaller methods or rename the variable to help follow the logic?


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/fb9ad634_65792dc6
PS5, Line 206: // can the merge of two components can produce a larger 
component w.r.t size
 : // size(mergedComponent) > size(comp1) + 
size(comp2) ?
 : // A possible case, two components with 
significant difference in the
 : // schema of data, will this let to increase the 
component size as we have to compensate for the
 : // null values, but this increase will be in few 
bytes. should we consider this possibility ?
remove this


https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/07459f57_5da51904
PS5, Line 236: getPossibleMergableComponentIndex
maybe we can refactor this with getMergableComponentsIndex by passing 
minMergeComponentCount as Int.Max or something?


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/ae56192f_0f942dc6
PS5, Line 40: max-merged-diskcomponent-size
rename


File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264/comment/1153242b_79af61d2
PS5, Line 68: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.MAX_COMPONENT_COUNT,
 "30");
: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.MIN_MERGE_COMPONENT_COUNT,
 "3");
: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.MAX_MERGE_COMPONENT_COUNT,
 "10");
: 
DEFAULT_COMPACTION_POLICY_PROPERTIES.put(ConcurrentMergePolicyFactory.SIZE_RATIO,
 "1.2");
do we still need to keep these?



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 5
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Ritik Raj 
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Attention: Ali Alsuliman 
Gerrit-Attention: Ritik Raj 
Gerrit-Attention: Wail Alkowaileet
Gerrit-Comment-Date: Mon, 06 May 2024 21:29:23 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Ritik 
Raj, Wail Alkowaileet.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 5: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/U5AjSTxo65iSwu3u5 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 5
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Ritik Raj 
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Attention: Murtadha Hubail 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Attention: Ritik Raj 
Gerrit-Attention: Wail Alkowaileet
Gerrit-Comment-Date: Mon, 06 May 2024 05:47:39 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
>From Ritik Raj :

Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Wail 
Alkowaileet.
Ritik Raj has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 5: Code-Review+1


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 5
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Ritik Raj 
Gerrit-Reviewer: Wail Alkowaileet
Gerrit-Attention: Murtadha Hubail 
Gerrit-Attention: Ali Alsuliman 
Gerrit-Attention: Wail Alkowaileet
Gerrit-Comment-Date: Mon, 06 May 2024 05:35:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Ritik Raj.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/463/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 5
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Mon, 06 May 2024 04:12:18 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
Attention is currently required from: Ritik Raj.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 5:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/77mGGtc27VeQ485K7 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 5
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Mon, 06 May 2024 03:38:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
>From Ritik Raj :

Attention is currently required from: Ritik Raj.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264

to look at the new patch set (#5).

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..

[ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Added storage config to set max mergable component size.
- Add storage config to set max mergable component size.
- The new merge policy will schedule merges similar to the current 
ConcurrentMergePolicy but it will consider the max mergable component size.

Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 

Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
>From Ritik Raj :

Attention is currently required from: Ritik Raj.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264

to look at the new patch set (#4).

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..

[ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Added storage config to set max mergable component size.
- Add storage config to set max mergable component size.
- The new merge policy will schedule merges similar to the current 
ConcurrentMergePolicy but it will consider the max mergable component size.

Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 

Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
Attention is currently required from: Ritik Raj.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 3: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/gpPRvjuavtuQ8waw9 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 3
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Sun, 05 May 2024 23:30:07 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Ritik Raj.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/461/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 3
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Sun, 05 May 2024 22:19:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
Attention is currently required from: Ritik Raj.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/J4ZBzwGScZdA699o7 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 3
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Sun, 05 May 2024 21:18:51 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-05 Thread AsterixDB Code Review
>From Ritik Raj :

Attention is currently required from: Ritik Raj.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264

to look at the new patch set (#3).

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..

[ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Added storage config to set max mergable component size.
- Add storage config to set max mergable component size.
- The new merge policy will schedule merges similar to the current 
ConcurrentMergePolicy but it will consider the max mergable component size.

Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
A 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/SizeBoundedConcurrentMergePolicyTest.java
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 

Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-04 Thread AsterixDB Code Review
>From Jenkins :

Attention is currently required from: Ritik Raj.
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/460/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 2
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Sat, 04 May 2024 15:16:20 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-04 Thread AsterixDB Code Review
Attention is currently required from: Ritik Raj.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 2: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/6Jz26rH6JPddxxTp8 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 2
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Sat, 04 May 2024 14:33:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-04 Thread AsterixDB Code Review
>From Ritik Raj :

Attention is currently required from: Ritik Raj.
Hello Jenkins, Anon. E. Moose #1000171,

I'd like you to reexamine a change. Please visit

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264

to look at the new patch set (#2).

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..

[ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Added storage config to set max mergable component size.
- Add storage config to set max mergable component size.
- The new merge policy will schedule merges similar to the current 
ConcurrentMergePolicy but it will consider the max mergable component size.

Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/user-defined-functions/udf23/udf23.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv19/cross-dv19.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-2/dataset_with_meta-2.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-5/dataset_with_meta-5.3.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv04/cross-dv04.3.query.sqlpp
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_compaction_policy/metadata_compaction_policy.1.adm
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/meta02/meta02.3.query.sqlpp
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_4/issue_251_dataset_hint_4.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-3/dataset_with_meta-2.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-3/dataset_with_meta-3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/dataset_with_meta-4/dataset_with_meta-4.3.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/dataset_with_meta-1/dataset_with_meta-1.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta09/meta09.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/meta02/meta02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv02/cross-dv02.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.1.adm
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/metadata_dataset/metadata_dataset.3.query.sqlpp
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicyFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StorageConstants.java
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_3/issue_251_dataset_hint_3.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_cloud/cross-dataverse/cross-dv04/cross-dv04.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/cross-dataverse/cross-dv02/cross-dv02.1.adm
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/SizeBoundedConcurrentMergePolicy.java
M 
asterixdb/asterix-app/src/test/resources/metadata/results/basic/metadata_dataset/metadata_dataset.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv02/cross-dv02.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/metadata/queries/basic/issue_251_dataset_hint_2/issue_251_dataset_hint_2.3.query.sqlpp
M 

Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-03 Thread AsterixDB Code Review
Attention is currently required from: Ritik Raj.
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://cbjenkins.page.link/a1NNNtFSJoyh9M9Z7 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 1
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Attention: Ritik Raj 
Gerrit-Comment-Date: Fri, 03 May 2024 23:39:28 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-03 Thread AsterixDB Code Review
>From Jenkins :

Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/457/ : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 1
Gerrit-Owner: Ritik Raj 
Gerrit-Reviewer: Jenkins 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-Comment-Date: Fri, 03 May 2024 22:36:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment


Change in asterixdb[master]: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge policy

2024-05-03 Thread AsterixDB Code Review
Anon. E. Moose #1000171 has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264 )

Change subject: [ASTERIXDB-3394][STO] Introducing concurrent size bound merge 
policy
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://cbjenkins.page.link/Wh6nPWBmpMPdxNGp8 : SUCCESS


--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18264
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I0cf0cfcfe5e7ff0131430ce2039ba89929fda274
Gerrit-Change-Number: 18264
Gerrit-PatchSet: 1
Gerrit-Owner: Ritik Raj 
Gerrit-CC: Anon. E. Moose #1000171
Gerrit-CC: Jenkins 
Gerrit-Comment-Date: Fri, 03 May 2024 21:25:49 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment