Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail :
Murtadha Hubail has submitted this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 )
Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
..
[NO ISSUE][*DB] Refactoring AssignRuntime Factory
Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266
Reviewed-by: Murtadha Hubail
Tested-by: Murtadha Hubail
---
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Murtadha Hubail: Looks good to me, approved; Verified
diff --git
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
index 300fac6..a39cd05 100644
---
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
+++
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
@@ -67,6 +67,10 @@
return outColumns;
}
+public boolean isFlushFramesRapidly() {
+return flushFramesRapidly;
+}
+
public IScalarEvaluatorFactory[] getEvalFactories() {
return evalFactories;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 3
Gerrit-Owner: Ritik Raj
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-MessageType: merged
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail : Attention is currently required from: Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 2: Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Tue, 07 May 2024 11:23:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail : Attention is currently required from: Ritik Raj. Murtadha Hubail has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Removed Integration-Tests-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ritik Raj Gerrit-MessageType: deleteVote
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail : Attention is currently required from: Ritik Raj. Murtadha Hubail has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Removed Verified-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ritik Raj Gerrit-MessageType: deleteVote
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail : Attention is currently required from: Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Tue, 07 May 2024 11:20:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Jenkins : Attention is currently required from: Ritik Raj. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 2: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/480/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 2 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Tue, 07 May 2024 05:45:11 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
Attention is currently required from: Ritik Raj. Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://cbjenkins.page.link/swhEzAbVQ8ZozePq7 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Mon, 06 May 2024 21:17:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail : Attention is currently required from: Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Mon, 06 May 2024 20:36:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Jenkins : Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/467/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Jenkins Gerrit-CC: Anon. E. Moose #1000171 Gerrit-Comment-Date: Mon, 06 May 2024 20:09:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/xbKof4A8b92ZFsSh7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d Gerrit-Change-Number: 18266 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Jenkins Gerrit-Comment-Date: Mon, 06 May 2024 19:06:45 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Ritik Raj :
Ritik Raj has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266 )
Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
..
[NO ISSUE][*DB] Refactoring AssignRuntime Factory
Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d
---
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/66/18266/1
diff --git
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
index 300fac6..a39cd05 100644
---
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
+++
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
@@ -67,6 +67,10 @@
return outColumns;
}
+public boolean isFlushFramesRapidly() {
+return flushFramesRapidly;
+}
+
public IScalarEvaluatorFactory[] getEvalFactories() {
return evalFactories;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18266
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I3c5f164b4750a4e873b0a9324f7c991aa147e38d
Gerrit-Change-Number: 18266
Gerrit-PatchSet: 1
Gerrit-Owner: Ritik Raj
Gerrit-MessageType: newchange
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail : Attention is currently required from: Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c Gerrit-Change-Number: 18249 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Tue, 23 Apr 2024 18:26:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail :
Murtadha Hubail has submitted this change. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 )
Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
..
[NO ISSUE][*DB] Refactoring AssignRuntime Factory
Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249
Integration-Tests: Jenkins
Reviewed-by: Peeyush Gupta
Tested-by: Murtadha Hubail
---
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
1 file changed, 110 insertions(+), 76 deletions(-)
Approvals:
Peeyush Gupta: Looks good to me, approved
Murtadha Hubail: Verified
Anon. E. Moose #1000171:
Jenkins: Verified
diff --git
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
index 5343069..300fac6 100644
---
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
+++
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
@@ -39,10 +39,9 @@
public class AssignRuntimeFactory extends
AbstractOneInputOneOutputRuntimeFactory {
private static final long serialVersionUID = 1L;
-
-private int[] outColumns;
-private IScalarEvaluatorFactory[] evalFactories;
-private final boolean flushFramesRapidly;
+protected int[] outColumns;
+protected IScalarEvaluatorFactory[] evalFactories;
+protected final boolean flushFramesRapidly;
/**
* @param outColumns
@@ -64,6 +63,14 @@
this.flushFramesRapidly = flushFramesRapidly;
}
+public int[] getOutColumns() {
+return outColumns;
+}
+
+public IScalarEvaluatorFactory[] getEvalFactories() {
+return evalFactories;
+}
+
@Override
public String toString() {
StringBuilder sb = new StringBuilder();
@@ -88,92 +95,106 @@
@Override
public AbstractOneInputOneOutputOneFramePushRuntime
createOneOutputPushRuntime(final IHyracksTaskContext ctx)
throws HyracksDataException {
-IEvaluatorContext evalCtx = new EvaluatorContext(ctx);
-final int[] projectionToOutColumns = new int[projectionList.length];
-for (int j = 0; j < projectionList.length; j++) {
-projectionToOutColumns[j] = Arrays.binarySearch(outColumns,
projectionList[j]);
+return new AssignRuntime(ctx);
+}
+
+public int[] getProjectionList() {
+return projectionList;
+}
+
+public class AssignRuntime extends
AbstractOneInputOneOutputOneFramePushRuntime {
+private IPointable result;
+private IScalarEvaluator[] eval;
+protected ArrayTupleBuilder tupleBuilder;
+private final int[] projectionToOutColumns;
+private boolean first = true;
+protected int tupleIndex = 0;
+protected final IHyracksTaskContext ctx;
+protected final IEvaluatorContext evalCtx;
+
+public AssignRuntime(IHyracksTaskContext ctx) {
+this.ctx = ctx;
+this.evalCtx = new EvaluatorContext(ctx);
+projectionToOutColumns = new int[projectionList.length];
+for (int j = 0; j < projectionList.length; j++) {
+projectionToOutColumns[j] = Arrays.binarySearch(outColumns,
projectionList[j]);
+}
+tupleBuilder = new ArrayTupleBuilder(projectionList.length);
+eval = new IScalarEvaluator[evalFactories.length];
+result = VoidPointable.FACTORY.createPointable();
}
-return new AbstractOneInputOneOutputOneFramePushRuntime() {
-private IPointable result =
VoidPointable.FACTORY.createPointable();
-private IScalarEvaluator[] eval = new
IScalarEvaluator[evalFactories.length];
-private ArrayTupleBuilder tupleBuilder = new
ArrayTupleBuilder(projectionList.length);
-private boolean first = true;
-private int tupleIndex = 0;
-
-@Override
-public void open() throws HyracksDataException {
-if (first) {
-initAccessAppendRef(ctx);
-first = false;
-int n = evalFactories.length;
-for (int i = 0; i < n; i++) {
-eval[i] =
evalFactories[i].createScalarEvaluator(evalCtx);
-}
+@Override
+public void open() throws HyracksDataException {
+if (first) {
+initAccessAppendRef(ctx);
+first = false;
+
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Murtadha Hubail : Attention is currently required from: Ritik Raj. Murtadha Hubail has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Removed Verified-1 by Jenkins -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c Gerrit-Change-Number: 18249 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Ritik Raj Gerrit-MessageType: deleteVote
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Peeyush Gupta : Attention is currently required from: Ritik Raj. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c Gerrit-Change-Number: 18249 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Peeyush Gupta Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Tue, 23 Apr 2024 17:17:24 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Jenkins : Attention is currently required from: Ritik Raj. Jenkins has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-trigger/339/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c Gerrit-Change-Number: 18249 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Attention: Ritik Raj Gerrit-Comment-Date: Tue, 23 Apr 2024 00:07:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://cbjenkins.page.link/EqpdQUVW3eiMGBai9 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c Gerrit-Change-Number: 18249 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-CC: Jenkins Gerrit-Comment-Date: Mon, 22 Apr 2024 23:36:03 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 ) Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory .. Patch Set 1: Analytics Compatibility Compilation Successful https://cbjenkins.page.link/bYsDA5espjQ8QPqL8 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c Gerrit-Change-Number: 18249 Gerrit-PatchSet: 1 Gerrit-Owner: Ritik Raj Gerrit-CC: Anon. E. Moose #1000171 Gerrit-CC: Jenkins Gerrit-Comment-Date: Mon, 22 Apr 2024 21:26:41 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in asterixdb[master]: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
>From Ritik Raj :
Ritik Raj has uploaded this change for review. (
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18249 )
Change subject: [NO ISSUE][*DB] Refactoring AssignRuntime Factory
..
[NO ISSUE][*DB] Refactoring AssignRuntime Factory
Change-Id: Ieb583580f7bc8a40a15839ce15c492aa0bfb410c
---
M
hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
1 file changed, 106 insertions(+), 76 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/49/18249/1
diff --git
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
index 5343069..300fac6 100644
---
a/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
+++
b/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/AssignRuntimeFactory.java
@@ -39,10 +39,9 @@
public class AssignRuntimeFactory extends
AbstractOneInputOneOutputRuntimeFactory {
private static final long serialVersionUID = 1L;
-
-private int[] outColumns;
-private IScalarEvaluatorFactory[] evalFactories;
-private final boolean flushFramesRapidly;
+protected int[] outColumns;
+protected IScalarEvaluatorFactory[] evalFactories;
+protected final boolean flushFramesRapidly;
/**
* @param outColumns
@@ -64,6 +63,14 @@
this.flushFramesRapidly = flushFramesRapidly;
}
+public int[] getOutColumns() {
+return outColumns;
+}
+
+public IScalarEvaluatorFactory[] getEvalFactories() {
+return evalFactories;
+}
+
@Override
public String toString() {
StringBuilder sb = new StringBuilder();
@@ -88,92 +95,106 @@
@Override
public AbstractOneInputOneOutputOneFramePushRuntime
createOneOutputPushRuntime(final IHyracksTaskContext ctx)
throws HyracksDataException {
-IEvaluatorContext evalCtx = new EvaluatorContext(ctx);
-final int[] projectionToOutColumns = new int[projectionList.length];
-for (int j = 0; j < projectionList.length; j++) {
-projectionToOutColumns[j] = Arrays.binarySearch(outColumns,
projectionList[j]);
+return new AssignRuntime(ctx);
+}
+
+public int[] getProjectionList() {
+return projectionList;
+}
+
+public class AssignRuntime extends
AbstractOneInputOneOutputOneFramePushRuntime {
+private IPointable result;
+private IScalarEvaluator[] eval;
+protected ArrayTupleBuilder tupleBuilder;
+private final int[] projectionToOutColumns;
+private boolean first = true;
+protected int tupleIndex = 0;
+protected final IHyracksTaskContext ctx;
+protected final IEvaluatorContext evalCtx;
+
+public AssignRuntime(IHyracksTaskContext ctx) {
+this.ctx = ctx;
+this.evalCtx = new EvaluatorContext(ctx);
+projectionToOutColumns = new int[projectionList.length];
+for (int j = 0; j < projectionList.length; j++) {
+projectionToOutColumns[j] = Arrays.binarySearch(outColumns,
projectionList[j]);
+}
+tupleBuilder = new ArrayTupleBuilder(projectionList.length);
+eval = new IScalarEvaluator[evalFactories.length];
+result = VoidPointable.FACTORY.createPointable();
}
-return new AbstractOneInputOneOutputOneFramePushRuntime() {
-private IPointable result =
VoidPointable.FACTORY.createPointable();
-private IScalarEvaluator[] eval = new
IScalarEvaluator[evalFactories.length];
-private ArrayTupleBuilder tupleBuilder = new
ArrayTupleBuilder(projectionList.length);
-private boolean first = true;
-private int tupleIndex = 0;
-
-@Override
-public void open() throws HyracksDataException {
-if (first) {
-initAccessAppendRef(ctx);
-first = false;
-int n = evalFactories.length;
-for (int i = 0; i < n; i++) {
-eval[i] =
evalFactories[i].createScalarEvaluator(evalCtx);
-}
+@Override
+public void open() throws HyracksDataException {
+if (first) {
+initAccessAppendRef(ctx);
+first = false;
+int n = evalFactories.length;
+for (int i = 0; i < n; i++) {
+eval[i] = evalFactories[i].createScalarEvaluator(evalCtx);
}
-
