Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


[NO ISSUE][CLUS] Fail Tasks When NC Not Active

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fail StartTasksWork if NC is not in active
  state (i.e. hasn't completed startup tasks).
- Set NC state to active only after completing
  startup tasks.
- Add test case.

Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2460
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/NodeStatus.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
8 files changed, 83 insertions(+), 8 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Michael Blow: Looks good to me, approved



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
index 844851a..5c497aa 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
@@ -146,7 +146,7 @@
 return buildActiveNCRegTasks(isMetadataNode);
 }
 final List tasks = new ArrayList<>();
-tasks.add(new UpdateNodeStatusTask(NodeStatus.ACTIVE));
+tasks.add(new UpdateNodeStatusTask(NodeStatus.BOOTING));
 if (state == SystemState.CORRUPTED) {
 //need to perform local recovery for node partitions
 LocalRecoveryTask rt = new 
LocalRecoveryTask(Arrays.asList(clusterManager.getNodePartitions(nodeId))
@@ -167,6 +167,7 @@
 tasks.add(new BindMetadataNodeTask());
 }
 tasks.add(new ReportLocalCountersTask());
+tasks.add(new UpdateNodeStatusTask(NodeStatus.ACTIVE));
 return tasks;
 }
 
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
index 0cd01ae..494198b 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
@@ -89,6 +89,8 @@
 @Override
 public void init(IServiceContext serviceCtx) throws Exception {
 ncServiceCtx = (INCServiceContext) serviceCtx;
+// set the node status initially to idle to indicate that it is 
pending booting
+((NodeControllerService) 
serviceCtx.getControllerService()).setNodeStatus(NodeStatus.IDLE);
 ncServiceCtx.setThreadFactory(
 new AsterixThreadFactory(ncServiceCtx.getThreadFactory(), 
ncServiceCtx.getLifeCycleComponentManager()));
 }
@@ -253,7 +255,7 @@
 }
 
 private boolean isPendingStartupTasks(NodeStatus nodeStatus, CcId 
primaryCc, CcId registeredCc) {
-return nodeStatus == NodeStatus.BOOTING && (primaryCc == null || 
primaryCc.equals(registeredCc));
+return nodeStatus == NodeStatus.IDLE && (primaryCc == null || 
primaryCc.equals(registeredCc));
 }
 
 private SystemState getCurrentSystemState() {
diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
new file mode 100644
index 000..df0740b
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
@@ -0,0 +1,64 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional 

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2460/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

PS4, Line 173: ACTIVE
> why do we initialize to ACTIVE?
other Hyracks tests and customers wont be able to start any tasks unless they 
change their applications to set this to active. I had it in earlier patches 
initialized to idle and many Hyracks tests failed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2460/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

PS4, Line 173: ACTIVE
why do we initialize to ACTIVE?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/9xLWhd : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5875/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2847/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/mPAVrB : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2847/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5875/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Analytics Compatibility Compilation Successful
https://goo.gl/WeuyMS : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3444/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2956/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8427/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/977/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3420/
 (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2882/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3501/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2967/
 (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2930/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3187/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Murtadha Hubail (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2460

to look at the new patch set (#4).

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..

[NO ISSUE][CLUS] Fail Tasks When NC Not Active

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fail StartTasksWork if NC is not in active
  state (i.e. hasn't completed startup tasks).
- Set NC state to active only after completing
  startup tasks.
- Add test case.

Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/NodeStatus.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
8 files changed, 83 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/60/2460/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3692/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6920/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/d3zo91 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5874/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3443/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://goo.gl/WCGsQr : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Murtadha Hubail (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2460

to look at the new patch set (#3).

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..

[NO ISSUE][CLUS] Fail Tasks When NC Not Active

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fail StartTasksWork if NC is not in active
  state (i.e. hasn't completed startup tasks).
- Set NC state to active only after completing
  startup tasks.
- Add test case.

Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/NodeStatus.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
8 files changed, 83 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/60/2460/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2955/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2881/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/976/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6919/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2929/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2966/
 (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3186/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3419/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3500/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3691/ (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8426/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5872/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2879/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/4DJZLK : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5872/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/xnA7Qh : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Murtadha Hubail (Code Review)]

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2460

to look at the new patch set (#2).

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..

[NO ISSUE][CLUS] Fail Tasks When NC Not Active

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fail StartTasksWork if NC is not in active
  state (i.e. hasn't completed startup tasks).
- Set NC state to active only after completing
  startup tasks.
- Add test case.

Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/NodeStatus.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
8 files changed, 81 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/60/2460/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6917/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3689/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2953/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2927/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2964/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3441/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8424/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3498/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2878/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/974/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3184/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3417/
 (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5871/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/F91RZ7 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5871/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/iaG1Ei : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8423/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2926/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3440/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2877/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3688/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2963/
 (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6916/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3497/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3416/
 (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2460

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..

[NO ISSUE][CLUS] Fail Tasks When NC Not Active

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Fail StartTasksWork if NC is not in active
  state (i.e. hasn't completed startup tasks).
- Set NC state to active after completing startup
  tasks.
- Add test case.

Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/NodeStatus.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
8 files changed, 79 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/60/2460/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
index 844851a..5c497aa 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
@@ -146,7 +146,7 @@
 return buildActiveNCRegTasks(isMetadataNode);
 }
 final List tasks = new ArrayList<>();
-tasks.add(new UpdateNodeStatusTask(NodeStatus.ACTIVE));
+tasks.add(new UpdateNodeStatusTask(NodeStatus.BOOTING));
 if (state == SystemState.CORRUPTED) {
 //need to perform local recovery for node partitions
 LocalRecoveryTask rt = new 
LocalRecoveryTask(Arrays.asList(clusterManager.getNodePartitions(nodeId))
@@ -167,6 +167,7 @@
 tasks.add(new BindMetadataNodeTask());
 }
 tasks.add(new ReportLocalCountersTask());
+tasks.add(new UpdateNodeStatusTask(NodeStatus.ACTIVE));
 return tasks;
 }
 
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
index 0cd01ae..f1fe18e 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplication.java
@@ -253,7 +253,7 @@
 }
 
 private boolean isPendingStartupTasks(NodeStatus nodeStatus, CcId 
primaryCc, CcId registeredCc) {
-return nodeStatus == NodeStatus.BOOTING && (primaryCc == null || 
primaryCc.equals(registeredCc));
+return nodeStatus == NodeStatus.IDLE && (primaryCc == null || 
primaryCc.equals(registeredCc));
 }
 
 private SystemState getCurrentSystemState() {
diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
new file mode 100644
index 000..df0740b
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/NcLifecycleTest.java
@@ -0,0 +1,64 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.apache.asterix.runtime;
+
+import org.apache.asterix.api.common.AsterixHyracksIntegrationUtil;
+import org.apache.asterix.common.TestDataUtil;
+import org.apache.asterix.common.config.GlobalConfig;

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3183/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/973/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][CLUS] Fail Tasks When NC Not Active

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Fail Tasks When NC Not Active
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2952/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2460
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I447d4f1e255211e9026b68eb9d931f25846ed153
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No