Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using
TestTypedAdapter
..
[NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter
WARN ...CleanupUtils - Failure closing a closeable resource
java.lang.NullPointerException: null
at
org.apache.asterix.external.dataset.adapter.FeedAdapter.close(FeedAdapter.java:63)
Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2903
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: abdullah alamoudi
---
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
2 files changed, 41 insertions(+), 1 deletion(-)
Approvals:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
Objections:
Anon. E. Moose #1000171: Violations found
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
index 90336fe..effd59f 100644
---
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
@@ -55,7 +55,7 @@
public TestTypedAdapter(ITupleParserFactory parserFactory, ARecordType
sourceDatatype, IHyracksTaskContext ctx,
Map configuration, int partition) throws
IOException {
-super(null);
+super(new TestTypedFeedDataFlowController(ctx));
pos = new PipedOutputStream();
pis = new PipedInputStream(pos);
this.configuration = configuration;
@@ -150,4 +150,5 @@
public boolean resume() {
return false;
}
+
}
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
new file mode 100644
index 000..708cdd8
--- /dev/null
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.external.library.adapter;
+
+import org.apache.asterix.external.dataflow.AbstractFeedDataFlowController;
+import org.apache.hyracks.api.comm.IFrameWriter;
+import org.apache.hyracks.api.context.IHyracksTaskContext;
+
+class TestTypedFeedDataFlowController extends AbstractFeedDataFlowController {
+TestTypedFeedDataFlowController(IHyracksTaskContext ctx) {
+super(ctx, null, 0);
+}
+
+@Override
+public String getStats() {
+throw new UnsupportedOperationException();
+}
+
+@Override
+public void start(IFrameWriter writer) {
+throw new UnsupportedOperationException();
+}
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2903
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Xikui Wang
Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7184/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3608/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4719/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4750/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/571/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7184/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/o5pqEE : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/sU9L8j : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4269/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4914/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2903 to look at the new patch set (#2). Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter WARN ...CleanupUtils - Failure closing a closeable resource java.lang.NullPointerException: null at org.apache.asterix.external.dataset.adapter.FeedAdapter.close(FeedAdapter.java:63) Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 --- M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java A asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java 2 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/03/2903/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2369/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4357/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4323/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/642/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4576/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8293/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4355/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9833/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7177/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4712/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4743/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/565/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7177/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/Ay2rgG : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4350/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4907/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4569/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4348/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/xwrKPC : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8286/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4261/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/636/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9826/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2362/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2903
Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using
TestTypedAdapter
..
[NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter
<>[Intake Thread] WARN org.apache.hyracks.api.util.CleanupUtils - Failure
closing a closeable resource
java.lang.NullPointerException: null
at
org.apache.asterix.external.dataset.adapter.FeedAdapter.close(FeedAdapter.java:63)
Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56
---
M
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
A
asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
2 files changed, 41 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/03/2903/1
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
index 90336fe..effd59f 100644
---
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedAdapter.java
@@ -55,7 +55,7 @@
public TestTypedAdapter(ITupleParserFactory parserFactory, ARecordType
sourceDatatype, IHyracksTaskContext ctx,
Map configuration, int partition) throws
IOException {
-super(null);
+super(new TestTypedFeedDataFlowController(ctx));
pos = new PipedOutputStream();
pis = new PipedInputStream(pos);
this.configuration = configuration;
@@ -150,4 +150,5 @@
public boolean resume() {
return false;
}
+
}
diff --git
a/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
new file mode 100644
index 000..2985b92
--- /dev/null
+++
b/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/adapter/TestTypedFeedDataFlowController.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.external.library.adapter;
+
+import org.apache.asterix.external.dataflow.AbstractFeedDataFlowController;
+import org.apache.hyracks.api.comm.IFrameWriter;
+import org.apache.hyracks.api.context.IHyracksTaskContext;
+
+class TestTypedFeedDataFlowController extends AbstractFeedDataFlowController {
+TestTypedFeedDataFlowController(IHyracksTaskContext ctx) {
+super(ctx, null, -1);
+}
+
+@Override
+public String getStats() {
+throw new UnsupportedOperationException();
+}
+
+@Override
+public void start(IFrameWriter writer) {
+throw new UnsupportedOperationException();
+}
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2903
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4316/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
