Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
abdullah alamoudi has submitted this change and it was merged.
Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
..
[NO ISSUE][HTTP] Fix buffer leak in HttpServer
- user model changes: no
- storage format changes: no
- interface changes: yes
Details:
- Prior to this change, cancelled requests before
they start leak request and response buffers.
- After this change, we distinguish between cancellation
of requests before they start or after and release resources
accordingly.
Change-Id: I9a34142e87158385152fa0a11be39abced307fcc
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2901
Reviewed-by: Michael Blow
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
---
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
5 files changed, 41 insertions(+), 1 deletion(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Michael Blow: Looks good to me, approved
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
index 38f2d23..95f8f27 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
@@ -86,4 +86,9 @@
* Notifies the response that the channel has become inactive.
*/
void notifyChannelInactive();
+
+/**
+ * Called on a created request that is cancelled before it is started
+ */
+void cancel();
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
index 891cc2a..adea133 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
@@ -29,6 +29,7 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.http.DefaultHttpContent;
import io.netty.handler.codec.http.HttpResponseStatus;
+import io.netty.util.ReferenceCountUtil;
import io.netty.util.internal.OutOfDirectMemoryError;
public class ChunkedNettyOutputStream extends OutputStream {
@@ -137,4 +138,8 @@
public synchronized void channelWritabilityChanged() {
notifyAll();
}
+
+public void cancel() {
+ReferenceCountUtil.release(buffer);
+}
}
\ No newline at end of file
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
index cd746b1..f02654e 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java
@@ -192,4 +192,9 @@
public void notifyChannelInactive() {
outputStream.channelWritabilityChanged();
}
+
+@Override
+public void cancel() {
+outputStream.cancel();
+}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
index 90e33b6..1d28472 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
@@ -111,4 +111,9 @@
// Do nothing.
// This response is sent as a single piece
}
+
+@Override
+public void cancel() {
+// Do nothing, as this response doesn't allocate buffers in constructor
+}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
index 72a8ea0..1c0801c 100644
---
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7176/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3604/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3604/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4711/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4742/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/564/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7176/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/GGFn4L : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4349/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4906/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4260/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4568/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4347/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/635/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8285/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2361/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9825/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4315/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/i1dK7S : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/RrHJcd : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4707/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4738/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/560/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7172/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/SCSrS4 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4901/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4344/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4563/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4310/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4255/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/630/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Hello Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2901 to look at the new patch set (#3). Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. [NO ISSUE][HTTP] Fix buffer leak in HttpServer - user model changes: no - storage format changes: no - interface changes: yes Details: - Prior to this change, cancelled requests before they start leak request and response buffers. - After this change, we distinguish between cancellation of requests before they start or after and release resources accordingly. Change-Id: I9a34142e87158385152fa0a11be39abced307fcc --- M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java 5 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/01/2901/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2356/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4342/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4706/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/559/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9820/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8280/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7171/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/QJGFYw : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4254/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4899/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9819/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4343/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8279/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/628/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4562/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2355/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4341/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4309/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Hello Anon. E. Moose #1000171, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2901 to look at the new patch set (#2). Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. [NO ISSUE][HTTP] Fix buffer leak in HttpServer - user model changes: no - storage format changes: no - interface changes: yes Details: - Prior to this change, cancelled requests before they start leak request and response buffers. - After this change, we distinguish between cancellation of requests before they start or after and release resources accordingly. Change-Id: I9a34142e87158385152fa0a11be39abced307fcc --- M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedResponse.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java M hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java 5 files changed, 39 insertions(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/01/2901/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Contrib-2 Analytics Compatibility Compilation Failed https://goo.gl/iLHw4C : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4308/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4253/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4561/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9818/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2354/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4340/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/627/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4342/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8278/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
Jenkins has posted comments on this change. Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4898/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2901 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34142e87158385152fa0a11be39abced307fcc Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2901
Change subject: [NO ISSUE][HTTP] Fix buffer leak in HttpServer
..
[NO ISSUE][HTTP] Fix buffer leak in HttpServer
- user model changes: no
- storage format changes: no
- interface changes: yes
Details:
- Prior to this change, cancelled requests before
they start leak request and response buffers.
- After this change, we distinguish between cancellation
of requests before they start or after and release resources
accordingly.
Change-Id: I9a34142e87158385152fa0a11be39abced307fcc
---
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
4 files changed, 34 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/01/2901/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
index 38f2d23..95f8f27 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletResponse.java
@@ -86,4 +86,9 @@
* Notifies the response that the channel has become inactive.
*/
void notifyChannelInactive();
+
+/**
+ * Called on a created request that is cancelled before it is started
+ */
+void cancel();
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
index 891cc2a..adea133 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
@@ -29,6 +29,7 @@
import io.netty.channel.ChannelHandlerContext;
import io.netty.handler.codec.http.DefaultHttpContent;
import io.netty.handler.codec.http.HttpResponseStatus;
+import io.netty.util.ReferenceCountUtil;
import io.netty.util.internal.OutOfDirectMemoryError;
public class ChunkedNettyOutputStream extends OutputStream {
@@ -137,4 +138,8 @@
public synchronized void channelWritabilityChanged() {
notifyAll();
}
+
+public void cancel() {
+ReferenceCountUtil.release(buffer);
+}
}
\ No newline at end of file
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
index 90e33b6..1d28472 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FullResponse.java
@@ -111,4 +111,9 @@
// Do nothing.
// This response is sent as a single piece
}
+
+@Override
+public void cancel() {
+// Do nothing, as this response doesn't allocate buffers in constructor
+}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
index 72a8ea0..dfe27e2 100644
---
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
+++
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpRequestHandler.java
@@ -40,6 +40,8 @@
private final IServlet servlet;
private final IServletRequest request;
private final IServletResponse response;
+private boolean started = false;
+private boolean cancelled = false;
public HttpRequestHandler(ChannelHandlerContext ctx, IServlet servlet,
IServletRequest request, int chunkSize) {
this.ctx = ctx;
@@ -52,6 +54,13 @@
@Override
public Void call() throws Exception {
+synchronized (this) {
+if (cancelled) {
+LOGGER.warn("Request cancelled before it is started");
+return null;
+}
+started = true;
+}
try {
ChannelFuture lastContentFuture = handle();
if
