Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-04-03 Thread Murtadha Hubail (Code Review) 
Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


[NO ISSUE][MD] Remove Legacy Metadata Latch

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
- Remove legacy metadata latch that was used before
  the metadata entity locking was introduced.

Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2556
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
4 files changed, 4 insertions(+), 50 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Michael Blow: Looks good to me, approved



diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
index a6a708f..4474684 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
@@ -97,7 +97,6 @@
 private final MetadataCache cache = new MetadataCache();
 protected final Collection proxies;
 protected IMetadataNode metadataNode;
-private final ReadWriteLock metadataLatch;
 protected boolean rebindMetadataNode = false;
 
 // TODO(mblow): replace references of this (non-constant) field with a 
method,
@@ -117,7 +116,6 @@
 throw new IllegalArgumentException("Null / empty list of proxies 
given to MetadataManager");
 }
 this.proxies = proxies;
-this.metadataLatch = new ReentrantReadWriteLock(true);
 }
 
 protected abstract TxnId createTxnId();
@@ -722,26 +720,6 @@
 throw new 
MetadataException(ErrorCode.REMOTE_EXCEPTION_WHEN_CALLING_METADATA_NODE, e);
 }
 return library;
-}
-
-@Override
-public void acquireWriteLatch() {
-metadataLatch.writeLock().lock();
-}
-
-@Override
-public void releaseWriteLatch() {
-metadataLatch.writeLock().unlock();
-}
-
-@Override
-public void acquireReadLatch() {
-metadataLatch.readLock().lock();
-}
-
-@Override
-public void releaseReadLatch() {
-metadataLatch.readLock().unlock();
 }
 
 @Override
diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
index 966792e..a646893 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
@@ -519,14 +519,6 @@
 
 int getMostRecentDatasetId() throws AlgebricksException;
 
-void acquireWriteLatch();
-
-void releaseWriteLatch();
-
-void acquireReadLatch();
-
-void releaseReadLatch();
-
 /**
  * Removes a library , acquiring local locks on behalf of the given 
transaction
  * id.
diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
index 980d36d..d110644 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
@@ -66,7 +66,6 @@
 import 
org.apache.asterix.transaction.management.opcallbacks.PrimaryIndexOperationTrackerFactory;
 import 
org.apache.asterix.transaction.management.opcallbacks.SecondaryIndexOperationTrackerFactory;
 import 
org.apache.asterix.transaction.management.resource.DatasetLocalResourceFactory;
-import 
org.apache.asterix.transaction.management.service.transaction.TransactionManagementConstants.LockManagerConstants.LockMode;
 import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
 import org.apache.hyracks.api.application.INCServiceContext;
 import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
@@ -375,35 +374,23 @@
 // as

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-04-03 Thread Michael Blow (Code Review) 
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6134/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3003/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3003/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/Y27UiX : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Anon. E. Moose (Code Review) 
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/LiQtKx : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6134/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3239/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3784/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3684/
 (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3165/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3964/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3468/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3212/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3253/
 (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8716/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7202/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1260/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Murtadha Hubail (Code Review) 
Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2556

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..

[NO ISSUE][MD] Remove Legacy Metadata Latch

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
- Remove legacy metadata latch that was used before
  the metadata entity locking was introduced.

Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
---
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/feeds/FeedMetadataUtil.java
4 files changed, 4 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/56/2556/1

diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
index a6a708f..4474684 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java
@@ -97,7 +97,6 @@
 private final MetadataCache cache = new MetadataCache();
 protected final Collection proxies;
 protected IMetadataNode metadataNode;
-private final ReadWriteLock metadataLatch;
 protected boolean rebindMetadataNode = false;
 
 // TODO(mblow): replace references of this (non-constant) field with a 
method,
@@ -117,7 +116,6 @@
 throw new IllegalArgumentException("Null / empty list of proxies 
given to MetadataManager");
 }
 this.proxies = proxies;
-this.metadataLatch = new ReentrantReadWriteLock(true);
 }
 
 protected abstract TxnId createTxnId();
@@ -722,26 +720,6 @@
 throw new 
MetadataException(ErrorCode.REMOTE_EXCEPTION_WHEN_CALLING_METADATA_NODE, e);
 }
 return library;
-}
-
-@Override
-public void acquireWriteLatch() {
-metadataLatch.writeLock().lock();
-}
-
-@Override
-public void releaseWriteLatch() {
-metadataLatch.writeLock().unlock();
-}
-
-@Override
-public void acquireReadLatch() {
-metadataLatch.readLock().lock();
-}
-
-@Override
-public void releaseReadLatch() {
-metadataLatch.readLock().unlock();
 }
 
 @Override
diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
index 966792e..a646893 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java
@@ -519,14 +519,6 @@
 
 int getMostRecentDatasetId() throws AlgebricksException;
 
-void acquireWriteLatch();
-
-void releaseWriteLatch();
-
-void acquireReadLatch();
-
-void releaseReadLatch();
-
 /**
  * Removes a library , acquiring local locks on behalf of the given 
transaction
  * id.
diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
index 980d36d..d110644 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
@@ -66,7 +66,6 @@
 import 
org.apache.asterix.transaction.management.opcallbacks.PrimaryIndexOperationTrackerFactory;
 import 
org.apache.asterix.transaction.management.opcallbacks.SecondaryIndexOperationTrackerFactory;
 import 
org.apache.asterix.transaction.management.resource.DatasetLocalResourceFactory;
-import 
org.apache.asterix.transaction.management.service.transaction.TransactionManagementConstants.LockManagerConstants.LockMode;
 import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
 import org.apache.hyracks.api.application.INCServiceContext;
 import org.apache.hyracks.api.dataflow.value.IBinaryComparatorFactory;
@@ -375,35 +374,23 @@
 // as traversing all records from DATAVERSE_DATASET to 
DATASET_DATASET, and then
 // to INDEX_DATASET.
 MetadataTransactionContext mdTxnCtx = null;
-MetadataManager.INSTANCE.acquireWriteLatch();
-if (LOGGER.isInfoEnabled()) {
-LOGGER.info("Starting DDL recovery ...");
-}
-
+LOGGER.info("Starting

Change in asterixdb[master]: [NO ISSUE][MD] Remove Legacy Metadata Latch

2018-03-31 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][MD] Remove Legacy Metadata Latch
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3706/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2556
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6b7153c8bc7bb6b489242c5d651879a09b57e0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No