Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


[NO ISSUE][NET] IPC Connections Improvements

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Refactor IPCConnectionManager.
- Halt on IPC message serialization failures.
- Ensure channels and handles are closed on connection
  failures.
- Remove IPCHandle unneeded CONNECT_FAILED state.
- Fix RegisterNodeWork failure handling.
- Consistently use NodeControllerRemoteProxy for NC RPC.

Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2617
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Murtadha Hubail 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/test/java/org/apache/hyracks/control/cc/cluster/NodeManagerTest.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/HandleState.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCSystem.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/test/java/org/apache/hyracks/ipc/tests/IPCTest.java
M 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java
13 files changed, 247 insertions(+), 191 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Michael Blow: Looks good to me, approved
  Murtadha Hubail: Looks good to me, but someone else must approve



diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
index b44a6bb..2b03324 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
@@ -105,9 +105,7 @@
 failNode(nodeId);
 }
 try {
-// TODO(mblow): it seems we should close IPC handles when we're 
done with them (like here)
-IIPCHandle ncIPCHandle = 
ccs.getClusterIPC().getHandle(ncState.getNodeController().getAddress());
-ncIPCHandle.send(-1, new AbortCCJobsFunction(ccConfig.getCcId()), 
null);
+ncState.getNodeController().abortJobs(ccs.getCcId());
 } catch (IPCException e) {
 throw HyracksDataException.create(e);
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
index de7d941..00693df 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
@@ -28,11 +28,8 @@
 import org.apache.hyracks.control.cc.cluster.INodeManager;
 import org.apache.hyracks.control.common.controllers.NodeParameters;
 import org.apache.hyracks.control.common.controllers.NodeRegistration;
-import org.apache.hyracks.control.common.ipc.CCNCFunctions;
 import org.apache.hyracks.control.common.ipc.NodeControllerRemoteProxy;
 import org.apache.hyracks.control.common.work.SynchronizableWork;
-import org.apache.hyracks.ipc.api.IIPCHandle;

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6307/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/fLMd1m : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/TS1YUu : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3108/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3108/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://goo.gl/Jc9kqK : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6307/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8901/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7377/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3869/
 (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Murtadha Hubail (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2617

to look at the new patch set (#3).

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..

[NO ISSUE][NET] IPC Connections Improvements

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Refactor IPCConnectionManager.
- Halt on IPC message serialization failures.
- Ensure channels and handles are closed on connection
  failures.
- Remove IPCHandle unneeded CONNECT_FAILED state.
- Fix RegisterNodeWork failure handling.
- Consistently use NodeControllerRemoteProxy for NC RPC.

Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/test/java/org/apache/hyracks/control/cc/cluster/NodeManagerTest.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/HandleState.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCSystem.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/test/java/org/apache/hyracks/ipc/tests/IPCTest.java
M 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java
13 files changed, 247 insertions(+), 191 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/17/2617/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3426/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3970/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3889/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3438/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3653/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3350/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4154/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3397/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1445/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Analytics Compatibility Compilation Successful
https://goo.gl/3AVihY : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3106/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3106/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6305/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6305/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4152/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6304/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6304/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8899/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7375/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3651/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3424/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3348/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3867/
 (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3395/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3968/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Murtadha Hubail (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2617

to look at the new patch set (#2).

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..

[NO ISSUE][NET] IPC Connections Improvements

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Refactor IPCConnectionManager.
- Halt on IPC message serialization failures.
- Ensure channels and handles are closed on connection
  failures.
- Remove IPCHandle unneeded CONNECT_FAILED state.
- Fix RegisterNodeWork failure handling.
- Consistently use NodeControllerRemoteProxy for NC RPC.

Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/test/java/org/apache/hyracks/control/cc/cluster/NodeManagerTest.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/HandleState.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCSystem.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/ReconnectingIPCHandle.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/test/java/org/apache/hyracks/ipc/tests/IPCTest.java
M 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java
14 files changed, 254 insertions(+), 203 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/17/2617/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4151/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3887/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3436/
 (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1443/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6303/ 
: FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6303/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3435/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8898/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3967/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3650/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4150/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3866/
 (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3423/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3347/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7374/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2617

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..

[NO ISSUE][NET] IPC Connections Improvements

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Refactor IPCConnectionManager.
- Halt on IPC message serialization failures.
- Ensure channels and handles are closed on connection
  failures.
- Remove IPCHandle unneeded CONNECT_FAILED state.
- Fix RegisterNodeWork failure handling.
- Consistently use NodeControllerRemoteProxy for NC RPC.

Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/test/java/org/apache/hyracks/control/cc/cluster/NodeManagerTest.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/base/INodeController.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/NodeControllerRemoteProxy.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ApplicationMessageWork.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/HandleState.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCSystem.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/ReconnectingIPCHandle.java
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/test/java/org/apache/hyracks/ipc/tests/IPCTest.java
M 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java
13 files changed, 254 insertions(+), 199 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/17/2617/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
index b44a6bb..2b03324 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/cluster/NodeManager.java
@@ -105,9 +105,7 @@
 failNode(nodeId);
 }
 try {
-// TODO(mblow): it seems we should close IPC handles when we're 
done with them (like here)
-IIPCHandle ncIPCHandle = 
ccs.getClusterIPC().getHandle(ncState.getNodeController().getAddress());
-ncIPCHandle.send(-1, new AbortCCJobsFunction(ccConfig.getCcId()), 
null);
+ncState.getNodeController().abortJobs(ccs.getCcId());
 } catch (IPCException e) {
 throw HyracksDataException.create(e);
 }
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
index de7d941..00693df 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
@@ -28,11 +28,8 @@
 import org.apache.hyracks.control.cc.cluster.INodeManager;
 import org.apache.hyracks.control.common.controllers.NodeParameters;
 import org.apache.hyracks.control.common.controllers.NodeRegistration;
-import org.apache.hyracks.control.common.ipc.CCNCFunctions;
 import org.apache.hyracks.control.common.ipc.NodeControllerRemoteProxy;
 import org.apache.hyracks.control.common.work.SynchronizableWork;
-import org.apache.hyracks.ipc.api.IIPCHandle;
-import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
@@ -52,36 +49,33 @@
 @Override
 protected void doRun() throws Exception {
 String id = reg.getNodeId();
-// TODO(mblow): it seems we should close IPC handles when we're done 
with them (like here)
-IIPCHandle ncIPCHandle = 

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1442/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3886/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][NET] IPC Connections Improvements

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] IPC Connections Improvements
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3394/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4049b16573c13fcdb1b12c0b6b2a97ee1fcc709e
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No