Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has submitted this change and it was merged.
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
[NO ISSUE][OTH] Log Level Fixes
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2883
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Murtadha Hubail
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/impl/ActivityClusterGraphBuilder.java
M
hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/ResultNetworkInputChannel.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/InMemoryHashJoin.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractSorterOperatorDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponent.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/MemoryComponentMetadata.java
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
14 files changed, 45 insertions(+), 46 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
Murtadha Hubail: Looks good to me, but someone else must approve
diff --git
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
index af9d109..b1a1fcc 100644
---
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
+++
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
@@ -93,7 +93,7 @@
@Override
public final void initialize() throws HyracksDataException {
-LOGGER.log(Level.INFO, "initialize() called on
ActiveSourceOperatorNodePushable");
+LOGGER.trace("initialize() called on
ActiveSourceOperatorNodePushable");
taskThread = Thread.currentThread();
activeManager.registerRuntime(this);
try {
@@ -113,7 +113,7 @@
done = true;
notifyAll();
}
-LOGGER.log(Level.INFO, "initialize() returning on
ActiveSourceOperatorNodePushable");
+LOGGER.trace("initialize() returning on
ActiveSourceOperatorNodePushable");
}
}
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
index 8ade9ec..e5d557b 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
@@ -183,9 +183,9 @@
@Override
public synchronized IActiveEntityEventsListener[] getEventListeners() {
-if (LOGGER.isEnabled(level)) {
-LOGGER.log(level, "getEventListeners() was called");
-LOGGER.log(level, "returning " + entityEventListeners.size() + "
Listeners");
+if (LOGGER.isTraceEnabled()) {
+LOGGER.trace("getEventListeners() was called");
+LOGGER.trace("returning " + entityEventListeners.size() + "
Listeners");
}
return entityEventListeners.values().toArray(new
IActiveEntityEventsListener[entityEventListeners.size()]);
}
diff --git
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7141/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/yC93x7 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3584/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3584/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4679/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/GBT3ZN : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7141/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4310/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4217/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4305/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2883
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
[NO ISSUE][OTH] Log Level Fixes
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20
---
M
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/HybridHashJoinPOperator.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/impl/ActivityClusterGraphBuilder.java
M
hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/ResultNetworkInputChannel.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/InMemoryHashJoin.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/join/OptimizedHybridHashJoinOperatorDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractSorterOperatorDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponent.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMMemoryComponent.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/MemoryComponentMetadata.java
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
14 files changed, 45 insertions(+), 46 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/83/2883/1
diff --git
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
index af9d109..b1a1fcc 100644
---
a/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
+++
b/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveSourceOperatorNodePushable.java
@@ -93,7 +93,7 @@
@Override
public final void initialize() throws HyracksDataException {
-LOGGER.log(Level.INFO, "initialize() called on
ActiveSourceOperatorNodePushable");
+LOGGER.trace("initialize() called on
ActiveSourceOperatorNodePushable");
taskThread = Thread.currentThread();
activeManager.registerRuntime(this);
try {
@@ -113,7 +113,7 @@
done = true;
notifyAll();
}
-LOGGER.log(Level.INFO, "initialize() returning on
ActiveSourceOperatorNodePushable");
+LOGGER.trace("initialize() returning on
ActiveSourceOperatorNodePushable");
}
}
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
index 8ade9ec..e5d557b 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
@@ -183,9 +183,9 @@
@Override
public synchronized IActiveEntityEventsListener[] getEventListeners() {
-if (LOGGER.isEnabled(level)) {
-LOGGER.log(level, "getEventListeners() was called");
-LOGGER.log(level, "returning " + entityEventListeners.size() + "
Listeners");
+if (LOGGER.isTraceEnabled()) {
+LOGGER.trace("getEventListeners() was called");
+LOGGER.trace("returning " + entityEventListeners.size() + "
Listeners");
}
return entityEventListeners.values().toArray(new
IActiveEntityEventsListener[entityEventListeners.size()]);
}
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
index b26342e..3f2412f 100644
---
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/592/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4861/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9783/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4272/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8243/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4526/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/530/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2318/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4710/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2883 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5fb7e3140bf36cf4ba5857b9fda8e6cc4bdfa20 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has submitted this change and it was merged.
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
[NO ISSUE][OTH] Log Level Fixes
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2879
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Michael Blow
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/ActivityClusterPlanner.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/partitions/PartitionMatchMaker.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/result/ResultPartitionWriter.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/collectors/NonDeterministicChannelReader.java
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
8 files changed, 138 insertions(+), 70 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Michael Blow: Looks good to me, approved
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
index 39a8402..b034f47 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
@@ -69,7 +69,7 @@
public abstract class ActiveEntityEventsListener implements
IActiveEntityController {
private static final Logger LOGGER = LogManager.getLogger();
-private static final Level level = Level.INFO;
+private static final Level level = Level.DEBUG;
private static final ActiveEvent STATE_CHANGED = new ActiveEvent(null,
Kind.STATE_CHANGED, null, null);
private static final EnumSet TRANSITION_STATES =
EnumSet.of(ActivityState.RESUMING,
ActivityState.STARTING, ActivityState.STOPPING,
ActivityState.RECOVERING, ActivityState.CANCELLING);
@@ -133,7 +133,9 @@
}
protected synchronized void setState(ActivityState newState) {
-LOGGER.log(level, "State of " + getEntityId() + "is being set to " +
newState + " from " + state);
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "State of " + getEntityId() + "is being set to "
+ newState + " from " + state);
+}
this.prevState = state;
this.state = newState;
if (newState == ActivityState.STARTING || newState ==
ActivityState.RECOVERING
@@ -148,7 +150,9 @@
@Override
public synchronized void notify(ActiveEvent event) {
try {
-LOGGER.log(level, "EventListener is notified.");
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "EventListener is notified.");
+}
ActiveEvent.Kind eventKind = event.getEventKind();
switch (eventKind) {
case JOB_CREATED:
@@ -187,7 +191,9 @@
@SuppressWarnings("unchecked")
protected void finish(ActiveEvent event) throws HyracksDataException {
-LOGGER.log(level, "the job " + jobId + " finished");
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "the job " + jobId + " finished");
+}
JobId lastJobId = jobId;
if (numRegistered != numDeRegistered) {
LOGGER.log(Level.WARN,
@@ -198,7 +204,9 @@
Pair> status = (Pair>) event.getEventObject();
JobStatus jobStatus = status.getLeft();
List exceptions = status.getRight();
-LOGGER.log(level, "The job finished with status: " + jobStatus);
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "The job finished with status: " + jobStatus);
+}
if (!jobSuccessfullyTerminated(jobStatus)) {
jobFailure = exceptions.isEmpty() ? new
RuntimeDataException(ErrorCode.UNREPORTED_TASK_FAILURE_EXCEPTION)
: exceptions.get(0);
@@ -348,7 +356,9 @@
@Override
public synchronized void recover() {
-LOGGER.log(level, "Recover is called on " + entityId);
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level,
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7132/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3579/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3579/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4671/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4702/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/522/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7132/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/vfVyE4 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4516/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4295/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4207/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2308/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/583/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8233/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9773/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4851/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/C1AKjH : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2879
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
[NO ISSUE][OTH] Log Level Fixes
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveNotificationHandler.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/ActivityClusterPlanner.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/partitions/PartitionMatchMaker.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/result/ResultDirectoryService.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/result/ResultPartitionWriter.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/collectors/NonDeterministicChannelReader.java
M
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
8 files changed, 138 insertions(+), 70 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/79/2879/1
diff --git
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
index 39a8402..b034f47 100644
---
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
+++
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java
@@ -69,7 +69,7 @@
public abstract class ActiveEntityEventsListener implements
IActiveEntityController {
private static final Logger LOGGER = LogManager.getLogger();
-private static final Level level = Level.INFO;
+private static final Level level = Level.DEBUG;
private static final ActiveEvent STATE_CHANGED = new ActiveEvent(null,
Kind.STATE_CHANGED, null, null);
private static final EnumSet TRANSITION_STATES =
EnumSet.of(ActivityState.RESUMING,
ActivityState.STARTING, ActivityState.STOPPING,
ActivityState.RECOVERING, ActivityState.CANCELLING);
@@ -133,7 +133,9 @@
}
protected synchronized void setState(ActivityState newState) {
-LOGGER.log(level, "State of " + getEntityId() + "is being set to " +
newState + " from " + state);
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "State of " + getEntityId() + "is being set to "
+ newState + " from " + state);
+}
this.prevState = state;
this.state = newState;
if (newState == ActivityState.STARTING || newState ==
ActivityState.RECOVERING
@@ -148,7 +150,9 @@
@Override
public synchronized void notify(ActiveEvent event) {
try {
-LOGGER.log(level, "EventListener is notified.");
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "EventListener is notified.");
+}
ActiveEvent.Kind eventKind = event.getEventKind();
switch (eventKind) {
case JOB_CREATED:
@@ -187,7 +191,9 @@
@SuppressWarnings("unchecked")
protected void finish(ActiveEvent event) throws HyracksDataException {
-LOGGER.log(level, "the job " + jobId + " finished");
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "the job " + jobId + " finished");
+}
JobId lastJobId = jobId;
if (numRegistered != numDeRegistered) {
LOGGER.log(Level.WARN,
@@ -198,7 +204,9 @@
Pair> status = (Pair>) event.getEventObject();
JobStatus jobStatus = status.getLeft();
List exceptions = status.getRight();
-LOGGER.log(level, "The job finished with status: " + jobStatus);
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "The job finished with status: " + jobStatus);
+}
if (!jobSuccessfullyTerminated(jobStatus)) {
jobFailure = exceptions.isEmpty() ? new
RuntimeDataException(ErrorCode.UNREPORTED_TASK_FAILURE_EXCEPTION)
: exceptions.get(0);
@@ -348,7 +356,9 @@
@Override
public synchronized void recover() {
-LOGGER.log(level, "Recover is called on " + entityId);
+if (LOGGER.isEnabled(level)) {
+LOGGER.log(level, "Recover is called on " + entityId);
+}
if (retryPolicyFactory == NoRetryPolicyFactory.INSTANCE) {
LOGGER.log(level, "But it has no recovery policy, so it is
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4262/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4300/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2879 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbf7a3ee1c358a40918be7badc4bd00ac5d492a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7109/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3558/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4648/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3558/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has submitted this change and it was merged.
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
[NO ISSUE][OTH] Log Level Fixes
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2865
Sonar-Qube: Jenkins
Reviewed-by: Michael Blow
Tested-by: Michael Blow
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
4 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Jenkins: No violations found
Michael Blow: Looks good to me, approved; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
index 9bfd061..81ceea5 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
@@ -103,6 +103,6 @@
ncs.getNodeControllerData().notifyHeartbeat(hbData);
}
-LOGGER.log(Level.DEBUG, "Successfully refreshed heartbeat data");
+LOGGER.trace("Successfully refreshed heartbeat data");
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
index 9160e46..6d08fb1 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
@@ -69,7 +69,7 @@
synchronized (hbData) {
cc.nodeHeartbeat(ncId, hbData);
}
-LOGGER.log(Level.DEBUG, "Successfully sent heartbeat");
+LOGGER.trace("Successfully sent heartbeat");
return true;
} catch (InterruptedException e) {
throw e;
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
index f51271e..980ad9b 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
@@ -235,8 +235,8 @@
}
maxFrameSize = Math.max(maxFrameSize, outputFrame.getFrameSize());
outputAppender.write(writer, true);
-if (LOGGER.isDebugEnabled()) {
-LOGGER.debug(
+if (LOGGER.isTraceEnabled()) {
+LOGGER.trace(
"Flushed records:" + limit + " out of " + tupleCount + ";
Flushed through " + (io + 1) + " frames");
}
return maxFrameSize;
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
index e63a5b8..0a7c842 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
@@ -40,7 +40,6 @@
import org.apache.hyracks.storage.common.file.FileMapManager;
import org.apache.hyracks.storage.common.file.IFileMapManager;
import org.apache.hyracks.util.JSONUtil;
-import org.apache.logging.log4j.Level;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -126,8 +125,8 @@
}
private void logStats() {
-
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4679/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/499/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7109/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has posted comments on this change.
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
Patch Set 1:
(1 comment)
https://asterix-gerrit.ics.uci.edu/#/c/2865/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java:
PS1, Line 190: LOGGER.trace("Reclaimed pages = {}", reclaimedPages
> perhaps we'd be saved at runtime w/ inlining, but otherwise we will have a
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2865
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/4wHZgS : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4268/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9745/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/555/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4274/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4823/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2865 to look at the new patch set (#2). Change subject: [NO ISSUE][OTH] Log Level Fixes .. [NO ISSUE][OTH] Log Level Fixes - user model changes: no - storage format changes: no - interface changes: no Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java M hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java 4 files changed, 8 insertions(+), 9 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/65/2865/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8206/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4234/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2281/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4490/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4181/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Michael Blow has posted comments on this change.
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
Patch Set 1:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2865/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
File
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java:
PS1, Line 72: trace
i mean sure, but it's only once every 10 (30 in some extensions) seconds by
default...
https://asterix-gerrit.ics.uci.edu/#/c/2865/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
File
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java:
PS1, Line 190: LOGGER.trace("Reclaimed pages = {}", reclaimedPages
perhaps we'd be saved at runtime w/ inlining, but otherwise we will have a
boxing of reclaimedPages here- should we surround with an is enabled check and
restore the concatenation?
--
To view, visit https://asterix-gerrit.ics.uci.edu/2865
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: abdullah alamoudi
Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/1TJFBC : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7103/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3552/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3552/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4642/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4673/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/493/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/coL4cc : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4484/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7103/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2274/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4262/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9738/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/548/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4816/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8199/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4267/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4174/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log Level Fixes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4227/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2865 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log Level Fixes
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2865
Change subject: [NO ISSUE][OTH] Log Level Fixes
..
[NO ISSUE][OTH] Log Level Fixes
- user model changes: no
- storage format changes: no
- interface changes: no
Change-Id: I6c83103e16b7a356167639a7a4d5c70d93335a53
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
M
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
4 files changed, 7 insertions(+), 10 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/65/2865/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
index 9bfd061..81ceea5 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatComputeTask.java
@@ -103,6 +103,6 @@
ncs.getNodeControllerData().notifyHeartbeat(hbData);
}
-LOGGER.log(Level.DEBUG, "Successfully refreshed heartbeat data");
+LOGGER.trace("Successfully refreshed heartbeat data");
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
index 9160e46..6d08fb1 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/heartbeat/HeartbeatTask.java
@@ -69,7 +69,7 @@
synchronized (hbData) {
cc.nodeHeartbeat(ncId, hbData);
}
-LOGGER.log(Level.DEBUG, "Successfully sent heartbeat");
+LOGGER.trace("Successfully sent heartbeat");
return true;
} catch (InterruptedException e) {
throw e;
diff --git
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
index f51271e..980ad9b 100644
---
a/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
+++
b/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/sort/AbstractFrameSorter.java
@@ -235,8 +235,8 @@
}
maxFrameSize = Math.max(maxFrameSize, outputFrame.getFrameSize());
outputAppender.write(writer, true);
-if (LOGGER.isDebugEnabled()) {
-LOGGER.debug(
+if (LOGGER.isTraceEnabled()) {
+LOGGER.trace(
"Flushed records:" + limit + " out of " + tupleCount + ";
Flushed through " + (io + 1) + " frames");
}
return maxFrameSize;
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
index e63a5b8..6527c62 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/VirtualBufferCache.java
@@ -40,7 +40,6 @@
import org.apache.hyracks.storage.common.file.FileMapManager;
import org.apache.hyracks.storage.common.file.IFileMapManager;
import org.apache.hyracks.util.JSONUtil;
-import org.apache.logging.log4j.Level;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -126,8 +125,8 @@
}
private void logStats() {
-if (LOGGER.isInfoEnabled()) {
-LOGGER.log(Level.INFO, "Free (allocated) pages = " +
