Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4724/
 (13/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7189/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/hDJGbG : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4328/ 
(10/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9838/ (7/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4755/ 
(4/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4919/ (1/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4581/ 
(2/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/647/ 
(12/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Michael Blow (Code Review)
Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2910

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..

[NO ISSUE][OTH] Log directory tweak, minor perf fix

Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
---
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
3 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/10/2910/1

diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
index 59ef913..22dea9f 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
@@ -18,6 +18,9 @@
  */
 package org.apache.hyracks.control.cc;
 
+import java.io.File;
+import java.net.URI;
+
 import org.apache.hyracks.control.common.controllers.CCConfig;
 import org.apache.logging.log4j.Level;
 import org.apache.logging.log4j.core.LoggerContext;
@@ -30,8 +33,6 @@
 import org.apache.logging.log4j.core.config.builder.api.LayoutComponentBuilder;
 import org.apache.logging.log4j.core.config.builder.impl.BuiltConfiguration;
 
-import java.net.URI;
-
 public class CCLogConfigurationFactory extends ConfigurationFactory {
 private CCConfig config;
 
@@ -40,7 +41,7 @@
 }
 
 public Configuration 
createConfiguration(ConfigurationBuilder builder) {
-String logDir = config.getLogDir();
+File logDir = new File(config.getLogDir());
 builder.setStatusLevel(Level.WARN);
 builder.setConfigurationName("RollingBuilder");
 // create a rolling file appender
@@ -50,8 +51,8 @@
 
.addComponent(builder.newComponent("CronTriggeringPolicy").addAttribute("schedule",
 "0 0 0 * * ?"))
 
.addComponent(builder.newComponent("SizeBasedTriggeringPolicy").addAttribute("size",
 "50M"));
 AppenderComponentBuilder defaultRoll =
-builder.newAppender("default", 
"RollingFile").addAttribute("fileName", logDir + "cc.log")
-.addAttribute("filePattern", logDir + 
"cc-%d{MM-dd-yy}.log.gz").add(defaultLayout)
+builder.newAppender("default", 
"RollingFile").addAttribute("fileName", new File(logDir, "cc.log"))
+.addAttribute("filePattern", new File(logDir, 
"cc-%d{MM-dd-yy}.log.gz")).add(defaultLayout)
 .addComponent(triggeringPolicy);
 builder.add(defaultRoll);
 
@@ -60,8 +61,8 @@
 
 LayoutComponentBuilder accessLayout = 
builder.newLayout("PatternLayout").addAttribute("pattern", "%m%n");
 AppenderComponentBuilder accessRoll =
-builder.newAppender("access", 
"RollingFile").addAttribute("fileName", logDir + "access.log")
-.addAttribute("filePattern", logDir + 
"access-%d{MM-dd-yy}.log.gz").add(accessLayout)
+builder.newAppender("access", 
"RollingFile").addAttribute("fileName", new File(logDir, "access.log"))
+.addAttribute("filePattern", new File(logDir, 
"access-%d{MM-dd-yy}.log.gz")).add(accessLayout)
 .addComponent(triggeringPolicy);
 builder.add(accessRoll);
 
builder.add(builder.newLogger("org.apache.hyracks.http.server.CLFLogger", 
Level.forName("ACCESS", 550))
diff --git 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
index 65c7ca5..07e61ba 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
@@ -45,7 +45,7 @@
 LOG_DIR(
 OptionTypes.STRING,
 (Function) appConfig -> FileUtil
-
.joinPath(appConfig.getString(ControllerConfig.Option.DEFAULT_DIR), "logs/"),
+

Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4360/ 
(3/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2374/ 
(8/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8298/ (5/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4362/
 (11/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/576/ 
(9/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix

2018-08-15 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4274/ 
(6/13)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2910
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No