Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. [NO ISSUE][OTH] Return Encountered Exception to NC - user model changes: no - storage format changes: no - interface changes: no Details: - Return the encountered exception during query execution to NC instead of wrapping only the exception message in a new exception. Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Reviewed-on: https://asterix-gerrit.ics.uci.edu/2628 Sonar-Qube: JenkinsTested-by: Jenkins Contrib: Jenkins Reviewed-by: Murtadha Hubail Integration-Tests: Jenkins Reviewed-by: Michael Blow --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Michael Blow: Looks good to me, approved Murtadha Hubail: Looks good to me, but someone else must approve diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java index d295304..8de3782 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java @@ -139,7 +139,7 @@ responseMsg.setError(pe); } catch (Exception e) { GlobalConfig.ASTERIX_LOGGER.log(Level.ERROR, "Unexpected exception", e); -responseMsg.setError(new Exception(e.toString())); +responseMsg.setError(e); } try { messageBroker.sendApplicationMessageToNC(responseMsg, requestNodeId); -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2628/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java: PS1, Line 142: responseMsg.setError(e); Not a fan of making it a generic-exception either, but do we want all the nested causes sent to the NC? -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6331/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/b7Gmqh : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3122/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3122/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/7xyDXj : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/6331/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3677/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2628 Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. [NO ISSUE][OTH] Return Encountered Exception to NC - user model changes: no - storage format changes: no - interface changes: no Details: - Return the encountered exception during query execution to NC instead of wrapping only the exception message in a new exception. Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/28/2628/1 diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java index d295304..8de3782 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java @@ -139,7 +139,7 @@ responseMsg.setError(pe); } catch (Exception e) { GlobalConfig.ASTERIX_LOGGER.log(Level.ERROR, "Unexpected exception", e); -responseMsg.setError(new Exception(e.toString())); +responseMsg.setError(e); } try { messageBroker.sendApplicationMessageToNC(responseMsg, requestNodeId); -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/4178/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8925/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3994/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3450/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1469/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3462/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3374/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3893/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3421/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3913/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Return Encountered Exception to NC
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Return Encountered Exception to NC .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7401/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2628 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51f3cba13edd4ef73c3833841e3990c2ed8fdfa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No