Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


[NO ISSUE][OTR] Clean up INcApplicationContext

Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2372
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
3 files changed, 4 insertions(+), 18 deletions(-)

Approvals:
  Anon. E. Moose #1000171: 
  Jenkins: Verified; No violations found; ; Verified
  Michael Blow: Looks good to me, approved



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
index 6e25856..3780078 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
@@ -306,11 +306,6 @@
 }
 
 @Override
-public double getBloomFilterFalsePositiveRate() {
-return storageProperties.getBloomFilterFalsePositiveRate();
-}
-
-@Override
 public ILSMIOOperationScheduler getLSMIOScheduler() {
 return lsmIOScheduler;
 }
@@ -373,11 +368,6 @@
 @Override
 public NodeProperties getNodeProperties() {
 return nodeProperties;
-}
-
-@Override
-public ILSMOperationTracker getPrimaryOperationTracker(int datasetID, int 
partition) {
-return datasetLifecycleManager.getOperationTracker(datasetID, 
partition);
 }
 
 @Override
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
index 19b4d61..9eb6259 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
@@ -23,7 +23,6 @@
 import java.util.concurrent.Executor;
 
 import org.apache.asterix.common.context.IStorageComponentProvider;
-import org.apache.asterix.common.exceptions.ACIDException;
 import org.apache.asterix.common.replication.IReplicationChannel;
 import org.apache.asterix.common.replication.IReplicationManager;
 import org.apache.asterix.common.storage.IIndexCheckpointManagerProvider;
@@ -36,7 +35,6 @@
 import org.apache.hyracks.api.io.IIOManager;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperationScheduler;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMMergePolicyFactory;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMOperationTracker;
 import org.apache.hyracks.storage.common.ILocalResourceRepository;
 import org.apache.hyracks.storage.common.buffercache.IBufferCache;
 import org.apache.hyracks.storage.common.file.IResourceIdFactory;
@@ -67,15 +65,11 @@
 
 IResourceIdFactory getResourceIdFactory();
 
-ILSMOperationTracker getPrimaryOperationTracker(int datasetID, int 
partition);
-
-void initialize(boolean initialRun) throws IOException, ACIDException, 
AlgebricksException;
+void initialize(boolean initialRun) throws IOException, 
AlgebricksException;
 
 void setShuttingdown(boolean b);
 
 void deinitialize() throws HyracksDataException;
-
-double getBloomFilterFalsePositiveRate();
 
 Object getActiveManager();
 
diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
index 23806bd..7d5558d 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
@@ -334,13 +334,15 @@
 new LSMBTreeIOOperationCallbackFactory(idGeneratorProvider);
 IStorageComponentProvider storageComponentProvider = 
appContext.getStorageComponentProvider();
 if (isNewUniverse()) {
+final double bloomFilterFalsePositiveRate =
+
appContext.getStorageProperties().getBloomFilterFalsePositiveRate();
 LSMBTreeLocalResourceFactory lsmBtreeFactory = new 
LSMBTreeLocalResourceFactory(
 

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Analytics Compatibility Tests Successful
https://goo.gl/7YYGVg : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5551/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2650/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/He13Yw : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2650/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/L8FnuG : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1: -Contrib

Analytics Compatibility Compilation Successful
https://goo.gl/1JzBFR : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5551/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1: Contrib-2

Analytics Compatibility Compilation Failed
https://goo.gl/u5uP9P : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3374/ (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8083/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2592/
 (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3120/
 (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2531/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2586/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6578/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/635/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3145/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3159/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2571/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2845/ 
(3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2372
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][OTR] Clean up INcApplicationContext

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2372

Change subject: [NO ISSUE][OTR] Clean up INcApplicationContext
..

[NO ISSUE][OTR] Clean up INcApplicationContext

Change-Id: Ide17ab0ea7553a6e8e22487b52ba0af379431f81
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
3 files changed, 4 insertions(+), 18 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/72/2372/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
index 6e25856..3780078 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
@@ -306,11 +306,6 @@
 }
 
 @Override
-public double getBloomFilterFalsePositiveRate() {
-return storageProperties.getBloomFilterFalsePositiveRate();
-}
-
-@Override
 public ILSMIOOperationScheduler getLSMIOScheduler() {
 return lsmIOScheduler;
 }
@@ -373,11 +368,6 @@
 @Override
 public NodeProperties getNodeProperties() {
 return nodeProperties;
-}
-
-@Override
-public ILSMOperationTracker getPrimaryOperationTracker(int datasetID, int 
partition) {
-return datasetLifecycleManager.getOperationTracker(datasetID, 
partition);
 }
 
 @Override
diff --git 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
index 19b4d61..9eb6259 100644
--- 
a/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
+++ 
b/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/INcApplicationContext.java
@@ -23,7 +23,6 @@
 import java.util.concurrent.Executor;
 
 import org.apache.asterix.common.context.IStorageComponentProvider;
-import org.apache.asterix.common.exceptions.ACIDException;
 import org.apache.asterix.common.replication.IReplicationChannel;
 import org.apache.asterix.common.replication.IReplicationManager;
 import org.apache.asterix.common.storage.IIndexCheckpointManagerProvider;
@@ -36,7 +35,6 @@
 import org.apache.hyracks.api.io.IIOManager;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMIOOperationScheduler;
 import org.apache.hyracks.storage.am.lsm.common.api.ILSMMergePolicyFactory;
-import org.apache.hyracks.storage.am.lsm.common.api.ILSMOperationTracker;
 import org.apache.hyracks.storage.common.ILocalResourceRepository;
 import org.apache.hyracks.storage.common.buffercache.IBufferCache;
 import org.apache.hyracks.storage.common.file.IResourceIdFactory;
@@ -67,15 +65,11 @@
 
 IResourceIdFactory getResourceIdFactory();
 
-ILSMOperationTracker getPrimaryOperationTracker(int datasetID, int 
partition);
-
-void initialize(boolean initialRun) throws IOException, ACIDException, 
AlgebricksException;
+void initialize(boolean initialRun) throws IOException, 
AlgebricksException;
 
 void setShuttingdown(boolean b);
 
 void deinitialize() throws HyracksDataException;
-
-double getBloomFilterFalsePositiveRate();
 
 Object getActiveManager();
 
diff --git 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
index 23806bd..7d5558d 100644
--- 
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
+++ 
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java
@@ -334,13 +334,15 @@
 new LSMBTreeIOOperationCallbackFactory(idGeneratorProvider);
 IStorageComponentProvider storageComponentProvider = 
appContext.getStorageComponentProvider();
 if (isNewUniverse()) {
+final double bloomFilterFalsePositiveRate =
+
appContext.getStorageProperties().getBloomFilterFalsePositiveRate();
 LSMBTreeLocalResourceFactory lsmBtreeFactory = new 
LSMBTreeLocalResourceFactory(
 storageComponentProvider.getStorageManager(), typeTraits, 
cmpFactories, null, null, null,
 opTrackerFactory, ioOpCallbackFactory, 
storageComponentProvider.getMetadataPageManagerFactory(),
 new AsterixVirtualBufferCacheProvider(datasetId),