Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter - user model changes: no - storage format changes: no - interface changes: no Details: Currently the durable flag is wrongly passed as true all the time in LSMRTreeWithAntiMatter while it should be based on the resource durable flag. Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2158 Sonar-Qube: JenkinsReviewed-by: Ian Maxon Tested-by: Jenkins Integration-Tests: Jenkins --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins: Verified; No violations found; Verified Ian Maxon: Looks good to me, approved Objections: Anon. E. Moose #1000171: Violations found diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java index e807c72..f586d51 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java @@ -85,6 +85,6 @@ mergePolicyFactory.createMergePolicy(mergePolicyProperties, serviceCtx), opTrackerProvider.getOperationTracker(serviceCtx), ioSchedulerProvider.getIoScheduler(serviceCtx), ioOpCallbackFactory, linearizeCmpFactory, rtreeFields, filterTypeTraits, filterCmpFactories, -filterFields, true, isPointMBR, metadataPageManagerFactory); +filterFields, durable, isPointMBR, metadataPageManagerFactory); } } -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4634/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2158/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed Build 2978 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2158/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Ian Maxon has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1624/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4634/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2288/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2482/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2269/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5656/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/799/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1602/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1614/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1620/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1936/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7153/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Jenkins has posted comments on this change. Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2229/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha HubailGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter
Murtadha Hubail has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/2158 Change subject: [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter .. [NO ISSUE][STO] Pass Durable Flag in LSMRTreeWithAntiMatter - user model changes: no - storage format changes: no - interface changes: no Details: Currently the durable flag is wrongly passed as true all the time in LSMRTreeWithAntiMatter while it should be based on the resource durable flag. Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 --- M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/58/2158/1 diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java index e807c72..f586d51 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/dataflow/LSMRTreeWithAntiMatterLocalResource.java @@ -85,6 +85,6 @@ mergePolicyFactory.createMergePolicy(mergePolicyProperties, serviceCtx), opTrackerProvider.getOperationTracker(serviceCtx), ioSchedulerProvider.getIoScheduler(serviceCtx), ioOpCallbackFactory, linearizeCmpFactory, rtreeFields, filterTypeTraits, filterCmpFactories, -filterFields, true, isPointMBR, metadataPageManagerFactory); +filterFields, durable, isPointMBR, metadataPageManagerFactory); } } -- To view, visit https://asterix-gerrit.ics.uci.edu/2158 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If6ad82cdf4f9105c918d69325762a6dfc733ca55 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail