Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3676/ (7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2913/ 
(10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3484/ (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3428/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Murtadha Hubail (Code Review)]

Murtadha Hubail has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2456

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..

[NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
- Ensure rollback of an atomic transaction starts
  from its first LSN.
- Ensure update logs of uncommited atomic transactions
  are undone during recovery.
- Add test case for atomic transaction rollback after
  flush.
- Add test case for atomic transaction recovery after
  flush.

Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/txn/RecoveryManagerTest.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITransactionContext.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/AtomicTransactionContext.java
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/EntityLevelTransactionContext.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/InvokeUtil.java
7 files changed, 198 insertions(+), 46 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/56/2456/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
index 74277ce..5a4bbc0 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java
@@ -49,6 +49,7 @@
 import org.apache.asterix.common.dataflow.DatasetLocalResource;
 import org.apache.asterix.common.exceptions.ACIDException;
 import org.apache.asterix.common.ioopcallbacks.AbstractLSMIOOperationCallback;
+import org.apache.asterix.common.metadata.MetadataIndexImmutableProperties;
 import org.apache.asterix.common.storage.DatasetResourceReference;
 import org.apache.asterix.common.storage.IIndexCheckpointManagerProvider;
 import org.apache.asterix.common.transactions.Checkpoint;
@@ -174,16 +175,16 @@
 public synchronized void replayPartitionsLogs(Set partitions, 
ILogReader logReader, long lowWaterMarkLSN)
 throws IOException, ACIDException {
 try {
-Set winnerJobSet = startRecoverysAnalysisPhase(partitions, 
logReader, lowWaterMarkLSN);
-startRecoveryRedoPhase(partitions, logReader, lowWaterMarkLSN, 
winnerJobSet);
+Set winnerJobSet = startRecoveryAnalysisPhase(partitions, 
logReader, lowWaterMarkLSN);
+startRecoveryUndoRedoPhase(partitions, logReader, lowWaterMarkLSN, 
winnerJobSet);
 } finally {
 logReader.close();
 deleteRecoveryTemporaryFiles();
 }
 }
 
-private synchronized Set startRecoverysAnalysisPhase(Set 
partitions, ILogReader logReader,
-long lowWaterMarkLSN) throws IOException, ACIDException {
+private synchronized Set startRecoveryAnalysisPhase(Set 
partitions, ILogReader logReader,
+long lowWaterMarkLSN) throws IOException {
 int updateLogCount = 0;
 int entityCommitLogCount = 0;
 int jobCommitLogCount = 0;
@@ -268,19 +269,21 @@
 jobEntityWinners.add(logRecord);
 }
 
-private synchronized void startRecoveryRedoPhase(Set partitions, 
ILogReader logReader,
-long lowWaterMarkLSN, Set winnerTxnSet) throws IOException, 
ACIDException {
+private synchronized void startRecoveryUndoRedoPhase(Set 
partitions, ILogReader logReader,
+long lowWaterMarkLSN, Set winnerTxnSet) throws IOException {
 int redoCount = 0;
+int undoCount = 0;
 long txnId = 0;
 
 long resourceId;
 long maxDiskLastLsn;
-long lsn = -1;
-ILSMIndex index = null;
-LocalResource localResource = null;
-DatasetLocalResource localResourceMetadata = null;
-boolean foundWinner = false;
-JobEntityCommits jobEntityWinners = null;
+long lsn;
+ILSMIndex index;
+LocalResource localResource;
+DatasetLocalResource localResourceMetadata;
+boolean foundWinner;
+boolean foundLoser;
+JobEntityCommits jobEntityWinners;
 
 IDatasetLifecycleManager datasetLifecycleManager = 
appCtx.getDatasetLifecycleManager();
 final IIndexCheckpointManagerProvider indexCheckpointManagerProvider =
@@ -290,8 +293,8 @@
 Map resourceId2MaxLSNMap = new HashMap<>();
 

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2864/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2950/
 (8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3170/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2939/ 
(9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6903/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3404/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8410/ (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [NO ISSUE][TX] Ensure Uncommited Atomic Txns Are Rolledback
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/960/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2456
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No