Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Taewoo Kim has submitted this change and it was merged.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1432
Reviewed-by: Yingyi Bu 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
BAD: Jenkins 
Integration-Tests: Jenkins 
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
M hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
6 files changed, 247 insertions(+), 5 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
 
b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
index 6e53e2a..92bc076 100644
--- 
a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
+++ 
b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
@@ -20,6 +20,7 @@
 
 import java.io.Serializable;
 
+import org.apache.hyracks.api.exceptions.ErrorCode;
 import org.apache.hyracks.api.util.ErrorMessageUtil;
 
 public class AlgebricksException extends Exception {
@@ -41,6 +42,10 @@
 this.params = params;
 }
 
+public static AlgebricksException create(int errorCode, Serializable... 
params) {
+return new AlgebricksException(ErrorCode.HYRACKS, errorCode, 
ErrorCode.getErrorMessage(errorCode), params);
+}
+
 public AlgebricksException(String message) {
 this(ErrorMessageUtil.NONE, UNKNOWN, message, null, null);
 }
diff --git a/hyracks-fullstack/algebricks/algebricks-compiler/pom.xml 
b/hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
index 951fe0f..505b268 100644
--- a/hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
+++ b/hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
@@ -66,5 +66,34 @@
   org.apache.commons
   commons-lang3
 
+
+  org.mockito
+  mockito-all
+  1.10.19
+  test
+
+   
+  org.powermock
+  powermock-api-mockito
+  1.6.6
+  test
+   
+   
+  org.powermock
+  powermock-core
+  1.6.6
+  test
+   
+   
+  org.powermock
+  powermock-module-junit4
+  1.6.6
+  test
+   
+
+  junit
+  junit
+  test
+
   
 
diff --git 
a/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
 
b/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
new file mode 100644
index 000..9446756
--- /dev/null
+++ 
b/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 12: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1654/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 12: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/338/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 12:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1654/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 12:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/338/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 11: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1652/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3988/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 12: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#12).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
M hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
6 files changed, 247 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 11:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1432/11/hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java
File 
hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java:

Line 95: //  Iteration2: R1 false, R2 false, R3 false
> false, true, false?
false, false, false


Line 95: //  Iteration2: R1 false, R2 false, R3 false
> true, true, false?
false, true, false


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 11:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1432/11/hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java
File 
hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java:

Line 93: // Case 3: a mixture of returning true/false.
> true, false, false? typo?
That's right, actually.


Line 95: //  Iteration2: R1 false, R2 false, R3 false
> true, true, false?
false, true, false?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 11: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/336/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 11:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1652/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 11:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/336/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3986/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3984/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3983/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#10).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
M hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
6 files changed, 241 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3982/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#9).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
M hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/test/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleControllerTest.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
6 files changed, 241 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/9
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1648/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1648/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1646/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/331/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/331/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1646/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8:

An unit test has not been added yet.  I will let you know once I'm done.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3977/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#8).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
4 files changed, 107 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/8
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1643/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 7: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/328/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1643/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 7:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/328/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3973/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#7).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
4 files changed, 108 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/7
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3972/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
File 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java:

Line 53: @Override
> Add a MockIto-based unit test for rewriteWithRuleCollection?
This part, it would be nice if you can provide an unit test that I can refer.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#6).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
4 files changed, 108 insertions(+), 5 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

(8 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
File 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java:

Line 45: public static AlgebricksException create(int code, Serializable... 
params) {
> code -> errorCode
Done


https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
File 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java:

Line 56: boolean anyRuleFired;
> move the declaration to line 69, combing that with the rest of the line.
Done


Line 57: boolean anyChange;
> move the declaration to line 79.
Done


Line 68: // Checks whether the first rule returns true.
> Make sure that empty input collection can still work gracefully?
Done


Line 70: if (!anyRuleFired) {
> Adding a "if" check after line 83 should be able to get rid of line 68 to l
Done


Line 75: for (int i = 1; i < rules.size(); i++) {
> Why do you need that for-loop iteration?
I have added this not to execute the first rule twice in the first iteration. 
But, I think addressing your above comment will solve this, too.


https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java:

Line 29:  */
> describe the error code boundary here.
Done


Line 38: public static final int RUNTIME_FULLTEXT_PHRASE_FOUND = 5;
> There is no corresponding message in the properties file.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
File 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java:

Line 68: // Checks whether the first rule returns true.
Make sure that empty input collection can still work gracefully?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
File 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java:

Line 53: @Override
Add a MockIto-based unit test for rewriteWithRuleCollection?

E.g, you can verify the call count etc.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
File 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java:

Line 45: public static AlgebricksException create(int code, Serializable... 
params) {
code -> errorCode


https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
File 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java:

Line 56: boolean anyRuleFired;
move the declaration to line 69, combing that with the rest of the line.


Line 57: boolean anyChange;
move the declaration to line 79.


Line 70: if (!anyRuleFired) {
Adding a "if" check after line 83 should be able to get rid of line 68 to line 
78?


Line 75: for (int i = 1; i < rules.size(); i++) {
Why do you need that for-loop iteration?


https://asterix-gerrit.ics.uci.edu/#/c/1432/5/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java:

Line 29:  */
describe the error code boundary here.


Line 38: public static final int RUNTIME_FULLTEXT_PHRASE_FOUND = 5;
There is no corresponding message in the properties file.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1639/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1639/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1636/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1636/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1632/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/320/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/320/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1632/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3961/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1622/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1622/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 4: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/313/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/313/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3954/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#4).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
3 files changed, 97 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 3: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/302/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/302/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1609/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3942/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#3).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
3 files changed, 97 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1589/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1589/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1585/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1585/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1580/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1580/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/278/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/278/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/274/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/274/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3908/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1432

to look at the new patch set (#2).

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
3 files changed, 97 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1554/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 1: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/257/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/257/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1554/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: AQLPlus Refactoring 1: add a new rule controller
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3877/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1432
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: AQLPlus Refactoring 1: add a new rule controller

[Taewoo Kim (Code Review)]

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1432

Change subject: AQLPlus Refactoring 1: add a new rule controller
..

AQLPlus Refactoring 1: add a new rule controller

 - Add a new rule controller that is to be used for FuzzyJoinRuleCollection.
   If the first rule is not fired in the first iteration, no additional rules
   in the given collection will be checked. If the first rule is fired, then
   it behaves like SequentialFixpointRuleController - run rules sequentially
   until one iteration over all rules produces no change.
 - This rule controller is added to make sure that fuzzy-join framework does
   not interfere with non-fuzzy-join queries.

Change-Id: I2742e891339e5aba37a00f77d7f18cb3c09bcfe2
---
M 
hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
A 
hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
3 files changed, 97 insertions(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/1432/1

diff --git 
a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
 
b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
index 6e53e2a..477efc7 100644
--- 
a/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
+++ 
b/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/exceptions/AlgebricksException.java
@@ -20,6 +20,7 @@
 
 import java.io.Serializable;
 
+import org.apache.hyracks.api.exceptions.ErrorCode;
 import org.apache.hyracks.api.util.ErrorMessageUtil;
 
 public class AlgebricksException extends Exception {
@@ -41,6 +42,10 @@
 this.params = params;
 }
 
+public static AlgebricksException create(int code, Serializable... params) 
{
+return new AlgebricksException(ErrorCode.HYRACKS, code, 
ErrorCode.getErrorMessage(code), params);
+}
+
 public AlgebricksException(String message) {
 this(ErrorMessageUtil.NONE, UNKNOWN, message, null, null);
 }
diff --git 
a/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
 
b/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
new file mode 100644
index 000..4dd6b64
--- /dev/null
+++ 
b/hyracks-fullstack/algebricks/algebricks-compiler/src/main/java/org/apache/hyracks/algebricks/compiler/rewriter/rulecontrollers/SequentialFirstRuleCheckFixpointRuleController.java
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.hyracks.algebricks.compiler.rewriter.rulecontrollers;
+
+import java.util.Collection;
+import java.util.List;
+
+import org.apache.commons.lang3.mutable.Mutable;
+import org.apache.hyracks.algebricks.common.exceptions.AlgebricksException;
+import org.apache.hyracks.algebricks.core.algebra.base.ILogicalOperator;
+import org.apache.hyracks.algebricks.core.rewriter.base.AbstractRuleController;
+import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule;
+import org.apache.hyracks.api.exceptions.ErrorCode;
+
+/**
+ * If the first rule in the given collection is fired during the first 
iteration, it also runs the other rules
+ * sequentially (round-robin) until one iteration over all rules produces no 
change. Except the case where the first
+ * rule in the first iteration fails, all rules will be checked for each 
iteration.
+ * An example scenario:
+ * Suppose there are three rules - R1, R2, and R3.
+