Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Taewoo Kim has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 8: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1119/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java: Line 197: private void gatherProducingDataScans(Mutable opRef, Set parentWithUM) { AbstractUnnestMapOperator Line 206: } else if (op.getOperatorTag() == LogicalOperatorTag.UNNEST_MAP) { We also have LEFT_OUTER_UNNEST_MAP. You need to add this too. Line 208: parentWithUM.add((UnnestMapOperator) op); AbstractUnnestMapOperator -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Chen Li has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 8: @wenhai: Similar to another "fuzzy issue", I talked to @taewoo about this patch. I suggest you two schedule a skype time to go through the changes together to explain/approve those changes. Also I think it's critical to make sure proper comments are added, and those comments are clear. Try to avoid grammatical mistakes in the comments. Thanks! -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 8: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/548/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Wenhai Li has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 8: @Chen It's a quite strange query, the high-level comments towards the example is like: 1. We setup a fuzzy join over A.a ~= B.b based on a word index over A.a 2. We want to aggregate on B's fields. If we switch the consequence of A and B in the two "FOR" lines, we get inconsistent result. The RemoveUnusedOneToOneEuquiJoinRule remove the branch of A after "pseudo" broadcase B to A for enabling "SELECT" instead of fuzzy join. But that is wrong. -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 8: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2505/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1119 to look at the new patch set (#8). Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. 1. Add the test case of ASTERIX-1487 with half records required. 2. Disable the join branch pruning in case of unnestmap following datasourcescan. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 6 files changed, 139 insertions(+), 17 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/8 -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Wenhai Li has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 7: @Chen Ok, I will give an example with comments ASAP. -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Wenhai Li Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Chen Li has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 7: Wenhai: I am trying to review this patch. To help me (or other reviewers), can you add a high-level description of the cause of the problem, and how you fix it? In addition, for those major changes (mainly the java file), add a few comments to explain those changes. That will help a lot! -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/477/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 7: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/477/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 7: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2414/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1119 to look at the new patch set (#7). Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. 1. Add the test case of ASTERIX-1487 with half records required. 2. Disable the join branch pruning in case of unnestmap following datasourcescan. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 6 files changed, 135 insertions(+), 17 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/7 -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 6: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/475/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Chen Li Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1119 to look at the new patch set (#6). Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. 1. Add the test case of ASTERIX-1487 with half records required. 2. Disable the join branch pruning in case of unnestmap following datasourcescan. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 6 files changed, 134 insertions(+), 17 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/6 -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 6: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2412/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1119 to look at the new patch set (#5). Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. 1. Add the test case of ASTERIX-1487 with half records required. 2. Disable the join branch pruning in case of unnestmap following datasourcescan. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveUnusedOneToOneEquiJoinRule.java A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_4.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 6 files changed, 134 insertions(+), 17 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/5 -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1119 to look at the new patch set (#4). Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. 1. Add the test case of ASTERIX-1487 with half records required. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_4.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 5 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/4 -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2407/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2406/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin.
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1119 to look at the new patch set (#3). Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. 1. Add the test case of ASTERIX-1487 with half records required. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_4.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 5 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The...
Wenhai Li has uploaded a new patch set (#2). Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The following commits from your working branch will be included: .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The following commits from your working branch will be included: 1. Add the test case of ASTERIX-1487 with half records required. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_4.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 5 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The...
Jenkins has posted comments on this change. Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The following commits from your working branch will be included: .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2405/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1119 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai LiGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The...
Wenhai Li has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1119 Change subject: ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The following commits from your working branch will be included: .. ASTERIX-1487: fix the wrong plan for inverted fuzzyjoin. The following commits from your working branch will be included: 1. Add the test case of ASTERIX-1487 with half records required. commit 957aaa59f279b53c7901758f88a1820dd8b689c9 Author: MichaelDate: Fri Aug 26 06:53:00 2016 -0700 ASTERIX-1487: fix the wrong plan for inverted index. Change-Id: I1aef69a2278853fd9f8020da6639331b367ed5ad --- A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql A asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql A asterixdb/asterix-app/src/test/resources/runtimets/results/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_4.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml 5 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/1119/1 diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql b/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql new file mode 100644 index 000..811c2b5 --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.1.ddl.aql @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +drop dataverse fuzzyjoin if exists; + +create dataverse fuzzyjoin; + +use dataverse fuzzyjoin; + +create type DBLPType as open { + id: int64, + dblpid: string?, + title: string?, + authors: string?, + misc: string? +} + +create type CSXType as open { + id: int64, + csxid: string?, + title: string?, + authors: string?, + misc: string? +} + +create dataset DBLP(DBLPType) primary key id; +create dataset CSX(CSXType) primary key id; + +create index author_index on DBLP(authors) type keyword; diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql b/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql new file mode 100644 index 000..fc2fb4b --- /dev/null +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.2.update.aql @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use dataverse fuzzyjoin; + +load dataset DBLP +using localfs +(("path"="asterix_nc1://data/pub-small/dblp-small-id.txt"),("format"="delimited-text"),("delimiter"=":")); + +load dataset CSX +using localfs +(("path"="asterix_nc1://data/pub-small/csx-small-id.txt"),("format"="delimited-text"),("delimiter"=":"),("quote"="\u")); + diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-aqlplus_5/dblp-csx-aqlplus_5.3.query.aql