Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-09 Thread Steven Jacobs (Code Review) 
Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-08 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/589/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-08 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/589/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-08 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2556/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-08 Thread Preston Carman (Code Review) 
Hello Steven Jacobs, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1151

to look at the new patch set (#2).

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..

ASTERIXDB-1635 Fix for overlap-bins start for dates.

The fix involves two code changes and several sonar fixes.
The code changes are the following:
 - DurationArithmeticOperations line 75:
When the month was zero, an index out of bound error occured in line 88 or 
92.
The month value should be between 1 and 12.
 - OverlapBinsDescriptor line 170:
The Gregorian Calendar is expecting a value in ms. When a date value comes 
in,
AsterixDB represents the value as the number of days from epoc. So the year
for a date basically allways translated to 1970. In lines 121, a condition
was added to check if the interval was a date, if so, convert the date to
ms.

Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/datetime_functions/datetime_functions.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/datetime_functions/datetime_functions.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/datetime_functions/datetime_functions.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/temporal/datetime_functions/datetime_functions.3.ast
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/temporal/overlap_bins/overlap_bins.3.ast
M asterixdb/asterix-doc/src/site/markdown/aql/functions.md
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DurationArithmeticOperations.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/OverlapBinsDescriptor.java
12 files changed, 178 insertions(+), 128 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/51/1151/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-07 Thread Steven Jacobs (Code Review) 
Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 1: Code-Review+1

Seems okay to me. I would be okay with giving a +2 if you could give a brief 
summary so that it's a little more clear why this change is needed

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/572/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/572/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Steven Jacobs 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-06 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2535/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1151
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Preston Carman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1635 Fix for overlap-bins start for dates.

2016-09-06 Thread Preston Carman (Code Review) 
Preston Carman has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1151

Change subject: ASTERIXDB-1635 Fix for overlap-bins start for dates.
..

ASTERIXDB-1635 Fix for overlap-bins start for dates.

Change-Id: I24122a84ef9edda4b05260af881c430177f1dc86
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/temporal/overlap_bins/overlap_bins.3.ast
M asterixdb/asterix-doc/src/site/markdown/aql/functions.md
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DurationArithmeticOperations.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/OverlapBinsDescriptor.java
8 files changed, 145 insertions(+), 127 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/51/1151/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
index 8011ad6..bfb5527 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/temporal/overlap_bins/overlap_bins.3.query.aql
@@ -25,5 +25,5 @@
 let $itv2 := interval(date("1984-03-17"), date("2013-08-22"))
 let $itv3 := interval(datetime("1800-01-01T23:59:48.938"), 
datetime("2015-07-26T13:28:30.218"))
 return { "timebins": overlap-bins($itv1, time("00:00:00"), 
day-time-duration("PT30M")),
- "datebins": overlap-bins($itv2, date("1990-01-01"), 
year-month-duration("P20Y")),
+ "datebins": overlap-bins($itv2, date("1990-01-01"), 
year-month-duration("P10Y")),
  "datetimebins": overlap-bins($itv3, 
datetime("1900-01-01T00:00:00.000"), year-month-duration("P100Y")) }
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
index e42707f..90cd95e 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/overlap_bins/overlap_bins.3.query.sqlpp
@@ -22,6 +22,6 @@
  **/
 
 { 
'timebins':`overlap-bins`(interval(time('17:23:37'),time('18:30:21')),time('00:00:00'),`day-time-duration`('PT30M')),
-  
'datebins':`overlap-bins`(interval(date('1984-03-17'),date('2013-08-22')),date('1990-01-01'),`year-month-duration`('P20Y')),
+  
'datebins':`overlap-bins`(interval(date('1984-03-17'),date('2013-08-22')),date('1990-01-01'),`year-month-duration`('P10Y')),
   
'datetimebins':`overlap-bins`(interval(datetime('1800-01-01T23:59:48.938'),datetime('2015-07-26T13:28:30.218')),datetime('1900-01-01T00:00:00.000'),
   `year-month-duration`('P100Y'))};
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
index 493a1ca..14f6aae 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/temporal/overlap_bins/overlap_bins.1.adm
@@ -1 +1 @@
-{ "timebins": [ interval(time("17:00:00.000Z"), time("17:30:00.000Z")), 
interval(time("17:30:00.000Z"), time("18:00:00.000Z")), 
interval(time("18:00:00.000Z"), time("18:30:00.000Z")), 
interval(time("18:30:00.000Z"), time("19:00:00.000Z")) ], "datebins": [ 
interval(date("1970-01-01"), date("1990-01-01")), interval(date("1990-01-01"), 
date("2010-01-01")), interval(date("2010-01-01"), date("2030-01-01")) ], 
"datetimebins": [ interval(datetime("1800-01-01T00:00:00.000Z"), 
datetime("1900-01-01T00:00:00.000Z")), 
interval(datetime("1900-01-01T00:00:00.000Z"), 
datetime("2000-01-01T00:00:00.000Z")), 
interval(datetime("2000-01-01T00:00:00.000Z"), 
datetime("2100-01-01T00:00:00.000Z")) ] }
+{ "timebins": [ interval(time("17:00:00.000Z"), time("17:30:00.000Z")), 
interval(time("17:30:00.000Z"), time("18:00:00.000Z")), 
interval(time("18:00:00.000Z"), time("18:30:00.000Z")), 
interval(time("18:30:00.000Z"), time("19:00:00.000Z")) ], "datebins": [ 
interval(date("1980-01-01"), date("1990-01-01")),