Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 46:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2097/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2096/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 46:

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/722/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 46:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2097/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 46:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/722/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 46:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 46:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4559/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2096/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: Configuration Revamp
..


Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1487
Reviewed-by: Michael Blow 
Integration-Tests: Michael Blow 
Tested-by: Michael Blow 
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 46: Code-Review+2 Integration-Tests+1 Verified+1

carrying forward votes on trivial rebase

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 46
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45: Verified+1

carrying forward from Jenkins

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45: Integration-Tests+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2091/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/718/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2091/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 45:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 45
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#45).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 44:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 44
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 44:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4548/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 44
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#44).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 43:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 43
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 43:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4547/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 43
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#43).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 42:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 42
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 42:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4545/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 42
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#42).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 41: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2062/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 41
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 41: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/690/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 41
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 41:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/690/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 41
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 41:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 41
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 41:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4510/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 41
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 40: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/689/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 40
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#41).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

(12 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java:

Line 162: if (systemState == SystemState.PERMANENT_DATA_LOSS && 
(nodeProperties.isInitialRun() || nodeProperties.isVirtualNc())) {
> indeed
Stupid rebasing.  Done.


PS38, Line 210: registerVirtualNode
> Why are we registering a virtual node here? I think that I don't understand
That makes two of us- but this is in the block where the node is a substitute 
node, not a known node.  I only got to this code path due to a bug- this is 
virtual in that it is not started by way of an NCService.  The terminology is 
not great.


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java:

PS38, Line 49: generateUsageCSV
> Could we add some kind of result validation (e.g. number of lines in the fi
someday.  (added TODO)


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MetadataProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MetadataProperties.java:

PS38, Line 36: Option
> There seems to be a lot of boilerplate in the methods. Is there a way to av
We could consider moving the state out from the enum instance, enabling us to 
relocate the boilerplate methods to the interface if there is ever a need to 
extend, but I think we should safe that for a future change.


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java:

Line 114: final ClusterControllerService controllerService = 
(ClusterControllerService) ccAppCtx.getControllerService();
> Can we indeed remove this?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IConfigManager.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IConfigManager.java:

PS38, Line 26: IConfigManager
> Some javadocs would be nice, maybe file an issue?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java:

Line 148: private Map newNode(String nodeId) {
> This is a little confusing. The method is private and the parameter is not 
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigUtils.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigUtils.java:

PS38, Line 83: getIniArray
> unused?
Done


PS38, Line 99: getStringArray
> unused?
Done


PS38, Line 177: camelToConstantCase
> unused?
Done


PS38, Line 194: findOptionByName
> unused?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java:

Line 166: private final IApplicationConfig appConfig;
> Seems to be a good suggestion.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 40:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/689/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 40
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 40:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2060/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 40
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 40:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 40
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 40:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4509/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 40
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#40).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 39:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4507/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 39
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 39:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 39
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#39).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

(14 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1487/38//COMMIT_MSG
Commit Message:

PS38, Line 9: of
keep width to 77 chars


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java:

Line 162: if (systemState == SystemState.PERMANENT_DATA_LOSS && 
(nodeProperties.isInitialRun() || nodeProperties.isVirtualNc())) {
> MAJOR SonarQube violation:
indeed


PS38, Line 210: registerVirtualNode
Why are we registering a virtual node here? I think that I don't understand the 
lifecycle here.


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java:

PS38, Line 49: generateUsageCSV
Could we add some kind of result validation (e.g. number of lines in the file, 
existence of options in the file)?


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MetadataProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MetadataProperties.java:

PS38, Line 36: Option
There seems to be a lot of boilerplate in the methods. Is there a way to avoid 
that (while decreasing the code size)?


https://asterix-gerrit.ics.uci.edu/#/c/1487/35/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java:

Line 114: final ClusterControllerService controllerService = 
(ClusterControllerService) ccAppCtx.getControllerService();
> MAJOR SonarQube violation:
One more?


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java:

Line 114: final ClusterControllerService controllerService = 
(ClusterControllerService) ccAppCtx.getControllerService();
> MAJOR SonarQube violation:
Can we indeed remove this?


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IConfigManager.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IConfigManager.java:

PS38, Line 26: IConfigManager
Some javadocs would be nice, maybe file an issue?


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java:

Line 148: private Map newNode(String nodeId) {
> MAJOR SonarQube violation:
This is a little confusing. The method is private and the parameter is not used.


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigUtils.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigUtils.java:

PS38, Line 83: getIniArray
unused?


PS38, Line 99: getStringArray
unused?


PS38, Line 177: camelToConstantCase
unused?


PS38, Line 194: findOptionByName
unused?


https://asterix-gerrit.ics.uci.edu/#/c/1487/38/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/CCConfig.java:

Line 166: private final IApplicationConfig appConfig;
> CRITICAL SonarQube violation:
Seems to be a good suggestion.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2053/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2053/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2052/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/683/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/683/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2052/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4499/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 38:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#38).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#37).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
A 
asterixdb/asterix-app/src/test/java/org/apache/asterix/common/config/ConfigUsageTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 36:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 36
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#36).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 36:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4493/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 36
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 35:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4484/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 35
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#35).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 35:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 35
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 34: Integration-Tests-1

Integration Tests Timed Out

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2037/ 
: ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 34: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/661/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 34:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2037/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 34:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/661/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 34:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 34:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4482/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 34
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#34).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
M 

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm:

PS33, Line 26: metadata
> Do we have/need tests for the config APIs that contain the information that
not yet, i would like to get validation from folks that the options are in the 
right sections (e.g. nc / cc / common) before adding new tests.


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java:

PS33, Line 21: .*;
> Expand * include.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
File asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh:

PS33, Line 21:  
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixInstallerIntegrationUtil.java
File 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixInstallerIntegrationUtil.java:

PS33, Line 129: sleep
> Why do we need this now?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java:

Line 79: private CCConfig ccConfig;
> Good point.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java:

PS33, Line 287: commandLineOptions
> Even though this is really efficient wrt screen real estate , splitting it 
Done


PS33, Line 390: recieve
> s/recieve/receive/
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Configuration Revamp

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm:

PS33, Line 26: metadata
Do we have/need tests for the config APIs that contain the information that is 
not reported here anymore?


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java:

PS33, Line 21: .*;
Expand * include.


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh
File asterixdb/asterix-events/src/main/resources/events/cc_start/cc_start.sh:

PS33, Line 21:  
WS


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixInstallerIntegrationUtil.java
File 
asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixInstallerIntegrationUtil.java:

PS33, Line 129: sleep
Why do we need this now?


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/AppContextInfo.java:

Line 79: private CCConfig ccConfig;
> MAJOR SonarQube violation:
Good point.


https://asterix-gerrit.ics.uci.edu/#/c/1487/33/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java:

PS33, Line 287: commandLineOptions
Even though this is really efficient wrt screen real estate , splitting it up 
might be a bit more readable :)


PS33, Line 390: recieve
s/recieve/receive/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2023/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/651/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/651/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2023/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 33:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4467/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 33
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#33).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
M 

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java:

PS30, Line 126: getCCConfig
> i.e. shouldn't it already, since we had it registerConfigOptions with it, o
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm:

PS30, Line 7: config
> Where do we find the missing info?
ports have moved to CC config; storage, core dump dirs, txn log dirs have moved 
to NC config.  the following configs aren't returned by the API any longer, as 
they are derived.  We can restore these if desired:
- partition info
- node stores


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 32: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/650/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 32
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 32:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/650/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 32
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 32:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2022/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 32
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30:

(27 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java:

PS30, Line 126: getCCConfig
> Does the ICCApplicationEntryPoint know about the config manager?
i.e. shouldn't it already, since we had it registerConfigOptions with it, or 
that it seems wrong that it should?


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java:

PS30, Line 68: /node/asterix_nc1/config
> How did the HTTP API change here?
These are NC options now, reported under the NC config, not [app] options (i.e. 
global) as before.


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java:

PS30, Line 21: .*;
> Resolve '*' includes?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

PS30, Line 63: CC
> Is this correct?
No, and neither is NC; same goes for CC above for CC_JAVA_OPTS.

These are options only used by asterix-configuration.xml & managix, and are not 
used in the ncservice world.  I've introduced a new section type (NULL) for 
these.  It's possible these should be merged with virtual options.


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
File asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh:

PS30, Line 24:  
> fix WS?
Done


PS30, Line 25:  
> fix WS?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh
File 
asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh:

PS30, Line 26:  
> fix WS?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/algebricks/algebricks-tests/src/test/java/org/apache/hyracks/algebricks/tests/util/AlgebricksHyracksIntegrationUtil.java
File 
hyracks-fullstack/algebricks/algebricks-tests/src/test/java/org/apache/hyracks/algebricks/tests/util/AlgebricksHyracksIntegrationUtil.java:

PS30, Line 66: data
> line too long?
Done


PS30, Line 78: data
> line too long?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOption.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOption.java:

PS30, Line 24: IOption
> I think that we need some javadoc here - especially on "hidden" and "virtua
Done


PS30, Line 52: defaultValue
> Not a big fan of default implementations - especially if they get complicat
Done


PS30, Line 67: usage
> Not a big fan of default implementations - especially if they get complicat
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/ICCContext.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/ICCContext.java:

PS30, Line 37: getConfigManager
> Do we need to get the config manager from the ICCContext? It seems that the
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java:

PS30, Line 147: aep
> Validate that the now necessary AEP is not null?
Done


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionMarker.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionMarker.java:

PS30, Line 32: setter
> Add an example?
Setters is not implemented, doc updated.


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

PS30, Line 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 32:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 32
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 32:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4466/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 32
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#32).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/VersionApiServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/IPropertiesProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 31: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2014/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 31
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 31: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/645/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 31
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 31:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/645/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 31
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 31:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2014/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 31
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30:

(32 comments)

Submitting (incomplete) comments for patch set 30.

https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java:

PS30, Line 126: getCCConfig
Does the ICCApplicationEntryPoint know about the config manager?


https://asterix-gerrit.ics.uci.edu/#/c/1487/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/AsterixNCConfig.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/AsterixNCConfig.java:

PS5, Line 25: 
Do we still have an app section?


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java:

PS30, Line 68: /node/asterix_nc1/config
How did the HTTP API change here?


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm:

PS30, Line 7: config
Where do we find the missing info?


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java:

PS30, Line 21: .*;
Resolve '*' includes?


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

PS30, Line 63: CC
Is this correct?


https://asterix-gerrit.ics.uci.edu/#/c/1487/5/asterixdb/asterix-doc/src/site/markdown/ncservice.md
File asterixdb/asterix-doc/src/site/markdown/ncservice.md:

PS5, Line 141: storage.subdir=storage
I'm confused. I thought we wanted to put those in the nc-section.


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh
File asterixdb/asterix-events/src/main/resources/events/node_join/nc_join.sh:

PS30, Line 24:  
fix WS?


PS30, Line 25:  
fix WS?


PS30, Line 31: TODO(mblow)
file an issue?


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh
File 
asterixdb/asterix-events/src/main/resources/events/node_restart/nc_restart.sh:

PS30, Line 26:  
fix WS?


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/algebricks/algebricks-tests/src/test/java/org/apache/hyracks/algebricks/tests/util/AlgebricksHyracksIntegrationUtil.java
File 
hyracks-fullstack/algebricks/algebricks-tests/src/test/java/org/apache/hyracks/algebricks/tests/util/AlgebricksHyracksIntegrationUtil.java:

PS30, Line 66: data
line too long?


PS30, Line 78: data
line too long?


https://asterix-gerrit.ics.uci.edu/#/c/1487/5/hyracks-fullstack/hyracks/hyracks-api/pom.xml
File hyracks-fullstack/hyracks/hyracks-api/pom.xml:

PS5, Line 104: 
Not a big fan of the args4j dependency in hyracks-api.


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOption.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOption.java:

PS30, Line 24: IOption
I think that we need some javadoc here - especially on "hidden" and "virtual".


PS30, Line 52: defaultValue
Not a big fan of default implementations - especially if they get complicated. 
I think that the goal of default methods is to enable interface additions 
without modifying all implementations and not to put a lot of code into the 
interface. I prefer if interface files are rarely touched and putting a lot of 
code into them seems to make that more unlikely.


PS30, Line 67: usage
Not a big fan of default implementations - especially if they get complicated.


https://asterix-gerrit.ics.uci.edu/#/c/1487/30/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/ICCContext.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/context/ICCContext.java:

PS30, Line 37: getConfigManager
Do we need to get the config manager from the ICCContext? It seems that the 
only use of this is to get the AppConfig which might be easily (and cleanly) 
achievable without modifying this interface.

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 31:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 31
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 31:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4461/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 31
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1487

to look at the new patch set (#31).

Change subject: Configuration Revamp
..

Configuration Revamp

- Ini section of node / cc details now returns ini param names instead of
  managix option names
- Normalized command line -vs- ini file configuration parameter names
- Eliminated unused parameters
- Ini validation
- Migrate *DB parameters out of [app] and into nc / cc sections as
  appropriate
- Eliminate [app] section.  Cluster-wide configuration lives in [common]
- Sort properties alphabetically when returned by HTTP api

Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
---
M asterixdb/asterix-app/pom.xml
M asterixdb/asterix-app/scripts/asterix/startnc.sh
M asterixdb/asterix-app/scripts/idefix/startnc1.sh
M asterixdb/asterix-app/scripts/idefix/startnc2.sh
M asterixdb/asterix-app/scripts/rainbow/startnc.sh
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ServletConstants.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/AutoFaultToleranceStrategy.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/util/FaultToleranceUtil.java
M asterixdb/asterix-app/src/main/resources/asterix-build-configuration.xml
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/ClusterStateDefaultParameterTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/OptimizerParserTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/SmokeParserTest.java
M asterixdb/asterix-app/src/test/resources/runtimets/api.xml
A asterixdb/asterix-app/src/test/resources/runtimets/queries/api/APIQueries.xml
D 
asterixdb/asterix-app/src/test/resources/runtimets/queries/api/replication/replication.1.get.http
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.adm
M 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.adm
D 
asterixdb/asterix-app/src/test/resources/runtimets/results/api/replication/replication.1.adm
M asterixdb/asterix-client-helper/pom.xml
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AbstractProperties.java
C 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixCCConfig.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixNCConfig.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/BuildProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CompilerProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/FeedProperties.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/MessagingProperties.java
M 

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/644/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/644/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2013/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 30:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4459/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 29: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/638/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 29
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 29:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/638/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 29
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Configuration Revamp

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Configuration Revamp
..


Patch Set 29:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2006/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1487
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95b7e0bd4538ef42817c8826e76412150074b754
Gerrit-PatchSet: 29
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No