Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1137/1/asterixdb/asterix-server/pom.xml
File asterixdb/asterix-server/pom.xml:

Line 179:   1.0.0-SNAPSHOT
> It can be anything we want. I'd almost prefer for it to be a never-changing
Not sure how realistic it is, especially given that we only release 
semi-annually but I was thinking of a case where we multiple versions are 
sharing a single local maven repo- that wouldn't work very well if we keep a 
constant snapshot version across releases.  That was my thought.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery 
Gerrit-Reviewer: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT

[Chris Hillery (Code Review)]

Chris Hillery has posted comments on this change.

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1137/1/asterixdb/asterix-server/pom.xml
File asterixdb/asterix-server/pom.xml:

Line 179:   1.0.0-SNAPSHOT
> I think this should match the asterixdb version (i.e. ${project.version})
It can be anything we want. I'd almost prefer for it to be a never-changing 
constant, and 1.0.0 seems like a reasonable constant to pick. But if you think 
it makes sense to use the asterixdb version, that's fine too I guess. It means 
we need to update asterix-opt whenever we bump the asterixdb version, but I 
suppose we'll need to anyway.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery 
Gerrit-Reviewer: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1137/1/asterixdb/asterix-server/pom.xml
File asterixdb/asterix-server/pom.xml:

Line 179:   1.0.0-SNAPSHOT
I think this should match the asterixdb version (i.e. ${project.version})


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/533/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/533/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2484/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Depend on asterix-opt-bom 1.0.0-SNAPSHOT

[Chris Hillery (Code Review)]

Chris Hillery has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1137

Change subject: Depend on asterix-opt-bom 1.0.0-SNAPSHOT
..

Depend on asterix-opt-bom 1.0.0-SNAPSHOT

Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
---
M asterixdb/asterix-server/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/37/1137/1

diff --git a/asterixdb/asterix-server/pom.xml b/asterixdb/asterix-server/pom.xml
index 269c219..c713505 100644
--- a/asterixdb/asterix-server/pom.xml
+++ b/asterixdb/asterix-server/pom.xml
@@ -176,7 +176,7 @@
 
   org.apache.asterix
   asterix-opt-bom
-  0.1-SNAPSHOT
+  1.0.0-SNAPSHOT
   pom
 
   

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1137
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd5b95bc052c87419d0e925e46f7741b97cc1132
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery