Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Ian Maxon has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Code-Review+1 I think this is a good change but it might be worthwhile to handle all the cases of the enum as well. Right now it does not cover everything and for those unhandled cases null gets passed. -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Yingyi Bu has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: @Xikui, OK, I see. Should Java UDFs be consistent on NULL/MISSING handling to builtin functions? -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Xikui Wang has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: @Yingyi, When UDF is trying to access a missing field, an unknown field exception will be thrown. -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1041/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Yingyi Bu has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: How is MISSING handled in UDF? -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1041/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5076/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2574/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/392/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/208/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3599/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/129/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2574/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1695 to look at the new patch set (#2). Change subject: Fix NULL field value handing in Java UDF .. Fix NULL field value handing in Java UDF Add NULL value support in Java UDF. This can avoid NPE when there is a NULL field in a record. Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/95/1695/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/210/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: BAD+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1040/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1040/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/390/ (6/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/208/ (1/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/127/ (5/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5073/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Xikui Wang has uploaded a new change for review. https://asterix-gerrit.ics.uci.edu/1695 Change subject: Fix NULL field value handing in Java UDF .. Fix NULL field value handing in Java UDF Add NULL value support in Java UDF. This can avoid NPE when there is a NULL field in a record. Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 --- M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/95/1695/1 diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java index e2ed092..6e35d79 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/JTypeObjectFactory.java @@ -19,6 +19,7 @@ package org.apache.asterix.external.library; import org.apache.asterix.external.api.IJObject; +import org.apache.asterix.external.library.java.JObjects; import org.apache.asterix.external.library.java.JObjects.JBoolean; import org.apache.asterix.external.library.java.JObjects.JCircle; import org.apache.asterix.external.library.java.JObjects.JDate; @@ -45,6 +46,7 @@ import org.apache.asterix.om.types.AUnorderedListType; import org.apache.asterix.om.types.IAType; import org.apache.asterix.om.util.container.IObjectFactory; + public class JTypeObjectFactory implements IObjectFactory{ @@ -108,6 +110,9 @@ case INT64: retValue = new JLong(0); break; +case NULL: +retValue = JObjects.JNull.INSTANCE; +break; case ORDEREDLIST: AOrderedListType ot = (AOrderedListType) type; IAType orderedItemType = ot.getItemType(); diff --git a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java index f8755b4..5122efb 100644 --- a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java +++ b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java @@ -140,6 +140,9 @@ case DURATION: accessor = new JDurationAccessor(); break; +case NULL: +accessor = new JNullAccessor(); +break; default: break; } @@ -188,6 +191,16 @@ return jObject; } } + +public static class JNullAccessor implements IJObjectAccessor { + +@Override +public IJObject access(IVisitablePointable pointable, IObjectPool objPool) +throws HyracksDataException { +IJObject jObject = objPool.allocate(BuiltinType.ANULL); +return jObject; +} +} public static class JInt64Accessor implements IJObjectAccessor { -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2572/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3597/ (2/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Fix NULL field value handing in Java UDF
Jenkins has posted comments on this change. Change subject: Fix NULL field value handing in Java UDF .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/206/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/1695 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf110b2f5b3658847967f5ee7163fb2e47713813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui WangGerrit-Reviewer: Jenkins Gerrit-HasComments: No