Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Taewoo Kim has submitted this change and it was merged.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Index-Only Plan Patch Set 4: Index SearchCursor adjustment

 - Modify the search cursors to maintain the result of proceed()
   since the result will be required to check whether the given tuple
   is qualified to be part of an index-only plan result or not.
   More details will be followed in the next patch set.
 - Fix the search cursors to call cancel() correctly.

Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1630
Tested-by: Jenkins 
BAD: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Yingyi Bu 
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
6 files changed, 175 insertions(+), 103 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
 
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
index 890823c..c319b64 100644
--- 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
+++ 
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
@@ -60,9 +60,18 @@
 }
 }
 
+/**
+ * Cancels the reconcile() operation. Since reconcile() gets a lock, this 
lock
+ * needs to be unlocked to reverse the effect of reconcile().
+ */
 @Override
 public void cancel(ITupleReference tuple) throws HyracksDataException {
-//no op
+int pkHash = computePrimaryKeyHashValue(tuple, primaryKeyFields);
+try {
+lockManager.unlock(datasetId, pkHash, LockMode.S, txnCtx);
+} catch (ACIDException e) {
+throw new HyracksDataException(e);
+}
 }
 
 @Override
diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
index 77c3573..99c3e3f 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
@@ -73,11 +73,14 @@
 btreeAccessors[i].search(rangeCursors[i], predicate);
 if (rangeCursors[i].hasNext()) {
 rangeCursors[i].next();
-// We use the predicate's to lock the key instead of the tuple 
that we get from cursor to avoid copying the tuple when we do the "unlatch 
dance"
+// We use the predicate's to lock the key instead of the tuple 
that we get from cursor
+// to avoid copying the tuple when we do the "unlatch dance".
 if (reconciled || 
searchCallback.proceed(predicate.getLowKey())) {
 // if proceed is successful, then there's no need for 
doing the "unlatch dance"
 if (((ILSMTreeTupleReference) 
rangeCursors[i].getTuple()).isAntimatter()) {
-searchCallback.cancel(predicate.getLowKey());
+if (reconciled) {
+searchCallback.cancel(predicate.getLowKey());
+}
 rangeCursors[i].close();
 

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2589/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1050/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1050/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/404/ (6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2589/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/222/ 
(2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1630

to look at the new patch set (#10).

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..

Index-Only Plan Patch Set 4: Index SearchCursor adjustment

 - Modify the search cursors to maintain the result of proceed()
   since the result will be required to check whether the given tuple
   is qualified to be part of an index-only plan result or not.
   More details will be followed in the next patch set.
 - Fix the search cursors to call cancel() correctly.

Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
6 files changed, 175 insertions(+), 103 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1630/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/5088/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/141/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3611/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/220/
 (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

(2 comments)

Thanks YingYi.

https://asterix-gerrit.ics.uci.edu/#/c/1630/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java:

PS9, Line 131: .
> Is it a no-op, essentially?  you call lock and then unlock()?
We need to make sure that the element is on a disk component. After this, we 
can return this element.


https://asterix-gerrit.ics.uci.edu/#/c/1630/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java:

PS9, Line 191: cancelProceed
> We didn't add cancel proceed.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1630/8/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java:

PS8, Line 109: ;
Should complete and cancel be placed as the first line in "finally" blocks such 
that we don't leak locks if any exception is thrown after lock acquisition but 
before unlocking?


https://asterix-gerrit.ics.uci.edu/#/c/1630/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java:

PS9, Line 83: searchCallback
should complete() always be called at the first line of  a finally block so 
that in case anything fails since searchCallback.reconcile(...) can not lead to 
leaked locks? E.g., what if the query gets cancelled?


PS9, Line 109: true
should complete() always be called at the first line of  a finally block so 
that in case anything fails since searchCallback.proceed(...) can not lead to 
leaked locks? E.g., what if the query gets cancelled?


PS9, Line 114: searchCallback
should cancel always be called at the first line of  a finally block so that in 
case anything fails since searchCallback.reconcile(...) can not lead to leaked 
locks?  E.g., what if the query gets cancelled?


https://asterix-gerrit.ics.uci.edu/#/c/1630/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java:

PS9, Line 131: .
Is it a no-op, essentially?  you call lock and then unlock()?


https://asterix-gerrit.ics.uci.edu/#/c/1630/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java:

PS9, Line 191: cancelProceed
We didn't add cancel proceed.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2479/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/995/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/995/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2479/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2478/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/118/ 
(6/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/41/ (5/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3512/ (4/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4980/ (3/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/117/
 (2/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/300/ (1/6)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 9:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3490/ (5/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2453/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/983/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/983/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/275/ (5/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2453/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3489/ (4/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/94/ 
(2/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4954/ (1/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/91/
 (3/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2449/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/980/ : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

TRIGGER: testseededrepo

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/980/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

testseededrepo

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2449/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/91/ 
(5/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4950/ (4/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3485/ (3/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/87/
 (2/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/272/ (1/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2443/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/975/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/975/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2443/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/86/ 
(5/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4945/ (2/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3480/ (1/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2368/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2368/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2366/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/941/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/2366/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/12/ 
(5/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/3414/ (4/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/13/
 (3/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/200/ (2/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4878/ (1/5)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1630

to look at the new patch set (#5).

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..

Index-Only Plan Patch Set 4: Index SearchCursor adjustment

 - Modify the search cursors to maintain the result of proceed()
   since the result will be required to check whether the given tuple
   is qualified to be part of an index-only plan result or not.
   More details will be followed in the next patch set.
 - Fix the search cursors to call cancel() correctly.

Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
6 files changed, 176 insertions(+), 103 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1630/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4863/ (2/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/187/ (1/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1630

to look at the new patch set (#4).

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..

Index-Only Plan Patch Set 4: Index SearchCursor adjustment

 - Modify the search cursors to maintain the result of proceed()
   since the result will be required to check whether the given tuple
   is qualified to be part of an index-only plan result or not.
   More details will be followed in the next patch set.
 - Fix the search cursors to call cancel() correctly.

Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
6 files changed, 173 insertions(+), 102 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1630/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4858/ (1/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/182/ (2/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1630

to look at the new patch set (#3).

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..

Index-Only Plan Patch Set 4: Index SearchCursor adjustment

 - Modify the search cursors to maintain the result of proceed()
   since the result will be required to check whether the given tuple
   is qualified to be part of an index-only plan result or not.
   More details will be followed in the next patch set.
 - Fix the search cursors to call cancel() correctly.

Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
6 files changed, 170 insertions(+), 101 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1630/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/176/ (2/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4853/ (1/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1630

to look at the new patch set (#2).

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..

Index-Only Plan Patch Set 4: Index SearchCursor adjustment

 - Modify the search cursors to maintain the result of proceed()
   since the result will be required to check whether the given tuple
   is qualified to be part of an index-only plan result or not.
   More details will be followed in the next patch set.
 - Fix the search cursors to call cancel() correctly.

Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
6 files changed, 171 insertions(+), 101 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1630/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/175/ (2/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4852/ (1/3)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1630
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Index-Only Plan Patch Set 4: Index SearchCursor adjustment

[Taewoo Kim (Code Review)]

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1630

Change subject: Index-Only Plan Patch Set 4: Index SearchCursor adjustment
..

Index-Only Plan Patch Set 4: Index SearchCursor adjustment

 - Modify the search cursors to maintain the result of proceed()
   since the result will be required to check whether the given tuple
   is qualified to be part of an index-only plan result or not.
   More details will be followed in the next patch set.
 - Fix the search cursors to call cancel() correctly.

Change-Id: I299b1858b7875ffc116f8f3115d319fe7b53a537
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexSearchCursor.java
M 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
6 files changed, 170 insertions(+), 101 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/1630/1

diff --git 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
 
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
index 890823c..c319b64 100644
--- 
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
+++ 
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexInstantSearchOperationCallback.java
@@ -60,9 +60,18 @@
 }
 }
 
+/**
+ * Cancels the reconcile() operation. Since reconcile() gets a lock, this 
lock
+ * needs to be unlocked to reverse the effect of reconcile().
+ */
 @Override
 public void cancel(ITupleReference tuple) throws HyracksDataException {
-//no op
+int pkHash = computePrimaryKeyHashValue(tuple, primaryKeyFields);
+try {
+lockManager.unlock(datasetId, pkHash, LockMode.S, txnCtx);
+} catch (ACIDException e) {
+throw new HyracksDataException(e);
+}
 }
 
 @Override
diff --git 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
index 2fb96c3..b8717c9 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java
@@ -74,7 +74,8 @@
 btreeAccessors[i].search(rangeCursors[i], predicate);
 if (rangeCursors[i].hasNext()) {
 rangeCursors[i].next();
-// We use the predicate's to lock the key instead of the tuple 
that we get from cursor to avoid copying the tuple when we do the "unlatch 
dance"
+// We use the predicate's to lock the key instead of the tuple 
that we get from cursor
+// to avoid copying the tuple when we do the "unlatch dance".
 if (reconciled || 
searchCallback.proceed(predicate.getLowKey())) {
 // if proceed is successful, then there's no need for 
doing the "unlatch dance"
 if (((ILSMTreeTupleReference) 
rangeCursors[i].getTuple()).isAntimatter()) {
@@ -95,7 +96,6 @@
 
 // retraverse
 btreeAccessors[0].search(rangeCursors[i], predicate);
-searchCallback.complete(predicate.getLowKey());
 if (rangeCursors[i].hasNext()) {
 rangeCursors[i].next();
 if (((ILSMTreeTupleReference) 
rangeCursors[i].getTuple()).isAntimatter()) {
@@ -105,9 +105,11 @@
 } else {
 frameTuple = rangeCursors[i].getTuple();