Change in asterixdb[master]: Parameter documentation for nc service installtion.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Parameter documentation for nc service installtion.
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1166/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1355
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0c4e4dd41e966cc5fcebb423b7ca1be218de9d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Yingyi Bu (Code Review)
Yingyi Bu has uploaded a new patch set (#2).

Change subject: Polish the SQL++ reference doc.
..

Polish the SQL++ reference doc.

Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
2 files changed, 41 insertions(+), 24 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/58/1358/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3354/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


[jira] [Commented] (ASTERIXDB-1711) Clean up class names

2016-11-23 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691826#comment-15691826
 ] 

ASF subversion and git services commented on ASTERIXDB-1711:


Commit 426005929cac4d839899f948389e3e89cfce0db2 in asterixdb's branch 
refs/heads/master from [~tillw]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=4260059 ]

ASTERIXDB-1711: remove some Aql-prefixes

Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1314
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 


> Clean up class names
> 
>
> Key: ASTERIXDB-1711
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1711
> Project: Apache AsterixDB
>  Issue Type: Task
>  Components: AsterixDB, Hyracks
>Reporter: Till
>Assignee: Till
>
> Some classes have names that include "AQL" (even though they are not language 
> specific) or "Asterix" (even tough that's part of package names).
> We should aim to name classes based on their functionality and clean up class 
> names that are not named that way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: some WebUI hackery

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: some WebUI hackery
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1167/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1097
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread Till Westmann (Code Review)
Till Westmann has submitted this change and it was merged.

Change subject: fix dependencies for asterix-common
..


fix dependencies for asterix-common

Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1357
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 
---
M asterixdb/asterix-common/pom.xml
M asterixdb/asterix-external-data/pom.xml
M asterixdb/asterix-runtime/pom.xml
M asterixdb/pom.xml
4 files changed, 121 insertions(+), 22 deletions(-)

Approvals:
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git a/asterixdb/asterix-common/pom.xml b/asterixdb/asterix-common/pom.xml
index 113c5b8..b966bcd 100644
--- a/asterixdb/asterix-common/pom.xml
+++ b/asterixdb/asterix-common/pom.xml
@@ -180,13 +180,33 @@
   commons-io
 
 
+  org.apache.commons
+  commons-lang3
+  3.5
+
+
   org.apache.httpcomponents
   httpclient
-  4.5.2
+
+
+  org.apache.httpcomponents
+  httpcore
 
 
   org.apache.hyracks
-  algebricks-compiler
+  algebricks-common
+
+
+  org.apache.hyracks
+  algebricks-core
+
+
+  org.apache.hyracks
+  hyracks-util
+
+
+  org.apache.hyracks
+  hyracks-dataflow-common
 
 
   org.apache.hyracks
@@ -199,6 +219,26 @@
 
   org.apache.hyracks
   hyracks-storage-am-common
+
+
+  org.apache.hyracks
+  hyracks-storage-am-common
+
+
+  org.apache.hyracks
+  hyracks-storage-common
+
+
+  org.apache.hyracks
+  hyracks-storage-am-btree
+
+
+  org.apache.hyracks
+  hyracks-storage-am-bloomfilter
+
+
+  org.apache.hyracks
+  hyracks-storage-am-rtree
 
 
   org.apache.hyracks
@@ -225,22 +265,30 @@
   hyracks-storage-am-lsm-rtree
 
 
-  org.apache.hyracks
-  hyracks-control-cc
+  log4j
+  log4j
+  1.2.17
 
 
-  org.apache.hyracks
-  hyracks-control-nc
+  org.json
+  json
 
 
-  com.fasterxml.jackson.core
-  jackson-core
-  2.2.0
+  javax.servlet
+  javax.servlet-api
+  test
 
 
-  org.codehaus.jackson
-  jackson-mapper-asl
-  1.9.12
+  org.eclipse.jetty
+  jetty-server
+  9.3.11.v20160721
+  test
+
+
+  org.eclipse.jetty
+  jetty-servlet
+  9.3.11.v20160721
+  test
 
 
   com.rometools
@@ -254,20 +302,10 @@
   test
 
 
-  log4j
-  log4j
-  1.2.17
-
-
   org.mockito
   mockito-all
   2.0.2-beta
   test
-
-
-  com.google.guava
-  guava
-  18.0
 
   
 
diff --git a/asterixdb/asterix-external-data/pom.xml 
b/asterixdb/asterix-external-data/pom.xml
index 0cc6826..aab1e57 100644
--- a/asterixdb/asterix-external-data/pom.xml
+++ b/asterixdb/asterix-external-data/pom.xml
@@ -324,5 +324,23 @@
   test-jar
   test
 
+
+  org.apache.wicket
+  wicket-core
+  1.5.2
+  test
+
+
+  org.apache.wicket
+  wicket-request
+  1.5.2
+  test
+
+
+  org.apache.wicket
+  wicket-util
+  1.5.2
+  test
+
   
 
diff --git a/asterixdb/asterix-runtime/pom.xml 
b/asterixdb/asterix-runtime/pom.xml
index f14eb49..cd7deed 100644
--- a/asterixdb/asterix-runtime/pom.xml
+++ b/asterixdb/asterix-runtime/pom.xml
@@ -57,6 +57,14 @@
   hyracks-api
 
 
+  org.apache.hyracks
+  hyracks-control-cc
+
+
+  org.apache.hyracks
+  hyracks-control-nc
+
+
   org.apache.asterix
   asterix-transactions
   ${project.version}
diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml
index 689663d..8862644 100644
--- a/asterixdb/pom.xml
+++ b/asterixdb/pom.xml
@@ -666,6 +666,16 @@
   
   
 org.apache.hyracks
+algebricks-common
+${algebricks.version}
+  
+  
+org.apache.hyracks
+algebricks-core
+${algebricks.version}
+  
+  
+org.apache.hyracks
 algebricks-compiler
 ${algebricks.version}
   
@@ -721,12 +731,27 @@
   
   
 org.apache.hyracks
+hyracks-dataflow-common
+${hyracks.version}
+  
+  
+org.apache.hyracks
 hyracks-dataflow-hadoop
 ${hyracks.version}
   
   
 org.apache.hyracks
+hyracks-storage-common
+${hyracks.version}
+  
+  
+org.apache.hyracks
 hyracks-storage-am-btree
+${hyracks.version}
+  
+  
+org.apache.hyracks
+hyracks-storage-am-bloomfilter
 

Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: fix dependencies for asterix-common
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1357
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: some WebUI hackery

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: some WebUI hackery
..


Patch Set 13:

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1167/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1097
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Parameter documentation for nc service installtion.

2016-11-23 Thread Yingyi Bu (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1355

to look at the new patch set (#3).

Change subject: Parameter documentation for nc service installtion.
..

Parameter documentation for nc service installtion.

Change-Id: I2e0c4e4dd41e966cc5fcebb423b7ca1be218de9d
---
M asterixdb/asterix-doc/src/site/markdown/ncservice.md
1 file changed, 61 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/55/1355/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1355
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e0c4e4dd41e966cc5fcebb423b7ca1be218de9d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Yingyi Bu (Code Review)
Yingyi Bu has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1358

Change subject: Polish the SQL++ reference doc.
..

Polish the SQL++ reference doc.

Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
2 files changed, 41 insertions(+), 24 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/58/1358/1

diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
index f3d4311..3fb3121 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
@@ -286,9 +286,8 @@
 FloatLiteral   ::=  ( "f" | "F" )
  |  ( "."  ( "f" | "F" ) )?
  | "."  ( "f" | "F" )
-DoubleLiteral  ::= 
- |  ( "."  )?
- | "." 
+DoubleLiteral  ::=  "." 
+   | "." 
 
 Literals (constants) in SQL++ can be strings, integers, floating point values, 
double values, boolean constants, or special constant values like `NULL` and 
`MISSING`. The `NULL` value is like a `NULL` in SQL; it is used to represent an 
unknown field value. The specialy value `MISSING` is only meaningful in the 
context of SQL++ field accesses; it occurs when the accessed field simply does 
not exist at all in a object being accessed.
 
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
index dc760ba..ed4a8d0 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
@@ -96,6 +96,19 @@
 ### SELECT VALUE Clause
 The `SELECT VALUE` clause in SQL++ returns a collection that contains the 
results of evaluating the `VALUE` expression, with one evaluation being 
performed per "binding tuple" (i.e., per `FROM` clause item) satisfying the 
statement's selection criteria.
 For historical reasons SQL++ also allows the keywords `ELEMENT` or `RAW` to be 
used in place of `VALUE` (not recommended).
+
+The following example shows a standard-alone SELECT.
+
+# Example
+
+SELECT VALUE 1;
+
+This query return:
+
+[
+  1
+]
+
 The following example shows a query that selects one user from the 
GleambookUsers collection.
 
 # Example
@@ -745,9 +758,10 @@
 
 # Example
 
-SELECT uid, (SELECT VALUE m.msg FROM msgs m) AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid GROUP AS msgs(message AS msg);
+   SELECT uid, (SELECT VALUE g.msg FROM g) AS msgs
+   FROM GleambookMessages gbm
+   GROUP BY gbm.authorId AS uid
+   GROUP AS g(gbm as msg);
 
 This variant of the example query returns:
 
@@ -835,9 +849,10 @@
 
 # Example
 
-SELECT uid, msg AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid GROUP AS msgs(message AS msg);
+   SELECT uid, msg AS msgs
+   FROM GleambookMessages gbm
+   GROUP BY gbm.authorId AS uid
+   GROUP AS g(gbm as msg);
 
 This variant of the query exploits a bit of SQL-style "syntactic sugar" that 
SQL++ offers to shorten some user queries.
 In particular, in the `SELECT` list, the reference to the `GROUP` variable 
field `msg` -- because it references a field of the group variable -- is 
allowed but is "pluralized". As a result, the `msg` reference in the `SELECT` 
list is
@@ -849,13 +864,14 @@
 # Example
 
 SELECT uid,
-   (SELECT VALUE m.msg
-FROM msgs m
-WHERE m.msg.message LIKE '% like%'
-ORDER BY m.msg.messageId
+   (SELECT VALUE g.msg
+FROM g
+WHERE g.msg.message LIKE '% like%'
+ORDER BY g.msg.messageId
 LIMIT 2) AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid GROUP AS msgs(message AS msg);
+FROM GleambookMessages gbm
+GROUP BY gbm.authorId AS uid
+GROUP AS g(gbm as msg);
 
 This example query returns:
 
@@ -912,14 +928,15 @@
 
 # Example
 
-SELECT authorId,
-   (SELECT VALUE g.msg
-FROM g
-WHERE g.msg.message LIKE '% like%'
-ORDER BY g.msg.messageId
-LIMIT 2) AS msgs
-FROM GleambookMessages gbm
-GROUP BY gbm.authorId GROUP AS g(gbm as msg);
+SELECT authorId,
+   (SELECT VALUE g.msg
+FROM g
+WHERE g.msg.message LIKE '% like%'
+ORDER BY g.msg.messageId
+LIMIT 2) AS msgs
+FROM GleambookMessages gbm
+GROUP BY gbm.authorId
+GROUP AS g(gbm as msg);
 
 This query returns:
 
@@ -1020,7 +1037,7 @@
 
 ### Aggregation functions
 In traditional SQL, which doesn't support nested data, grouping always also 
involves the use 

Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3353/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1168/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1165/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Parameter documentation for nc service installtion.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Parameter documentation for nc service installtion.
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1166/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1355
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0c4e4dd41e966cc5fcebb423b7ca1be218de9d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Parameter documentation for nc service installtion.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Parameter documentation for nc service installtion.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3352/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1355
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e0c4e4dd41e966cc5fcebb423b7ca1be218de9d
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..


Patch Set 9: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1165/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1358/2/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md:

Line 761:SELECT uid, (SELECT VALUE g.msg FROM g) AS msgs
Why this indentation change?


Line 852:SELECT uid, msg AS msgs
Why this indentation change?


Line 931: SELECT authorId,
Why this indentation change?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Yingyi Bu (Code Review)
Yingyi Bu has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1358/2/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
File asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md:

Line 761:SELECT uid, (SELECT VALUE g.msg FROM g) AS msgs
> Why this indentation change?
Done


Line 852:SELECT uid, msg AS msgs
> Why this indentation change?
Done


Line 931: SELECT authorId,
> Why this indentation change?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Cleanup FileSplit and FileReference
..


Patch Set 4: Code-Review+2

(7 comments)

Need to fix more things in the next few days.

https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java:

Line 184: partition.put("relative", relative);
Seems that we're changing an external interface here. 
Who is using this interface? Do we change the code as well?


https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java:

Line 173: fileMapManager = new AsterixFileMapManager(ioManager);
Why does the AsterixFileMapManager need the ioMananger?


https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java:

Line 159: element1.put("relative", true);
Ok, this modifies the test that is supposed to validate that the interface does 
not change ...


https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java:

Line 55: if (next == device) {
Use equals instead of == ? Seems more robust wrt change in the code base. If 
this is performance critical we might want to reconsider the linear search.


https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java:

Line 169: validateDatasetLifecycleManagerState();
Indentation seems wrong.


https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Resource.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Resource.java:

Line 33: public abstract class Resource implements Serializable {
That's a very generic name. What is it really about? Can we add a descriptive 
comment?


https://asterix-gerrit.ics.uci.edu/#/c/1352/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java
File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java:

Line 40: import org.apache.hyracks.api.io.FileSplit;
Why do we need to move this?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1352
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1169/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: Cleanup FileSplit and FileReference
..


Patch Set 4:

Going over the comments and addressing them in the next patch...

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1352
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1168/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 3:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1169/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Yingyi Bu (Code Review)
Yingyi Bu has submitted this change and it was merged.

Change subject: Polish the SQL++ reference doc.
..


Polish the SQL++ reference doc.

Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1358
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
2 files changed, 38 insertions(+), 21 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found



diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
index f3d4311..3fb3121 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
@@ -286,9 +286,8 @@
 FloatLiteral   ::=  ( "f" | "F" )
  |  ( "."  ( "f" | "F" ) )?
  | "."  ( "f" | "F" )
-DoubleLiteral  ::= 
- |  ( "."  )?
- | "." 
+DoubleLiteral  ::=  "." 
+   | "." 
 
 Literals (constants) in SQL++ can be strings, integers, floating point values, 
double values, boolean constants, or special constant values like `NULL` and 
`MISSING`. The `NULL` value is like a `NULL` in SQL; it is used to represent an 
unknown field value. The specialy value `MISSING` is only meaningful in the 
context of SQL++ field accesses; it occurs when the accessed field simply does 
not exist at all in a object being accessed.
 
diff --git a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md 
b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
index dc760ba..b90eb06 100644
--- a/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
+++ b/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
@@ -96,6 +96,19 @@
 ### SELECT VALUE Clause
 The `SELECT VALUE` clause in SQL++ returns a collection that contains the 
results of evaluating the `VALUE` expression, with one evaluation being 
performed per "binding tuple" (i.e., per `FROM` clause item) satisfying the 
statement's selection criteria.
 For historical reasons SQL++ also allows the keywords `ELEMENT` or `RAW` to be 
used in place of `VALUE` (not recommended).
+
+The following example shows a standard-alone `SELECT VALUE`, which wraps a 
value into an array.
+
+# Example
+
+SELECT VALUE 1;
+
+This query return:
+
+[
+  1
+]
+
 The following example shows a query that selects one user from the 
GleambookUsers collection.
 
 # Example
@@ -745,9 +758,10 @@
 
 # Example
 
-SELECT uid, (SELECT VALUE m.msg FROM msgs m) AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid GROUP AS msgs(message AS msg);
+SELECT uid, (SELECT VALUE g.msg FROM g) AS msgs
+FROM GleambookMessages gbm
+GROUP BY gbm.authorId AS uid
+GROUP AS g(gbm as msg);
 
 This variant of the example query returns:
 
@@ -836,8 +850,9 @@
 # Example
 
 SELECT uid, msg AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid GROUP AS msgs(message AS msg);
+FROM GleambookMessages gbm
+GROUP BY gbm.authorId AS uid
+GROUP AS g(gbm as msg);
 
 This variant of the query exploits a bit of SQL-style "syntactic sugar" that 
SQL++ offers to shorten some user queries.
 In particular, in the `SELECT` list, the reference to the `GROUP` variable 
field `msg` -- because it references a field of the group variable -- is 
allowed but is "pluralized". As a result, the `msg` reference in the `SELECT` 
list is
@@ -849,13 +864,14 @@
 # Example
 
 SELECT uid,
-   (SELECT VALUE m.msg
-FROM msgs m
-WHERE m.msg.message LIKE '% like%'
-ORDER BY m.msg.messageId
+   (SELECT VALUE g.msg
+FROM g
+WHERE g.msg.message LIKE '% like%'
+ORDER BY g.msg.messageId
 LIMIT 2) AS msgs
-FROM GleambookMessages message
-GROUP BY message.authorId AS uid GROUP AS msgs(message AS msg);
+FROM GleambookMessages gbm
+GROUP BY gbm.authorId AS uid
+GROUP AS g(gbm as msg);
 
 This example query returns:
 
@@ -913,13 +929,14 @@
 # Example
 
 SELECT authorId,
-   (SELECT VALUE g.msg
-FROM g
-WHERE g.msg.message LIKE '% like%'
-ORDER BY g.msg.messageId
-LIMIT 2) AS msgs
+   (SELECT VALUE g.msg
+FROM g
+WHERE g.msg.message LIKE '% like%'
+ORDER BY g.msg.messageId
+LIMIT 2) AS msgs
 FROM GleambookMessages gbm
-GROUP BY gbm.authorId GROUP AS g(gbm as msg);
+GROUP BY gbm.authorId
+GROUP AS g(gbm as msg);
 
 This query returns:
 
@@ -1020,7 +1037,7 @@
 
 ### 

Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Yingyi Bu (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1358

to look at the new patch set (#3).

Change subject: Polish the SQL++ reference doc.
..

Polish the SQL++ reference doc.

Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
---
M asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md
M asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md
2 files changed, 38 insertions(+), 21 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/58/1358/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3355/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup FileSplit and FileReference
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1352
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Polish the SQL++ reference doc.

2016-11-23 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: Polish the SQL++ reference doc.
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1358
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3cc23ebbf9e390d6eabf9386b15550aa5d6d43
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread abdullah alamoudi (Code Review)
Hello Till Westmann, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1352

to look at the new patch set (#5).

Change subject: Cleanup FileSplit and FileReference
..

Cleanup FileSplit and FileReference

This change gives FileSplit and FileReference specific meaning to
avoid confusion of an absolute vs relative, local vs global, inside
an IO device vs outside IO devices.

In addition, it enables better abstraction of global partitions and
delegate the responsibility of choosing which partition goes to which
IO device to the IO Manager through the introduction of FileDeviceComputer

In details:
Previously, the LocalResource in Hyracks had partition (storage partition)
and there is no such thing in Hyracks. This scope leak is bad. In addition
The local resource had a name and a path. they were always the same and so
the name was removed.
The storage partition was instead moved to asterixdb implementation of the
serialized object in the local resource.

With all of these changes, the cluster controller (compiler) only needs to
know about partitions and relative paths. It doesn't need to worry about
heterogenous Node setups and different io device configurations. For File
assignment to IO devices, a new interface (IFileDeviceComputer) was
introduced which can be overriden by applications to have their own
strategy for distributing files among IO devices.

Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryInvertedIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixFileMapManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInvertedIndexInsertDeleteOperatorDescriptor.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IResourceFactory.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Resource.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ResourceFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/AbstractExternalDatasetIndexesOperatorDescriptor.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalBTreeSearchOperatorDescriptor.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalBTreeSearchOperatorNodePushable.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalDatasetIndexesAbortOperatorDescriptor.java
M 

Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup FileSplit and FileReference
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3356/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1352
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup FileSplit and FileReference
..


Patch Set 5:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1170/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1352
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has submitted this change and it was merged.

Change subject: Cleanup FileSplit and FileReference
..


Cleanup FileSplit and FileReference

This change gives FileSplit and FileReference specific meaning to
avoid confusion of an absolute vs relative, local vs global, inside
an IO device vs outside IO devices.

In addition, it enables better abstraction of global partitions and
delegate the responsibility of choosing which partition goes to which
IO device to the IO Manager through the introduction of FileDeviceComputer

In details:
Previously, the LocalResource in Hyracks had partition (storage partition)
and there is no such thing in Hyracks. This scope leak is bad. In addition
The local resource had a name and a path. they were always the same and so
the name was removed.
The storage partition was instead moved to asterixdb implementation of the
serialized object in the local resource.

With all of these changes, the cluster controller (compiler) only needs to
know about partitions and relative paths. It doesn't need to worry about
heterogenous Node setups and different io device configurations. For File
assignment to IO devices, a new interface (IFileDeviceComputer) was
introduced which can be overriden by applications to have their own
strategy for distributing files among IO devices.

Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1352
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: abdullah alamoudi 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ConnectorAPIServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalIndexingOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/FeedOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/AsterixNCAppRuntimeContext.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryBTreeOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryInvertedIndexOperationsHelper.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/api/http/servlet/ConnectorAPIServletTest.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/app/bootstrap/TestNodeController.java
M asterixdb/asterix-common/pom.xml
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixFileMapManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInsertDeleteOperatorNodePushable.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/dataflow/AsterixLSMInvertedIndexInsertDeleteOperatorDescriptor.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IResourceFactory.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/Resource.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ResourceFactory.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/adapter/factory/GenericAdapterFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/LocalFSInputStreamFactory.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/AbstractExternalDatasetIndexesOperatorDescriptor.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalBTreeSearchOperatorDescriptor.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalBTreeSearchOperatorNodePushable.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/ExternalDatasetIndexesAbortOperatorDescriptor.java
M 

Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: Cleanup FileSplit and FileReference
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1352
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Cleanup FileSplit and FileReference

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Cleanup FileSplit and FileReference
..


Patch Set 5: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1170/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1352
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fac508bf9af5a3bed41a3cf4464d2cbfecf2f61
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..


Patch Set 8: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1159/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - materialize QueryService result in a file

2016-11-23 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1166

to look at the new patch set (#4).

Change subject: WIP - materialize QueryService result in a file
..

WIP - materialize QueryService result in a file

Change-Id: I539e2678f23e59f50cb4b2b8a1c2cd9fbe1147a3
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
hyracks-fullstack/hyracks/hyracks-client/src/main/java/org/apache/hyracks/client/dataset/HyracksDatasetReader.java
3 files changed, 116 insertions(+), 76 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/66/1166/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1166
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I539e2678f23e59f50cb4b2b8a1c2cd9fbe1147a3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: WIP - materialize QueryService result in a file

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - materialize QueryService result in a file
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3344/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1166
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I539e2678f23e59f50cb4b2b8a1c2cd9fbe1147a3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - materialize QueryService result in a file

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - materialize QueryService result in a file
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1166
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I539e2678f23e59f50cb4b2b8a1c2cd9fbe1147a3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - materialize QueryService result in a file

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - materialize QueryService result in a file
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1160/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1166
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I539e2678f23e59f50cb4b2b8a1c2cd9fbe1147a3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread Till Westmann (Code Review)
Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1357

Change subject: fix dependencies for asterix-common
..

fix dependencies for asterix-common

Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
---
M asterixdb/asterix-common/pom.xml
M asterixdb/pom.xml
2 files changed, 82 insertions(+), 26 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/57/1357/1

diff --git a/asterixdb/asterix-common/pom.xml b/asterixdb/asterix-common/pom.xml
index 113c5b8..7ef770e 100644
--- a/asterixdb/asterix-common/pom.xml
+++ b/asterixdb/asterix-common/pom.xml
@@ -180,13 +180,33 @@
   commons-io
 
 
+  org.apache.commons
+  commons-lang3
+  3.5
+
+
   org.apache.httpcomponents
   httpclient
-  4.5.2
+
+
+  org.apache.httpcomponents
+  httpcore
 
 
   org.apache.hyracks
-  algebricks-compiler
+  algebricks-common
+
+
+  org.apache.hyracks
+  algebricks-core
+
+
+  org.apache.hyracks
+  hyracks-util
+
+
+  org.apache.hyracks
+  hyracks-dataflow-common
 
 
   org.apache.hyracks
@@ -199,6 +219,26 @@
 
   org.apache.hyracks
   hyracks-storage-am-common
+
+
+  org.apache.hyracks
+  hyracks-storage-am-common
+
+
+  org.apache.hyracks
+  hyracks-storage-common
+
+
+  org.apache.hyracks
+  hyracks-storage-am-btree
+
+
+  org.apache.hyracks
+  hyracks-storage-am-bloomfilter
+
+
+  org.apache.hyracks
+  hyracks-storage-am-rtree
 
 
   org.apache.hyracks
@@ -225,22 +265,13 @@
   hyracks-storage-am-lsm-rtree
 
 
-  org.apache.hyracks
-  hyracks-control-cc
+  log4j
+  log4j
+  1.2.17
 
 
-  org.apache.hyracks
-  hyracks-control-nc
-
-
-  com.fasterxml.jackson.core
-  jackson-core
-  2.2.0
-
-
-  org.codehaus.jackson
-  jackson-mapper-asl
-  1.9.12
+  org.json
+  json
 
 
   com.rometools
@@ -254,20 +285,10 @@
   test
 
 
-  log4j
-  log4j
-  1.2.17
-
-
   org.mockito
   mockito-all
   2.0.2-beta
   test
-
-
-  com.google.guava
-  guava
-  18.0
 
   
 
diff --git a/asterixdb/pom.xml b/asterixdb/pom.xml
index 689663d..8862644 100644
--- a/asterixdb/pom.xml
+++ b/asterixdb/pom.xml
@@ -666,6 +666,16 @@
   
   
 org.apache.hyracks
+algebricks-common
+${algebricks.version}
+  
+  
+org.apache.hyracks
+algebricks-core
+${algebricks.version}
+  
+  
+org.apache.hyracks
 algebricks-compiler
 ${algebricks.version}
   
@@ -721,12 +731,27 @@
   
   
 org.apache.hyracks
+hyracks-dataflow-common
+${hyracks.version}
+  
+  
+org.apache.hyracks
 hyracks-dataflow-hadoop
 ${hyracks.version}
   
   
 org.apache.hyracks
+hyracks-storage-common
+${hyracks.version}
+  
+  
+org.apache.hyracks
 hyracks-storage-am-btree
+${hyracks.version}
+  
+  
+org.apache.hyracks
+hyracks-storage-am-bloomfilter
 ${hyracks.version}
   
   
@@ -812,6 +837,16 @@
 args4j
 2.33
   
+  
+org.apache.httpcomponents
+httpclient
+4.5.2
+  
+  
+org.apache.httpcomponents
+httpcore
+4.4
+  
 
   
 

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1357
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 


[jira] [Created] (ASTERIXDB-1739) Confusing strings in LoadableDataSource

2016-11-23 Thread Till (JIRA)
Till created ASTERIXDB-1739:
---

 Summary: Confusing strings in LoadableDataSource
 Key: ASTERIXDB-1739
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1739
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Metadata
Reporter: Till
Assignee: Abdullah Alamoudi


The constructor of LoadableDataSource contains the strings "loadable_dv" and 
"loadable_ds" and it is not obvious what they do.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: fix dependencies for asterix-common
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3345/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1357
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..


Patch Set 8:

@Abdullah: This has been updated a bit more and your comments have been 
addressed. Issue ASTERIXDB-1739 has been filed.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - materialize QueryService result in a file

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - materialize QueryService result in a file
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1160/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1166
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I539e2678f23e59f50cb4b2b8a1c2cd9fbe1147a3
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: some WebUI hackery

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: some WebUI hackery
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3346/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1097
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: some WebUI hackery

2016-11-23 Thread Till Westmann (Code Review)
Hello Michael Blow, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1097

to look at the new patch set (#13).

Change subject: some WebUI hackery
..

some WebUI hackery

- use query/service endpoint (and SQL++)
- add option to display JSON
- some code simplification

Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
M asterixdb/asterix-app/src/main/resources/queryui/css/master.css
M asterixdb/asterix-app/src/main/resources/queryui/js/main.js
M asterixdb/asterix-app/src/main/resources/queryui/queryui.html
4 files changed, 62 insertions(+), 57 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/97/1097/13
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1097
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 


Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread abdullah alamoudi (Code Review)
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..


Patch Set 8: Code-Review+2

Looks good to me.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: some WebUI hackery

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: some WebUI hackery
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1161/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1097
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - symbolic constants in lock manager

2016-11-23 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/694

to look at the new patch set (#12).

Change subject: WIP - symbolic constants in lock manager
..

WIP - symbolic constants in lock manager

Change-Id: I774dd40113f5fa4fee94dde72f4ec6a1891c6b6e
---
M 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ConcurrentLockManager.java
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/94/694/12
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/694
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I774dd40113f5fa4fee94dde72f4ec6a1891c6b6e
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: WIP - symbolic constants in lock manager

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - symbolic constants in lock manager
..


Patch Set 12:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3347/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/694
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774dd40113f5fa4fee94dde72f4ec6a1891c6b6e
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - UTF-8 encoding/decoding

2016-11-23 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1115

to look at the new patch set (#4).

Change subject: WIP - UTF-8 encoding/decoding
..

WIP - UTF-8 encoding/decoding

Change-Id: Ibe6cd240094eaccfe4a954f9b76fd3345d5a0c06
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/PrintTools.java
M 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java
2 files changed, 90 insertions(+), 70 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/15/1115/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1115
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe6cd240094eaccfe4a954f9b76fd3345d5a0c06
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 


Change in asterixdb[master]: WIP - UTF-8 encoding/decoding

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - UTF-8 encoding/decoding
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3348/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1115
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe6cd240094eaccfe4a954f9b76fd3345d5a0c06
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - UTF-8 encoding/decoding

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - UTF-8 encoding/decoding
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1115
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe6cd240094eaccfe4a954f9b76fd3345d5a0c06
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - symbolic constants in lock manager

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - symbolic constants in lock manager
..


Patch Set 12: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1162/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/694
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774dd40113f5fa4fee94dde72f4ec6a1891c6b6e
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread Till Westmann (Code Review)
Hello abdullah alamoudi, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1314

to look at the new patch set (#9).

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..

ASTERIXDB-1711: remove some Aql-prefixes

Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/base/ILangExpressionToPlanTranslatorFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/extension/IExtensionStatement.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/CommitPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/ExternalDataLookupPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/IndexSearchPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/InvertedIndexPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/RTreeSearchPOperator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/AnalysisUtil.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ConstantFoldingRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyEqRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceMaterializationForInsertWithSelfScanRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceRandomPartitioningFeedComputationRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceSecondaryIndexInsertDeleteRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceStaticTypeCastForInsertRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveSortInFeedIngestionRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ResolveVariableRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetupCommitExtensionOpRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/UnnestToDataScanRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlExpressionToPlanTranslatorFactory.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/AqlPlusExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslator.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SqlppExpressionToPlanTranslatorFactory.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M 

Change in asterixdb[master]: ASTERIXDB-1711: remove some Aql-prefixes

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1711: remove some Aql-prefixes
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3351/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1314
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b64ffa7c50cd62fc3303fdb44eb769f56c978a
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Support LSM-filter on multiple input paths
..


Patch Set 3:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1163/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: fix dependencies for asterix-common
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1164/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1357
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Support LSM-filter on multiple input paths
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1163/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change.

Change subject: Support LSM-filter on multiple input paths
..


Patch Set 3: -Code-Review

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has submitted this change and it was merged.

Change subject: Support LSM-filter on multiple input paths
..


Support LSM-filter on multiple input paths

The IntroduceLSMComponentFilterRule only checked one input path,
which does not work for the multiple-path cases (e.g., intersection case)
This patch fixes this bug.

Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1356
Reviewed-by: Taewoo Kim 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect-with-filter.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/multi-indexes/btree-rtree-ngram-intersect-with-filter.plan
3 files changed, 99 insertions(+), 6 deletions(-)

Approvals:
  Taewoo Kim: Looks good to me, approved
  Jenkins: Verified; No violations found



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
index 0e54640..9b568b9 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
@@ -19,7 +19,9 @@
 package org.apache.asterix.optimizer.rules.am;
 
 import java.util.ArrayList;
+import java.util.LinkedList;
 import java.util.List;
+import java.util.Queue;
 
 import org.apache.asterix.common.config.DatasetConfig.DatasetType;
 import org.apache.asterix.metadata.declared.AqlDataSource;
@@ -149,8 +151,12 @@
 private void changePlan(List optFuncExprs, 
AbstractLogicalOperator op, Dataset dataset,
 IOptimizationContext context) throws AlgebricksException {
 
-AbstractLogicalOperator descendantOp = (AbstractLogicalOperator) 
op.getInputs().get(0).getValue();
-while (descendantOp != null) {
+Queue queue = new 
LinkedList<>(op.getInputs());
+while (!queue.isEmpty()) {
+AbstractLogicalOperator descendantOp = (AbstractLogicalOperator) 
queue.poll().getValue();
+if (descendantOp == null) {
+continue;
+}
 if (descendantOp.getOperatorTag() == 
LogicalOperatorTag.DATASOURCESCAN) {
 DataSourceScanOperator dataSourceScanOp = 
(DataSourceScanOperator) descendantOp;
 AqlDataSource ds = (AqlDataSource) 
dataSourceScanOp.getDataSource();
@@ -208,10 +214,7 @@
 }
 }
 }
-if (descendantOp.getInputs().isEmpty()) {
-break;
-}
-descendantOp = (AbstractLogicalOperator) 
descendantOp.getInputs().get(0).getValue();
+queue.addAll(descendantOp.getInputs());
 }
 }
 
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect-with-filter.aql
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect-with-filter.aql
new file mode 100644
index 000..353129e
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect-with-filter.aql
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*
+ * Description: Tests three types of secondary indexes should trigger 
intersection rule
+ * Success: Yes
+ */
+
+drop dataverse test if exists;
+create dataverse test;
+use dataverse test;
+
+create type tTweet as closed {
+  id: int32,
+  location: point,
+  message: string,
+  create_at: datetime,
+  misc: string
+}
+
+create dataset dsTweet(tTweet) primary key id with filter on create_at;
+
+create index ngram_index on dsTweet(message) 

Change in asterixdb[master]: some WebUI hackery

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: some WebUI hackery
..


Patch Set 13: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1161/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1097
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32361a523e656c62a6bc878b1eed9750579097f9
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No


Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: fix dependencies for asterix-common
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1164/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1357
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: Support filter on multiple input path

2016-11-23 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change.

Change subject: Support filter on multiple input path
..


Patch Set 2: Code-Review+2

Please change the commit message before merging this.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Taewoo Kim (Code Review)
Taewoo Kim has posted comments on this change.

Change subject: Support LSM-filter on multiple input paths
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: WIP - symbolic constants in lock manager

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: WIP - symbolic constants in lock manager
..


Patch Set 12:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1162/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/694
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I774dd40113f5fa4fee94dde72f4ec6a1891c6b6e
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: Support LSM-filter on multiple input paths
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3349/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Jianfeng Jia has posted comments on this change.

Change subject: Support LSM-filter on multiple input paths
..


Patch Set 3: Code-Review+2

Forward Taewoo's +2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: Support LSM-filter on multiple input paths

2016-11-23 Thread Jianfeng Jia (Code Review)
Hello Taewoo Kim, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1356

to look at the new patch set (#3).

Change subject: Support LSM-filter on multiple input paths
..

Support LSM-filter on multiple input paths

The IntroduceLSMComponentFilterRule only checked one input path,
which does not work for the multiple-path cases (e.g., intersection case)
This patch fixes this bug.

Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceLSMComponentFilterRule.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/multi-indexes/btree-rtree-ngram-intersect-with-filter.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/multi-indexes/btree-rtree-ngram-intersect-with-filter.plan
3 files changed, 99 insertions(+), 6 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/56/1356/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1356
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I390ac11f3a2781f10f726dce917d89ec640dd917
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 


Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: fix dependencies for asterix-common
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3350/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1357
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: fix dependencies for asterix-common

2016-11-23 Thread Till Westmann (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1357

to look at the new patch set (#2).

Change subject: fix dependencies for asterix-common
..

fix dependencies for asterix-common

Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
---
M asterixdb/asterix-common/pom.xml
M asterixdb/asterix-external-data/pom.xml
M asterixdb/asterix-runtime/pom.xml
M asterixdb/pom.xml
4 files changed, 121 insertions(+), 22 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/57/1357/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1357
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I699fad60cfac996940d6017e4f0791027b6494c3
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi