[GitHub] commons-compress issue #61: Code Cleanup.

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/61
  

[![Coverage 
Status](https://coveralls.io/builds/15045202/badge)](https://coveralls.io/builds/15045202)

Coverage increased (+0.1%) to 86.194% when pulling 
**394a315316063d30769c89355732d57863d656cb on shahabkondri:cleanup** into 
**08cdbe2993fef2890e2b2609a653217e38fb67e0 on apache:master**.



---

[GitHub] commons-compress pull request #61: Code Cleanup.

[shahabkondri]

GitHub user shahabkondri opened a pull request:

https://github.com/apache/commons-compress/pull/61

Code Cleanup.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shahabkondri/commons-compress cleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #61


commit 182ccc1a418ec882270db5bc503aa5737265c9a9
Author: shahab 
Date:   2018-01-14T19:06:33Z

Modifier 'private' is redundant for enum constructors.

commit 4818cf0ccf606c2a4c0bca463d05c64b6bc404a8
Author: shahab 
Date:   2018-01-14T19:08:17Z

Modifier 'static' is redundant for enum constructors.

commit adb0b2ab641f629fe6da99a0a996eabff8b78911
Author: shahab 
Date:   2018-01-14T19:12:51Z

if statement can be simplified.

commit f5af518667398f02c78511247eb3338111fd8b92
Author: shahab 
Date:   2018-01-14T19:19:10Z

if statement can be simplified.

commit 30d624385def5739a5ec9eb1f6754b392c8392d2
Author: shahab 
Date:   2018-01-14T19:21:33Z

Local variable is redundant.

commit fef06ba8c650f2a2963dbbb23c2ba09e519da53d
Author: shahab 
Date:   2018-01-14T19:25:04Z

There is General exception 'IOException' in the throws list already.

commit f26634ce898eb1db4f71becf98b07bc3ebddb4d4
Author: shahab 
Date:   2018-01-14T19:26:56Z

remove unused import.

commit 068eefbae5a0df4000961e84a4dd37fe4bdb9f70
Author: shahab 
Date:   2018-01-14T19:32:18Z

Explicit manual boxing is unnecessary under Java 5 and newer, and can be 
safely removed.

commit 394a315316063d30769c89355732d57863d656cb
Author: shahab 
Date:   2018-01-14T19:37:59Z

'long' literal ending with lowercase 'l' instead of 'L'




---

[GitHub] commons-compress issue #60: Replace custom 'dummy' byte addition for the odd...

[dweiss]

Github user dweiss commented on the issue:

https://github.com/apache/commons-compress/pull/60
  
No problem at all; sorry I missed that other place that was using the 
inflater (glad you spotted it); had kids on my back and couldn't focus.


---

Jenkins build is back to stable : Commons-Compress-Windows #472

[Apache Jenkins Server]

See 

Jenkins build is back to stable : Commons-Compress-Windows » Apache Commons Compress #472

[Apache Jenkins Server]

See 

[GitHub] commons-compress pull request #60: Replace custom 'dummy' byte addition for ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-compress/pull/60


---

[GitHub] commons-compress issue #60: Replace custom 'dummy' byte addition for the odd...

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/commons-compress/pull/60
  
your PR and 43e8d3d collided mid-flight, sorry about that, I'll incorporate 
a few of your changes that I have missed.

Honestly, I don't recall why the methods are synchronized anymore either.


---

Jenkins build is still unstable: Commons-Compress-Windows #471

[Apache Jenkins Server]

See 

Jenkins build is still unstable: Commons-Compress-Windows » Apache Commons Compress #471

[Apache Jenkins Server]

See 

[GitHub] commons-compress issue #60: Replace custom 'dummy' byte addition for the odd...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/60
  

[![Coverage 
Status](https://coveralls.io/builds/15042075/badge)](https://coveralls.io/builds/15042075)

Coverage decreased (-0.06%) to 86.003% when pulling 
**49fa6740524dbcad89564d897de1806aef1dd92c on dweiss:dummyByte** into 
**c66db899cb061c79934986f0efa19a50ca33703f on apache:master**.



---

[GitHub] commons-compress issue #60: Replace custom 'dummy' byte addition for the odd...

[dweiss]

Github user dweiss commented on the issue:

https://github.com/apache/commons-compress/pull/60
  
Also, to be honest -- this boundedinputstream has synchronized read methods 
and I've no idea why they're there. I don't think we have to create thread-safe 
streams here (is this a requirement anyhow?). This isn't included in the patch, 
but I'd drop synchronized from boundedinputstream entirely.


---

[GitHub] commons-compress pull request #60: Replace custom 'dummy' byte addition for ...

[dweiss]

GitHub user dweiss opened a pull request:

https://github.com/apache/commons-compress/pull/60

Replace custom 'dummy' byte addition for the odd inflater contract wi…

…th a sequence input stream. Clean up the code a bit. I did not use 
NOSONAR flags because I don't use sonar, so it may require some tweaking.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dweiss/commons-compress dummyByte

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60


commit 49fa6740524dbcad89564d897de1806aef1dd92c
Author: Dawid Weiss 
Date:   2018-01-14T10:20:02Z

Replace custom 'dummy' byte addition for the odd inflater contract with a 
sequence input stream. Clean up the code a bit. I did not use NOSONAR flags 
because I don't use sonar, so it may require some tweaking.




---

Jenkins build became unstable: Commons-Compress-Windows » Apache Commons Compress #470

[Apache Jenkins Server]

See 

Jenkins build became unstable: Commons-Compress-Windows #470

[Apache Jenkins Server]

See 

Jenkins build is back to normal : commons-io #107

[Apache Jenkins Server]

See 

Build failed in Jenkins: commons-io #106

[Apache Jenkins Server]

See 

Changes:

[pascalschumacher] IO-557: UnsupportedEncodingException when opening an 
ISO-8859-1 XML

[pascalschumacher] IO-557: UnsupportedEncodingException when opening an 
ISO-8859-1 XML

--
[...truncated 20.97 KB...]
[INFO] Running org.apache.commons.io.input.TailerTest
Elapsed: 1799
testMultiByteBreak() Default charset: windows-1252
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.024 
s - in org.apache.commons.io.input.TailerTest
[INFO] Running org.apache.commons.io.input.TeeInputStreamTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.143 s 
- in org.apache.commons.io.input.TeeInputStreamTest
[INFO] Running org.apache.commons.io.input.UnixLineEndingInputStreamTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.13 s - 
in org.apache.commons.io.input.UnixLineEndingInputStreamTest
[INFO] Running org.apache.commons.io.input.WindowsLineEndingInputStreamTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.135 s 
- in org.apache.commons.io.input.WindowsLineEndingInputStreamTest
[INFO] Running org.apache.commons.io.input.XmlStreamReaderTest
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.537 s 
- in org.apache.commons.io.input.XmlStreamReaderTest
[INFO] Running org.apache.commons.io.input.XmlStreamReaderUtilitiesTest
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.164 s 
- in org.apache.commons.io.input.XmlStreamReaderUtilitiesTest
[INFO] Running org.apache.commons.io.IOCaseTestCase
[INFO] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.269 s 
- in org.apache.commons.io.IOCaseTestCase
[INFO] Running org.apache.commons.io.IOExceptionWithCauseTestCase
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.116 s 
- in org.apache.commons.io.IOExceptionWithCauseTestCase
[INFO] Running org.apache.commons.io.IOUtilsCopyTestCase
[INFO] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.237 s 
- in org.apache.commons.io.IOUtilsCopyTestCase
[INFO] Running org.apache.commons.io.IOUtilsTestCase
[INFO] Tests run: 107, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.824 
s - in org.apache.commons.io.IOUtilsTestCase
[INFO] Running org.apache.commons.io.IOUtilsWriteTestCase
[INFO] Tests run: 53, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.211 s 
- in org.apache.commons.io.IOUtilsWriteTestCase
[INFO] Running org.apache.commons.io.LineIteratorTestCase
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.329 s 
- in org.apache.commons.io.LineIteratorTestCase
[INFO] Running org.apache.commons.io.monitor.FileAlterationMonitorTestCase
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.901 s 
- in org.apache.commons.io.monitor.FileAlterationMonitorTestCase
[INFO] Running org.apache.commons.io.monitor.FileAlterationObserverTestCase
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.404 s 
- in org.apache.commons.io.monitor.FileAlterationObserverTestCase
[INFO] Running org.apache.commons.io.output.AppendableOutputStreamTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.16 s - 
in org.apache.commons.io.output.AppendableOutputStreamTest
[INFO] Running org.apache.commons.io.output.BrokenOutputStreamTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 s 
- in org.apache.commons.io.output.BrokenOutputStreamTest
[INFO] Running org.apache.commons.io.output.ByteArrayOutputStreamTestCase
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.136 s 
- in org.apache.commons.io.output.ByteArrayOutputStreamTestCase
[INFO] Running org.apache.commons.io.output.ChunkedOutputStreamTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.136 s 
- in org.apache.commons.io.output.ChunkedOutputStreamTest
[INFO] Running org.apache.commons.io.output.ChunkedWriterTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.14 s - 
in org.apache.commons.io.output.ChunkedWriterTest
[INFO] Running org.apache.commons.io.output.ClosedOutputStreamTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.134 s 
- in org.apache.commons.io.output.ClosedOutputStreamTest
[INFO] Running org.apache.commons.io.output.CloseShieldOutputStreamTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 s 
- in org.apache.commons.io.output.CloseShieldOutputStreamTest
[INFO] Running org.apache.commons.io.output.CountingOutputStreamTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.189 s 
- in org.apache.commons.io.output.CountingOutputStreamTest
[INFO] Running org.apache.commons.io.output.DeferredFileOutputStreamTest
[INFO] Tests run: 130, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.397 
s -