[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[davisp]

Github user davisp commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204155467
  
Not a bad idea. I'd not try and add it to the current replicator though as 
there are way too many sharp corners with the HTTP stuff for us to trip up on 
and accidentally fail to checkpoint often enough or something.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

[Nick Vatamaniuc (JIRA)]

 [ 
https://issues.apache.org/jira/browse/COUCHDB-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Vatamaniuc resolved COUCHDB-2979.
--
Resolution: Fixed

> Replicator manager attempts to checkpoint too frequently
> 
>
> Key: COUCHDB-2979
> URL: https://issues.apache.org/jira/browse/COUCHDB-2979
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Nick Vatamaniuc
>
> Current checkpoint interval is set to 5 seconds. That works well for a few 
> replications but when there are thousands of them it ends up being an attempt 
> every few milliseconds or so.
> Moreover to decide on ownership (in order to keep on replication running per 
> cluster) each replication during an attempted checkpoint uses a gen_server 
> call to replicator manager. Those usually are fast (I bench-marked at a 
> 100-200 usec) however if replicator manager is busy (say stuck fetching large 
> filter documents when computing replication ids), none of the replication 
> would be able to checkpoint and make progress.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal

[kxepal]

Github user kxepal commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/676#issuecomment-204141459
  
The message is awesome! It seems I can delete google.com now (:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Deleting cors domain moved to modal

[benkeen]

GitHub user benkeen opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/676

Deleting cors domain moved to modal

This is part of the death-to-all-window.confirms that Justin's
leading. The delete origin is now a modal.

Two related things:
- The cors page wasn't scrolling, hence the addition of the flex-body
class on the page element.
- the ConfirmationModal component now lets you pass in a class
for the main button to change the style.

https://cloud.githubusercontent.com/assets/512116/14191688/2ba1eeb2-f74e-11e5-926d-47f5bf245c81.png;>


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/benkeen/couchdb-fauxton cors-page-modal

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #676


commit ed3319185a93d397698b663761488d7ad9bf6cf7
Author: Ben Keen 
Date:   2016-03-31T21:36:57Z

Deleting cors domain moved to modal

This is part of the death-to-all-window.confirms that Justin's
leading. The delete origin is now a modal.

Two related things:
- The cors page wasn't scrolling, hence the addition of the flex-body
class on the page element.
- the ConfirmationModal component now lets you pass in a class
for the main button to change the style.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[nickva]

Github user nickva commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204138765
  
@kxepal Yeah it seems like a decent optimization. 

@rnewson @davisp  -- Robert, Paul, what do you think? Is this doable based 
on how _local docs are handled? i.e. to modify _bulk_docs to handle _local then 
to modify replicator to use it in some cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[kxepal]

Github user kxepal commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204136297
  
@nickva Right. This saves you one HTTP request and makes checkpoints more 
often for free. However, it doesn't removes need to do PUT to _local as not all 
the docs we send via _bulk_docs. But if attachments are the rare thing in the 
database, this will give the highest profit for free. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[nickva]

Github user nickva commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204135460
  
@kxepal Oh interesting. I took at look and yeah PouchDB supports _bulk_docs 
on _local docs ( https://pouchdb.com/guides/local-documents.html ).  So the 
idea is that instead of PUT-ing to  _local separately, replicator will just 
send those updates in the _bulk_docs ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[kxepal]

Github user kxepal commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204108936
  
@nickva Idea for future: I think it worth to steal the idea from PouchDB 
about sending checkpoint with _bulk_docs update. This is: 1) cheap 2) reduces 
the window of not-checkpointed data 3) reduces queue of processes who want to 
set checkpoint via separate request. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Style update for metadata page

[benkeen]

Github user benkeen commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-204107230
  
Curious. Couldn't reproduce, but I made the code a bit more defensive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: adding velocity-react license for Fauxton

[benkeen]

Github user benkeen closed the pull request at:

https://github.com/apache/couchdb/pull/392


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: adding velocity-react license for Fauxton

[benkeen]

Github user benkeen commented on the pull request:

https://github.com/apache/couchdb/pull/392#issuecomment-204100958
  
Merged as 1a91fe5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220488#comment-15220488
 ] 

ASF GitHub Bot commented on COUCHDB-2979:
-

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch-replicator/pull/34


> Replicator manager attempts to checkpoint too frequently
> 
>
> Key: COUCHDB-2979
> URL: https://issues.apache.org/jira/browse/COUCHDB-2979
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Nick Vatamaniuc
>
> Current checkpoint interval is set to 5 seconds. That works well for a few 
> replications but when there are thousands of them it ends up being an attempt 
> every few milliseconds or so.
> Moreover to decide on ownership (in order to keep on replication running per 
> cluster) each replication during an attempted checkpoint uses a gen_server 
> call to replicator manager. Those usually are fast (I bench-marked at a 
> 100-200 usec) however if replicator manager is busy (say stuck fetching large 
> filter documents when computing replication ids), none of the replication 
> would be able to checkpoint and make progress.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220487#comment-15220487
 ] 

ASF subversion and git services commented on COUCHDB-2979:
--

Commit 9ee3e19b997258a7d57b993afec34bcbbf4772c5 in couchdb-couch-replicator's 
branch refs/heads/master from [~kzx]
[ 
https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=9ee3e19
 ]

Reduce checkpoint frequency from 5 to 30 seconds

Use a macro to avoid hard-coding magic number
in two places.

COUCHDB-2979


> Replicator manager attempts to checkpoint too frequently
> 
>
> Key: COUCHDB-2979
> URL: https://issues.apache.org/jira/browse/COUCHDB-2979
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Nick Vatamaniuc
>
> Current checkpoint interval is set to 5 seconds. That works well for a few 
> replications but when there are thousands of them it ends up being an attempt 
> every few milliseconds or so.
> Moreover to decide on ownership (in order to keep on replication running per 
> cluster) each replication during an attempted checkpoint uses a gen_server 
> call to replicator manager. Those usually are fast (I bench-marked at a 
> 100-200 usec) however if replicator manager is busy (say stuck fetching large 
> filter documents when computing replication ids), none of the replication 
> would be able to checkpoint and make progress.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch-replicator/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[rnewson]

Github user rnewson commented on the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#issuecomment-204082838
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Minor fixes

[benkeen]

GitHub user benkeen opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/675

Minor fixes

Three unrelated small changes:
- typo fix on doc page
- fix for absolute URLs for APIs setup and config pages
- spacing tweak for icons on db page

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/benkeen/couchdb-fauxton general-minor-tweaks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #675


commit 91d30bcd5569432909453c9e0ce793d61271f7e4
Author: Ben Keen 
Date:   2016-03-31T16:44:23Z

Minor fixes

Three unrelated small changes:
- typo fix on doc page
- fix for absolute URLs for APIs setup and config pages
- spacing tweak for icons on db page




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Refactor rename on delete

[rnewson]

Github user rnewson commented on the pull request:

https://github.com/apache/couchdb-couch/pull/141#issuecomment-204014583
  
I think this can and should be much simpler. I'm not sure where the 
reluctance to call `config:get` in `couch_file:delete` comes from but I don't 
find it objectionable and it will radically simplify this change.

I note, as it's not noted anywhere so far, that the intention of the patch 
is to allow the administrator to decide if compacted files are immediately 
deleted or just renamed to the `.delete` directory (for removal by an external 
process). Cloudant does this to avoid performance issues when deleting large 
files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Improvements for table view

[benkeen]

Github user benkeen commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/667#issuecomment-204008207
  
I ran that command but don't see any new addition in the table view content 
for that DB. How new is that feature? Do I need to update couch?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[kxepal]

Github user kxepal commented on a diff in the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#discussion_r58083278
  
--- Diff: src/couch_replicator.erl ---
@@ -76,7 +78,7 @@
 target_monitor = nil,
 source_seq = nil,
 use_checkpoints = true,
-checkpoint_interval = 5000,
+checkpoint_interval = ?DEFAULT_CHECKPOINT_INTERVAL,
--- End diff --

You have change `5000` to `30`. That's indeed is timeout reducing, but I 
fear that in wrong way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[nickva]

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-couch-replicator/pull/34

Better handling of multiple concurrent replications

* Reduce checkpoint frequency from 5 to 30 seconds

* Avoid calling replicator manager for ownership checks. During attempted 
checkpoints each replication made a gen_server call to replication manager to 
decide if replication should still be running on that node. Use a function 
instead.


COUCHDB-2979

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-couch-replicator couch-2979

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-couch-replicator/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 43f3c720811be0ad757cd9b9b823b30104b6913c
Author: Nick Vatamaniuc 
Date:   2016-03-31T15:50:53Z

Reduce checkpoint frequency from 5 to 30 seconds

Use a macro to avoid hard-coding magic number
in two places.

COUCHDB-2979

commit 1a2eb18f0ed1a2dbca6dd6b346ae7e0f96deed95
Author: Nick Vatamaniuc 
Date:   2016-03-31T15:58:01Z

Avoid calling replicator manager for ownership checks

During attempted checkpoint each replication made
a gen_server call to replication manager to decide
if replication should still be running that node.

The call is generally fast (10s to 100s of microseconds),
however if replication manager is blocked,
for example, fetching large filter functions,
none of the replications could checkpoint &
make progress.

Now replications call the ownership function
without going through a gen_server call.

COUCHDB-2979




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Better handling of multiple...

[rnewson]

Github user rnewson commented on a diff in the pull request:


https://github.com/apache/couchdb-couch-replicator/pull/34#discussion_r58082760
  
--- Diff: src/couch_replicator_manager.erl ---
@@ -134,9 +134,14 @@ replication_error(#rep{id = {BaseId, _} = RepId}, 
Error) ->
 continue(#rep{doc_id = null}) ->
 {true, no_owner};
 continue(#rep{id = RepId}) ->
-Owner = gen_server:call(?MODULE, {owner, RepId}, infinity),
-{node() == Owner, Owner}.
-
+case rep_state(RepId) of
+nil ->
+{false, nonode};
+#rep_state{rep = #rep{db_name = DbName, doc_id = DocId}} ->
+Node = node(),
+Owner = owner(DbName, DocId, [Node | nodes()]),
--- End diff --

(The idea being that, eventually, all nodes would have rescanned with the 
same [node()|nodes()] value if we're tracking it in state. It could well be 
just the same as you are doing).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (COUCHDB-2979) Replicator manager attempts to checkpoint too frequently

[Nick Vatamaniuc (JIRA)]

Nick Vatamaniuc created COUCHDB-2979:


 Summary: Replicator manager attempts to checkpoint too frequently
 Key: COUCHDB-2979
 URL: https://issues.apache.org/jira/browse/COUCHDB-2979
 Project: CouchDB
  Issue Type: Bug
Reporter: Nick Vatamaniuc


Current checkpoint interval is set to 5 seconds. That works well for a few 
replications but when there are thousands of them it ends up being an attempt 
every few milliseconds or so.

Moreover to decide on ownership (in order to keep on replication running per 
cluster) each replication during an attempted checkpoint uses a gen_server call 
to replicator manager. Those usually are fast (I bench-marked at a 100-200 
usec) however if replicator manager is busy (say stuck fetching large filter 
documents when computing replication ids), none of the replication would be 
able to checkpoint and make progress.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-couch pull request: Refactor rename on delete

[rnewson]

Github user rnewson commented on the pull request:

https://github.com/apache/couchdb-couch/pull/141#issuecomment-203984230
  
This is a lot to read for something apparently simple. It's also not a 
refactor as it changes behaviour, so please correct the title and any comments 
claiming its a refactor.

Will try to devote some time to this soon, but, really, it's this 
complicated?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Notifications update

[garrensmith]

Github user garrensmith commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203980010
  
I'm on chrome. It always looked jagged.

On Thu, Mar 31, 2016 at 4:33 PM, Benjamin Keen 
wrote:

> @garrensmith  - worrying about the
> animation looking jagged. Did it always look jagged for you, or just now
> and then? You're on Chrome/FF, I guess.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Refactor rename on delete

[iilyak]

Github user iilyak commented on the pull request:

https://github.com/apache/couchdb-couch/pull/141#issuecomment-203979341
  
I am +1 for this change. However since I also contributed to this work it 
would be nice if someone else would review it as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch pull request: Refactor rename on delete

[iilyak]

Github user iilyak commented on a diff in the pull request:

https://github.com/apache/couchdb-couch/pull/141#discussion_r58068950
  
--- Diff: src/couch_file.erl ---
@@ -247,7 +247,7 @@ delete_file(FilePath) ->
 deleted_filename(_RootDir, Original, rename) ->
 deleted_filename(Original, "deleted");
 deleted_filename(RootDir, Original, _Strategy) ->
-DelFileName = deleted_filename_base(RootDir, Original),
+DelFileName = couch_util:url_encode(Original -- RootDir),
--- End diff --

I have a concern with using `--` here. I know that it is a common thing in 
erlang community to do something like this. But it so error prone. There are at 
least two problems:
1. number of slashes makes the difference
2. it brakes badly if two paths do not have common prefix
```
"/foo/bar/baz" -- "/src/bar".
"foo/baz"
```
Feel free to ignore this. Since this is my complain to the state of 
erlang's stdlib which is the mess.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Notifications update

[benkeen]

Github user benkeen commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203966945
  
@garrensmith - worrying about the animation looking jagged. Did it always 
look jagged for you, or just now and then? You're on Chrome/FF, I guess. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Notifications update

[benkeen]

Github user benkeen commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58063745
  
--- Diff: app/templates.js ---
@@ -0,0 +1,623 @@
+this["JST"] = this["JST"] || {};
--- End diff --

Ah ok, thanks. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (COUCHDB-2978) Stale ETags are re-used for _local docs

[Garren Smith (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219936#comment-15219936
 ] 

Garren Smith commented on COUCHDB-2978:
---

I can take a look at this next week and get a fix in.

> Stale ETags are re-used for _local docs
> ---
>
> Key: COUCHDB-2978
> URL: https://issues.apache.org/jira/browse/COUCHDB-2978
> Project: CouchDB
>  Issue Type: Bug
>  Components: HTTP Interface
>Reporter: Nolan Lawson
>Priority: Blocker
> Fix For: 1.7.0
>
>
> CouchDB re-uses the same ETags for _local documents even when the content of 
> the _local document has changed, meaning that clients who cache based on the 
> ETag may end up with permanently stale content. To reproduce the bug, it's 
> simply:
> 1. Create a _local doc
> 2. Fetch the doc, ETag is "0-1"
> 3. Delete the database (or the _local doc)
> 4. Recreate the database (or the _local doc), insert a *changed* _local doc
> 5. Fetch the doc, ETag is still "0-1" and therefore the client may end up 
> with a stale version.
> Here are related issues in PouchDB and WebKit for further details:
> - [PouchDB bug|https://github.com/pouchdb/pouchdb/issues/5010]
> - [WebKit bug|https://bugs.webkit.org/show_bug.cgi?id=156048]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-2978) Stale ETags are re-used for _local docs

[Jan Lehnardt (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219898#comment-15219898
 ] 

Jan Lehnardt commented on COUCHDB-2978:
---

Via IRC discussion:

rnewson:I think the best fix is to not add ETag for _local docs
jan:in this case we should not send an ETag for local docs, and we 
should whatever no-cache headers that are appropriate

e.g.: this bug is on us.

> Stale ETags are re-used for _local docs
> ---
>
> Key: COUCHDB-2978
> URL: https://issues.apache.org/jira/browse/COUCHDB-2978
> Project: CouchDB
>  Issue Type: Bug
>  Components: HTTP Interface
>Reporter: Nolan Lawson
> Fix For: 1.7.0
>
>
> CouchDB re-uses the same ETags for _local documents even when the content of 
> the _local document has changed, meaning that clients who cache based on the 
> ETag may end up with permanently stale content. To reproduce the bug, it's 
> simply:
> 1. Create a _local doc
> 2. Fetch the doc, ETag is "0-1"
> 3. Delete the database (or the _local doc)
> 4. Recreate the database (or the _local doc), insert a *changed* _local doc
> 5. Fetch the doc, ETag is still "0-1" and therefore the client may end up 
> with a stale version.
> Here are related issues in PouchDB and WebKit for further details:
> - [PouchDB bug|https://github.com/pouchdb/pouchdb/issues/5010]
> - [WebKit bug|https://bugs.webkit.org/show_bug.cgi?id=156048]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-fauxton pull request: Webpack fixes

[robertkowalski]

Github user robertkowalski commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/674#issuecomment-203954265
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (COUCHDB-2978) ETag should not be sent for _local docs

[Nolan Lawson (JIRA)]

Nolan Lawson created COUCHDB-2978:
-

 Summary: ETag should not be sent for _local docs
 Key: COUCHDB-2978
 URL: https://issues.apache.org/jira/browse/COUCHDB-2978
 Project: CouchDB
  Issue Type: Bug
  Components: HTTP Interface
Reporter: Nolan Lawson


CouchDB re-uses the same ETags for _local documents even when the content of 
the _local document has changed, meaning that clients who cache based on the 
ETag may end up with permanently stale content. To reproduce the bug, it's 
simply:

1. Create a _local doc
2. Fetch the doc, ETag is "0-1"
3. Delete the database (or the _local doc)
4. Recreate the database (or the _local doc), insert a *changed* _local doc
5. Fetch the doc, ETag is still "0-1" and therefore the client may end up with 
a stale version.

Here are related issues in PouchDB and WebKit for further details:
- [PouchDB bug|https://github.com/pouchdb/pouchdb/issues/5010]
- [WebKit bug|https://bugs.webkit.org/show_bug.cgi?id=156048]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-fauxton pull request: Webpack fixes

[robertkowalski]

Github user robertkowalski commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/674#discussion_r58056436
  
--- Diff: assets/js/libs/css.escape.js ---
@@ -1,84 +0,0 @@
-/*! https://mths.be/cssescape v0.2.1 by @mathias | MIT license */
-;(function(root) {
--- End diff --

why is it unneeded?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (COUCHDB-2977) JavaScript and CSS files for fauxton can not be found

[Patrick Palacin (JIRA)]

Patrick Palacin created COUCHDB-2977:


 Summary: JavaScript and CSS files for fauxton can not be found
 Key: COUCHDB-2977
 URL: https://issues.apache.org/jira/browse/COUCHDB-2977
 Project: CouchDB
  Issue Type: Bug
  Components: Fauxton
Reporter: Patrick Palacin


Hi folks,

i followed these guide:
https://docs.google.com/document/d/1BtndYr-0KDQTqBSLVdJoR_8C5ObYjT1RBo_Qyh5ykdQ/edit#

installing as single node setup on latest alpha (15.3) . When i try now to open 
_utils I get a blank page. Firefox devtools are showing:

"NetworkError: 404 Object Not Found - 
http://159.122.91.165:5984/_utils/dashboard.assets/js/require-c9def4126d9d299af5b771713151534f.js;
require...534f.js
"NetworkError: 404 Object Not Found - 
http://159.122.91.165:5984/_utils/dashboard.assets/css/index-6772bc2fbb800cb971b29ad7f561.css;

I am running on Ubuntu 16.04 LTS and installed all dependencies from the 
standard repository.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] couchdb-fauxton pull request: Style update for metadata page

[garrensmith]

Github user garrensmith commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/663#issuecomment-203904853
  
I'm getting this error

`bundle.js:135902 Uncaught TypeError: Cannot read property 'toLocaleString' 
of undefined`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Notifications update

[garrensmith]

Github user garrensmith commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/668#issuecomment-203903107
  
This looks really cool, so awesome to see another piece of backbone 
disappear. Two things

* The animation looks a little jagged when a notification appears.
* The one test is failing - I think its worth just restarting the tests to 
see if its a flaky test.

Otherwise +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Notifications update

[garrensmith]

Github user garrensmith commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/668#discussion_r58041150
  
--- Diff: app/templates.js ---
@@ -0,0 +1,623 @@
+this["JST"] = this["JST"] || {};
--- End diff --

This file shouldn't be here. you will have to do a `git rm`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: adding velocity-react license for Fauxton

[garrensmith]

Github user garrensmith commented on the pull request:

https://github.com/apache/couchdb/pull/392#issuecomment-203895791
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---