[jira] [Commented] (COUCHDB-2983) is_replicator_db do not take into account shard's suffix
[ https://issues.apache.org/jira/browse/COUCHDB-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248750#comment-15248750 ] ASF subversion and git services commented on COUCHDB-2983: -- Commit 14c15179296d0c1934497ca4e8db42c4822fdd8f in couchdb-fabric's branch refs/heads/master from [~iilyak] [ https://git-wip-us.apache.org/repos/asf?p=couchdb-fabric.git;h=14c1517 ] Use couch_db:dbname_suffix in path_ends_with Replace couch_db:normalize_dbname with couch_db:dbname_suffix since the semantic of normalize_dbname has been changed. couch_db:normalize_dbname would return all components of the path with shard info removed from it. couch_db:dbname_suffix on the other hand would return the last component of the path. It would also ensure that shard's suffix is removed from the result. COUCHDB-2983 > is_replicator_db do not take into account shard's suffix > > > Key: COUCHDB-2983 > URL: https://issues.apache.org/jira/browse/COUCHDB-2983 > Project: CouchDB > Issue Type: Bug > Components: Database Core, Replication >Reporter: ILYA >Assignee: ILYA > > We use number of ways to detect replicator db: > 1. [<<"_replicator">> == > couch_db:normalize_dbname(Path)|https://github.com/apache/couchdb-fabric/blob/master/src/fabric_util.erl#L289] > in fabric. > 2. hardcoded as > [<<"_replicator">>|https://github.com/apache/couchdb-couch-replicator/blob/master/src/couch_replicator_manager.erl#L166:L167] > in replicator_manager > 3. calculated as [lists:last(binary:split(mem3:dbname(DbName), <<"/">>, > ...))|https://github.com/apache/couchdb-couch-replicator/blob/master/src/couch_replicator_manager.erl#L924] > in replicator_manager:is_replicator_db > We need to unify the way we do it. We also would want to make sure we remove > shard's suffix from the last part of the path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2983) is_replicator_db do not take into account shard's suffix
[ https://issues.apache.org/jira/browse/COUCHDB-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248727#comment-15248727 ] ASF subversion and git services commented on COUCHDB-2983: -- Commit 24fb718c01c37ca40a51339c554fb66ae75c5e42 in couchdb-couch-replicator's branch refs/heads/2983-use-dbname_suffix from [~iilyak] [ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=24fb718 ] Use couch_db:dbname_suffix in is_replicator_db couch_db:dbname_suffix would take shard's suffix into account. COUCHDB-2983 > is_replicator_db do not take into account shard's suffix > > > Key: COUCHDB-2983 > URL: https://issues.apache.org/jira/browse/COUCHDB-2983 > Project: CouchDB > Issue Type: Bug > Components: Database Core, Replication >Reporter: ILYA >Assignee: ILYA > > We use number of ways to detect replicator db: > 1. [<<"_replicator">> == > couch_db:normalize_dbname(Path)|https://github.com/apache/couchdb-fabric/blob/master/src/fabric_util.erl#L289] > in fabric. > 2. hardcoded as > [<<"_replicator">>|https://github.com/apache/couchdb-couch-replicator/blob/master/src/couch_replicator_manager.erl#L166:L167] > in replicator_manager > 3. calculated as [lists:last(binary:split(mem3:dbname(DbName), <<"/">>, > ...))|https://github.com/apache/couchdb-couch-replicator/blob/master/src/couch_replicator_manager.erl#L924] > in replicator_manager:is_replicator_db > We need to unify the way we do it. We also would want to make sure we remove > shard's suffix from the last part of the path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2994) Trouble Compiling couchdb-snappy
[ https://issues.apache.org/jira/browse/COUCHDB-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248691#comment-15248691 ] Noah Mehl commented on COUCHDB-2994: Oh hey! Sorry about that. Sounds great :) > Trouble Compiling couchdb-snappy > > > Key: COUCHDB-2994 > URL: https://issues.apache.org/jira/browse/COUCHDB-2994 > Project: CouchDB > Issue Type: Bug > Components: Build System >Affects Versions: 2.0.0 >Reporter: Noah Mehl > Fix For: 2.0.0 > > > I am trying to build CouchDB (master) on a smartos base64-lts zone. I'm > getting the following output from couchdb-snappy: > root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]# > /opt/local/src/couchdb/bin/rebar clean > ==> snappy (clean) > [root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 > /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar co > ==> snappy (compile) > Compiled src/snappy.erl > Compiling c_src/snappy_nif.cc > Compiling c_src/snappy/snappy-sinksource.cc > Compiling c_src/snappy/snappy-stubs-internal.cc > Compiling c_src/snappy/snappy.cc > c_src/snappy/snappy.cc: In member function 'bool > snappy::SnappyDecompressor::RefillTag()': > c_src/snappy/snappy.cc:834:21: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > c_src/snappy/snappy.cc: In instantiation of 'bool > snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t, > std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t = > long unsigned int]': > c_src/snappy/snappy.cc:779:9: required from 'void > snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer = > snappy::SnappyScatteredWriter]' > c_src/snappy/snappy.cc:865:3: required from 'bool > snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*, > snappy::uint32) [with Writer = > snappy::SnappyScatteredWriter; snappy::uint32 = > unsigned int]' > c_src/snappy/snappy.cc:1549:78: required from here > c_src/snappy/snappy.cc:1401:5: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > Any help would be appreciated. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (COUCHDB-2994) Trouble Compiling couchdb-snappy
[
https://issues.apache.org/jira/browse/COUCHDB-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Shorin reopened COUCHDB-2994:
---
Let's keep this open for a while since GCC 4.8 is quite old and the problem
with new versions still exists. Also the issue could be reproduced on any else
systems with {{-Wall -Werror}} flags.
> Trouble Compiling couchdb-snappy
>
>
> Key: COUCHDB-2994
> URL: https://issues.apache.org/jira/browse/COUCHDB-2994
> Project: CouchDB
> Issue Type: Bug
> Components: Build System
>Affects Versions: 2.0.0
>Reporter: Noah Mehl
> Fix For: 2.0.0
>
>
> I am trying to build CouchDB (master) on a smartos base64-lts zone. I'm
> getting the following output from couchdb-snappy:
> root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]#
> /opt/local/src/couchdb/bin/rebar clean
> ==> snappy (clean)
> [root@441920aa-c373-40a0-a990-a6b8ce0d8dd4
> /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar co
> ==> snappy (compile)
> Compiled src/snappy.erl
> Compiling c_src/snappy_nif.cc
> Compiling c_src/snappy/snappy-sinksource.cc
> Compiling c_src/snappy/snappy-stubs-internal.cc
> Compiling c_src/snappy/snappy.cc
> c_src/snappy/snappy.cc: In member function 'bool
> snappy::SnappyDecompressor::RefillTag()':
> c_src/snappy/snappy.cc:834:21: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
> c_src/snappy/snappy.cc: In instantiation of 'bool
> snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t,
> std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t =
> long unsigned int]':
> c_src/snappy/snappy.cc:779:9: required from 'void
> snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer =
> snappy::SnappyScatteredWriter]'
> c_src/snappy/snappy.cc:865:3: required from 'bool
> snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*,
> snappy::uint32) [with Writer =
> snappy::SnappyScatteredWriter; snappy::uint32 =
> unsigned int]'
> c_src/snappy/snappy.cc:1549:78: required from here
> c_src/snappy/snappy.cc:1401:5: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
> Any help would be appreciated. Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (COUCHDB-2995) Can't build CouchDB on Smartos
Noah Mehl created COUCHDB-2995:
--
Summary: Can't build CouchDB on Smartos
Key: COUCHDB-2995
URL: https://issues.apache.org/jira/browse/COUCHDB-2995
Project: CouchDB
Issue Type: Bug
Components: Build System
Reporter: Noah Mehl
When I try to build CouchDB on SmartOS, I get the following output:
./configure --prefix=/opt/local
==> configuring couchdb in rel/couchdb.config
Cloning into '/opt/local/src/couchdb/src/rebar'...
remote: Counting objects: 367, done.
remote: Compressing objects: 100% (249/249), done.
remote: Total 367 (delta 60), reused 363 (delta 59)
Receiving objects: 100% (367/367), 241.62 KiB | 0 bytes/s, done.
Resolving deltas: 100% (60/60), done.
Checking connectivity... done.
Note: checking out '5dea85db1b697466586877bed133748bd80fa180'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b
make: Entering directory '/opt/local/src/couchdb/src/rebar'
./bootstrap
Recompile: src/rebar
Recompile: src/rebar_abnfc_compiler
Recompile: src/rebar_app_utils
Recompile: src/rebar_appups
Recompile: src/rebar_asn1_compiler
Recompile: src/rebar_base_compiler
Recompile: src/rebar_cleaner
Recompile: src/rebar_config
Recompile: src/rebar_core
Recompile: src/rebar_cover_utils
Recompile: src/rebar_ct
Recompile: src/rebar_deps
Recompile: src/rebar_dia_compiler
Recompile: src/rebar_dialyzer
Recompile: src/rebar_edoc
Recompile: src/rebar_erlc_compiler
Recompile: src/rebar_erlydtl_compiler
Recompile: src/rebar_escripter
Recompile: src/rebar_eunit
Recompile: src/rebar_file_utils
Recompile: src/rebar_getopt
Recompile: src/rebar_lfe_compiler
Recompile: src/rebar_log
Recompile: src/rebar_metacmds
Recompile: src/rebar_mustache
Recompile: src/rebar_neotoma_compiler
Recompile: src/rebar_otp_app
Recompile: src/rebar_otp_appup
Recompile: src/rebar_port_compiler
Recompile: src/rebar_proto_compiler
Recompile: src/rebar_proto_gpb_compiler
Recompile: src/rebar_protobuffs_compiler
Recompile: src/rebar_qc
Recompile: src/rebar_rel_utils
Recompile: src/rebar_reltool
Recompile: src/rebar_require_vsn
Recompile: src/rebar_shell
Recompile: src/rebar_subdirs
Recompile: src/rebar_templater
Recompile: src/rebar_upgrade
Recompile: src/rebar_utils
Recompile: src/rebar_xref
Recompile: src/rmemo
==> rebar (compile)
==> rebar (escriptize)
Congratulations! You now have a self-contained script called "rebar" in
your current working directory. Place this script anywhere in your path
and you can use rebar to build OTP-compliant apps.
make: Leaving directory '/opt/local/src/couchdb/src/rebar'
make: Entering directory '/opt/local/src/couchdb/src/rebar'
make: Leaving directory '/opt/local/src/couchdb/src/rebar'
==> updating dependencies
WARN: Expected /opt/local/src/couchdb/src/docs to be a raw dependency
directory, but no directory found.
WARN: Expected /opt/local/src/couchdb/src/fauxton to be a raw dependency
directory, but no directory found.
==> rel (get-deps)
==> couchdb (get-deps)
WARN: Expected /opt/local/src/couchdb/src/docs to be a raw dependency
directory, but no directory found.
WARN: Expected /opt/local/src/couchdb/src/fauxton to be a raw dependency
directory, but no directory found.
Pulling couch_epi from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-couch-epi.git;,
"5a7f2868c720bc428e6c888dc61d988b9a5f63f1"}
Cloning into 'couch_epi'...
Pulling config from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-config.git;,
"a2d5ad2eedc960248b806f61df0a1009462bdb46"}
Cloning into 'config'...
Pulling b64url from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-b64url.git;,
"319fc604235ab1fde37047b38a432450161db750"}
Cloning into 'b64url'...
Pulling cassim from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-cassim.git;,
"ab1ef1cee5f7b7ec1733e44845c1df99fc7a66a3"}
Cloning into 'cassim'...
Pulling couch_log from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-couch-log.git;,
"e4abbd3874356dc7a201b09676e27ff7dc8bed7c"}
Cloning into 'couch_log'...
Pulling couch_log_lager from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-couch-log-lager.git;,
"b2a0471a87765de50c5eb05c65c121f68a9ae9fa"}
Cloning into 'couch_log_lager'...
Pulling chttpd from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-chttpd.git;,
"1ca86421bafd17cc5b954d9075e3a053ea951f6a"}
Cloning into 'chttpd'...
Pulling couch from
{git,"https://git-wip-us.apache.org/repos/asf/couchdb-couch.git;,
[jira] [Closed] (COUCHDB-2994) Trouble Compiling couchdb-snappy
[ https://issues.apache.org/jira/browse/COUCHDB-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noah Mehl closed COUCHDB-2994. -- Resolution: Fixed Fix Version/s: 2.0.0 Need to use the gcc48 package > Trouble Compiling couchdb-snappy > > > Key: COUCHDB-2994 > URL: https://issues.apache.org/jira/browse/COUCHDB-2994 > Project: CouchDB > Issue Type: Bug > Components: Build System >Affects Versions: 2.0.0 >Reporter: Noah Mehl > Fix For: 2.0.0 > > > I am trying to build CouchDB (master) on a smartos base64-lts zone. I'm > getting the following output from couchdb-snappy: > root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]# > /opt/local/src/couchdb/bin/rebar clean > ==> snappy (clean) > [root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 > /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar co > ==> snappy (compile) > Compiled src/snappy.erl > Compiling c_src/snappy_nif.cc > Compiling c_src/snappy/snappy-sinksource.cc > Compiling c_src/snappy/snappy-stubs-internal.cc > Compiling c_src/snappy/snappy.cc > c_src/snappy/snappy.cc: In member function 'bool > snappy::SnappyDecompressor::RefillTag()': > c_src/snappy/snappy.cc:834:21: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > c_src/snappy/snappy.cc: In instantiation of 'bool > snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t, > std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t = > long unsigned int]': > c_src/snappy/snappy.cc:779:9: required from 'void > snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer = > snappy::SnappyScatteredWriter]' > c_src/snappy/snappy.cc:865:3: required from 'bool > snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*, > snappy::uint32) [with Writer = > snappy::SnappyScatteredWriter; snappy::uint32 = > unsigned int]' > c_src/snappy/snappy.cc:1549:78: required from here > c_src/snappy/snappy.cc:1401:5: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > Any help would be appreciated. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2994) Trouble Compiling couchdb-snappy
[ https://issues.apache.org/jira/browse/COUCHDB-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248659#comment-15248659 ] Noah Mehl commented on COUCHDB-2994: I'm going to close this issue and open a different one for the main build. > Trouble Compiling couchdb-snappy > > > Key: COUCHDB-2994 > URL: https://issues.apache.org/jira/browse/COUCHDB-2994 > Project: CouchDB > Issue Type: Bug > Components: Build System >Affects Versions: 2.0.0 >Reporter: Noah Mehl > > I am trying to build CouchDB (master) on a smartos base64-lts zone. I'm > getting the following output from couchdb-snappy: > root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]# > /opt/local/src/couchdb/bin/rebar clean > ==> snappy (clean) > [root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 > /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar co > ==> snappy (compile) > Compiled src/snappy.erl > Compiling c_src/snappy_nif.cc > Compiling c_src/snappy/snappy-sinksource.cc > Compiling c_src/snappy/snappy-stubs-internal.cc > Compiling c_src/snappy/snappy.cc > c_src/snappy/snappy.cc: In member function 'bool > snappy::SnappyDecompressor::RefillTag()': > c_src/snappy/snappy.cc:834:21: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > c_src/snappy/snappy.cc: In instantiation of 'bool > snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t, > std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t = > long unsigned int]': > c_src/snappy/snappy.cc:779:9: required from 'void > snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer = > snappy::SnappyScatteredWriter]' > c_src/snappy/snappy.cc:865:3: required from 'bool > snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*, > snappy::uint32) [with Writer = > snappy::SnappyScatteredWriter; snappy::uint32 = > unsigned int]' > c_src/snappy/snappy.cc:1549:78: required from here > c_src/snappy/snappy.cc:1401:5: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > Any help would be appreciated. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2994) Trouble Compiling couchdb-snappy
[ https://issues.apache.org/jira/browse/COUCHDB-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248656#comment-15248656 ] Noah Mehl commented on COUCHDB-2994: Apparently, there is a gcc47, gcc48, and gcc49 package available. gcc48 will build snappy with no issues. > Trouble Compiling couchdb-snappy > > > Key: COUCHDB-2994 > URL: https://issues.apache.org/jira/browse/COUCHDB-2994 > Project: CouchDB > Issue Type: Bug > Components: Build System >Affects Versions: 2.0.0 >Reporter: Noah Mehl > > I am trying to build CouchDB (master) on a smartos base64-lts zone. I'm > getting the following output from couchdb-snappy: > root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]# > /opt/local/src/couchdb/bin/rebar clean > ==> snappy (clean) > [root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 > /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar co > ==> snappy (compile) > Compiled src/snappy.erl > Compiling c_src/snappy_nif.cc > Compiling c_src/snappy/snappy-sinksource.cc > Compiling c_src/snappy/snappy-stubs-internal.cc > Compiling c_src/snappy/snappy.cc > c_src/snappy/snappy.cc: In member function 'bool > snappy::SnappyDecompressor::RefillTag()': > c_src/snappy/snappy.cc:834:21: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > c_src/snappy/snappy.cc: In instantiation of 'bool > snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t, > std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t = > long unsigned int]': > c_src/snappy/snappy.cc:779:9: required from 'void > snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer = > snappy::SnappyScatteredWriter]' > c_src/snappy/snappy.cc:865:3: required from 'bool > snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*, > snappy::uint32) [with Writer = > snappy::SnappyScatteredWriter; snappy::uint32 = > unsigned int]' > c_src/snappy/snappy.cc:1549:78: required from here > c_src/snappy/snappy.cc:1401:5: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > Any help would be appreciated. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2994) Trouble Compiling couchdb-snappy
[
https://issues.apache.org/jira/browse/COUCHDB-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248644#comment-15248644
]
Noah Mehl commented on COUCHDB-2994:
I get a different error with gcc49:
root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb-snappy]#
/opt/local/src/couchdb/bin/rebar clean
==> couchdb-snappy (clean)
[root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb-snappy]#
/opt/local/src/couchdb/bin/rebar co
==> couchdb-snappy (compile)
Compiled src/snappy.erl
Compiling c_src/snappy_nif.cc
Compiling c_src/snappy/snappy-sinksource.cc
Compiling c_src/snappy/snappy-stubs-internal.cc
Compiling c_src/snappy/snappy.cc
c_src/snappy/snappy.cc: In instantiation of 'bool
snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t,
std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t = long
unsigned int]':
c_src/snappy/snappy.cc:779:13: required from 'void
snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer =
snappy::SnappyScatteredWriter]'
c_src/snappy/snappy.cc:865:3: required from 'bool
snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*,
snappy::uint32) [with Writer =
snappy::SnappyScatteredWriter; snappy::uint32 =
unsigned int]'
c_src/snappy/snappy.cc:1549:78: required from here
c_src/snappy/snappy.cc:1401:21: warning: comparison between signed and unsigned
integer expressions [-Wsign-compare]
if (offset - 1u < op_ptr_ - op_base_) {
> Trouble Compiling couchdb-snappy
>
>
> Key: COUCHDB-2994
> URL: https://issues.apache.org/jira/browse/COUCHDB-2994
> Project: CouchDB
> Issue Type: Bug
> Components: Build System
>Affects Versions: 2.0.0
>Reporter: Noah Mehl
>
> I am trying to build CouchDB (master) on a smartos base64-lts zone. I'm
> getting the following output from couchdb-snappy:
> root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]#
> /opt/local/src/couchdb/bin/rebar clean
> ==> snappy (clean)
> [root@441920aa-c373-40a0-a990-a6b8ce0d8dd4
> /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar co
> ==> snappy (compile)
> Compiled src/snappy.erl
> Compiling c_src/snappy_nif.cc
> Compiling c_src/snappy/snappy-sinksource.cc
> Compiling c_src/snappy/snappy-stubs-internal.cc
> Compiling c_src/snappy/snappy.cc
> c_src/snappy/snappy.cc: In member function 'bool
> snappy::SnappyDecompressor::RefillTag()':
> c_src/snappy/snappy.cc:834:21: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
> c_src/snappy/snappy.cc: In instantiation of 'bool
> snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t,
> std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t =
> long unsigned int]':
> c_src/snappy/snappy.cc:779:9: required from 'void
> snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer =
> snappy::SnappyScatteredWriter]'
> c_src/snappy/snappy.cc:865:3: required from 'bool
> snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*,
> snappy::uint32) [with Writer =
> snappy::SnappyScatteredWriter; snappy::uint32 =
> unsigned int]'
> c_src/snappy/snappy.cc:1549:78: required from here
> c_src/snappy/snappy.cc:1401:5: warning: comparison between signed and
> unsigned integer expressions [-Wsign-compare]
> Any help would be appreciated. Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] couchdb-couch pull request: Change normalize_dbname semantic add d...
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/160#issuecomment-212127664 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric pull request: Use couch_db:dbname_suffix in path_en...
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fabric/pull/45#issuecomment-212120601 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch-replicator pull request: Use couch_db:dbname_suffix ...
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/35#issuecomment-212120523 You're just in time! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch-replicator pull request: Use couch_db:dbname_suffix ...
Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/35#issuecomment-212118248 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: Change normalize_dbname semantic add d...
Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch/pull/160#issuecomment-212117735 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric pull request: Use couch_db:dbname_suffix in path_en...
Github user davisp commented on the pull request: https://github.com/apache/couchdb-fabric/pull/45#issuecomment-212117786 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (COUCHDB-2631) Ensure that system databases callbacks are adds correctly for shared case
[
https://issues.apache.org/jira/browse/COUCHDB-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248545#comment-15248545
]
Nick Vatamaniuc commented on COUCHDB-2631:
--
{code}
IsReplicatorDb = DbName == config:get("replicator", "db", "_replicator")
{code}
Doesn't apply to 2.x anymore. Local replicator is always "_replicator". Also
it expects binaries.
{code}
(node1@127.0.0.1)4>
couch_db:normalize_dbname("shards/-1fff/_users.1460972107").
"shards/-1fff/_users.1460972107"
(node1@127.0.0.1)5>
couch_db:normalize_dbname("shards/-1fff/_users").
"shards/-1fff/_users"
(node1@127.0.0.1)6>
couch_db:normalize_dbname(<<"shards/-1fff/_users">>).
<<"_users">>
(node1@127.0.0.1)7>
couch_db:normalize_dbname(<<"shards/-1fff/_users.134565677">>).
<<"_users">>
{code}
[~eiri] pointed to this PR that should handle this issue
https://github.com/apache/couchdb-couch/pull/160
> Ensure that system databases callbacks are adds correctly for shared case
> -
>
> Key: COUCHDB-2631
> URL: https://issues.apache.org/jira/browse/COUCHDB-2631
> Project: CouchDB
> Issue Type: Bug
> Components: BigCouch
>Reporter: Alexander Shorin
>Priority: Blocker
> Labels: needs-pr
> Fix For: 2.0.0
>
>
> We have the following code in
> [couch_server|https://github.com/apache/couchdb-couch/blob/master/src/couch_server.erl#L119-L143]
> {code}
> maybe_add_sys_db_callbacks(DbName, Options) when is_binary(DbName) ->
> maybe_add_sys_db_callbacks(?b2l(DbName), Options);
> maybe_add_sys_db_callbacks(DbName, Options) ->
> DbsDbName = config:get("mem3", "shard_db", "dbs"),
> NodesDbName = config:get("mem3", "node_db", "nodes"),
> IsReplicatorDb = DbName == config:get("replicator", "db", "_replicator")
> orelse
> path_ends_with(DbName, <<"_replicator">>),
> IsUsersDb = DbName ==config:get("couch_httpd_auth", "authentication_db",
> "_users") orelse
> path_ends_with(DbName, <<"_users">>),
> if
> DbName == DbsDbName ->
> [sys_db | Options];
> DbName == NodesDbName ->
> [sys_db | Options];
> IsReplicatorDb ->
> [{before_doc_update, fun
> couch_replicator_manager:before_doc_update/2},
>{after_doc_read, fun couch_replicator_manager:after_doc_read/2},
>sys_db | Options];
> IsUsersDb ->
> [{before_doc_update, fun couch_users_db:before_doc_update/2},
>{after_doc_read, fun couch_users_db:after_doc_read/2},
>sys_db | Options];
> true ->
> Options
> end.
> {code}
> Which works perfectly except if system database is clustered. So, for shared
> _users and _replicator the check condition will not work since shared
> databases ends with timestamp and full name looks as
> "shards/-1fff/_users.1424979962"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (COUCHDB-2994) Trouble Compiling couchdb-snappy
Noah Mehl created COUCHDB-2994: -- Summary: Trouble Compiling couchdb-snappy Key: COUCHDB-2994 URL: https://issues.apache.org/jira/browse/COUCHDB-2994 Project: CouchDB Issue Type: Bug Components: Build System Reporter: Noah Mehl I am trying to build CouchDB (master) on a smartos base64-lts zone. I'm getting the following output from couchdb-snappy: root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar clean ==> snappy (clean) [root@441920aa-c373-40a0-a990-a6b8ce0d8dd4 /opt/local/src/couchdb/src/snappy]# /opt/local/src/couchdb/bin/rebar co ==> snappy (compile) Compiled src/snappy.erl Compiling c_src/snappy_nif.cc Compiling c_src/snappy/snappy-sinksource.cc Compiling c_src/snappy/snappy-stubs-internal.cc Compiling c_src/snappy/snappy.cc c_src/snappy/snappy.cc: In member function 'bool snappy::SnappyDecompressor::RefillTag()': c_src/snappy/snappy.cc:834:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] c_src/snappy/snappy.cc: In instantiation of 'bool snappy::SnappyScatteredWriter::AppendFromSelf(std::size_t, std::size_t) [with Allocator = snappy::SnappySinkAllocator; std::size_t = long unsigned int]': c_src/snappy/snappy.cc:779:9: required from 'void snappy::SnappyDecompressor::DecompressAllTags(Writer*) [with Writer = snappy::SnappyScatteredWriter]' c_src/snappy/snappy.cc:865:3: required from 'bool snappy::InternalUncompressAllTags(snappy::SnappyDecompressor*, Writer*, snappy::uint32) [with Writer = snappy::SnappyScatteredWriter; snappy::uint32 = unsigned int]' c_src/snappy/snappy.cc:1549:78: required from here c_src/snappy/snappy.cc:1401:5: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Any help would be appreciated. Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2990) admins not honored in _security
[
https://issues.apache.org/jira/browse/COUCHDB-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248496#comment-15248496
]
Jan Lehnardt commented on COUCHDB-2990:
---
just the curl commands for easier copy and paste:
{noformat}
curl -X PUT 'http://localhost:15984/play'
curl -X PUT 'http://localhost:15984/_users/org.couchdb.user:jerry' -d
'{"_id":"org.couchdb.user:jerry","name":"jerry","password":"mouse","type":"user","roles":[]}'
curl -X PUT 'http://localhost:15984/play/_security' -d '{"admins": {"names":
["jerry"]}}'
curl -X PUT 'http://localhost:15984/play/test' -d '{}' -u jerry:mouseee
curl -X PUT 'http://localhost:15984/play/test' -d '{}' -u jerry:mouse
curl -X PUT 'http://localhost:15984/play/_design/test' -d '{}' -u jerry:mouse
{noformat}
> admins not honored in _security
> ---
>
> Key: COUCHDB-2990
> URL: https://issues.apache.org/jira/browse/COUCHDB-2990
> Project: CouchDB
> Issue Type: Bug
> Components: BigCouch
>Reporter: Sebastian Rothbucher
>Priority: Blocker
> Labels: needs-pr
>
> Setting a user as admin (by name) and invoking a command (giving credentials
> via Basic Auth) comes back saying the user is no DB admin.
> Certainly minor thing for 2.1+ but 2 keep in mind; steps 2 reproduce (sorry 4
> the C error earlier):
> {noformat}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play'
> {"ok":true}
> [root@localhost couchdb]# curl -X PUT
> 'http://localhost:15984/_users/org.couchdb.user:jerry' -d
> '{"_id":"org.couchdb.user:jerry","name":"jerry","password":"mouse","type":"user","roles":[]}'
> {"ok":true,"id":"org.couchdb.user:jerry","rev":"1-f97ddcb58c67b47084168f5945217d10"}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/_security'
> -d '{"admins": {"names": ["jerry"]}}'
> {"ok":true,"id":"db/play/_security.1461053645","rev":"2-dfe4d0fbab9b154d2100a95cefa66a92"}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/test' -d
> '{}' -u jerry:mouseee
> {"error":"unauthorized","reason":"Name or password is incorrect."}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/test' -d
> '{}' -u jerry:mouse
> {"ok":true,"id":"test","rev":"1-967a00dff5e02add41819138abb3284d"}
> [root@localhost couchdb]# curl -X PUT
> 'http://localhost:15984/play/_design/test' -d '{}' -u jerry:mouse
> {"error":"forbidden","reason":"You are not a db or server admin."}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2990) admins not honored in _security
[
https://issues.apache.org/jira/browse/COUCHDB-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248484#comment-15248484
]
Jan Lehnardt commented on COUCHDB-2990:
---
can confirm, definitely a blocker.
In addition, on the PUT /db I get this response:
{"error":"error","reason":"internal_server_error"}
the database gets created though.
Log entries:
2016-04-19 21:46:01.991 [warning] node1@127.0.0.1 <0.2373.0> no record of user
root
2016-04-19 21:46:02.154 [notice] node1@127.0.0.1 <0.2373.0> 37bfe34462
127.0.0.1 localhost:15984 PUT /play5 500 ok 163
not sure how to get better logging up here
> admins not honored in _security
> ---
>
> Key: COUCHDB-2990
> URL: https://issues.apache.org/jira/browse/COUCHDB-2990
> Project: CouchDB
> Issue Type: Bug
> Components: BigCouch
>Reporter: Sebastian Rothbucher
>Priority: Minor
>
> Setting a user as admin (by name) and invoking a command (giving credentials
> via Basic Auth) comes back saying the user is no DB admin.
> Certainly minor thing for 2.1+ but 2 keep in mind; steps 2 reproduce (sorry 4
> the C error earlier):
> {noformat}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play'
> {"ok":true}
> [root@localhost couchdb]# curl -X PUT
> 'http://localhost:15984/_users/org.couchdb.user:jerry' -d
> '{"_id":"org.couchdb.user:jerry","name":"jerry","password":"mouse","type":"user","roles":[]}'
> {"ok":true,"id":"org.couchdb.user:jerry","rev":"1-f97ddcb58c67b47084168f5945217d10"}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/_security'
> -d '{"admins": {"names": ["jerry"]}}'
> {"ok":true,"id":"db/play/_security.1461053645","rev":"2-dfe4d0fbab9b154d2100a95cefa66a92"}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/test' -d
> '{}' -u jerry:mouseee
> {"error":"unauthorized","reason":"Name or password is incorrect."}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/test' -d
> '{}' -u jerry:mouse
> {"ok":true,"id":"test","rev":"1-967a00dff5e02add41819138abb3284d"}
> [root@localhost couchdb]# curl -X PUT
> 'http://localhost:15984/play/_design/test' -d '{}' -u jerry:mouse
> {"error":"forbidden","reason":"You are not a db or server admin."}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2384) Provide configuration options for lager
[ https://issues.apache.org/jira/browse/COUCHDB-2384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248469#comment-15248469 ] Jan Lehnardt commented on COUCHDB-2384: --- After doing `make build` (in the no-make-install branch), we get a standalone CouchDB directory in `rel/couchdb`, within there, there is lager configuration in releases/2.0.0a/sys.config, release/2.0.0a/couchdb.script and release/2.0.0a/start_clean.script. Making any changes to the lager config in either file and restarting CouchDB has no effect. Where else can we config lager? > Provide configuration options for lager > --- > > Key: COUCHDB-2384 > URL: https://issues.apache.org/jira/browse/COUCHDB-2384 > Project: CouchDB > Issue Type: Improvement > Components: Logging >Reporter: Alexander Shorin >Priority: Blocker > Labels: needs-pr, regression > Fix For: 2.0.0 > > > Yay! We have logging driven by lager now, but there is no way for users to > configure it via ini files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (COUCHDB-2631) Ensure that system databases callbacks are adds correctly for shared case
[
https://issues.apache.org/jira/browse/COUCHDB-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248454#comment-15248454
]
Jan Lehnardt commented on COUCHDB-2631:
---
…which is used in:
path_ends_with(Path, Suffix) ->
Suffix == couch_db:normalize_dbname(Path).
> Ensure that system databases callbacks are adds correctly for shared case
> -
>
> Key: COUCHDB-2631
> URL: https://issues.apache.org/jira/browse/COUCHDB-2631
> Project: CouchDB
> Issue Type: Bug
> Components: BigCouch
>Reporter: Alexander Shorin
>Priority: Blocker
> Labels: needs-pr
> Fix For: 2.0.0
>
>
> We have the following code in
> [couch_server|https://github.com/apache/couchdb-couch/blob/master/src/couch_server.erl#L119-L143]
> {code}
> maybe_add_sys_db_callbacks(DbName, Options) when is_binary(DbName) ->
> maybe_add_sys_db_callbacks(?b2l(DbName), Options);
> maybe_add_sys_db_callbacks(DbName, Options) ->
> DbsDbName = config:get("mem3", "shard_db", "dbs"),
> NodesDbName = config:get("mem3", "node_db", "nodes"),
> IsReplicatorDb = DbName == config:get("replicator", "db", "_replicator")
> orelse
> path_ends_with(DbName, <<"_replicator">>),
> IsUsersDb = DbName ==config:get("couch_httpd_auth", "authentication_db",
> "_users") orelse
> path_ends_with(DbName, <<"_users">>),
> if
> DbName == DbsDbName ->
> [sys_db | Options];
> DbName == NodesDbName ->
> [sys_db | Options];
> IsReplicatorDb ->
> [{before_doc_update, fun
> couch_replicator_manager:before_doc_update/2},
>{after_doc_read, fun couch_replicator_manager:after_doc_read/2},
>sys_db | Options];
> IsUsersDb ->
> [{before_doc_update, fun couch_users_db:before_doc_update/2},
>{after_doc_read, fun couch_users_db:after_doc_read/2},
>sys_db | Options];
> true ->
> Options
> end.
> {code}
> Which works perfectly except if system database is clustered. So, for shared
> _users and _replicator the check condition will not work since shared
> databases ends with timestamp and full name looks as
> "shards/-1fff/_users.1424979962"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2631) Ensure that system databases callbacks are adds correctly for shared case
[
https://issues.apache.org/jira/browse/COUCHDB-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248452#comment-15248452
]
Jan Lehnardt commented on COUCHDB-2631:
---
I don’t know how to validate whether this works as intended or not, but I see
this, when I log things before the if with this:
io:format("~nDbName: ~p, IsUsersDb: ~p, IsReplicatorDb: ~p", [DbName,
IsUsersDb, IsReplicatorDb]),
DbName: "shards/-1fff/_replicator.1460972107", IsUsersDb: false,
IsReplicatorDb: false
DbName: "shards/-1fff/_users.1460972107", IsUsersDb: false,
IsReplicatorDb: false
DbName: "_users", IsUsersDb: true, IsReplicatorDb: false
DbName: "_replicator", IsUsersDb: false, IsReplicatorDb: false (!)
especially the last one doesn’t look right ;)
Maybe because this doesn’t account for the DbName not a binary?
couch_db:normalize_dbname(<<"shards/", _/binary>> = Path) ->
lists:last(binary:split(mem3:dbname(Path), <<"/">>, [global]));
normalize_dbname(DbName) ->
DbName.
> Ensure that system databases callbacks are adds correctly for shared case
> -
>
> Key: COUCHDB-2631
> URL: https://issues.apache.org/jira/browse/COUCHDB-2631
> Project: CouchDB
> Issue Type: Bug
> Components: BigCouch
>Reporter: Alexander Shorin
>Priority: Blocker
> Labels: needs-pr
> Fix For: 2.0.0
>
>
> We have the following code in
> [couch_server|https://github.com/apache/couchdb-couch/blob/master/src/couch_server.erl#L119-L143]
> {code}
> maybe_add_sys_db_callbacks(DbName, Options) when is_binary(DbName) ->
> maybe_add_sys_db_callbacks(?b2l(DbName), Options);
> maybe_add_sys_db_callbacks(DbName, Options) ->
> DbsDbName = config:get("mem3", "shard_db", "dbs"),
> NodesDbName = config:get("mem3", "node_db", "nodes"),
> IsReplicatorDb = DbName == config:get("replicator", "db", "_replicator")
> orelse
> path_ends_with(DbName, <<"_replicator">>),
> IsUsersDb = DbName ==config:get("couch_httpd_auth", "authentication_db",
> "_users") orelse
> path_ends_with(DbName, <<"_users">>),
> if
> DbName == DbsDbName ->
> [sys_db | Options];
> DbName == NodesDbName ->
> [sys_db | Options];
> IsReplicatorDb ->
> [{before_doc_update, fun
> couch_replicator_manager:before_doc_update/2},
>{after_doc_read, fun couch_replicator_manager:after_doc_read/2},
>sys_db | Options];
> IsUsersDb ->
> [{before_doc_update, fun couch_users_db:before_doc_update/2},
>{after_doc_read, fun couch_users_db:after_doc_read/2},
>sys_db | Options];
> true ->
> Options
> end.
> {code}
> Which works perfectly except if system database is clustered. So, for shared
> _users and _replicator the check condition will not work since shared
> databases ends with timestamp and full name looks as
> "shards/-1fff/_users.1424979962"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (COUCHDB-2834) Server sends connection: close too early
[
https://issues.apache.org/jira/browse/COUCHDB-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Lehnardt closed COUCHDB-2834.
-
Resolution: Fixed
> Server sends connection: close too early
>
>
> Key: COUCHDB-2834
> URL: https://issues.apache.org/jira/browse/COUCHDB-2834
> Project: CouchDB
> Issue Type: Bug
>Reporter: Nick Vatamaniuc
>Priority: Blocker
> Labels: has-pr
> Fix For: 2.0.0
>
>
> This is related COUCHDB-2833.
> This was found investigating the failure of replication tests. Specifically
> couch_replicator_large_atts_tests, the {local, remote} sub-case.
> The test sets up push replications from local to remote.
> Replication workers have more than 1 document larger than
> MAX_BULK_ATT_SIZE=64K. They start pushing them to the target, using a
> keep-alive connection (default for HTTP 1.1), the first few pipelined
> requests will go through using the same connection, then server will accept
> the first PUT to …/docid?edits=false, then return Connection:close and close
> the connection after the 201 Created result.
> Server should not close request too early and instead keep it open longer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] couchdb-fauxton pull request: conflict-solving: first pass on revi...
Github user janl commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/670#issuecomment-212068990 intro blog post including screenshots and video here: https://github.com/robertkowalski/couch-labs/blob/blog/blog/databases-are-not-boring/databases-are-not-boring.md this is really sweet. I canât comment on the code yet, but I just have a tiny feature request (that isnât blocking for this PR or anything): itâd be nice if the doc-compare view would still show the differences, kinda like GitHub split view:  but yeah, excellent work, thanks so much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: conflict-solving: first pass on revi...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/670#discussion_r60264667
--- Diff:
test/nightwatch_tests/custom-commands/populateDatabaseWithConflicts.js ---
@@ -0,0 +1,75 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+var util = require('util'),
+events = require('events'),
+helpers = require('../helpers/helpers.js'),
+request = require('request');
--- End diff --
const
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: conflict-solving: first pass on revi...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/670#discussion_r60264588
--- Diff:
app/addons/documents/index-results/index-results.components.react.jsx ---
@@ -132,21 +132,40 @@ function (app, FauxtonAPI, React, Stores, Actions,
Components, Documents, Fauxto
);
},
-getAttachmentRow: function (el) {
+getAdditionalInfoRow: function (el) {
var attachmentCount = Object.keys(el._attachments ||Â {}).length;
- var paperClip = null;
- var text = null;
+ var attachmentIndicator = null;
+ var textAttachments = null;
+
+ var conflictCount = Object.keys(el._conflicts ||Â {}).length;
+ var conflictIndicator = null;
+ var textConflicts = null;
+
--- End diff --
note to self: use use `const` and `let`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Created] (COUCHDB-2993) Not able to view long lists of attachments
Garren Smith created COUCHDB-2993: - Summary: Not able to view long lists of attachments Key: COUCHDB-2993 URL: https://issues.apache.org/jira/browse/COUCHDB-2993 Project: CouchDB Issue Type: Bug Components: Fauxton Reporter: Garren Smith As described here https://twitter.com/ermouth/status/722427896858599425 Fauxton doesn't give the user an option to scroll to the bottom of a long list of attachments for a document. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] couchdb-couch pull request: Extend rename_on_delete behaviour on c...
Github user eiri commented on the pull request: https://github.com/apache/couchdb-couch/pull/161#issuecomment-211923314 @davisp I thought there are performance penalty on deleting a lot of files in deep filesystem hierarchy, I remember @rnewson mentioned this while we've been discussing how `rename_on_delete` should be done before I started this implementation. That's why I did urlencode trick to keep the file structure flat. Do I understand correctly that you are proposing instead: 1) to change `rename_on_delete` config parameter for `delete_after_rename` 2) keep doing what we are doing with renaming files in uuids, moving them in flat fashion in `.delete` and removing them if `delete_after_rename` set to `true`. 3) mirroring data directory hierarchy in `.delete` directory, moving there after-compaction, deleted database and view files and disabling `init_delete_dir/1` if `delete_after_rename` set to `false` If this is the case, do you think we should add random suffix to moved after-compaction files to keep them distinguished? On one hand this could lead to accumulation of a lot of files in `.delete`, on a flip hand rapid compaction without suffixing would override previous compactions files that might have some value. Should we change config parameter to `rename_instead_of_delete` as @rnewson proposed, since there are two different ways to rename files and strictly speaking Couch admin don't necessary need to know how we are deleting files when we are deleting them for real. Switching `rename_instead_of_delete` (or `delete_after_rename`) during Couch life could lead to an interesting state in `.delete` directory - do you think this is not a concern? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (COUCHDB-2834) Server sends connection: close too early
[
https://issues.apache.org/jira/browse/COUCHDB-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247491#comment-15247491
]
ASF GitHub Bot commented on COUCHDB-2834:
-
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/164
> Server sends connection: close too early
>
>
> Key: COUCHDB-2834
> URL: https://issues.apache.org/jira/browse/COUCHDB-2834
> Project: CouchDB
> Issue Type: Bug
>Reporter: Nick Vatamaniuc
>Priority: Blocker
> Labels: has-pr
> Fix For: 2.0.0
>
>
> This is related COUCHDB-2833.
> This was found investigating the failure of replication tests. Specifically
> couch_replicator_large_atts_tests, the {local, remote} sub-case.
> The test sets up push replications from local to remote.
> Replication workers have more than 1 document larger than
> MAX_BULK_ATT_SIZE=64K. They start pushing them to the target, using a
> keep-alive connection (default for HTTP 1.1), the first few pipelined
> requests will go through using the same connection, then server will accept
> the first PUT to …/docid?edits=false, then return Connection:close and close
> the connection after the 201 Created result.
> Server should not close request too early and instead keep it open longer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2834) Server sends connection: close too early
[
https://issues.apache.org/jira/browse/COUCHDB-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247490#comment-15247490
]
ASF subversion and git services commented on COUCHDB-2834:
--
Commit c4624d95e45ec4b45f7c6ddfbc4cd61413ee1d63 in couchdb-couch's branch
refs/heads/master from [~kzx]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=c4624d9 ]
When reading attachments, avoid closing connections too early
Signal mochiweb to not send connection:close headers
in order for the socket to be reused.
Before this commit, this signaling was done too late.
COUCHDB-2834
> Server sends connection: close too early
>
>
> Key: COUCHDB-2834
> URL: https://issues.apache.org/jira/browse/COUCHDB-2834
> Project: CouchDB
> Issue Type: Bug
>Reporter: Nick Vatamaniuc
>Priority: Blocker
> Labels: has-pr
> Fix For: 2.0.0
>
>
> This is related COUCHDB-2833.
> This was found investigating the failure of replication tests. Specifically
> couch_replicator_large_atts_tests, the {local, remote} sub-case.
> The test sets up push replications from local to remote.
> Replication workers have more than 1 document larger than
> MAX_BULK_ATT_SIZE=64K. They start pushing them to the target, using a
> keep-alive connection (default for HTTP 1.1), the first few pipelined
> requests will go through using the same connection, then server will accept
> the first PUT to …/docid?edits=false, then return Connection:close and close
> the connection after the 201 Created result.
> Server should not close request too early and instead keep it open longer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] couchdb-couch pull request: When reading attachments, avoid closin...
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user kxepal commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-211809973 @janl ok, let see how it goes. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (COUCHDB-2990) admins not honored in _security
[
https://issues.apache.org/jira/browse/COUCHDB-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247362#comment-15247362
]
Sebastian Rothbucher commented on COUCHDB-2990:
---
my C mistake - sorry 4 that. But still it holds 4 some reason - see above the
1:1 script run on a blank n=1 cluster
> admins not honored in _security
> ---
>
> Key: COUCHDB-2990
> URL: https://issues.apache.org/jira/browse/COUCHDB-2990
> Project: CouchDB
> Issue Type: Bug
> Components: BigCouch
>Reporter: Sebastian Rothbucher
>Priority: Minor
>
> Setting a user as admin (by name) and invoking a command (giving credentials
> via Basic Auth) comes back saying the user is no DB admin.
> Certainly minor thing for 2.1+ but 2 keep in mind; steps 2 reproduce (sorry 4
> the C error earlier):
> {noformat}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play'
> {"ok":true}
> [root@localhost couchdb]# curl -X PUT
> 'http://localhost:15984/_users/org.couchdb.user:jerry' -d
> '{"_id":"org.couchdb.user:jerry","name":"jerry","password":"mouse","type":"user","roles":[]}'
> {"ok":true,"id":"org.couchdb.user:jerry","rev":"1-f97ddcb58c67b47084168f5945217d10"}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/_security'
> -d '{"admins": {"names": ["jerry"]}}'
> {"ok":true,"id":"db/play/_security.1461053645","rev":"2-dfe4d0fbab9b154d2100a95cefa66a92"}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/test' -d
> '{}' -u jerry:mouseee
> {"error":"unauthorized","reason":"Name or password is incorrect."}
> [root@localhost couchdb]# curl -X PUT 'http://localhost:15984/play/test' -d
> '{}' -u jerry:mouse
> {"ok":true,"id":"test","rev":"1-967a00dff5e02add41819138abb3284d"}
> [root@localhost couchdb]# curl -X PUT
> 'http://localhost:15984/play/_design/test' -d '{}' -u jerry:mouse
> {"error":"forbidden","reason":"You are not a db or server admin."}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (COUCHDB-2990) admins not honored in _security
[
https://issues.apache.org/jira/browse/COUCHDB-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247273#comment-15247273
]
Jan Lehnardt commented on COUCHDB-2990:
---
[~sebastianrothbucher] this seems like an incomplete script, e.g. you are
missing the line where you create the user. Also, you get DB info in the first
line and then create the db in the next.
Could you clean this up so we can exactly see what you are doing?
If this holds, this is a 2.0 blocker.
> admins not honored in _security
> ---
>
> Key: COUCHDB-2990
> URL: https://issues.apache.org/jira/browse/COUCHDB-2990
> Project: CouchDB
> Issue Type: Bug
> Components: BigCouch
>Reporter: Sebastian Rothbucher
>Priority: Minor
>
> Setting a user as admin (by name) and invoking a command (giving credentials
> via Basic Auth) comes back saying the user is no DB admin.
> Certainly minor thing for 2.1+ but 2 keep in mind; steps 2 reproduce:
> {noformat}
> # curl -X GET 'http://localhost:15984/play/_security'
> {"_rev":"2-dfe4d0fbab9b154d2100a95cefa66a92","admins":{"names":["jerry"]}}
> # curl -X PUT 'http://localhost:15984/play/'
> # curl -X PUT 'http://localhost:15984/play/_security' -d '{"admins":
> {"names": ["jerry"]}}'
> # curl -X PUT 'http://localhost:15984/play/test' -d '{}' -u jerry:mouseee
> {"error":"unauthorized","reason":"Name or password is incorrect."}
> # curl -X PUT 'http://localhost:15984/play/test' -d '{}' -u jerry:mouse
> {"ok":true,"id":"test","rev":"1-967a00dff5e02add41819138abb3284d"}
> # curl -X PUT 'http://localhost:15984/play/_design/test' -d '{}' -u
> jerry:mouse
> {"error":"forbidden","reason":"You are not a db or server admin."}
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] couchdb pull request: Add recommended docs section
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/403#issuecomment-211743736 I also like this idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
