[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@rnewson Updated. 

Tried to do features right. Ended up with less code than expected, but not 
sure if missed an obvious corner case or something of that sort. 

Added some tests as suggested. Tests fail on travis as they need the new 
config API, would have to try it locally with the couch-config PR ...  
[obligatory multi-repo complaint goes here].


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
Here is what I have for the implementation:

https://github.com/apache/couchdb-config/pull/14

I tried to keep it simple, but probably missed obvious things...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550655#comment-15550655
 ] 

ASF GitHub Bot commented on COUCHDB-3180:
-

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-config/pull/14

Features API and implementation.

Implement ability to enable, disable and query feature flags.

Features are identified as binary strings. Usage intent is for
various components in the system to enable features, then the HTTP API will
expose those to the user. For example, features could indicate the presence
of an optional component, a plugin or a new mode of operation.

The API has 3 functions:

 * `config:features/0` : Return a sorted list of feature flags

 * `config:feature_enable/1` : Enables a feature. Feature argument could be 
a
   list, a binary or an atom.

 * `config:feature_disable/1` : Same as `feature_enable/1` but disables the
   feature.

`feature_enable/1` and `feature_disable/1` are idempotent.

Implementation is a thin wrapper around setting and deleting keys from the
'[features]' config section. This means, users can also set their own 
features
there via the .ini config files. Features set via the API are not 
persistent,
so applications will have to set them every time they initialize.

Jira: COUCHDB-3180

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-config couchdb-3180

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-config/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit d811a5472a91016633e217a2992df4c9ea88b876
Author: Nick Vatamaniuc 
Date:   2016-10-06T02:08:51Z

Features API and implementation.

Implement ability to enable, disable and query feature flags.

Features are identified as binary strings. Usage intent is for
various components in the system to enable features, then the HTTP API will
expose those to the user. For example, features could indicate the presence
of an optional component, a plugin or a new mode of operation.

The API has 3 functions:

 * `config:features/0` : Return a sorted list of feature flags

 * `config:feature_enable/1` : Enables a feature. Feature argument could be 
a
   list, a binary or an atom.

 * `config:feature_disable/1` : Same as `feature_enable/1` but disables the
   feature.

`feature_enable/1` and `feature_disable/1` are idempotent.

Implementation is a thin wrapper around setting and deleting keys from the
'[features]' config section. This means, users can also set their own 
features
there via the .ini config files. Features set via the API are not 
persistent,
so applications will have to set them every time they initialize.

Jira: COUCHDB-3180




> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3180
> URL: https://issues.apache.org/jira/browse/COUCHDB-3180
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-config pull request #14: Features API and implementation.

2016-10-05 Thread nickva
GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-config/pull/14

Features API and implementation.

Implement ability to enable, disable and query feature flags.

Features are identified as binary strings. Usage intent is for
various components in the system to enable features, then the HTTP API will
expose those to the user. For example, features could indicate the presence
of an optional component, a plugin or a new mode of operation.

The API has 3 functions:

 * `config:features/0` : Return a sorted list of feature flags

 * `config:feature_enable/1` : Enables a feature. Feature argument could be 
a
   list, a binary or an atom.

 * `config:feature_disable/1` : Same as `feature_enable/1` but disables the
   feature.

`feature_enable/1` and `feature_disable/1` are idempotent.

Implementation is a thin wrapper around setting and deleting keys from the
'[features]' config section. This means, users can also set their own 
features
there via the .ini config files. Features set via the API are not 
persistent,
so applications will have to set them every time they initialize.

Jira: COUCHDB-3180

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-config couchdb-3180

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-config/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit d811a5472a91016633e217a2992df4c9ea88b876
Author: Nick Vatamaniuc 
Date:   2016-10-06T02:08:51Z

Features API and implementation.

Implement ability to enable, disable and query feature flags.

Features are identified as binary strings. Usage intent is for
various components in the system to enable features, then the HTTP API will
expose those to the user. For example, features could indicate the presence
of an optional component, a plugin or a new mode of operation.

The API has 3 functions:

 * `config:features/0` : Return a sorted list of feature flags

 * `config:feature_enable/1` : Enables a feature. Feature argument could be 
a
   list, a binary or an atom.

 * `config:feature_disable/1` : Same as `feature_enable/1` but disables the
   feature.

`feature_enable/1` and `feature_disable/1` are idempotent.

Implementation is a thin wrapper around setting and deleting keys from the
'[features]' config section. This means, users can also set their own 
features
there via the .ini config files. Features set via the API are not 
persistent,
so applications will have to set them every time they initialize.

Jira: COUCHDB-3180




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Issue Comment Deleted] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread Nick Vatamaniuc (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Vatamaniuc updated COUCHDB-3180:
-
Comment: was deleted

(was: From GH [~rnewson] mentioned:
{quote}
We've wanted a general feature discovery thing for a while now so let's come up 
with a way for code to register with this. The patch should include that 
mechanism even if nothing in couchdb calls it yet, and a test that shows that a 
registered feature shows up in the welcome message.
{quote}

Here is what I came up with on first try:

* Don't add a new application, it would be silly.

* Stick it in config application. It seems like a configuration-y thing.

* API looks like
   - {{config:features() -> \[<<"feature1">>, <<"feature2">>, ...\].}}
   - {{config:feature_enable(<<"feature1">>).}}
   - {{config:feature_disable(<<"feature2">>).}}
* Applications enable features and disable them. Then `chttpd` reads list of 
features from config and shows them in the welcome message.

* Behind the scenes it is really just writing to config "\[features\]" section 
a bunch of booleans. With persistence set to `false`. 

* Users can directly set features in the config file if they want. Could be a 
something external to the CouchDB instance, maybe something about how code was 
compiled or where it is running that warrants a different treatment from the 
API standpoint.

The advantage is it doesn't reinvent the world. Takes advantage of config 
server (so applications can monitor for changes and such if needed).)

> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3180
> URL: https://issues.apache.org/jira/browse/COUCHDB-3180
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550515#comment-15550515
 ] 

ASF GitHub Bot commented on COUCHDB-3180:
-

Github user nickva commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
Alright, good points, agree. If it's worth doing, it's worth doing right.  

Here is what I came with as first thing: 

* Don't add a new application, it would be silly.

* Stick it in config application. It seems like a configuration-y thing.

* 3 new functions. API looks like
   - `config:features() -> [<<"feature1">>, <<"feature2">>, ...].`
   - `config:feature_enable(<<"feature1">>).`
   - `config:feature_disable(<<"feature2">>).`

* Applications enable features and disable them. Then `chttpd` reads list 
of features from config and shows them in the welcome message.

* Behind the scenes it is really just writing to config "[features]" 
section a bunch of booleans. With persistence set to `false`. 

* Users can directly set "features" in the config file transparently.

The advantage is it doesn't reinvent the world. Takes advantage of config 
server (so applications can monitor for changes and such if needed).

( Added same comment to https://issues.apache.org/jira/browse/COUCHDB-3180 )

@rnewson I'll give this a try and see what it looks like


> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3180
> URL: https://issues.apache.org/jira/browse/COUCHDB-3180
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread Nick Vatamaniuc (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550508#comment-15550508
 ] 

Nick Vatamaniuc commented on COUCHDB-3180:
--

>From GH [~rnewson] mentioned:
{quote}
We've wanted a general feature discovery thing for a while now so let's come up 
with a way for code to register with this. The patch should include that 
mechanism even if nothing in couchdb calls it yet, and a test that shows that a 
registered feature shows up in the welcome message.
{quote}

Here is what I came up with on first try:

* Don't add a new application, it would be silly.

* Stick it in config application. It seems like a configuration-y thing.

* API looks like
   - {{config:features() -> \[<<"feature1">>, <<"feature2">>, ...\].}}
   - {{config:feature_enable(<<"feature1">>).}}
   - {{config:feature_disable(<<"feature2">>).}}
* Applications enable features and disable them. Then `chttpd` reads list of 
features from config and shows them in the welcome message.

* Behind the scenes it is really just writing to config "\[features\]" section 
a bunch of booleans. With persistence set to `false`. 

* Users can directly set features in the config file if they want. Could be a 
something external to the CouchDB instance, maybe something about how code was 
compiled or where it is running that warrants a different treatment from the 
API standpoint.

The advantage is it doesn't reinvent the world. Takes advantage of config 
server (so applications can monitor for changes and such if needed).

> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3180
> URL: https://issues.apache.org/jira/browse/COUCHDB-3180
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-documentation pull request #76: Fix PouchDB replication source code ...

2016-10-05 Thread pnc
GitHub user pnc opened a pull request:

https://github.com/apache/couchdb-documentation/pull/76

Fix PouchDB replication source code link

👋 Tiny thing, but noticed a broken link in the docs.

It might make sense to link to a specific commit blob in case the file ever 
moves. I'm also not 100% sure this is still the right file to link to.

It might also make sense to just link to the main project repo and let 
people hunt down the replication bit themselves if they're curious.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pnc/couchdb-documentation patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-documentation/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit 2bc0115aa8fccf9b09ee6d89b6b046a7c4bc498b
Author: Phillip Calvin 
Date:   2016-10-06T00:52:06Z

Fix PouchDB replication source code link




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread rnewson
Github user rnewson commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
I agree with kxepal that it's odd to create an hardcoded empty list. We've 
wanted a general feature discovery thing for a while now so let's come up with 
a way for code to register with this. The patch should include that mechanism 
even if nothing in couchdb calls it yet, and a test that shows that a 
registered feature shows up in the welcome message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (COUCHDB-3181) function_clause when adding attachment to doc in _users db

2016-10-05 Thread Robert Newson (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Newson resolved COUCHDB-3181.

   Resolution: Fixed
Fix Version/s: 2.0.1

> function_clause when adding attachment to doc in _users db
> --
>
> Key: COUCHDB-3181
> URL: https://issues.apache.org/jira/browse/COUCHDB-3181
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Robert Newson
> Fix For: 2.0.1
>
>
> {"error":"unknown_error","reason":"function_clause","ref":1841055428}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3150) Update all shards with stale=update_after

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550168#comment-15550168
 ] 

ASF subversion and git services commented on COUCHDB-3150:
--

Commit d68a00fdeba9113bd1a3dd41d8e546b05bb2e533 in couchdb-fabric's branch 
refs/heads/master from [~rnewson]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-fabric.git;h=d68a00f ]

Fix function clause introduced by fix for COUCHDB-3150


> Update all shards with stale=update_after
> -
>
> Key: COUCHDB-3150
> URL: https://issues.apache.org/jira/browse/COUCHDB-3150
> Project: CouchDB
>  Issue Type: Story
>  Components: Database Core
>Reporter: Bala Kolla
>
> Stale=update_after should update shards that won't participate in the 
> response due to not being a ushard.
> Discussed with Paul Davis and he suggested the following approach.
> For this ticket we should just need to add a 
> fabric_view:maybe_update_others/3 that we call just after [1,2] with 
> fabric_view:maybe_update_others(DbName, Shards, Args). And then if 
> stable=true and update=(true or lazy) we do mem3:shards(DbName) -- 
> ShardsInvolved, and throw a message at them to trigger an update.
> [1] 
> https://github.com/apache/couchdb-fabric/blob/master/src/fabric_view_map.erl#L27
> [2] 
> https://github.com/apache/couchdb-fabric/blob/master/src/fabric_view_reduce.erl#L28



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-fabric issue #70: Update all shards with stale=update_after

2016-10-05 Thread rnewson
Github user rnewson commented on the issue:

https://github.com/apache/couchdb-fabric/pull/70
  
I'll fix this but fyi @brkolla @davisp 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fabric issue #70: Update all shards with stale=update_after

2016-10-05 Thread rnewson
Github user rnewson commented on the issue:

https://github.com/apache/couchdb-fabric/pull/70
  
contributors need to run `make check` on their changes before submitting 
for PR, let's make that a new rule k.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fabric issue #70: Update all shards with stale=update_after

2016-10-05 Thread rnewson
Github user rnewson commented on the issue:

https://github.com/apache/couchdb-fabric/pull/70
  
this turned out to be broken, all tests fail that touch this code as 
maybe_update_others only has a clause for stale=update_after


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch pull request #203: update typespec of find_newest_header

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch/pull/203


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch pull request #203: update typespec of find_newest_header

2016-10-05 Thread iilyak
GitHub user iilyak opened a pull request:

https://github.com/apache/couchdb-couch/pull/203

update typespec of find_newest_header



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-couch 
fix-find_newest_header-type-spec

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-couch/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #203


commit be236b9a8957af4ba3fc4520a53f25855b9c5d92
Author: ILYA Khlopotov 
Date:   2016-10-05T21:25:19Z

update typespec of find_newest_header




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch pull request #:

2016-10-05 Thread jaydoane
Github user jaydoane commented on the pull request:


https://github.com/apache/couchdb-couch/commit/d5fbb6dd0d770861222b6a5de3124f10d9eafd4f#commitcomment-19309476
  
In src/couch_file.erl:
In src/couch_file.erl on line 597:
Ugh, you are right @iilyak :(
I will create a patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@kxepal 

> So semantically, object is better here since we guarantee only one 
feature presence and we can raise conflicts exceptions with easy.

Can just as easily write code which overwrites a feature object key just as 
can do lists:usort on the features list before returning.  Or if we want server 
to crash can easily check for `lists:usort(Features)  = lists:sort(Features)` 
before returning the request.

I still don't see having to manage an object as being a lot better than a 
simple list of labels


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3181) function_clause when adding attachment to doc in _users db

2016-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549947#comment-15549947
 ] 

ASF GitHub Bot commented on COUCHDB-3181:
-

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-chttpd/pull/145


> function_clause when adding attachment to doc in _users db
> --
>
> Key: COUCHDB-3181
> URL: https://issues.apache.org/jira/browse/COUCHDB-3181
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Robert Newson
>
> {"error":"unknown_error","reason":"function_clause","ref":1841055428}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3181) function_clause when adding attachment to doc in _users db

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549946#comment-15549946
 ] 

ASF subversion and git services commented on COUCHDB-3181:
--

Commit d2c449b7bebc52bb40913be868c977cdbc7d0d9a in couchdb-chttpd's branch 
refs/heads/master from [~rnewson]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-chttpd.git;h=d2c449b ]

Pass user context when opening doc in db_attachment_req

COUCHDB-3181


> function_clause when adding attachment to doc in _users db
> --
>
> Key: COUCHDB-3181
> URL: https://issues.apache.org/jira/browse/COUCHDB-3181
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Robert Newson
>
> {"error":"unknown_error","reason":"function_clause","ref":1841055428}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-couch pull request #:

2016-10-05 Thread iilyak
Github user iilyak commented on the pull request:


https://github.com/apache/couchdb-couch/commit/d5fbb6dd0d770861222b6a5de3124f10d9eafd4f#commitcomment-19309232
  
In src/couch_file.erl:
In src/couch_file.erl on line 597:
The return value doesn't match the spec


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd pull request #145: Pass user context when opening doc in db_a...

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-chttpd/pull/145


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3181) function_clause when adding attachment to doc in _users db

2016-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549926#comment-15549926
 ] 

ASF GitHub Bot commented on COUCHDB-3181:
-

GitHub user rnewson opened a pull request:

https://github.com/apache/couchdb-chttpd/pull/145

Pass user context when opening doc in db_attachment_req

COUCHDB-3181

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-chttpd 3181-attachments-users

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-chttpd/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #145


commit d2c449b7bebc52bb40913be868c977cdbc7d0d9a
Author: Robert Newson 
Date:   2016-10-05T20:57:16Z

Pass user context when opening doc in db_attachment_req

COUCHDB-3181




> function_clause when adding attachment to doc in _users db
> --
>
> Key: COUCHDB-3181
> URL: https://issues.apache.org/jira/browse/COUCHDB-3181
> Project: CouchDB
>  Issue Type: Bug
>Reporter: Robert Newson
>
> {"error":"unknown_error","reason":"function_clause","ref":1841055428}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-chttpd pull request #145: Pass user context when opening doc in db_a...

2016-10-05 Thread rnewson
GitHub user rnewson opened a pull request:

https://github.com/apache/couchdb-chttpd/pull/145

Pass user context when opening doc in db_attachment_req

COUCHDB-3181

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-chttpd 3181-attachments-users

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-chttpd/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #145


commit d2c449b7bebc52bb40913be868c977cdbc7d0d9a
Author: Robert Newson 
Date:   2016-10-05T20:57:16Z

Pass user context when opening doc in db_attachment_req

COUCHDB-3181




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch issue #185: 3061 adaptive header search

2016-10-05 Thread kocolosk
Github user kocolosk commented on the issue:

https://github.com/apache/couchdb-couch/pull/185
  
Wow, great stuff @jaydoane


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (COUCHDB-3181) function_clause when adding attachment to doc in _users db

2016-10-05 Thread Robert Newson (JIRA)
Robert Newson created COUCHDB-3181:
--

 Summary: function_clause when adding attachment to doc in _users db
 Key: COUCHDB-3181
 URL: https://issues.apache.org/jira/browse/COUCHDB-3181
 Project: CouchDB
  Issue Type: Bug
Reporter: Robert Newson


{"error":"unknown_error","reason":"function_clause","ref":1841055428}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread Nick Vatamaniuc (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Vatamaniuc updated COUCHDB-3180:
-
Comment: was deleted

(was: https://github.com/apache/couchdb-chttpd/pull/144)

> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3180
> URL: https://issues.apache.org/jira/browse/COUCHDB-3180
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread Nick Vatamaniuc (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549772#comment-15549772
 ] 

Nick Vatamaniuc commented on COUCHDB-3180:
--

https://github.com/apache/couchdb-chttpd/pull/144

> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3180
> URL: https://issues.apache.org/jira/browse/COUCHDB-3180
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@nickva 
It's logical issue and it may leads to conflicts. Say, we have a feature 
FTS (full text search) which could be both provided by couchdb-lucene and 
dreyfus. Both acts differently, but feature is the same. Both may works 
together, but from point of client, who process that list it will be undefined 
behaviour which FTS feature to use. 

So semantically, object is better here since we guarantee only one feature 
presence and we can raise conflicts exceptions with easy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@nickva 
>  This commit shouldn't prevent it, the comment about the features being a 
list of binaries is just a suggestion. A feature could be an object as well.

Yea, I see. I just about early things standardization to not fall into 
legacy hell eventually before it will be too late to change anything. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@nickva no, I mean `features` feature (:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@kxepal 

You mean the new replicator code? It shouldn't be abandoned.  You can check 
out what we have so far: 
https://github.com/cloudant/couchdb-couch-replicator/tree/63012-scheduler it is 
not 100% finished, still polishing the API, then will probably be ready for 
more eyes too look at it.

> As for replicator I see here case when this list will be not list of 
strings, but objects, since replicator may provide own set of features like 
version...

Good idea. This commit shouldn't prevent it, the comment about the features 
being a list of binaries is just a suggestion. A feature could be an object as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
Probably, in this case it's better to have `features` an object of objects 
rather than list of things. Because we couldn't have any feature mentioned 
there twice, but would like to have quick and simple way to check feature 
presence and access it without iteration over whole list (not Erlang case 
unless we're going to maps soon).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@nickva Ok, thanks. How it will not be abandoned (:

As for replicator I see here case when this list will be not list of 
strings, but objects, since replicator may provide own set of features like 
version, preferred mode and else bits. I mean that it would be nice to design 
this feature well for future needs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@kxepal It probably can be used to build the list of features, maybe with 
some feature discover- ability API extension. Or maybe it can override 
get_features().

So far I left it simple as a start.  

To provide more context for this, for example Cloudant uses something like 
this for the  geo code. Users can tell if it is enabled or not. 

We just had another usage example: the new replicator code (you might have 
seen it in the "next" CouchDB mailing list). It improves a few things, but in 
doing so it changes the API a bit so docs don't get all the state updates 
written back to them. This would allow for example for user code to quickly 
check if the new replicator is loaded (to know not to expect "triggered" states 
in replication docs). I imagine some might prefer to user one replicator vs the 
other for a while to maintain backwards compatibility.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@kxepal if we have a new feature say geo, we'd add a function it would 
check of config option or the presence of a plugin. 

For example:

```
get_features() ->
Features = [
check_geo_enabled(),
check_other()
],
[Feature || {Feature, true} <- Features].


check_geo_enabled() ->
{<<"geo">>, config:get_boolean("geo_module", "enabled", false)}.

check_other() ->
{<<"other">>, code:which(other_module) =/= non_existing}.
```
Could eventually become a fancier implementation where some components can 
post their features to a special application or API, and this would read from 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return a "features" list in the se...

2016-10-05 Thread kxepal
Github user kxepal commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
@nickva How would this features list get filled?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3010) Handle 429 for replication

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549436#comment-15549436
 ] 

ASF subversion and git services commented on COUCHDB-3010:
--

Commit a51561c1e07e63371cef4f797f063028b4c61999 in couchdb-couch-replicator's 
branch refs/heads/master from [~tonysun83]
[ 
https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=a51561c
 ]

Fix timeout clause in backoff retry

The second clause for a timeout will never be reached because the first
will always match before the second clause. Switching the clauses to
fix this.

BugzId:70400
COUCHDB-3010


> Handle 429 for replication
> --
>
> Key: COUCHDB-3010
> URL: https://issues.apache.org/jira/browse/COUCHDB-3010
> Project: CouchDB
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Tony Sun
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3010) Handle 429 for replication

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549438#comment-15549438
 ] 

ASF subversion and git services commented on COUCHDB-3010:
--

Commit cb41bacb2a06613649df46d62249afebda42b8c0 in couchdb-couch-replicator's 
branch refs/heads/master from [~tonysun83]
[ 
https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=cb41bac
 ]

Merge branch '3010-port-429' into apache

COUCHDB-3010


> Handle 429 for replication
> --
>
> Key: COUCHDB-3010
> URL: https://issues.apache.org/jira/browse/COUCHDB-3010
> Project: CouchDB
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Tony Sun
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3010) Handle 429 for replication

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549434#comment-15549434
 ] 

ASF subversion and git services commented on COUCHDB-3010:
--

Commit 80e9578228365277ee20d0b02a1f4bd6514c5f12 in couchdb-couch-replicator's 
branch refs/heads/master from [~tonysun83]
[ 
https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=80e9578
 ]

Handle 429

When we encounter a 429, we retry with a different set of retries and
timeout. This will theoretically reduce client replication overload.
When 429s have stopped, it's possible that a 500 error could occur.
Then the retry mechanism should go back to the original way for
backwards compatibility.

BugzId:60007
COUCHDB-3010


> Handle 429 for replication
> --
>
> Key: COUCHDB-3010
> URL: https://issues.apache.org/jira/browse/COUCHDB-3010
> Project: CouchDB
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Tony Sun
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3010) Handle 429 for replication

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549435#comment-15549435
 ] 

ASF subversion and git services commented on COUCHDB-3010:
--

Commit 2db0d7f2a697c7e4aae9ca0ccb1658591a7579c5 in couchdb-couch-replicator's 
branch refs/heads/master from [~tonysun83]
[ 
https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=2db0d7f
 ]

Retry when connection_closed is received during a streamed response

The changes_reader uses a streamed response. During the stream, it's
possible to receive a connection_closed error due to timeouts or
network issues. We simply retry the request because for streamed
responses a connection must be established first in order for the
stream to begin. So if the network is truly down, the initial request
will fail and the code path will go through the normal retry clause
which decrements the number of retries. This way we won't be stuck
forever if it's an actual network issue.

BugzId: 70400
COUCHDB-3010


> Handle 429 for replication
> --
>
> Key: COUCHDB-3010
> URL: https://issues.apache.org/jira/browse/COUCHDB-3010
> Project: CouchDB
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Tony Sun
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3010) Handle 429 for replication

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549437#comment-15549437
 ] 

ASF subversion and git services commented on COUCHDB-3010:
--

Commit ada53cbff71c06c924ad4044241d3e01c888e133 in couchdb-couch-replicator's 
branch refs/heads/master from [~tonysun83]
[ 
https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-replicator.git;h=ada53cb
 ]

Make backoff macros configurable

COUCHDB-3010


> Handle 429 for replication
> --
>
> Key: COUCHDB-3010
> URL: https://issues.apache.org/jira/browse/COUCHDB-3010
> Project: CouchDB
>  Issue Type: New Feature
>  Components: Replication
>Reporter: Tony Sun
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-couch-replicator pull request #48: Port HTTP 429 Commits

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch-replicator/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3158) Fix a crash when connection closes for _update

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549342#comment-15549342
 ] 

ASF subversion and git services commented on COUCHDB-3158:
--

Commit 570376b47cf661804891597329b4b662fafb6a74 in couchdb-couch's branch 
refs/heads/master from ILYA Khlopotov
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch.git;h=570376b ]

Adding test suite for trancated _update

COUCHDB-3158


> Fix a crash when connection closes for _update 
> ---
>
> Key: COUCHDB-3158
> URL: https://issues.apache.org/jira/browse/COUCHDB-3158
> Project: CouchDB
>  Issue Type: Bug
>Reporter: ILYA
> Attachments: acra
>
>
> There is a crash when the client issue an update request and closes the 
> connection. 
> {{//_design//_update//}}
> The resulting crash dump is:
> {code}
> req_err(3443101085) unknown_error : normal
> [<<"mochiweb_request:recv/3 L180">>,  
> <<"mochiweb_request:stream_unchunked_body/4 L540">>,
> <<"mochiweb_request:recv_body/2 L214">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:json_req_obj/4 L67">>,
> <<"chttpd_show:send_doc_update_response/6 L119">>, 
> <<"chttpd:process_request/1 L293">>]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3158) Fix a crash when connection closes for _update

2016-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549343#comment-15549343
 ] 

ASF GitHub Bot commented on COUCHDB-3158:
-

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch/pull/200


> Fix a crash when connection closes for _update 
> ---
>
> Key: COUCHDB-3158
> URL: https://issues.apache.org/jira/browse/COUCHDB-3158
> Project: CouchDB
>  Issue Type: Bug
>Reporter: ILYA
> Attachments: acra
>
>
> There is a crash when the client issue an update request and closes the 
> connection. 
> {{//_design//_update//}}
> The resulting crash dump is:
> {code}
> req_err(3443101085) unknown_error : normal
> [<<"mochiweb_request:recv/3 L180">>,  
> <<"mochiweb_request:stream_unchunked_body/4 L540">>,
> <<"mochiweb_request:recv_body/2 L214">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:json_req_obj/4 L67">>,
> <<"chttpd_show:send_doc_update_response/6 L119">>, 
> <<"chttpd:process_request/1 L293">>]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-couch pull request #200: Adding test suite for trancated _update

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-couch/pull/200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3158) Fix a crash when connection closes for _update

2016-10-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549336#comment-15549336
 ] 

ASF subversion and git services commented on COUCHDB-3158:
--

Commit 3868099565dbf8eb7851c50a2e2940f078aea14e in couchdb-chttpd's branch 
refs/heads/master from ILYA Khlopotov
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-chttpd.git;h=3868099 ]

Handle disconnect when receiving body

When any error happen on an underlying socket mochiweb uses
exit(normal). Add catch for exit:normal and convert it to
exit({bad_request, <<"Incomplete">>}).

COUCHDB-3158


> Fix a crash when connection closes for _update 
> ---
>
> Key: COUCHDB-3158
> URL: https://issues.apache.org/jira/browse/COUCHDB-3158
> Project: CouchDB
>  Issue Type: Bug
>Reporter: ILYA
> Attachments: acra
>
>
> There is a crash when the client issue an update request and closes the 
> connection. 
> {{//_design//_update//}}
> The resulting crash dump is:
> {code}
> req_err(3443101085) unknown_error : normal
> [<<"mochiweb_request:recv/3 L180">>,  
> <<"mochiweb_request:stream_unchunked_body/4 L540">>,
> <<"mochiweb_request:recv_body/2 L214">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:json_req_obj/4 L67">>,
> <<"chttpd_show:send_doc_update_response/6 L119">>, 
> <<"chttpd:process_request/1 L293">>]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (COUCHDB-3158) Fix a crash when connection closes for _update

2016-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549338#comment-15549338
 ] 

ASF GitHub Bot commented on COUCHDB-3158:
-

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-chttpd/pull/140


> Fix a crash when connection closes for _update 
> ---
>
> Key: COUCHDB-3158
> URL: https://issues.apache.org/jira/browse/COUCHDB-3158
> Project: CouchDB
>  Issue Type: Bug
>Reporter: ILYA
> Attachments: acra
>
>
> There is a crash when the client issue an update request and closes the 
> connection. 
> {{//_design//_update//}}
> The resulting crash dump is:
> {code}
> req_err(3443101085) unknown_error : normal
> [<<"mochiweb_request:recv/3 L180">>,  
> <<"mochiweb_request:stream_unchunked_body/4 L540">>,
> <<"mochiweb_request:recv_body/2 L214">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:-json_req_obj/4-lc$^0/1-0-/4 L67">>,
> <<"chttpd_external:json_req_obj/4 L67">>,
> <<"chttpd_show:send_doc_update_response/6 L119">>, 
> <<"chttpd:process_request/1 L293">>]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-chttpd pull request #140: Handle disconnect when receiving body

2016-10-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-chttpd/pull/140


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-chttpd issue #144: Add ability to return "features" list in the serv...

2016-10-05 Thread iilyak
Github user iilyak commented on the issue:

https://github.com/apache/couchdb-chttpd/pull/144
  
+1 after fixing a typo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549306#comment-15549306
 ] 

ASF GitHub Bot commented on COUCHDB-3180:
-

GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-chttpd/pull/144

Add ability to return "features" list in the server's welcome message.

This could help users quickly discover the presence of an API or mode of
operation.

Jira: COUCHDB-3180

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-chttpd 
couchdb-3180-features-chttpd

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-chttpd/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 0e2b7510cd06c4667ccfe44ab8720438f49c4d2e
Author: Nick Vatamaniuc 
Date:   2016-10-05T16:51:37Z

Add ability to return "features" list in the server's welcome message.

This could help users quickly discover the presence of an API or mode of
operation.

Jira: COUCHDB-3180




> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3180
> URL: https://issues.apache.org/jira/browse/COUCHDB-3180
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-chttpd pull request #144: Add ability to return "features" list in t...

2016-10-05 Thread nickva
GitHub user nickva opened a pull request:

https://github.com/apache/couchdb-chttpd/pull/144

Add ability to return "features" list in the server's welcome message.

This could help users quickly discover the presence of an API or mode of
operation.

Jira: COUCHDB-3180

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-chttpd 
couchdb-3180-features-chttpd

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-chttpd/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 0e2b7510cd06c4667ccfe44ab8720438f49c4d2e
Author: Nick Vatamaniuc 
Date:   2016-10-05T16:51:37Z

Add ability to return "features" list in the server's welcome message.

This could help users quickly discover the presence of an API or mode of
operation.

Jira: COUCHDB-3180




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Closed] (COUCHDB-3179) Add ability to return a list of features in server's welcome message

2016-10-05 Thread Nick Vatamaniuc (JIRA)

 [ 
https://issues.apache.org/jira/browse/COUCHDB-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Vatamaniuc closed COUCHDB-3179.

Resolution: Duplicate

> Add ability to return a list of features in server's welcome message
> 
>
> Key: COUCHDB-3179
> URL: https://issues.apache.org/jira/browse/COUCHDB-3179
> Project: CouchDB
>  Issue Type: New Feature
>Reporter: Nick Vatamaniuc
>
> This could be used to let users discover quickly the availability of some API 
> or modes of operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (COUCHDB-3180) Add ability to return a list of features in server's welcome message

2016-10-05 Thread Nick Vatamaniuc (JIRA)
Nick Vatamaniuc created COUCHDB-3180:


 Summary: Add ability to return a list of features in server's 
welcome message
 Key: COUCHDB-3180
 URL: https://issues.apache.org/jira/browse/COUCHDB-3180
 Project: CouchDB
  Issue Type: New Feature
Reporter: Nick Vatamaniuc


This could be used to let users discover quickly the availability of some API 
or modes of operation.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (COUCHDB-3179) Add ability to return a list of features in server's welcome message

2016-10-05 Thread Nick Vatamaniuc (JIRA)
Nick Vatamaniuc created COUCHDB-3179:


 Summary: Add ability to return a list of features in server's 
welcome message
 Key: COUCHDB-3179
 URL: https://issues.apache.org/jira/browse/COUCHDB-3179
 Project: CouchDB
  Issue Type: New Feature
Reporter: Nick Vatamaniuc


This could be used to let users discover quickly the availability of some API 
or modes of operation.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] couchdb-couch-replicator issue #48: Port HTTP 429 Commits

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-couch-replicator/pull/48
  
@tonysun83 looks like it is flaky and it is in the couch repo anyway, not 
even in replicator, so go ahead and merge if you want


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch-replicator issue #48: Port HTTP 429 Commits

2016-10-05 Thread nickva
Github user nickva commented on the issue:

https://github.com/apache/couchdb-couch-replicator/pull/48
  
@tonysun83 I think that is a flaky test, will try it locally see what it 
does


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---