[jira] [Commented] (COUCHDB-3302) Attachment replication over low bandwidth network connections

2017-02-20 Thread Nick Vatamaniuc (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875076#comment-15875076
 ] 

Nick Vatamaniuc commented on COUCHDB-3302:
--

Confirmed that setting fabric request_timeout to a higher value like 9 
helps with this.

At least {{./attach_large.py --size=10 --mintime=80}}

Successfully finishes while it doesn't with the default value of 6

> Attachment replication over low bandwidth network connections
> -
>
> Key: COUCHDB-3302
> URL: https://issues.apache.org/jira/browse/COUCHDB-3302
> Project: CouchDB
>  Issue Type: Bug
>  Components: Replication
>Reporter: Jan Lehnardt
> Attachments: attach_large.py, replication-failure.log, 
> replication-failure-target.log
>
>
> Setup:
> Two CouchDB instances `source` (5981) and `target` (5983) with a 2MBit 
> network connection (simulated locally with traffic shaping, see way below for 
> an example).
> {noformat}
> git clone https://github.com/apache/couchdb.git
> cd couchdb
> ./configure --disable-docs --disable-fauxton
> make release
> cd ..
> cp -r couchdb/rel/couchdb source
> cp -r couchdb/rel/couchdb target
> # set up local ini: chttpd / port: 5981 / 5983
> # set up vm.args: source@hostname.local / target@hostname.local
> # no admins
> Start both CouchDB in their own terminal windows: ./bin/couchdb
> # create all required databases, and our `t` test database
> curl -X PUT http://127.0.0.1:598{1,3}/{_users,_replicator,_global_changes,t}
> # create 64MB attachments
> dd if=/dev/urandom of=att-64 bs=1024 count=65536
> # create doc on source
> curl -X PUT http://127.0.0.1:5981/t/doc1/att_64 -H 'Content-Type: 
> application/octet-stream' -d @att-64
> # replicate to target
> curl -X POST http://127.0.0.1:5981/_replicate -Hcontent-type:application/json 
> -d '{"source":"http://127.0.0.1:5981/t","target":"http://127.0.0.1:5983/t"}'
> {noformat}
> With the traffic shaping in place, the replication call doesn’t return, and 
> eventually CouchDB fails with:
> {noformat}
> [error] 2017-02-16T17:37:30.488990Z source@hostname.local emulator  
> Error in process <0.15811.0> on node 'source@hostname.local' with exit value:
> {{nocatch,{mp_parser_died,noproc}},[{couch_att,'-foldl/4-fun-0-',3,[{file,"src/couch_att.erl"},{line,591}]},{couch_att,fold_streamed_data,4,[{file,"src/couch_att.erl"},{line,642}]},{couch_att,foldl,4,[{file,"src/couch_att.erl"},{line,595}]},{couch_httpd_multipart,atts_to_mp,4,[{file,"src/couch_httpd_multipart.erl"},{line,208}]}]}
> [error] 2017-02-16T17:37:30.490610Z source@hostname.local <0.8721.0>  
> Replicator, request PUT to "http://127.0.0.1:5983/t/doc1?new_edits=false; 
> failed due to error {error,
> {'EXIT',
> {{{nocatch,{mp_parser_died,noproc}},
>   [{couch_att,'-foldl/4-fun-0-',3,
>[{file,"src/couch_att.erl"},{line,591}]},
>{couch_att,fold_streamed_data,4,
>[{file,"src/couch_att.erl"},{line,642}]},
>{couch_att,foldl,4,[{file,"src/couch_att.erl"},{line,595}]},
>{couch_httpd_multipart,atts_to_mp,4,
>[{file,"src/couch_httpd_multipart.erl"},{line,208}]}]},
>  {gen_server,call,
>  [<0.15778.0>,
>   {send_req,
>   {{url,"http://127.0.0.1:5983/t/doc1?new_edits=false;,
>"127.0.0.1",5983,undefined,undefined,
>"/t/doc1?new_edits=false",http,ipv4_address},
>[{"Accept","application/json"},
> {"Content-Length",33194202},
> {"Content-Type",
>  "multipart/related; 
> boundary=\"0dea87076009b928b191e0b456375c93\""},
> {"User-Agent","CouchDB-Replicator/2.0.0"}],
>put,
>{#Fun,
> 
> {<<"{\"_id\":\"doc1\",\"_rev\":\"1-15ae43c5b53de894b936c08db31d537c\",\"_revisions\":{\"start\":1,\"ids\":[\"15ae43c5b53de894b936c08db31d537c\"]},\"_attachments\":{\"att_64\":{\"content_type\":\"application/octet-stream\",\"revpos\":1,\"digest\":\"md5-s3AA0cYvwOzrSFTaALGh8g==\",\"length\":33193656,\"follows\":true}}}">>,
>  [{att,<<"att_64">>,<<"application/octet-stream">>,
>   33193656,33193656,
>   <<179,112,0,209,198,47,192,236,235,72,84,218,0,177,
> 161,242>>,
>   1,
>   {follows,<0.8720.0>,#Ref<0.0.1.23804>},
>   identity}],
>  <<"0dea87076009b928b191e0b456375c93">>,33194202}},
>[{response_format,binary},
> {inactivity_timeout,3},
> {socket_options,[{keepalive,true},{nodelay,false}]}],
> 

[GitHub] couchdb-fauxton pull request #860: replace url construction with FauxtonAPI ...

2017-02-20 Thread millayr
GitHub user millayr opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/860

replace url construction with FauxtonAPI lookup

By using `Fauxton.urls` we limit the number of times we determine/construct 
the URL and allow for it be overridden elsewhere.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/millayr/couchdb-fauxton 
read-bulk-docs-url-from-fauxtonapi

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/860.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #860


commit db0c9e013849586bbbf14345d5b13f9f1e28764f
Author: Ryan Millay 
Date:   2017-02-20T20:45:40Z

replace url construction with FauxtonAPI lookup




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (COUCHDB-3302) Attachment replication over low bandwidth network connections

2017-02-20 Thread Nick Vatamaniuc (JIRA)

[ 
https://issues.apache.org/jira/browse/COUCHDB-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875031#comment-15875031
 ] 

Nick Vatamaniuc commented on COUCHDB-3302:
--

>From investigating it seems  to be related to how long it takes for the 
>request to complete. 

I created a "paced" python multi-part sender which PUTs an attachment over  
period of time. It splits it into chunks then sends those with sleep in between.

Attached script as attach_large.py. Can run it with {[./attach_large.py 
--size=10 --mintime=80}} that will put an attachment of size 10 bytes 
over at least 80 seconds.

With that code I was able to get a 500 error and I get:

{code}
HTTP/1.1 500 Internal Server Error
Cache-Control: must-revalidate
Content-Length: 47
Content-Type: application/json
Date: Mon, 20 Feb 2017 19:27:30 GMT
Server: CouchDB/2.0.0 (Erlang OTP/18)
X-Couch-Request-ID: 80a6cfd301
X-CouchDB-Body-Time: 0

{"error":"unknown_error","reason":"undefined"}
{code}

> Attachment replication over low bandwidth network connections
> -
>
> Key: COUCHDB-3302
> URL: https://issues.apache.org/jira/browse/COUCHDB-3302
> Project: CouchDB
>  Issue Type: Bug
>  Components: Replication
>Reporter: Jan Lehnardt
> Attachments: attach_large.py, replication-failure.log, 
> replication-failure-target.log
>
>
> Setup:
> Two CouchDB instances `source` (5981) and `target` (5983) with a 2MBit 
> network connection (simulated locally with traffic shaping, see way below for 
> an example).
> {noformat}
> git clone https://github.com/apache/couchdb.git
> cd couchdb
> ./configure --disable-docs --disable-fauxton
> make release
> cd ..
> cp -r couchdb/rel/couchdb source
> cp -r couchdb/rel/couchdb target
> # set up local ini: chttpd / port: 5981 / 5983
> # set up vm.args: source@hostname.local / target@hostname.local
> # no admins
> Start both CouchDB in their own terminal windows: ./bin/couchdb
> # create all required databases, and our `t` test database
> curl -X PUT http://127.0.0.1:598{1,3}/{_users,_replicator,_global_changes,t}
> # create 64MB attachments
> dd if=/dev/urandom of=att-64 bs=1024 count=65536
> # create doc on source
> curl -X PUT http://127.0.0.1:5981/t/doc1/att_64 -H 'Content-Type: 
> application/octet-stream' -d @att-64
> # replicate to target
> curl -X POST http://127.0.0.1:5981/_replicate -Hcontent-type:application/json 
> -d '{"source":"http://127.0.0.1:5981/t","target":"http://127.0.0.1:5983/t"}'
> {noformat}
> With the traffic shaping in place, the replication call doesn’t return, and 
> eventually CouchDB fails with:
> {noformat}
> [error] 2017-02-16T17:37:30.488990Z source@hostname.local emulator  
> Error in process <0.15811.0> on node 'source@hostname.local' with exit value:
> {{nocatch,{mp_parser_died,noproc}},[{couch_att,'-foldl/4-fun-0-',3,[{file,"src/couch_att.erl"},{line,591}]},{couch_att,fold_streamed_data,4,[{file,"src/couch_att.erl"},{line,642}]},{couch_att,foldl,4,[{file,"src/couch_att.erl"},{line,595}]},{couch_httpd_multipart,atts_to_mp,4,[{file,"src/couch_httpd_multipart.erl"},{line,208}]}]}
> [error] 2017-02-16T17:37:30.490610Z source@hostname.local <0.8721.0>  
> Replicator, request PUT to "http://127.0.0.1:5983/t/doc1?new_edits=false; 
> failed due to error {error,
> {'EXIT',
> {{{nocatch,{mp_parser_died,noproc}},
>   [{couch_att,'-foldl/4-fun-0-',3,
>[{file,"src/couch_att.erl"},{line,591}]},
>{couch_att,fold_streamed_data,4,
>[{file,"src/couch_att.erl"},{line,642}]},
>{couch_att,foldl,4,[{file,"src/couch_att.erl"},{line,595}]},
>{couch_httpd_multipart,atts_to_mp,4,
>[{file,"src/couch_httpd_multipart.erl"},{line,208}]}]},
>  {gen_server,call,
>  [<0.15778.0>,
>   {send_req,
>   {{url,"http://127.0.0.1:5983/t/doc1?new_edits=false;,
>"127.0.0.1",5983,undefined,undefined,
>"/t/doc1?new_edits=false",http,ipv4_address},
>[{"Accept","application/json"},
> {"Content-Length",33194202},
> {"Content-Type",
>  "multipart/related; 
> boundary=\"0dea87076009b928b191e0b456375c93\""},
> {"User-Agent","CouchDB-Replicator/2.0.0"}],
>put,
>{#Fun,
> 
> {<<"{\"_id\":\"doc1\",\"_rev\":\"1-15ae43c5b53de894b936c08db31d537c\",\"_revisions\":{\"start\":1,\"ids\":[\"15ae43c5b53de894b936c08db31d537c\"]},\"_attachments\":{\"att_64\":{\"content_type\":\"application/octet-stream\",\"revpos\":1,\"digest\":\"md5-s3AA0cYvwOzrSFTaALGh8g==\",\"length\":33193656,\"follows\":true}}}">>,
>  

[GitHub] couchdb-fauxton issue #859: fix replication source/target url

2017-02-20 Thread nolanlawson
Github user nolanlawson commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/859
  
Also I'll note that there's another issue somewhere in Fauxton where, when 
you run it in dev mode, it still posts replications to `localhost:5984` even if 
you try to point it to somewhere else... seems hardcoded somewhere. :confused:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #859: fix replication source/target url

2017-02-20 Thread nolanlawson
GitHub user nolanlawson opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/859

fix replication source/target url

Based on manual testing, this fixes the issue described in 
https://github.com/apache/couchdb-fauxton/pull/858#issuecomment-281150205 . I 
didn't run the Nightwatch tests out of laziness, though, so let's just see what 
Travis says.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nolanlawson/couchdb-fauxton fix-replication

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/859.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #859


commit 18d45f1dfa274e51a8ca788dddc15610efa53deb
Author: Nolan Lawson 
Date:   2017-02-20T19:10:37Z

fix replication source/target url




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #858: Replication from local

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/858
  
Oh no. That's frustrating. 

All misspelling thanks to my iPhone.




On Mon, Feb 20, 2017 at 8:24 PM +0200, "Nolan Lawson" 
 wrote:












Well, I probably should have tested this before saying 👍. 😅 It 
actually breaks worse than before. Attempting to replicate from 
http://examples.cloudant.com/animaldb to a new local DB animaldb results in a 
replicator document looking like this:
{
  "source": {
"headers": {},
"url": "http://examples.cloudant.com/animaldb;
  },
  "target": {
"headers": {},
"url": "http://localhost:6984/animaldb;
  },
  "create_target": true
}


I'll open a PR to fix it.



—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


  
  












---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #858: Replication from local

2017-02-20 Thread nolanlawson
Github user nolanlawson commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/858
  
Well, I probably should have tested this before saying :+1:. 😅 It 
actually breaks worse than before. Attempting to replicate from 
`http://examples.cloudant.com/animaldb` to a new local DB `animaldb` results in 
a replicator document looking like this:

```json
{
  "source": {
"headers": {},
"url": "http://examples.cloudant.com/animaldb;
  },
  "target": {
"headers": {},
"url": "http://localhost:6984/animaldb;
  },
  "create_target": true
}
```

I'll open a PR to fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #858: Replication from local

2017-02-20 Thread millayr
Github user millayr commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/858
  
+1 from me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #858: Replication from local

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/858
  
Thanks merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #858: Replication from local

2017-02-20 Thread garrensmith
Github user garrensmith closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/858


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #840: Generic tab layout wrapper for Fauxton

2017-02-20 Thread millayr
Github user millayr closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/840


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #840: Generic tab layout wrapper for Fauxton

2017-02-20 Thread millayr
Github user millayr commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/840
  
been merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #833: remove backbone from auth

2017-02-20 Thread millayr
Github user millayr commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/833
  
hey @timmak awesome job on this.  I'd recommend taking a look at this 
https://github.com/apache/couchdb-fauxton/pull/840 if you haven't already for a 
handy tab layout component.  thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #853: code-split "brace" into second bundle

2017-02-20 Thread nolanlawson
Github user nolanlawson commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/853
  
Definitely, this is a risky change and should be thoroughly tested. But 
potentially nice performance gains for first load!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #855: Update CONTRIBUTING with quickstart instr...

2017-02-20 Thread nolanlawson
Github user nolanlawson closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/855


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #856: use travis_retry in travis script

2017-02-20 Thread nolanlawson
Github user nolanlawson closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/856


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #858: Replication from local

2017-02-20 Thread nolanlawson
Github user nolanlawson commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/858
  
LGTM, looking forward to replication working for pouchdb server!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #854: don't encode username/pass unless necessa...

2017-02-20 Thread nolanlawson
Github user nolanlawson closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/854


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #854: don't encode username/pass unless necessary

2017-02-20 Thread nolanlawson
Github user nolanlawson commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/854
  
okay, closing in favor of https://github.com/apache/couchdb-fauxton/pull/858


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #850: extract css to separate file in productio...

2017-02-20 Thread nolanlawson
Github user nolanlawson closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/850


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #851: use modular pouchdb

2017-02-20 Thread nolanlawson
Github user nolanlawson closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/851


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #852: trim moment locale using IgnorePlugin

2017-02-20 Thread nolanlawson
Github user nolanlawson closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/852


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (COUCHDB-3304) Rollback default value of config global_change:max_write_delay to 500

2017-02-20 Thread Bala Kolla (JIRA)
Bala Kolla created COUCHDB-3304:
---

 Summary: Rollback default value of config 
global_change:max_write_delay to 500
 Key: COUCHDB-3304
 URL: https://issues.apache.org/jira/browse/COUCHDB-3304
 Project: CouchDB
  Issue Type: Bug
  Components: Database Core
Reporter: Bala Kolla


This config default value has changed from 500 to 25 and it's causing a 
noticeable impact on the performance. We executed a performance test benchmark 
to simulate the load test of put_insert (create) scenario. The summary of the 
results is shown here.

As evident in the performance test results shown below, there is improvement 
across the board. Throughput improved by around 10%, p99 is improved by around 
20% and similar gains in other latency metrics.

A0 ==> Default config of 25
A1 ==> 500.0
 
bench_resultp90 
  p99   p999
global_changes-max_write_delay   
A0  363874  83485.6 115756  
176128
A1  403827  63356.4 84457.6 
102221




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] couchdb-fauxton issue #854: don't encode username/pass unless necessary

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/854
  
One thing, we need full urls because CouchDB 2.0 requires it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #854: don't encode username/pass unless necessary

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/854
  
@nolanlawson I've added a test and continued this work here 
https://github.com/apache/couchdb-fauxton/pull/858

If the tests all pass I'll merge it all in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #858: Replication from local

2017-02-20 Thread garrensmith
GitHub user garrensmith opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/858

Replication from local



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrensmith/couchdb-fauxton 
replication-from-local

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #858


commit d98cefc2cba10b9d408e70b9ebdb89318c2bad99
Author: Nolan Lawson 
Date:   2017-02-18T16:01:31Z

don't encode username/pass unless necessary

commit 6a41304cfa96960a0a358918fd8826ac7e984cab
Author: Garren Smith 
Date:   2017-02-20T11:52:35Z

Add test for replication without password

This extends Nolan's work and adds a test to prove its working




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #853: code-split "brace" into second bundle

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/853
  
This is really interesting. I want to hold off merging it and do a bit of 
research on this. It also might be worth upgrading to webpack 2.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #849: Currently reducers seem to be handled qui...

2017-02-20 Thread timmak
Github user timmak closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/849


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #849: Currently reducers seem to be handled quite stra...

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/849
  
Thanks @timmak I've merged this in. Can you close this PR. 

For future reference don't merge from master into your working branch. 
Rather rebase master into your PR branch. And then when getting your code into 
master do a merge then. Otherwise it makes a mess of the git history. I've 
fixed up the git history and squished your commits into one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #852: trim moment locale using IgnorePlugin

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/852
  
Thanks. I've merged it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #852: trim moment locale using IgnorePlugin

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/852
  
I've documented your ideas here 
https://issues.apache.org/jira/browse/COUCHDB-3303


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #851: use modular pouchdb

2017-02-20 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/851
  
+1. Thanks @nolanlawson I've merged it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---