[GitHub] couchdb-fauxton pull request #863: fix font routes

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/863


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #863: fix font routes

2017-02-23 Thread garrensmith
Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/863
  
Travis is taking really long. This is green over here 
https://travis-ci.org/garrensmith/couchdb-fauxton/builds/204752027


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #863: fix font routes

2017-02-23 Thread millayr
Github user millayr commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/863
  
+1 pending travis


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #863: fix font routes

2017-02-23 Thread garrensmith
GitHub user garrensmith opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/863

fix font routes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrensmith/couchdb-fauxton fix-style-paths

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/863.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #863


commit b940979f7456168f33d7aabb7116c66de6b03c9e
Author: Garren Smith 
Date:   2017-02-23T21:29:34Z

fix font routes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch issue #229: Return error row instead of crashing

2017-02-23 Thread davisp
Github user davisp commented on the issue:

https://github.com/apache/couchdb-couch/pull/229
  
My bad, I missed the fact that we were talking about removing the top level 
value. I don't think we should do that in this case because of what I described 
earlier. These are just alternative implementations of reduce functions. As 
such they can return whatever we want them to although it should probably stay 
within the confines of the existing protocol.

As to the point that users could write a reduce function that maps to the 
same error object, that's precisely the point. Users could write this 
themselves in JavaScript. The only reason that builtins exist is for 
performance for the common cases of counting, summing, and statistics. 
Inventing a new protocol for builtin reduces seems a bit of a crossing of 
abstractions. Granted we could go and create a whole new protocol that custom 
reduce functions could use, but that seems significantly different than the 
original intention of this ticket.

For extra specificity the full response would look something like such:

{
  "rows": [
{"key": $whatever, "value":{"error": "builtin_reduce_error", "reason": 
"stuff", "caused_by": bad_value}},
...
]}

If we want to change the row definition there then we do have to go and 
start changing our protocols which does require things like multiple rolling 
reboots. However if we do go that direction we should think harder and make it 
an available option for custom reduce functions as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch pull request #229: Return error row instead of crashing

2017-02-23 Thread tonysun83
Github user tonysun83 commented on a diff in the pull request:

https://github.com/apache/couchdb-couch/pull/229#discussion_r102818120
  
--- Diff: src/couch_query_servers.erl ---
@@ -169,8 +177,20 @@ sum_values(Value, Acc) when is_number(Value), 
is_list(Acc) ->
 sum_arrays(Acc, [Value]);
 sum_values(Value, Acc) when is_list(Value), is_number(Acc) ->
 sum_arrays([Acc], Value);
-sum_values(Else, _Acc) ->
-throw_sum_error(Else).
--- End diff --

eh not sure how that one got left out


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch issue #229: Return error row instead of crashing

2017-02-23 Thread davisp
Github user davisp commented on the issue:

https://github.com/apache/couchdb-couch/pull/229
  
That was a really confusing description in hindsight...

Consider it this way: what you're changing could easily be written as a 
custom reduce function in JavaScript. The only difference between the two is 
that one is in Erlang and there's some goop about aliasing the implementation 
with a "_name". That's it.

And given that we know that reduce functions can return whatever they want 
we know that there's no reason that we have to change anything related to 
chttpd or fabric or invent changes to the worker protocol that's sending 
messages around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-couch pull request #229: Return error row instead of crashing

2017-02-23 Thread davisp
Github user davisp commented on a diff in the pull request:

https://github.com/apache/couchdb-couch/pull/229#discussion_r102814914
  
--- Diff: src/couch_query_servers.erl ---
@@ -169,8 +177,20 @@ sum_values(Value, Acc) when is_number(Value), 
is_list(Acc) ->
 sum_arrays(Acc, [Value]);
 sum_values(Value, Acc) when is_list(Value), is_number(Acc) ->
 sum_arrays([Acc], Value);
-sum_values(Else, _Acc) ->
-throw_sum_error(Else).
--- End diff --

This clause needs to be reinstated and fixed to return the proper error 
object.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (COUCHDB-3308) Upgrade snappy to 1.1.4

2017-02-23 Thread Nick Vatamaniuc (JIRA)
Nick Vatamaniuc created COUCHDB-3308:


 Summary: Upgrade snappy to 1.1.4
 Key: COUCHDB-3308
 URL: https://issues.apache.org/jira/browse/COUCHDB-3308
 Project: CouchDB
  Issue Type: Improvement
Reporter: Nick Vatamaniuc


They claim a 20% decompression and 5% compression speed improvement.

https://github.com/google/snappy/commit/2d99bd14d471664758e4dfdf81b44f413a7353fd



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] couchdb-fauxton pull request #659: [WIP] Clipboard.js

2017-02-23 Thread benkeen
Github user benkeen closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/659


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton issue #669: Replication page update

2017-02-23 Thread benkeen
Github user benkeen commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/669
  
No problem. Hope all's going well, @garrensmith! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #669: Replication page update

2017-02-23 Thread benkeen
Github user benkeen closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/669


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-nano issue #6: Adding replication using the "_replicator" database

2017-02-23 Thread glynnbird
Github user glynnbird commented on the issue:

https://github.com/apache/couchdb-nano/pull/6
  
That would be greate @carlosduclos. I'm happy to write the docs from 
scratch, or to edit another commit to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---