date:20170816

[GitHub] realulim commented on issue #749: 2.1.0 crashes if peruser = true

2017-08-16 Thread git

realulim commented on issue #749: 2.1.0 crashes if peruser = true
URL: https://github.com/apache/couchdb/issues/749#issuecomment-322976258
 
 
   It's line 236 in my default.ini, which is unchanged from the download. After 
commenting it out, CouchDB starts up and my test suite works. I haven't checked 
yet, whether the per user DB is actually created, will do that later and report 
back.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wonderfuljamesjin commented on issue #755: Age time calculate results are not updated in the couchdb view

2017-08-16 Thread git

wonderfuljamesjin commented on issue #755: Age time calculate results are not 
updated in the couchdb view
URL: https://github.com/apache/couchdb/issues/755#issuecomment-322963527
 
 
   hi @wohali
   thanks, and what do you mean it is not a bug with CouchDB?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali closed issue #755: Age time calculate results are not updated in the couchdb view

2017-08-16 Thread git

wohali closed issue #755: Age time calculate results are not updated in the 
couchdb view
URL: https://github.com/apache/couchdb/issues/755
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #755: Age time calculate results are not updated in the couchdb view

2017-08-16 Thread git

wohali commented on issue #755: Age time calculate results are not updated in 
the couchdb view
URL: https://github.com/apache/couchdb/issues/755#issuecomment-322961786
 
 
   This is not a bug with CouchDB. Please take your question to our 
us...@couchdb.apache.org mailing list.
   
   You can subscribe to the list by sending an email to 
user-subscr...@couchdb.apache.org.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wonderfuljamesjin opened a new issue #755: Age time calculate results are not updated in the couchdb view

2017-08-16 Thread git

wonderfuljamesjin opened a new issue #755: Age time calculate results are not 
updated in the couchdb view
URL: https://github.com/apache/couchdb/issues/755
 
 
   Hi
   
   I need calculate the time age days based on the couchdb document : 
doc.lastupdate with current day, I defined the couchdb map view as following, I 
did not know why the results not update/refresh everyday? like the 
doc.lastupdate =2017-08-16 23:15:1, but today it still see the results as 0 age 
day? only after I change the view and save it, the result can be taken effect 
as expected, I know there is a setting in couched stale=update_after, but it is 
not working,  please help figure out the issue, thanks a lot
   
   ```
   function(doc) {
   if (doc.type) {
  new_date = doc.lastupdate;
 var date_arr = new_date.split(" ");
 var date_aar2 = date_arr[0];
 date_aar2 = new Date(date_aar2.replace(/-/g, "/"));
 date_aar1 = new Date();
 var days = date_aar1.getTime() - date_aar2.getTime();
 var age = parseInt(days / (1000 * 60 * 60 * 24));
 emit(date_aar2,age);
  }
  }
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] FAILURE: CouchDB » master #47

2017-08-16 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/47/

[Jenkins] FAILURE: CouchDB » master #46

2017-08-16 Thread Apache Jenkins Server

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/46/

[GitHub] wohali commented on issue #749: 2.1.0 crashes if peruser = true

2017-08-16 Thread git

wohali commented on issue #749: 2.1.0 crashes if peruser = true
URL: https://github.com/apache/couchdb/issues/749#issuecomment-322913763
 
 
   We nave a possible workaround for @realulim @rasdaniil . Can you try 
removing this line from your `default.ini` file?
   
   ```
   couch_peruser={couch_peruser, start_link, []}
   ```
   
   It should be line 247.
   
   If you remove that line and try again, does it work?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] iilyak closed pull request #746: Log additional information on crashes from rexi

2017-08-16 Thread git

iilyak closed pull request #746: Log additional information on crashes from rexi
URL: https://github.com/apache/couchdb/pull/746
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chewbranca commented on issue #746: Log additional information on crashes from rexi

2017-08-16 Thread git

chewbranca commented on issue #746: Log additional information on crashes from 
rexi
URL: https://github.com/apache/couchdb/pull/746#issuecomment-322909158
 
 
   +1
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] realulim commented on issue #749: 2.1.0 crashes if peruser = true

2017-08-16 Thread git

realulim commented on issue #749: 2.1.0 crashes if peruser = true
URL: https://github.com/apache/couchdb/issues/749#issuecomment-322888251
 
 
   I'm having the same issue, but without docker. Compiled from sources, 
ensured that I have a working CouchDB (via an integration test suite) and can 
add and remove users. All that with the couch_peruser feature disabled. Once I 
enable it and restart CouchDB I get an error in the logfile (see attached file
   [log.txt](https://github.com/apache/couchdb/files/1229431/log.txt)
   ).
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] realulim commented on issue #749: 2.1.0 crashes if peruser = true

2017-08-16 Thread git

realulim commented on issue #749: 2.1.0 crashes if peruser = true
URL: https://github.com/apache/couchdb/issues/749#issuecomment-322888251
 
 
   I'm having the same issue, but without docker. Compiled from sources, 
ensured that I have a working CouchDB (via an integration test suite) and can 
add and remove users. All that with the couch_peruser feature disabled. Once I 
enable it and restart CouchDB I get this in the logfile:
   
   [info] 2017-08-16T20:23:35.396381Z couchdb@10.4.0.86 <0.7.0>  
Application couch_log started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.399406Z couchdb@10.4.0.86 <0.7.0>  
Application folsom started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.425621Z couchdb@10.4.0.86 <0.7.0>  
Application couch_stats started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.425714Z couchdb@10.4.0.86 <0.7.0>  
Application khash started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.430959Z couchdb@10.4.0.86 <0.7.0>  
Application couch_event started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.434529Z couchdb@10.4.0.86 <0.7.0>  
Application ibrowse started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.437645Z couchdb@10.4.0.86 <0.7.0>  
Application ioq started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.437743Z couchdb@10.4.0.86 <0.7.0>  
Application mochiweb started on node 'couchdb@10.4.0.86'
   [info] 2017-08-16T20:23:35.442567Z couchdb@10.4.0.86 <0.203.0>  
Apache CouchDB 2.1.0 is starting.
   
   [info] 2017-08-16T20:23:35.442644Z couchdb@10.4.0.86 <0.204.0>  
Starting couch_sup
   [error] 2017-08-16T20:23:35.488398Z couchdb@10.4.0.86 <0.216.0>  
CRASH REPORT Process  (<0.216.0>) with 0 neighbors exited with reason: bad 
argument in call to ets:member(mem3_openers, <<"_users">>) at 
mem3_shards:maybe_spawn_shard_writer/3(line:486) <= 
mem3_shards:load_shards_from_db/2(line:389) <= 
mem3_shards:load_shards_from_disk/1(line:378) <= mem3_shards:for_db/2(line:59) 
<= mem3_shards:local/1(line:156) <= couch_peruser:init/0(line:58) <= 
couch_peruser:init/1(line:187); initial_call: 
{couch_peruser,init,['Argument__1']}, ancestors: 
[couch_secondary_services,couch_sup,<0.203.0>], messages: [], links: 
[<0.212.0>,<0.92.0>], dictionary: [], trap_exit: false, status: running, 
heap_size: 2586, stack_size: 27, reductions: 3758
   [error] 2017-08-16T20:23:35.488639Z couchdb@10.4.0.86 <0.212.0>  
Supervisor couch_secondary_services had child couch_peruser started with 
couch_peruser:start_link() at undefined exit with reason bad argument in call 
to ets:member(mem3_openers, <<"_users">>) at 
mem3_shards:maybe_spawn_shard_writer/3(line:486) <= 
mem3_shards:load_shards_from_db/2(line:389) <= 
mem3_shards:load_shards_from_disk/1(line:378) <= mem3_shards:for_db/2(line:59) 
<= mem3_shards:local/1(line:156) <= couch_peruser:init/0(line:58) <= 
couch_peruser:init/1(line:187) in context start_error
   [error] 2017-08-16T20:23:35.488984Z couchdb@10.4.0.86 <0.204.0>  
Supervisor couch_sup had child couch_secondary_services started with 
couch_secondary_sup:start_link() at undefined exit with reason 
{shutdown,{failed_to_start_child,couch_peruser,{badarg,[{ets,member,[mem3_openers,<<"_users">>],[]},{mem3_shards,maybe_spawn_shard_writer,3,[{file,"src/mem3_shards.erl"},{line,486}]},{mem3_shards,load_shards_from_db,2,[{file,"src/mem3_shards.erl"},{line,389}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,378}]},{mem3_shards,for_db,2,[{file,"src/mem3_shards.erl"},{line,59}]},{mem3_shards,local,1,[{file,"src/mem3_shards.erl"},{line,156}]},{couch_peruser,init,0,[{file,...},...]},...]}}}
 in context start_error
   [error] 2017-08-16T20:23:35.489245Z couchdb@10.4.0.86 <0.203.0>  
Error starting Apache CouchDB:
   
   
{error,{shutdown,{failed_to_start_child,couch_secondary_services,{shutdown,{failed_to_start_child,couch_peruser,{badarg,[{ets,member,[mem3_openers,<<"_users">>],[]},{mem3_shards,maybe_spawn_shard_writer,3,[{file,"src/mem3_shards.erl"},{line,486}]},{mem3_shards,load_shards_from_db,2,[{file,"src/mem3_shards.erl"},{line,389}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,378}]},{mem3_shards,for_db,2,[{file,"src/mem3_shards.erl"},{line,59}]},{mem3_shards,local,1,[{file,"src/mem3_shards.erl"},{line,156}]},{couch_peruser,init,0,[{file,"src/couch_peruser.erl"},{line,58}]},{couch_peruser,init,1,[{file,"src/couch_peruser.erl"},{line,187}]}]}}
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #949: No list of databases shown in IE 11

2017-08-16 Thread git

wohali commented on issue #949: No list of databases shown in IE 11 
URL: https://github.com/apache/couchdb-fauxton/issues/949#issuecomment-322888009
 
 
   Can confirm everything is fine in Chrome. We don't do testing on IE so I'm 
unsurprised it's broken in IE11...as always we're happy to welcome PRs if you 
can help us get to the bottom of things.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bagguley commented on issue #949: No list of databases shown in IE 11

2017-08-16 Thread git

bagguley commented on issue #949: No list of databases shown in IE 11 
URL: https://github.com/apache/couchdb-fauxton/issues/949#issuecomment-322855569
 
 
   ~@wohali Are you serious? You're not sure how much effort to put into this? 
CouchDB is now unusable unless you install Firefox because Chrome doesn't even 
render anything on the page. It's appalling that such simple testing wasn't 
conducted before release. The exception that @gdelfino referred to is probably 
a red herring because jQuery (which I presume is where it's occurring) handles 
these exceptions, they are expected.~
   
   ~Chrome has around 60% of the browser share of desktop browser usage with 
Firefox bumbling around 6  to 10%. I suggest that this should be top priority.~
   
   [EDIT; See comment below]
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #749: 2.1.0 crashes if peruser = true

2017-08-16 Thread git

wohali commented on issue #749: 2.1.0 crashes if peruser = true
URL: https://github.com/apache/couchdb/issues/749#issuecomment-322884228
 
 
   We need more time to investigate this one. Reopening until we have time to 
do so.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rasdaniil opened a new issue #749: 2.1.0 crashes if peruser = true

2017-08-16 Thread git

rasdaniil opened a new issue #749: 2.1.0 crashes if peruser = true
URL: https://github.com/apache/couchdb/issues/749
 
 
   So I've compiled 2.1.0 under docker image. Launched it. Created DBs, switch 
cors on, set peruser = true in local.ini. Commit, run the newly commited image, 
couchdb crashes :-(
   
   ```
   [error] 2017-08-12T17:18:07.625357Z nonode@nohost <0.194.0>  CRASH 
REPORT Process  (<0.194.0>) with 0 neighbors exited with reason: 
{{shutdown,{failed_to_start_child,couch_secondary_services,{shutdown,{failed_to_start_child,couch_peruser,{badarg,[{ets,member,[mem3_openers,<<"_users">>],[]},{mem3_shards,maybe_spawn_shard_writer,3,[{file,"src/mem3_shards.erl"},{line,486}]},{mem3_shards,load_shards_from_db,2,[{file,"src/mem3_shards.erl"},{line,389}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,378}]},{mem3_shards,for_db,2,[{file,"src/mem3_shards.erl"},{line,59}]},{mem3_shards,local,1,[{file,"s..."},...]},...]},...}
 at application_master:init/4(line:133) <= 
proc_lib:init_p_do_apply/3(line:237); initial_call: 
{application_master,init,['Argument__1','Argument__2',...]}, ancestors: 
[<0.193.0>], messages: [{'EXIT',<0.195.0>,normal}], links: [<0.193.0>,<0.7.0>], 
dictionary: [], trap_exit: true, status: running, heap_size: 987, stack_size: 
27, reduct
 ions: 157
   [info] 2017-08-12T17:18:07.626827Z nonode@nohost <0.7.0>  
Application couch exited with reason: 
{{shutdown,{failed_to_start_child,couch_secondary_services,{shutdown,{failed_to_start_child,couch_peruser,{badarg,[{ets,member,[mem3_openers,<<"_users">>],[]},{mem3_shards,maybe_spawn_shard_writer,3,[{file,"src/mem3_shards.erl"},{line,486}]},{mem3_shards,load_shards_from_db,2,[{file,"src/mem3_shards.erl"},{line,389}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,378}]},{mem3_shards,for_db,2,[{file,"src/mem3_shards.erl"},{line,59}]},{mem3_shards,local,1,[{file,"s..."},...]},...]},...}
   [os_mon] memory supervisor port (memsup): Erlang has closed
   [os_mon] cpu supervisor port (cpu_sup): Erlang has closed
   {"Kernel pid 
terminated",application_controller,"{application_start_failure,couch,{{shutdown,{failed_to_start_child,couch_secondary_services,{shutdown,{failed_to_start_child,couch_peruser,{badarg,[{ets,member,[mem3_openers,<<\"_users\">>],[]},{mem3_shards,maybe_spawn_shard_writer,3,[{file,\"src/mem3_shards.erl\"},{line,486}]},{mem3_shards,load_shards_from_db,2,[{file,\"src/mem3_shards.erl\"},{line,389}]},{mem3_shards,load_shards_from_disk,1,[{file,\"src/mem3_shards.erl\"},{line,378}]},{mem3_shards,for_db,2,[{file,\"src/mem3_shards.erl\"},{line,59}]},{mem3_shards,local,1,[{file,\"src/mem3_shards.erl\"},{line,156}]},{couch_peruser,init,0,[{file,\"src/couch_peruser.erl\"},{line,58}]},{couch_peruser,init,1,[{file,\"src/couch_peruser.erl\"},{line,187}]}]},{couch_app,start,[normal,[]]}}}"}
   ```
   
   Crash dump:
   https://gist.github.com/rasdaniil/8fe6e94a68e5730f56404d65dcd2ff9e
   
   
   Dockerfile
   https://gist.github.com/rasdaniil/fada64e4015ba1a1a3a651a3ad41e4fa
   
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #713: Fauxton doesn't handle well all design docs names (with special characters)

2017-08-16 Thread git

wohali commented on issue #713: Fauxton doesn't handle well all design docs 
names (with special characters)
URL: https://github.com/apache/couchdb/issues/713#issuecomment-322883041
 
 
   2.1.0 has been released, can you confirm it fixes your issues?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali closed issue #741: error "Unauthorized" (401) when loading "_security"-doc

2017-08-16 Thread git

wohali closed issue #741: error "Unauthorized" (401) when loading 
"_security"-doc
URL: https://github.com/apache/couchdb/issues/741
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #741: error "Unauthorized" (401) when loading "_security"-doc

2017-08-16 Thread git

wohali commented on issue #741: error "Unauthorized" (401) when loading 
"_security"-doc
URL: https://github.com/apache/couchdb/issues/741#issuecomment-322882877
 
 
   This is a Fauxton bug, so I'm closing it out in apache/couchdb. See the 
other referenced issues for more info.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on a change in pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

davisp commented on a change in pull request #754: Compactor optimization - PR 
FOR FEEDBACK ONLY
URL: https://github.com/apache/couchdb/pull/754#discussion_r133549058
 
 

 ##
 File path: src/couch/src/couch_db_updater.erl
 ##
 @@ -1258,6 +1313,7 @@ copy_docs(Db, #db{fd = DestFd} = NewDb, MixedInfos, 
Retry) ->
 % first pass. This means we may have docs that already exist
 % in the seq_tree in the .data file. Here we lookup any old
 % update_seqs so that they can be removed.
+OldDocIdTree =
 
 Review comment:
   Totes was. Got mixed in when separating commits.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp commented on a change in pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

davisp commented on a change in pull request #754: Compactor optimization - PR 
FOR FEEDBACK ONLY
URL: https://github.com/apache/couchdb/pull/754#discussion_r133548905
 
 

 ##
 File path: src/couch/src/couch_db_updater.erl
 ##
 @@ -1034,56 +1041,90 @@ check_md5(_, _) -> throw(md5_mismatch).
 
 start_copy_compact(#db{}=Db) ->
 erlang:put(io_priority, {db_compact, Db#db.name}),
-#db{name=Name, filepath=Filepath, options=Options, header=Header} = Db,
-couch_log:debug("Compaction process spawned for db \"~s\"", [Name]),
+couch_log:debug("Compaction process spawned for db \"~s\"", [Db#db.name]),
+
+{ok, InitCompSt} = open_compaction_files(Db),
+
+Stages = [
+fun copy_purge_info/1,
+fun copy_compact/1,
+fun commit_compaction_data/1,
+fun sort_meta_data/1,
+fun commit_compaction_data/1,
+fun copy_meta_data/1,
+fun compact_final_sync/1
+],
 
-{ok, NewDb, DName, DFd, MFd, Retry} =
-open_compaction_files(Name, Header, Filepath, Options),
-erlang:monitor(process, MFd),
+FinalCompSt = lists:foldl(fun(Stage, CompSt) ->
+Stage(CompSt)
+end, InitCompSt, Stages),
 
-% This is a bit worrisome. init_db/4 will monitor the data fd
-% but it doesn't know about the meta fd. For now I'll maintain
-% that the data fd is the old normal fd and meta fd is special
-% and hope everything works out for the best.
 
 Review comment:
   Yep, it got moved to clean up start_compact. That comment is way old me. I 
know how couch_file works better now so the comment can go as its misleading.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kocolosk commented on a change in pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

kocolosk commented on a change in pull request #754: Compactor optimization - 
PR FOR FEEDBACK ONLY
URL: https://github.com/apache/couchdb/pull/754#discussion_r133547489
 
 

 ##
 File path: src/couch/src/couch_db_updater.erl
 ##
 @@ -1258,6 +1313,7 @@ copy_docs(Db, #db{fd = DestFd} = NewDb, MixedInfos, 
Retry) ->
 % first pass. This means we may have docs that already exist
 % in the seq_tree in the .data file. Here we lookup any old
 % update_seqs so that they can be removed.
+OldDocIdTree =
 
 Review comment:
   I'm a little rusty but this looks like a refactoring mistake ...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ksnavely commented on a change in pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

ksnavely commented on a change in pull request #754: Compactor optimization - 
PR FOR FEEDBACK ONLY
URL: https://github.com/apache/couchdb/pull/754#discussion_r133543459
 
 

 ##
 File path: src/couch/src/couch_db_updater.erl
 ##
 @@ -1216,7 +1218,7 @@ copy_compact(#comp_st{} = CompSt) ->
 {changes_done, 0},
 {total_changes, TotalChanges}
 ],
-case (Retry /= nil) and couch_task_status:is_task_added() of
+case (Retry) and couch_task_status:is_task_added() of
 
 Review comment:
   unnecessary parens
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ksnavely commented on a change in pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

ksnavely commented on a change in pull request #754: Compactor optimization - 
PR FOR FEEDBACK ONLY
URL: https://github.com/apache/couchdb/pull/754#discussion_r133542172
 
 

 ##
 File path: src/couch/src/couch_db_updater.erl
 ##
 @@ -1034,56 +1041,90 @@ check_md5(_, _) -> throw(md5_mismatch).
 
 start_copy_compact(#db{}=Db) ->
 erlang:put(io_priority, {db_compact, Db#db.name}),
-#db{name=Name, filepath=Filepath, options=Options, header=Header} = Db,
-couch_log:debug("Compaction process spawned for db \"~s\"", [Name]),
+couch_log:debug("Compaction process spawned for db \"~s\"", [Db#db.name]),
+
+{ok, InitCompSt} = open_compaction_files(Db),
+
+Stages = [
+fun copy_purge_info/1,
+fun copy_compact/1,
+fun commit_compaction_data/1,
+fun sort_meta_data/1,
+fun commit_compaction_data/1,
+fun copy_meta_data/1,
+fun compact_final_sync/1
+],
 
-{ok, NewDb, DName, DFd, MFd, Retry} =
-open_compaction_files(Name, Header, Filepath, Options),
-erlang:monitor(process, MFd),
+FinalCompSt = lists:foldl(fun(Stage, CompSt) ->
+Stage(CompSt)
+end, InitCompSt, Stages),
 
-% This is a bit worrisome. init_db/4 will monitor the data fd
-% but it doesn't know about the meta fd. For now I'll maintain
-% that the data fd is the old normal fd and meta fd is special
-% and hope everything works out for the best.
 
 Review comment:
   Or is it this? 
https://github.com/apache/couchdb/pull/754/commits/c4969f3916f52554179b69dda245f14feb1e19db#diff-c0abd721a4433ae0399b0c2cbdea8d18R1126
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ksnavely commented on a change in pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

ksnavely commented on a change in pull request #754: Compactor optimization - 
PR FOR FEEDBACK ONLY
URL: https://github.com/apache/couchdb/pull/754#discussion_r133541752
 
 

 ##
 File path: src/couch/src/couch_db_updater.erl
 ##
 @@ -1034,56 +1041,90 @@ check_md5(_, _) -> throw(md5_mismatch).
 
 start_copy_compact(#db{}=Db) ->
 erlang:put(io_priority, {db_compact, Db#db.name}),
-#db{name=Name, filepath=Filepath, options=Options, header=Header} = Db,
-couch_log:debug("Compaction process spawned for db \"~s\"", [Name]),
+couch_log:debug("Compaction process spawned for db \"~s\"", [Db#db.name]),
+
+{ok, InitCompSt} = open_compaction_files(Db),
+
+Stages = [
+fun copy_purge_info/1,
+fun copy_compact/1,
+fun commit_compaction_data/1,
+fun sort_meta_data/1,
+fun commit_compaction_data/1,
+fun copy_meta_data/1,
+fun compact_final_sync/1
+],
 
-{ok, NewDb, DName, DFd, MFd, Retry} =
-open_compaction_files(Name, Header, Filepath, Options),
-erlang:monitor(process, MFd),
+FinalCompSt = lists:foldl(fun(Stage, CompSt) ->
+Stage(CompSt)
+end, InitCompSt, Stages),
 
-% This is a bit worrisome. init_db/4 will monitor the data fd
-% but it doesn't know about the meta fd. For now I'll maintain
-% that the data fd is the old normal fd and meta fd is special
-% and hope everything works out for the best.
 
 Review comment:
   Is the concern over the lack of a monitor on the meta file descriptor still 
valid? Or is it moot with the `couch_file:close(MetaFd)` call now?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ksnavely commented on a change in pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

ksnavely commented on a change in pull request #754: Compactor optimization - 
PR FOR FEEDBACK ONLY
URL: https://github.com/apache/couchdb/pull/754#discussion_r133540363
 
 

 ##
 File path: src/couch/src/couch_db_updater.erl
 ##
 @@ -1034,56 +1041,90 @@ check_md5(_, _) -> throw(md5_mismatch).
 
 start_copy_compact(#db{}=Db) ->
 erlang:put(io_priority, {db_compact, Db#db.name}),
-#db{name=Name, filepath=Filepath, options=Options, header=Header} = Db,
-couch_log:debug("Compaction process spawned for db \"~s\"", [Name]),
+couch_log:debug("Compaction process spawned for db \"~s\"", [Db#db.name]),
+
+{ok, InitCompSt} = open_compaction_files(Db),
+
+Stages = [
+fun copy_purge_info/1,
+fun copy_compact/1,
+fun commit_compaction_data/1,
+fun sort_meta_data/1,
+fun commit_compaction_data/1,
+fun copy_meta_data/1,
+fun compact_final_sync/1
+],
 
-{ok, NewDb, DName, DFd, MFd, Retry} =
-open_compaction_files(Name, Header, Filepath, Options),
-erlang:monitor(process, MFd),
+FinalCompSt = lists:foldl(fun(Stage, CompSt) ->
+Stage(CompSt)
+end, InitCompSt, Stages),
 
-% This is a bit worrisome. init_db/4 will monitor the data fd
-% but it doesn't know about the meta fd. For now I'll maintain
-% that the data fd is the old normal fd and meta fd is special
-% and hope everything works out for the best.
-unlink(DFd),
+#comp_st{
+new_db = FinalNewDb,
+meta_fd = MetaFd
+} = FinalCompSt,
 
-NewDb1 = copy_purge_info(Db, NewDb),
-NewDb2 = copy_compact(Db, NewDb1, Retry),
-NewDb3 = sort_meta_data(NewDb2),
-NewDb4 = commit_compaction_data(NewDb3),
-NewDb5 = copy_meta_data(NewDb4),
-NewDb6 = sync_header(NewDb5, db_to_header(NewDb5, NewDb5#db.header)),
-close_db(NewDb6),
+close_db(FinalNewDb),
+ok = couch_file:close(MetaFd),
 
-ok = couch_file:close(MFd),
-gen_server:cast(Db#db.main_pid, {compact_done, DName}).
+gen_server:cast(Db#db.main_pid, {compact_done, FinalNewDb#db.filepath}).
 
 
-open_compaction_files(DbName, SrcHdr, DbFilePath, Options) ->
+open_compaction_files(OldDb) ->
+#db{
+name = DbName,
+filepath = DbFilePath,
+options = Options,
+header = SrcHdr
+} = OldDb,
 DataFile = DbFilePath ++ ".compact.data",
 MetaFile = DbFilePath ++ ".compact.meta",
 {ok, DataFd, DataHdr} = open_compaction_file(DataFile),
 {ok, MetaFd, MetaHdr} = open_compaction_file(MetaFile),
 DataHdrIsDbHdr = couch_db_header:is_header(DataHdr),
-case {DataHdr, MetaHdr} of
+CompSt = case {DataHdr, MetaHdr} of
 {#comp_header{}=A, #comp_header{}=A} ->
+% We're restarting a compaction that did not finish
+% before trying to swap out with the original db
 DbHeader = A#comp_header.db_header,
 Db0 = init_db(DbName, DataFile, DataFd, DbHeader, Options),
-Db1 = bind_emsort(Db0, MetaFd, A#comp_header.meta_state),
-{ok, Db1, DataFile, DataFd, MetaFd, Db0#db.id_tree};
+Db1 = bind_emsort(Db0, MetaFd, A#comp_header.meta_st),
+#comp_st{
+old_db = OldDb,
+new_db = Db1,
+meta_fd = MetaFd,
+retry = Db0#db.id_tree
+};
 _ when DataHdrIsDbHdr ->
+% We tried to swap out the compaction but there were
+% writes to the database during compction. Start
 
 Review comment:
   compaction typo
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bagguley commented on issue #949: No list of databases shown in IE 11

2017-08-16 Thread git

bagguley commented on issue #949: No list of databases shown in IE 11 
URL: https://github.com/apache/couchdb-fauxton/issues/949#issuecomment-322870025
 
 
   Hi @garrensmith
   
   It wasn't meant aggressively, but just in a completely shocked tone. It 
works in Edge and Firefox but not in IE with the Edge renderer. I'll try and 
dig out more details tomorrow.
   
   Best regards.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] davisp opened a new pull request #754: Compactor optimization - PR FOR FEEDBACK ONLY

2017-08-16 Thread git

davisp opened a new pull request #754: Compactor optimization - PR FOR FEEDBACK 
ONLY
URL: https://github.com/apache/couchdb/pull/754
 
 
   It occurred to me the other day that we already have the docid tree stored 
in the original database so the first pass at compaction is wasting a lot of 
time and IO writing out the emsort structure. This optimizes the compactor to 
avoid that first use of emsort and instead reads document IDs from the original 
db's id_tree.
   
   There are zero tests for correct compactor behavior right now (outside of 
the PSE branch) so I'm going to start writing a bunch of tests that will do 
mean things to the compactor to make sure that this doesn't have any issues 
around breaking things. However, given the change I figured I'd at least open a 
feedback PR while I write the test suite for the compactor behavior.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] garrensmith commented on issue #949: No list of databases shown in IE 11

2017-08-16 Thread git

garrensmith commented on issue #949: No list of databases shown in IE 11 
URL: https://github.com/apache/couchdb-fauxton/issues/949#issuecomment-322864505
 
 
   Hi @bagguley,
   
   That's a pretty aggressive tone. You are the first person to report it 
doesn't work on Chrome. Could you provide more details around that. We do a lot 
of testing to make sure it works on chrome and Firefox. So I am surprised to 
hear it doesn't work on it.
   
   Cheers
   Garren
   
   All misspelling thanks to my iPhone.
   
   From: bagguley 
   Sent: Wednesday, August 16, 2017 8:15:43 PM
   To: apache/couchdb-fauxton
   Cc: garren smith; Mention
   Subject: Re: [apache/couchdb-fauxton] No list of databases shown in IE 11 
(#949)
   
   
   @wohali Are you serious? You're not sure how much 
effort to put into this? CouchDB is now unusable unless you install Firefox 
because Chrome doesn't even render anything on the page. It's appalling that 
such simple testing wasn't conducted before release. The exception that 
@gdelfino referred to is probably a red herring 
because jQuery (which I presume is where it's occurring) handles these 
exceptions, they are expected.
   
   Chrome has around 60% of the browser share of desktop browser usage with 
Firefox bumbling around 6 to 10%. I suggest that this should be top priority.
   
   ?
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bagguley commented on issue #949: No list of databases shown in IE 11

2017-08-16 Thread git

bagguley commented on issue #949: No list of databases shown in IE 11 
URL: https://github.com/apache/couchdb-fauxton/issues/949#issuecomment-322855569
 
 
   @wohali Are you serious? You're not sure how much effort to put into this? 
CouchDB is now unusable unless you install Firefox because Chrome doesn't even 
render anything on the page. It's appalling that such simple testing wasn't 
conducted before release. The exception that @gdelfino referred to is probably 
a red herring because jQuery (which I presume is where it's occurring) handles 
these exceptions, they are expected.
   
   Chrome has around 60% of the browser share of desktop browser usage with 
Firefox bumbling around 6  to 10%. I suggest that this should be top priority.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #750: couchup replicate issue

2017-08-16 Thread git

wohali commented on issue #750: couchup replicate issue
URL: https://github.com/apache/couchdb/issues/750#issuecomment-322821591
 
 
   Does the problem persist when you leave off the `-f` option?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lostnet opened a new pull request #959: correct initial fetch() of _security to use credentials (#929)

2017-08-16 Thread git

lostnet opened a new pull request #959: correct initial fetch() of _security to 
use credentials (#929)
URL: https://github.com/apache/couchdb-fauxton/pull/959
 
 
   
   
   ## Overview
   
   sends credentials in the fetch of a db's existing _security policy so that 
it is correctly displayed and can be amended with changes. (issue #929) 
   
   ## Testing recommendations
   
   In chrome, update permissions on a db, reload fauxton, modify the 
permissions and save, reload fauxton, verify permissions based on both sessions 
are correctly displayed.
   
   ## GitHub issue number
929
   
   
   ## Related Pull Requests
   
   
   ## Checklist
   
   - [X] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [X] Documentation reflects the changes; **(fixes a regression, so 
presumably)**
   - [X] Update 
[rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
 with the correct tag once a new Fauxton release is made **(is this an action 
for me or a request from me?)**
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wohali commented on issue #753: run mango tests on travis

2017-08-16 Thread git

wohali commented on issue #753: run mango tests on travis
URL: https://github.com/apache/couchdb/pull/753#issuecomment-322808874
 
 
   Thank you @garrensmith ! ? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] willholley opened a new pull request #958: add query history to Mango UI

2017-08-16 Thread git

willholley opened a new pull request #958: add query history to Mango UI
URL: https://github.com/apache/couchdb-fauxton/pull/958
 
 
   
   
   ## Overview
   
   
   Adds a dropdown which shows the previous 5 Mango queries executed against 
the current database.
   
   Query history is persisted in localstorage (so only persists locally to the 
browser) and is currently limited to 5 items.
   
   Where no history exists, we populate the history with the default query.
   
   ## Testing recommendations
   
   
   
   Go to the Query panel in the dashboard. Some things to try (these are 
already covered by unit tests):
* Execute some Mango queries and ensure they get added to the history drop 
down. 
* Running a query that already exists in the dropdown should bump it to the 
top of the list. 
* The history should be limited to 5 queries.
* History should be unique for each database (keyed on db name).
   
   It's also worth trying complex queries and small screen sizes to see whether 
the layout is clear enough. The dropdown currently contains a single-line JSON 
representation of the query.
   
   ## GitHub issue number
   
   
   
   ## Related Pull Requests
   
   
   
   ## Checklist
   
   - [ ] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   - [ ] Update 
[rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script)
 with the correct tag once a new Fauxton release is made
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] SUCCESS: CouchDB » master #45

2017-08-16 Thread Apache Jenkins Server

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/45/

[GitHub] garrensmith closed pull request #753: run mango tests on travis

2017-08-16 Thread git

garrensmith closed pull request #753: run mango tests on travis
URL: https://github.com/apache/couchdb/pull/753
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] garrensmith commented on issue #158: add docs around pagination

2017-08-16 Thread git

garrensmith commented on issue #158: add docs around pagination
URL: 
https://github.com/apache/couchdb-documentation/pull/158#issuecomment-322732799
 
 
   Merged. Thanks @willholley for the help
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] garrensmith closed pull request #158: add docs around pagination

2017-08-16 Thread git

garrensmith closed pull request #158: add docs around pagination
URL: https://github.com/apache/couchdb-documentation/pull/158
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] willholley commented on issue #158: add docs around pagination

2017-08-16 Thread git

willholley commented on issue #158: add docs around pagination
URL: 
https://github.com/apache/couchdb-documentation/pull/158#issuecomment-322726059
 
 
   lgtm
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] willholley commented on a change in pull request #158: add docs around pagination

2017-08-16 Thread git

willholley commented on a change in pull request #158: add docs around 
pagination
URL: 
https://github.com/apache/couchdb-documentation/pull/158#discussion_r133401046
 
 

 ##
 File path: src/api/database/find.rst
 ##
 @@ -833,6 +832,18 @@ Example of selective retrieval of fields from matching 
documents:
 "fields": ["Actor_name", "Movie_year", "_id", "_rev"]
 }
 
+Pagination
+==
+
+Mango queries support pagination via the bookmark field. Each query will
+return a bookmark. A bookmark is a placeholder that CouchDB uses to
+determine where to start the query from. To get the next set of query
+results for a given query, add the bookmark that was received in the previous
+query to your next query. Remember to keep the query selector the same,
+otherwise you will receive unexpected results. This will return the next
+set of results. To paginate backwards use the previous bookmarks to return
+the previous set of results.
 
 Review comment:
   probably worth mentioning that the presence of a bookmark doesn't guarantee 
that there are more results. The only way to test for more results is to fetch 
the next page.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] willholley commented on a change in pull request #158: add docs around pagination

2017-08-16 Thread git

willholley commented on a change in pull request #158: add docs around 
pagination
URL: 
https://github.com/apache/couchdb-documentation/pull/158#discussion_r133400761
 
 

 ##
 File path: src/api/database/find.rst
 ##
 @@ -55,8 +55,7 @@
 returns an opaque string under the ``bookmark`` key that can then be
 passed back in a query to get the next page of results. If any part of
 the query other than ``bookmark`` changes between requests, the results
-are undefined. *Optional, default: null  Only for indexes of type
-``text``.*
+are undefined. *Optional, default: null
 
 Review comment:
   is it just the `selector` that should be consistent between calls to 
`_find`? If `limit` or `skip` are defined when passing a bookmark, won't that 
generate unexpected results?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nicolai86 opened a new pull request #24: Add couchdb 2.1.0 docker image

2017-08-16 Thread git

nicolai86 opened a new pull request #24: Add couchdb 2.1.0 docker image
URL: https://github.com/apache/couchdb-docker/pull/24
 
 
   ## Overview
   
   this PR adjusts the `2.0.0` setup to build `2.1.0`
   
   ## Testing recommendations
   
   ```
   $ cd 2.1.0
   $ docker build -t 2.1.0 .
   ```
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] garrensmith opened a new pull request #158: add docs around pagination

2017-08-16 Thread git

garrensmith opened a new pull request #158: add docs around pagination
URL: https://github.com/apache/couchdb-documentation/pull/158
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Jenkins] SUCCESS: CouchDB » master #44

2017-08-16 Thread Apache Jenkins Server

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/44/

[GitHub] garrensmith closed pull request #740: Add Bookmark support for mango json queries

2017-08-16 Thread git

garrensmith closed pull request #740: Add Bookmark support for mango json 
queries
URL: https://github.com/apache/couchdb/pull/740
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

45 matches

Mail list logo