[GitHub] [couchdb] subgero removed a comment on issue #2630: Unable to run Clouseau after following the documentation

2020-06-22 Thread GitBox


subgero removed a comment on issue #2630:
URL: https://github.com/apache/couchdb/issues/2630#issuecomment-631914613


   Hi guys, we are unable to run Clouseau. We created a Docker image, but when 
run this 
   
   `java -server \
-classpath '/opt/clouseau/*' \
-Xmx2G \
-Dsun.net.inetaddr.ttl=30 \
-Dsun.net.inetaddr.negative.ttl=30 \
-Dlog4j.configuration=file:/opt/clouseau/log4j.properties \
-XX:OnOutOfMemoryError=\"kill -9 %p\" \
-XX:+UseConcMarkSweepGC \
-XX:+CMSParallelRemarkEnabled \
com.cloudant.clouseau.Main \
/opt/clouseau/clouseau.ini
   `
   
   We are getting this message: 
   
   `2020-05-21 06:31:56,744 org.apache.commons.configuration.ConfigurationUtils 
[DEBUG] ConfigurationUtils.locate(): base is null, name is 
/opt/clouseau/clouseau.ini
   2020-05-21 06:31:56,745 org.apache.commons.configuration.DefaultFileSystem 
[DEBUG] Could not locate file /opt/clouseau/clouseau.ini at null: no protocol: 
/opt/clouseau/clouseau.ini
   2020-05-21 06:31:56,745 org.apache.commons.configuration.ConfigurationUtils 
[DEBUG] Loading configuration from the absolute path /opt/clouseau/clouseau.ini
   2020-05-21 06:31:57,053 
org.jboss.netty.channel.socket.nio.NioProviderMetadata [DEBUG] Couldn't 
determine the NIO constraint level from the system properties; using the safest 
level (2)
   2020-05-21 06:31:57,107 clouseau.main [FATAL] Uncaught exception: Connection 
refused
   `
   
   Files clouseau.ini and log4j are in place.
   We have searched the errors in google without obtaining results and we dont 
know whats going on.
   We dont know where must be setted cookie=monster on Couchdb, we dont use 
cluster, instead we have a single node.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] anuragvohraec opened a new issue #2961: Couchdb becomes unreachable after replication of large number of docs with attachments!

2020-06-22 Thread GitBox


anuragvohraec opened a new issue #2961:
URL: https://github.com/apache/couchdb/issues/2961


   Local Couchdb becomes "Failed to connect" state, after replicate large 
number of documents.
   
   ## Description
   I have written a replication client in dart language.
   I am able to replicate docs,  say 30 docs with attachments with couchdb.
   But when I am replicating [from my dart client to couchdb] say 1000 docs, 
with 250 of them having attachments, couchdb fails completely during the 
replication process.
   
   
![image](https://user-images.githubusercontent.com/53807480/85362526-4c3db880-b53c-11ea-90f8-bb2d23573ca4.png)
   
   By fialing here I mean, that when you hit url : http://0.0.0.0:5984, in 
browser, it doesnot gives any result.
   
   
![image](https://user-images.githubusercontent.com/53807480/85362965-72178d00-b53d-11ea-83ee-fa5128869dd8.png)
   
   
   The confusing thing here is that docker container is still running but if we 
try to access local couchdb address http://0.0.0.0:5984, it cannot be connected 
any more.
   
   
   * CouchDB version used: 3.1.0
   * Browser name and version: Google Chrome 81.0.4044.138 (Official Build) 
(64-bit)
   * Operating system and version: Ubuntu 19.04 
   
   ## Additional Context
   Logs of my replication
   ```
   notice] 2020-06-23T04:35:36.183390Z nonode@nohost <0.315.0>  
chttpd_auth_cache changes listener died because the _users database does not 
exist. Create the database to silence this notice.
   [error] 2020-06-23T04:35:36.183650Z nonode@nohost emulator  Error in 
process <0.2326.0> with exit value:
   
{database_does_not_exist,[{mem3_shards,load_shards_from_db,"_users",[{file,"src/mem3_shards.erl"},{line,399}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,374}]},{mem3_shards,load_shards_from_disk,2,[{file,"src/mem3_shards.erl"},{line,403}]},{mem3_shards,for_docid,3,[{file,"src/mem3_shards.erl"},{line,96}]},{fabric_doc_open,go,3,[{file,"src/fabric_doc_open.erl"},{line,39}]},{chttpd_auth_cache,ensure_auth_ddoc_exists,2,[{file,"src/chttpd_auth_cache.erl"},{line,198}]},{chttpd_auth_cache,listen_for_changes,1,[{file,"src/chttpd_auth_cache.erl"},{line,145}]}]}
   
   [notice] 2020-06-23T04:35:41.184000Z nonode@nohost <0.315.0>  
chttpd_auth_cache changes listener died because the _users database does not 
exist. Create the database to silence this notice.
   [error] 2020-06-23T04:35:41.184113Z nonode@nohost emulator  Error in 
process <0.2363.0> with exit value:
   
{database_does_not_exist,[{mem3_shards,load_shards_from_db,"_users",[{file,"src/mem3_shards.erl"},{line,399}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,374}]},{mem3_shards,load_shards_from_disk,2,[{file,"src/mem3_shards.erl"},{line,403}]},{mem3_shards,for_docid,3,[{file,"src/mem3_shards.erl"},{line,96}]},{fabric_doc_open,go,3,[{file,"src/fabric_doc_open.erl"},{line,39}]},{chttpd_auth_cache,ensure_auth_ddoc_exists,2,[{file,"src/chttpd_auth_cache.erl"},{line,198}]},{chttpd_auth_cache,listen_for_changes,1,[{file,"src/chttpd_auth_cache.erl"},{line,145}]}]}
   
   [notice] 2020-06-23T04:35:45.499407Z nonode@nohost <0.2392.0> 2adc51c20e 
0.0.0.0:5984 172.17.0.1 admin HEAD /targetdb 404 ok 1
   [error] 2020-06-23T04:35:45.517912Z nonode@nohost <0.2392.0> 822314bf98 
Request to create N=3 DB but only 1 node(s)
   [notice] 2020-06-23T04:35:46.009740Z nonode@nohost <0.2392.0> 822314bf98 
0.0.0.0:5984 172.17.0.1 admin PUT /targetdb 201 ok 496
   [notice] 2020-06-23T04:35:46.025914Z nonode@nohost <0.2392.0> ce3a65c4de 
0.0.0.0:5984 172.17.0.1 admin HEAD 
/targetdb/_local/f22614633d9c88d7e0cf3e111d1db28a 404 ok 1
   [notice] 2020-06-23T04:35:46.185654Z nonode@nohost <0.315.0>  
chttpd_auth_cache changes listener died because the _users database does not 
exist. Create the database to silence this notice.
   [error] 2020-06-23T04:35:46.186219Z nonode@nohost emulator  Error in 
process <0.2437.0> with exit value:
   
{database_does_not_exist,[{mem3_shards,load_shards_from_db,"_users",[{file,"src/mem3_shards.erl"},{line,399}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,374}]},{mem3_shards,load_shards_from_disk,2,[{file,"src/mem3_shards.erl"},{line,403}]},{mem3_shards,for_docid,3,[{file,"src/mem3_shards.erl"},{line,96}]},{fabric_doc_open,go,3,[{file,"src/fabric_doc_open.erl"},{line,39}]},{chttpd_auth_cache,ensure_auth_ddoc_exists,2,[{file,"src/chttpd_auth_cache.erl"},{line,198}]},{chttpd_auth_cache,listen_for_changes,1,[{file,"src/chttpd_auth_cache.erl"},{line,145}]}]}
   
   [notice] 2020-06-23T04:35:46.193309Z nonode@nohost <0.2392.0> 07ed721f18 
0.0.0.0:5984 172.17.0.1 admin PUT 
/targetdb/_local/f22614633d9c88d7e0cf3e111d1db28a 201 ok 164
   [notice] 2020-06-23T04:35:46.200939Z nonode@nohost <0.2392.0> ba8af030c9 
0.0.0.0:5984 172.17.0.1 admin GET 
/targetdb/_local/f22614633d9c88d7e0cf3e111d1db28a 200 ok 3
   [notice] 2020-06-23T04:35:46.250372Z 

[GitHub] [couchdb] IgorrG commented on issue #2736: Couchdb - intermittent fabric timeout errors

2020-06-22 Thread GitBox


IgorrG commented on issue #2736:
URL: https://github.com/apache/couchdb/issues/2736#issuecomment-647899924


   Hello, 
   We have experienced the same issue with kazoo and couchdb 3.1. Requests to 
the couchdb sometimes return with timeout and similar log in couchdb.log. 
Couchdb configured as 2-zone cluster with 3 servers in each zone, we do not get 
timeouts in single server configuration.
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb-pkg] wohali commented on issue #69: Alpine Linux apk build

2020-06-22 Thread GitBox


wohali commented on issue #69:
URL: https://github.com/apache/couchdb-pkg/issues/69#issuecomment-647862814


   @olekristensen No news, but your issue is not anything Alpine-specific. I 
recommend researching this through Docker forums.
   
   Further, for CouchDB, we have users who have experienced major data loss 
using persistent storage via CIFS or network mount - this is not a recommended 
deployment scenario for CouchDB in any regard.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] subgero edited a comment on issue #2630: Unable to run Clouseau after following the documentation

2020-06-22 Thread GitBox


subgero edited a comment on issue #2630:
URL: https://github.com/apache/couchdb/issues/2630#issuecomment-631914613


   Hi guys, we are unable to run Clouseau. We created a Docker image, but when 
run this 
   
   `java -server \
-classpath '/opt/clouseau/*' \
-Xmx2G \
-Dsun.net.inetaddr.ttl=30 \
-Dsun.net.inetaddr.negative.ttl=30 \
-Dlog4j.configuration=file:/opt/clouseau/log4j.properties \
-XX:OnOutOfMemoryError=\"kill -9 %p\" \
-XX:+UseConcMarkSweepGC \
-XX:+CMSParallelRemarkEnabled \
com.cloudant.clouseau.Main \
/opt/clouseau/clouseau.ini
   `
   
   We are getting this message: 
   
   `2020-05-21 06:31:56,744 org.apache.commons.configuration.ConfigurationUtils 
[DEBUG] ConfigurationUtils.locate(): base is null, name is 
/opt/clouseau/clouseau.ini
   2020-05-21 06:31:56,745 org.apache.commons.configuration.DefaultFileSystem 
[DEBUG] Could not locate file /opt/clouseau/clouseau.ini at null: no protocol: 
/opt/clouseau/clouseau.ini
   2020-05-21 06:31:56,745 org.apache.commons.configuration.ConfigurationUtils 
[DEBUG] Loading configuration from the absolute path /opt/clouseau/clouseau.ini
   2020-05-21 06:31:57,053 
org.jboss.netty.channel.socket.nio.NioProviderMetadata [DEBUG] Couldn't 
determine the NIO constraint level from the system properties; using the safest 
level (2)
   2020-05-21 06:31:57,107 clouseau.main [FATAL] Uncaught exception: Connection 
refused
   `
   
   Files clouseau.ini and log4j are in place.
   We have searched the errors in google without obtaining results and we dont 
know whats going on.
   We dont know where must be setted cookie=monster on Couchdb, we dont use 
cluster, instead we have a single node.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb-pkg] olekristensen edited a comment on issue #69: Alpine Linux apk build

2020-06-22 Thread GitBox


olekristensen edited a comment on issue #69:
URL: https://github.com/apache/couchdb-pkg/issues/69#issuecomment-647791701


   Any news on this? I am forced to mount persistent storage via cifs using 
local mounts in compose files at a customer's inhouse RHEL docker swarm setup, 
and for some reason i can usually make it work on alpine-based images. 
otherwise it fails with an operation not permitted.
   
   Let me know if you need any testing and what i could do to help



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb-pkg] olekristensen commented on issue #69: Alpine Linux apk build

2020-06-22 Thread GitBox


olekristensen commented on issue #69:
URL: https://github.com/apache/couchdb-pkg/issues/69#issuecomment-647791701


   Any news on this? I am forced to mount persistent storage via cifs using 
local mounts in compose files at a customer's inhouse RHEL docker swarm setup, 
and for some reason i can usually make it work on alpine-based images. 
otherwise it fails with an operation not permitted.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] iilyak opened a new pull request #2960: Add max_bulk_get_count configuration option

2020-06-22 Thread GitBox


iilyak opened a new pull request #2960:
URL: https://github.com/apache/couchdb/pull/2960


   ## Overview
   
   Let admin users specify the maximum document count for the `_bulk_get` 
requests via `max_bulk_get_count` configuration. If the document count exceeds 
the maximum it would return a 413 HTTP error. The implementation is based on 
https://github.com/apache/couchdb/pull/2910.
   
   ## Testing recommendations
   
   ```
   make && make eunit apps=chttpd tests=all_test_
   ```
   
   ## Related Issues or Pull Requests
   
   N/A
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [x] Any new configurable parameters are documented in 
`rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in 
https://github.com/apache/couchdb-documentation
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] SUCCESS: CouchDB » Full Platform Builds » master #185

2020-06-22 Thread Apache Jenkins Server
Yay, we passed. 
https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/master/185/display/redirect

[Jenkins] FAILURE: CouchDB » Full Platform Builds » master #184

2020-06-22 Thread Apache Jenkins Server
Boo, we failed. 
https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/master/184/display/redirect

[GitHub] [couchdb] rnewson merged pull request #2958: Allow drilldown for search to always be specified as list of lists

2020-06-22 Thread GitBox


rnewson merged pull request #2958:
URL: https://github.com/apache/couchdb/pull/2958


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] wohali commented on pull request #2957: Upgrade Credo to 1.4.0 – merge 3.x

2020-06-22 Thread GitBox


wohali commented on pull request #2957:
URL: https://github.com/apache/couchdb/pull/2957#issuecomment-647585381


   @dottorblaster yes, it is! No more 3.0.x though.
   
   `3.x` will last for a long while yet, as `master` is going to become 4.x 
very shortly...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] garrensmith commented on pull request #2958: Allow drilldown for search to always be specified as list of lists

2020-06-22 Thread GitBox


garrensmith commented on pull request #2958:
URL: https://github.com/apache/couchdb/pull/2958#issuecomment-647574982


   Nice that fix looks way better.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb-www] janl commented on pull request #33: remove slack.js and use slack join link

2020-06-22 Thread GitBox


janl commented on pull request #33:
URL: https://github.com/apache/couchdb-www/pull/33#issuecomment-647484171


   Nice!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb-www] garrensmith merged pull request #33: remove slack.js and use slack join link

2020-06-22 Thread GitBox


garrensmith merged pull request #33:
URL: https://github.com/apache/couchdb-www/pull/33


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] vd2org edited a comment on issue #2947: JWT settings not working

2020-06-22 Thread GitBox


vd2org edited a comment on issue #2947:
URL: https://github.com/apache/couchdb/issues/2947#issuecomment-647457696


   Heh, you're right. I tried to put the `kid` field in the payload instead of 
the header. 
   
   Fine! It works well now!
   
   Sorry to waste your time and thanks for the help!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] vd2org commented on issue #2947: JWT settings not working

2020-06-22 Thread GitBox


vd2org commented on issue #2947:
URL: https://github.com/apache/couchdb/issues/2947#issuecomment-647457696


   Heh, you're right. I tried to put the `kid` field in the payload instead of 
the header. Sorry to waste your time and thanks for the help!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] vd2org closed issue #2947: JWT settings not working

2020-06-22 Thread GitBox


vd2org closed issue #2947:
URL: https://github.com/apache/couchdb/issues/2947


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb-www] garrensmith opened a new pull request #33: remove slack.js and use slack join link

2020-06-22 Thread GitBox


garrensmith opened a new pull request #33:
URL: https://github.com/apache/couchdb-www/pull/33


   Slack now allows to create a join link that does not expire. I think that is 
better to use than the slack.js app.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] SUCCESS: CouchDB » Full Platform Builds » 3.x #20

2020-06-22 Thread Apache Jenkins Server
Yay, we passed. 
https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/3.x/20/display/redirect

[GitHub] [couchdb] vd2org removed a comment on issue #2947: JWT settings not working

2020-06-22 Thread GitBox


vd2org removed a comment on issue #2947:
URL: https://github.com/apache/couchdb/issues/2947#issuecomment-647442807


   Yep. And it does not work. CouchDB ignoring `kid` field at all.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] vd2org edited a comment on issue #2947: JWT settings not working

2020-06-22 Thread GitBox


vd2org edited a comment on issue #2947:
URL: https://github.com/apache/couchdb/issues/2947#issuecomment-647442807


   Yep. And it does not work. CouchDB ignoring `kid` field at all.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] vd2org commented on issue #2947: JWT settings not working

2020-06-22 Thread GitBox


vd2org commented on issue #2947:
URL: https://github.com/apache/couchdb/issues/2947#issuecomment-647442807


   Yeah. And it does not work. CouchDB ignoring `kid` field at all.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] FAILURE: CouchDB » Full Platform Builds » 3.x #19

2020-06-22 Thread Apache Jenkins Server
Boo, we failed. 
https://ci-couchdb.apache.org/job/jenkins-cm1/job/FullPlatformMatrix/job/3.x/19/display/redirect

[GitHub] [couchdb] dottorblaster merged pull request #2957: Upgrade Credo to 1.4.0 – merge 3.x

2020-06-22 Thread GitBox


dottorblaster merged pull request #2957:
URL: https://github.com/apache/couchdb/pull/2957


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] dottorblaster commented on pull request #2957: Upgrade Credo to 1.4.0 – merge 3.x

2020-06-22 Thread GitBox


dottorblaster commented on pull request #2957:
URL: https://github.com/apache/couchdb/pull/2957#issuecomment-647421261


   Thanks for reviewing @jjrodrig!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] bessbd commented on pull request #2958: Allow drilldown for search to always be specified as list of lists

2020-06-22 Thread GitBox


bessbd commented on pull request #2958:
URL: https://github.com/apache/couchdb/pull/2958#issuecomment-647415218


   Thank you for the review, @garrensmith ! I've performed all the changes 
you've requested in f997160515c2c7d2ee4fdd31d591a08745911565 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] garrensmith commented on a change in pull request #2958: Allow drilldown for search to always be specified as list of lists

2020-06-22 Thread GitBox


garrensmith commented on a change in pull request #2958:
URL: https://github.com/apache/couchdb/pull/2958#discussion_r443431868



##
File path: src/dreyfus/src/dreyfus_httpd.erl
##
@@ -31,11 +31,14 @@ handle_search_req(#httpd{method=Method, path_parts=[_, _, 
_, _, IndexName]}=Req
   when Method == 'GET'; Method == 'POST' ->
 DbName = couch_db:name(Db),
 Start = os:timestamp(),
-QueryArgs = #index_query_args{
+RawQueryArgs = #index_query_args{
 include_docs = IncludeDocs,
 grouping = Grouping
 } = parse_index_params(Req, Db),
-validate_search_restrictions(Db, DDoc, QueryArgs),
+validate_search_restrictions(Db, DDoc, RawQueryArgs),
+QueryArgs = RawQueryArgs#index_query_args{
+drilldown= 
unwrap_list_of_list_of_lists(RawQueryArgs#index_query_args.drilldown)

Review comment:
   You are missing a space after `drilldown`

##
File path: src/dreyfus/src/dreyfus_httpd.erl
##
@@ -31,11 +31,14 @@ handle_search_req(#httpd{method=Method, path_parts=[_, _, 
_, _, IndexName]}=Req
   when Method == 'GET'; Method == 'POST' ->
 DbName = couch_db:name(Db),
 Start = os:timestamp(),
-QueryArgs = #index_query_args{
+RawQueryArgs = #index_query_args{

Review comment:
   Rather make this `QueryArgs0`
   
   And then later make it `QueryArgs1`

##
File path: src/dreyfus/src/dreyfus_httpd.erl
##
@@ -209,6 +212,16 @@ parse_index_params(IndexParams, Db) ->
 validate_index_query(K, V, Args2)
 end, Args, IndexParams).
 
+unwrap_list_of_list_of_lists([Inner]=Outer) when is_list(Inner) ->

Review comment:
   Can you rename this to what its actually doing and leave a comment 
explaining the list of lists of lists thing with drilldowns.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [couchdb] dottorblaster commented on pull request #2957: Upgrade Credo to 1.4.0 – merge 3.x

2020-06-22 Thread GitBox


dottorblaster commented on pull request #2957:
URL: https://github.com/apache/couchdb/pull/2957#issuecomment-647366283


   @wohali is porting to `3.x` branch still a thing? Shall I merge this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org