[GitHub] [couchdb-rebar] jaydoane opened a new pull request, #6: Relax ANNO limitation in test coverage utils
jaydoane opened a new pull request, #6:
URL: https://github.com/apache/couchdb-rebar/pull/6
Currently the code to determine whether a particular file attribute
("header") exists assumes an ANNO format of a single line number, but versions
of OTP > 23 return a tuple, so that pattern will never match, resulting in
coverage failing to account for the inclusion of the `eunit.hrl` file, and then
incorrectly calculating the coverage of the test module as 66%, rather than the
expected 100%.
This change relaxes the pattern so that it will also match tuples, and fixes
the eunit coverage test.
```
make test_eunit
```
should now pass on OTP version >= 23.
See also: https://github.com/apache/couchdb-rebar/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 merged pull request #4358: [BP/3.2.2-docs] Escape special (html) chars in section names (#4350)
big-r81 merged PR #4358: URL: https://github.com/apache/couchdb/pull/4358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-helm] rileyai-dev commented on pull request #104: Simplify secrets to avoid dependencies on a file and keep only the se…
rileyai-dev commented on PR #104: URL: https://github.com/apache/couchdb-helm/pull/104#issuecomment-1374618836 @willholley Would highly appreciate if you could have a look at this. I added a new autoSetup feature to automatically finalize the cluster (set to false by default). It's very useful for fluxCD or equivalent tools! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] jaydoane commented on a diff in pull request #4: Copy rebar.app before bootstrapping
jaydoane commented on code in PR #4:
URL: https://github.com/apache/couchdb-rebar/pull/4#discussion_r1064044623
##
bootstrap:
##
@@ -49,6 +49,12 @@ main(Args) ->
false -> undefined
end,
+%% Ensure, that the ebin folder exists after "make clean"
+ok = filelib:ensure_dir("ebin/"),
+
+%% Copy rebar.app into ebin
+{ok, _} = file:copy("rebar.app", "ebin/rebar.app"),
Review Comment:
maybe we can add something like e.g. ?
```
%% CouchDB's `make clean` clobbers all ebin directories, so protect
rebar.app by
%% moving it out of harm's way, and copying it into ebin before
building.
```
##
bootstrap:
##
@@ -49,6 +49,12 @@ main(Args) ->
false -> undefined
end,
+%% Ensure, that the ebin folder exists after "make clean"
+ok = filelib:ensure_dir("ebin/"),
+
+%% Copy rebar.app into ebin
+{ok, _} = file:copy("rebar.app", "ebin/rebar.app"),
Review Comment:
maybe we can add something like e.g. ?
```
%% CouchDB's `make clean` clobbers all ebin directories, so protect
rebar.app by
%% moving it out of harm's way, and copying it into ebin before building.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4355: chore: protect 3.3.x and 3.2.x branches
big-r81 commented on PR #4355: URL: https://github.com/apache/couchdb/pull/4355#issuecomment-1374594793 @nickva @janl We have 3.2.2 and 3.2.2-docs. Should we integrate 3.2.2-docs into 3.2.x to clean up and change RTD to 3.2.x? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 opened a new pull request, #4359: [BP/3.3.x/] Escape special (html) chars in section names (#4350)
big-r81 opened a new pull request, #4359: URL: https://github.com/apache/couchdb/pull/4359 To correctly generate the configuration reference html output, escape special html characters like '<' and '>' in section names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 opened a new pull request, #4358: [BP/3.2.2-docs] Escape special (html) chars in section names (#4350)
big-r81 opened a new pull request, #4358: URL: https://github.com/apache/couchdb/pull/4358 To correctly generate the configuration reference html output, escape special html characters like '<' and '>' in section names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 merged pull request #4350: Escape special (html) chars in section names
big-r81 merged PR #4350: URL: https://github.com/apache/couchdb/pull/4350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4340: Use the bootstrap script to build local rebar
big-r81 commented on code in PR #4340:
URL: https://github.com/apache/couchdb/pull/4340#discussion_r1064039944
##
configure:
##
@@ -296,9 +296,10 @@ install_local_rebar() {
if [ ! -d "${rootdir}/src/rebar" ]; then
git clone --depth 1 https://github.com/apache/couchdb-rebar.git
${rootdir}/src/rebar
fi
-make -C ${rootdir}/src/rebar
+cd src/rebar
+./bootstrap
Review Comment:
@jaydoane You are right, there are no advantages and it works without
calling bootstrap directly. Closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 closed pull request #4340: Use the bootstrap script to build local rebar
big-r81 closed pull request #4340: Use the bootstrap script to build local rebar URL: https://github.com/apache/couchdb/pull/4340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] big-r81 commented on pull request #4: Copy rebar.app before bootstrapping
big-r81 commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1374573919 Oh yes, it's a leftover of the changes. Since we now always copy rebar.app when building, it is of course sufficient to leave it in the top-level directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4340: Use the bootstrap script to build local rebar
big-r81 commented on code in PR #4340:
URL: https://github.com/apache/couchdb/pull/4340#discussion_r1064035063
##
configure:
##
@@ -296,9 +296,10 @@ install_local_rebar() {
if [ ! -d "${rootdir}/src/rebar" ]; then
git clone --depth 1 https://github.com/apache/couchdb-rebar.git
${rootdir}/src/rebar
fi
-make -C ${rootdir}/src/rebar
+cd src/rebar
+./bootstrap
Review Comment:
I used the rebar3 example as a guide at the beginning. I will test it again
without this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb-rebar] jaydoane commented on pull request #4: Copy rebar.app before bootstrapping
jaydoane commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1374570472 It appears that you've added a new copy of ebin/rebar.app in the top level while leaving the original in place. Did you mean to do e.g. `git mv ebin/rebar.app .` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] jaydoane commented on a diff in pull request #4340: Use the bootstrap script to build local rebar
jaydoane commented on code in PR #4340:
URL: https://github.com/apache/couchdb/pull/4340#discussion_r1064033192
##
configure:
##
@@ -296,9 +296,10 @@ install_local_rebar() {
if [ ! -d "${rootdir}/src/rebar" ]; then
git clone --depth 1 https://github.com/apache/couchdb-rebar.git
${rootdir}/src/rebar
fi
-make -C ${rootdir}/src/rebar
+cd src/rebar
+./bootstrap
Review Comment:
Can you help me understand why it's preferable to run `bootstrap` explicitly
when it appears that `make` [should be using bootstrap
already?](https://github.com/apache/couchdb-rebar/blob/main/Makefile#L8-L9)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 merged pull request #4357: [DOC] Update required Erlang OTP versions
big-r81 merged PR #4357: URL: https://github.com/apache/couchdb/pull/4357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 merged pull request #4356: Add Prometheus port to Windows couchdb.config
big-r81 merged PR #4356: URL: https://github.com/apache/couchdb/pull/4356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] dependabot[bot] opened a new pull request, #1383: Bump json5 from 2.2.0 to 2.2.3
dependabot[bot] opened a new pull request, #1383: URL: https://github.com/apache/couchdb-fauxton/pull/1383 Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.3. Release notes Sourced from https://github.com/json5/json5/releases;>json5's releases. v2.2.3 Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (https://github-redirect.dependabot.com/json5/json5/issues/299;>#299) v2.2.2 Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199;>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295;>#295). v2.2.1 Fix: Removed dependence on minimist to patch CVE-2021-44906. (https://github-redirect.dependabot.com/json5/json5/issues/266;>#266) Changelog Sourced from https://github.com/json5/json5/blob/main/CHANGELOG.md;>json5's changelog. v2.2.3 [https://github.com/json5/json5/tree/v2.2.3;>code, https://github.com/json5/json5/compare/v2.2.2...v2.2.3;>diff] Fix: json5@2.2.3 is now the 'latest' release according to npm instead of v1.0.2. (https://github-redirect.dependabot.com/json5/json5/issues/299;>#299) v2.2.2 [https://github.com/json5/json5/tree/v2.2.2;>code, https://github.com/json5/json5/compare/v2.2.1...v2.2.2;>diff] Fix: Properties with the name __proto__ are added to objects and arrays. (https://github-redirect.dependabot.com/json5/json5/issues/199;>#199) This also fixes a prototype pollution vulnerability reported by Jonathan Gregson! (https://github-redirect.dependabot.com/json5/json5/issues/295;>#295). v2.2.1 [https://github.com/json5/json5/tree/v2.2.1;>code, https://github.com/json5/json5/compare/v2.2.0...v2.2.1;>diff] Fix: Removed dependence on minimist to patch CVE-2021-44906. (https://github-redirect.dependabot.com/json5/json5/issues/266;>#266) Commits https://github.com/json5/json5/commit/c3a75242772a5026a49c4017a16d9b3543b62776;>c3a7524 2.2.3 https://github.com/json5/json5/commit/94fd06d82eeed225fa172f6fb2ca27375cbd2e39;>94fd06d docs: update CHANGELOG for v2.2.3 https://github.com/json5/json5/commit/3b8cebf0c474a8b20c78bd75c89cca0c4dce84ce;>3b8cebf docs(security): use GitHub security advisories https://github.com/json5/json5/commit/f0fd9e194dde282caff114a110f4fac635f3a62c;>f0fd9e1 docs: publish a security policy https://github.com/json5/json5/commit/6a91a05fffeda16ff6b3b5008b6b340d42d31ec0;>6a91a05 docs(template): bug - bug report https://github.com/json5/json5/commit/14f8cb186e8abdfaccf6527171da7b1224374650;>14f8cb1 2.2.2 https://github.com/json5/json5/commit/10cc7ca9169b59c5e0f5afc03dbd870cd06bcc46;>10cc7ca docs: update CHANGELOG for v2.2.2 https://github.com/json5/json5/commit/7774c1097993bc3ce9f0ac4b722a32bf7d6871c8;>7774c10 fix: add proto to objects and arrays https://github.com/json5/json5/commit/edde30abd8b22facf2c06c72586b9f6edf12700d;>edde30a Readme: slight tweak to intro https://github.com/json5/json5/commit/97286f8bd542c89dcee096bc05dd28ed2dfc1e16;>97286f8 Improve example in readme Additional commits viewable in https://github.com/json5/json5/compare/v2.2.0...v2.2.3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen
[GitHub] [couchdb] big-r81 commented on pull request #4342: Set Spidermonkey 91 as default
big-r81 commented on PR #4342: URL: https://github.com/apache/couchdb/pull/4342#issuecomment-1374050147 @janl separated all non sm91-default changes to standalone PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 opened a new pull request, #4356: Add Prometheus port to Windows couchdb.config
big-r81 opened a new pull request, #4356: URL: https://github.com/apache/couchdb/pull/4356 ## Overview Add Prometheus port to ./configure.ps1 to catch up with ./configure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #4355: chore: protect 3.3.x and 3.2.x branches
nickva commented on PR #4355: URL: https://github.com/apache/couchdb/pull/4355#issuecomment-1373978465 Good idea to encourage using rebases if possible, especially for small or medium PR. But it could just be an admonishment rather than an enforcement. I can see in cases when large features are merged a merge commit might make sense. Another thing I often watch out for is that I avoid merging main into my PR branch and then merging back into main. That often ends up looking rather confusing in git history. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] big-r81 commented on pull request #4: Copy rebar.app before bootstrapping
big-r81 commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1373977970 I think the PR is ready. On bootstrapping it checks if beim exists (create it if not) and copy the rebar.app into it. In combination with https://github.com/apache/couchdb/pull/4340 it’s now possible to rebuild rebar if missing in bin/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] jaydoane commented on pull request #4: Copy rebar.app before bootstrapping
jaydoane commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1373951639 > I think about that too, but then the ebin dirs are not removed, but empty. I thought more about this as well. They would not quite be empty, but still contain the .app files generated by rebar from the .app.src files, which I think could be a problem since I think we'd want `make clean` to remove those as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on a diff in pull request #105: Support existing persistent volume
willholley commented on code in PR #105:
URL: https://github.com/apache/couchdb-helm/pull/105#discussion_r1063630994
##
docs/index.yaml:
##
@@ -1,6 +1,30 @@
apiVersion: v1
entries:
couchdb:
+ - apiVersion: v1
+appVersion: 3.2.1
+created: "2022-12-20T17:53:44.680236109-08:00"
+description: A database featuring seamless multi-master sync, that scales
from
+ big data to mobile, with an intuitive HTTP/JSON API and designed for
reliability.
+digest: 5a66b7584d72bb2ac9c30e65d751ee374adbea2fe73dac20a058fb20bf1476e2
+home: https://couchdb.apache.org/
+icon:
http://couchdb.apache.org/CouchDB-visual-identity/logo/CouchDB-couch-symbol.svg
+keywords:
+- couchdb
+- database
+- nosql
+maintainers:
+- email: kocol...@apache.org
+ name: kocolosk
+- email: willhol...@apache.org
+ name: willholley
+name: couchdb
+sources:
+- https://github.com/apache/couchdb-helm
+- https://github.com/apache/couchdb-docker
+urls:
+- couchdb-3.6.4.tgz
+version: 3.6.4
- apiVersion: v1
appVersion: 3.2.1
created: "2022-11-16T10:04:19.187911144-08:00"
Review Comment:
This doesn't need to be manually updated - it's now generated automatically
on release. We need to update the contributing guide / remove the docs folder...
##
couchdb/Chart.yaml:
##
@@ -1,6 +1,6 @@
apiVersion: v1
name: couchdb
-version: 3.6.3
+version: 3.6.4
Review Comment:
Can you rebase / re-bump the version please?
##
couchdb/templates/persistentvolumeclaim.yaml:
##
@@ -0,0 +1,29 @@
+{{- if and .Values.persistentVolume.enabled .Values.persistentVolume.existing
-}}
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+ name: {{ .Values.persistentVolume.claimName }}
+ labels:
+app: {{ template "couchdb.name" . }}
+release: {{ .Release.Name }}
+ {{- with .Values.persistentVolume.annotations }}
+ annotations:
+{{- toYaml . | nindent 10 }}
Review Comment:
nindent value here is probably 6 rather than 10? I assume it is 10 since it
was copied from the statefulset yaml?
It feels like there's some potential for the persistentvolumeclaim.yaml and
statefulset.yaml to get out of sync - perhaps we could extract a helper
function for the common yaml?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #100: Default value for ingress.annotations is now {}
willholley commented on PR #100: URL: https://github.com/apache/couchdb-helm/pull/100#issuecomment-1373913100 @emcellsoft can you bump the chart version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #70: Fix "Annotations is a table" error
willholley commented on PR #70: URL: https://github.com/apache/couchdb-helm/pull/70#issuecomment-1373912744 duplicated by https://github.com/apache/couchdb-helm/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #70: Fix "Annotations is a table" error
willholley commented on PR #70: URL: https://github.com/apache/couchdb-helm/pull/70#issuecomment-1373912607 This was auto-closed because the `master` branch was replaced with `main` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-helm] willholley closed pull request #70: Fix "Annotations is a table" error
willholley closed pull request #70: Fix "Annotations is a table" error URL: https://github.com/apache/couchdb-helm/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-helm] willholley closed issue #94: Ingress should point to the "not headless" service
willholley closed issue #94: Ingress should point to the "not headless" service URL: https://github.com/apache/couchdb-helm/issues/94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-helm] willholley merged pull request #95: add service.labels and fix ingress service reference
willholley merged PR #95: URL: https://github.com/apache/couchdb-helm/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-nano] glynnbird opened a new pull request, #318: first attempt at removing Travis and replacing with GitHub workflows
glynnbird opened a new pull request, #318: URL: https://github.com/apache/couchdb-nano/pull/318 ## Overview ASF has requested that Travis not be used. This PR attempts to replace the running of automated tests with GitHub workflows. ## Testing recommendations See if automated tests run successfully. ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [x] Documentation reflects the changes; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] big-r81 commented on pull request #4: Move rebar.app out of ebin
big-r81 commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1373612899 > According to [the docs](https://www.erlang.org/doc/man/app.html#file-syntax): > > > The file is to be located in directory ebin for the application Okay, then let's follow the docs. > Maybe a better solution would be to fix `make clean`? What if we changed [this line](https://github.com/apache/couchdb/blob/main/Makefile#L442) to e.g. > > ``` >@rm -f src/*/ebin/*.beam > ``` I think about that too, but then the `ebin` dirs are not removed, but empty. I will update the PR, that the `rebar.app` is copied to `ebin` before building. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] janl commented on pull request #4355: chore: protect 3.3.x and 3.2.x branches
janl commented on PR #4355: URL: https://github.com/apache/couchdb/pull/4355#issuecomment-1373483172 > Can we also prevent „merge“ commits for a cleaner git history? We’d have to discuss this on dev@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] janl merged pull request #4354: Fix/debug
janl merged PR #4354: URL: https://github.com/apache/couchdb/pull/4354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4355: chore: protect 3.3.x and 3.2.x branches
big-r81 commented on PR #4355: URL: https://github.com/apache/couchdb/pull/4355#issuecomment-1373462751 Can we also prevent „merge“ commits for a cleaner git history? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] janl opened a new pull request, #4354: Fix/debug
janl opened a new pull request, #4354: URL: https://github.com/apache/couchdb/pull/4354 leftover, speeds up local rebar builds -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] janl merged pull request #4353: Fix replication job start_link.
janl merged PR #4353: URL: https://github.com/apache/couchdb/pull/4353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] nickva opened a new pull request, #4353: Fix replication job start_link.
nickva opened a new pull request, #4353: URL: https://github.com/apache/couchdb/pull/4353 We don't want to register replication jobs with the module name as that prevents us from running more than one job at a time. This was introduced when we removed the dependence on global registrations and switched to using pg instead. Even more embarrassing is we didn't have tests to check multiple replication jobs running at the same time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] jaydoane commented on pull request #4: Move rebar.app out of ebin
jaydoane commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1373163533 According to [the docs](https://www.erlang.org/doc/man/app.html#file-syntax): > The file is to be located in directory ebin for the application Maybe a better solution would be to fix `make clean`? What if we changed [this line](https://github.com/apache/couchdb/blob/main/Makefile#L442) to e.g. ``` @rm -rf src/*/ebin/*.beam ``` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] big-r81 commented on pull request #4: Move rebar.app out of ebin
big-r81 commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1372901586 I have an open PR on the main repo too. Can you test this PR with the combination of https://github.com/apache/couchdb/pull/4340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] jaydoane commented on pull request #4: Move rebar.app out of ebin
jaydoane commented on PR #4: URL: https://github.com/apache/couchdb-rebar/pull/4#issuecomment-1372893555 I ran into this issue today, so appreciate that it could be improved! However, moving rebar.app file to the top level looks weird, even though it seems to build that way. What if we moved it to src/rebar.app and then in bootstrap ensure ebin exists then copy it there from src/rebar.app? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #4352: Fix Ubuntu Jammy CI image reference
nickva merged PR #4352: URL: https://github.com/apache/couchdb/pull/4352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] jaydoane merged pull request #5: Relax xref ANNO limitation
jaydoane merged PR #5: URL: https://github.com/apache/couchdb-rebar/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] nickva opened a new pull request, #4352: Fix Ubuntu Jammy CI image reference
nickva opened a new pull request, #4352: URL: https://github.com/apache/couchdb/pull/4352 Just make it use the Erlang 24 version like all the other images -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] jaydoane opened a new pull request, #5: Relax xref ANNO limitation
jaydoane opened a new pull request, #5:
URL: https://github.com/apache/couchdb-rebar/pull/5
Currently this xref interface assumes an ANNO format of a single line
number, but versions of OTP > 23 return a tuple, resulting in a an error like:
```
ERROR: xref failed while processing /Users/jay/repos/couchdb/src/snappy:
{'EXIT',
{{badmatch,
[{attribute,{1,1},file,{"src/snappy.erl",1}},
```
This relaxes the assumption on any particular ANNO format and accepts them
all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] janl merged pull request #4351: Feat/main 3.3.x
janl merged PR #4351: URL: https://github.com/apache/couchdb/pull/4351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson commented on a diff in pull request #4349: feat(build): fail build if xref complains
rnewson commented on code in PR #4349: URL: https://github.com/apache/couchdb/pull/4349#discussion_r1062532302 ## build-aux/xref-helper.sh: ## @@ -0,0 +1,23 @@ +#!/bin/sh -x +REBAR=$1 +DIALYZE_OPTS=$2 + +# run rebar xref, grep out rebar meta output (==> and WARN) +# pipe the rest into a file +$REBAR --keep-going --recursive xref $DIALYZE_OPTS | \ + grep -v '==>' | \ + grep -v 'WARN' | \ + grep -v hastings > ./tmp/xref-output.txt + +# compare result against known allowed output +mkdir -p ./tmp Review Comment: mkdir should happen before first use above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4342: Set Spidermonkey 91 as default
big-r81 commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062506843
##
configure.ps1:
##
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
ok, fixed. Should the doc update be separate too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4342: Set Spidermonkey 91 as default
janl commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062486124
##
configure.ps1:
##
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
ok, but this also has nothing to do with SM91? It’d be good to keep topical
things in separate commits/PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 opened a new pull request, #4350: Escape special (html) chars in section names
big-r81 opened a new pull request, #4350: URL: https://github.com/apache/couchdb/pull/4350 ## Overview To correctly generate the configuration reference html output, escape special html characters like '<' and '>' in section names. Before PR: https://user-images.githubusercontent.com/9985963/210784263-84ec203b-b5e5-4687-94bc-657876fee29a.png;> ``` smoosh. ``` and https://user-images.githubusercontent.com/9985963/210784494-a8db8f37-94c5-4a60-a5b1-391264556e39.png;> ``` smoosh. ``` After PR: https://user-images.githubusercontent.com/9985963/210785053-fac88e13-18d9-45d3-8a58-e80966743e55.png;> ``` smoosh.channel ``` and https://user-images.githubusercontent.com/9985963/210784952-74460e9a-3c35-4fea-802f-1f9a52435ea6.png;> ``` smoosh.channel ``` ## Checklist - [x] Code is written and works correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] janl merged pull request #4348: fix: undefined function warning
janl merged PR #4348: URL: https://github.com/apache/couchdb/pull/4348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] janl merged pull request #4347: feat: remove failed couch_plugins experiment
janl merged PR #4347: URL: https://github.com/apache/couchdb/pull/4347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] janl opened a new pull request, #4349: feat(build): fail build if xref complains
janl opened a new pull request, #4349:
URL: https://github.com/apache/couchdb/pull/4349
only works on Erlang 23. 24 and 25 fail,
24 e.g. with:
```==> mem3 (xref)
Warning: hastings_index:await/2 is undefined function (Xref)
Warning: hastings_index:design_doc_to_indexes/1 is undefined function (Xref)
Warning: hastings_index_manager:get_index/2 is undefined function (Xref)
WARN: Continuing on after abort: [xref]
ERROR: xref failed while processing
/Users/jan/Work/asf/tmp/couchdb/src/mem3: {'EXIT',
{{badmatch,
[{attribute,{1,1},file,{"src/mem3_reshard_index.erl",1}},
{attribute,{13,2},module,mem3_reshard_index},
{attribute,
{15,2},
export,
[{design_docs,1},{target_indices,2},{spawn_builders,1},{build_index,2}]},
… big symbol dump
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4342: Set Spidermonkey 91 as default
big-r81 commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062370470
##
configure.ps1:
##
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
No, I only adapted this to the *nix
configure-[version](https://github.com/apache/couchdb/blob/33ee2164e6e73429193bc353a2c7dfb9d27a7790/configure#L261)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4342: Set Spidermonkey 91 as default
janl commented on code in PR #4342:
URL: https://github.com/apache/couchdb/pull/4342#discussion_r1062353502
##
configure.ps1:
##
@@ -138,6 +138,7 @@ $CouchDBConfig = @"
{node_name, "-name couchdb@localhost"}.
{cluster_port, 5984}.
{backend_port, 5986}.
+{prometheus_port, 17986}.
Review Comment:
stray commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] rnewson merged pull request #4346: add find_bugs makefile target for undefined functions
rnewson merged PR #4346: URL: https://github.com/apache/couchdb/pull/4346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson commented on pull request #4346: add find_bugs makefile target for undefined functions
rnewson commented on PR #4346: URL: https://github.com/apache/couchdb/pull/4346#issuecomment-1371484238 the smoosh_persist one is because it uses a function only present in OTP 24 and I tested on OTP 23 which is the lowest OTP couchdb officially supports (and thus it needs fixing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson commented on pull request #4346: add find_bugs makefile target for undefined functions
rnewson commented on PR #4346: URL: https://github.com/apache/couchdb/pull/4346#issuecomment-1371483584 current output on main ``` make find_bugs | grep Warn | grep -v hastin Warning: couch_config:delete/2 is undefined function (Xref) Warning: couch_config:get/2 is undefined function (Xref) Warning: couch_config:parse_ini_file/1 is undefined function (Xref) Warning: couch_config:set/3 is undefined function (Xref) src/couch_plugins.erl:121: Warning: couch_plugins:delete_config/1 calls undefined function couch_config:delete/2 (Xref) src/couch_plugins.erl:112: Warning: couch_plugins:load_config_file/2 calls undefined function couch_config:parse_ini_file/1 (Xref) src/couch_plugins.erl:19: Warning: couch_plugins:plugin_dir/0 calls undefined function couch_config:get/2 (Xref) src/couch_plugins.erl:83: Warning: couch_plugins:register_plugin/2 calls undefined function couch_config:set/3 (Xref) src/couch_plugins.erl:117: Warning: couch_plugins:set_config/1 calls undefined function couch_config:set/3 (Xref) src/couch_plugins.erl:87: Warning: couch_plugins:unregister_plugin/1 calls undefined function couch_config:delete/2 (Xref) src/couch_plugins_httpd.erl:18: Warning: couch_plugins_httpd:handle_req/1 calls undefined function couch_config:get/2 (Xref) src/couch_plugins_httpd.erl:53: Warning: couch_plugins_httpd:plugin_dir/0 calls undefined function couch_config:get/2 (Xref) file.erl: Warning: file:delete/2 is undefined function (Xref) src/smoosh_persist.erl:136: Warning: smoosh_persist:delete_file/1 calls undefined function file:delete/2 (Xref) src/ioq.erl: Warning: ioq:get_disk_queues/0 is undefined function (Xref) src/weatherreport_check_ioq.erl:88: Warning: weatherreport_check_ioq:check_legacy/1 calls undefined function ioq:get_disk_queues/0 (Xref) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson opened a new pull request, #4346: add find_bugs makefile target for undefined functions
rnewson opened a new pull request, #4346: URL: https://github.com/apache/couchdb/pull/4346 some false positives for hastings (part of geo feature not present in couchdb core) but the rest need fixin' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson closed issue #4315: Auto Shard Management
rnewson closed issue #4315: Auto Shard Management URL: https://github.com/apache/couchdb/issues/4315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson commented on issue #4315: Auto Shard Management
rnewson commented on issue #4315: URL: https://github.com/apache/couchdb/issues/4315#issuecomment-1371470067 Thank you for the ticket. We're aware that couchdb could improve its sharding system, and particularly we see value in higher level tools to allow resharding in place, and so on. This is a huge topic and not one that this issue will advance at all, unless you are willing to do this work in substantial part. I note that neither project you mention would be appropriate for CouchDB. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson commented on issue #4315: Auto Shard Management
rnewson commented on issue #4315: URL: https://github.com/apache/couchdb/issues/4315#issuecomment-1371463209 Are you planning to work on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] jaydoane merged pull request #4345: Add test coverage for replicator user_ctx parser
jaydoane merged PR #4345: URL: https://github.com/apache/couchdb/pull/4345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on pull request #4342: Set Spidermonkey 91 as default
big-r81 commented on PR #4342: URL: https://github.com/apache/couchdb/pull/4342#issuecomment-1371360376 Okay, setting only the default sm version to 91 and reverted the remove of 1.8.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] jaydoane commented on a diff in pull request #4343: fix undef when parsing replication doc body
jaydoane commented on code in PR #4343: URL: https://github.com/apache/couchdb/pull/4343#discussion_r1061797024 ## src/couch_replicator/src/couch_replicator_parse.erl: ## @@ -490,7 +490,7 @@ get_json_value(Key, Obj) -> couch_replicator_utils:get_json_value(Key, Obj). get_json_value(Key, Obj, Default) -> -couch_replicator_util:get_json_value(Key, Obj, Default). +couch_replicator_utils:get_json_value(Key, Obj, Default). Review Comment: https://github.com/apache/couchdb/pull/4345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] jaydoane opened a new pull request, #4345: Add test coverage for replicator user_ctx parser
jaydoane opened a new pull request, #4345: URL: https://github.com/apache/couchdb/pull/4345 See: https://github.com/apache/couchdb/pull/4343 ## Overview This adds a test to cover the case when a replication doc contains a user_ctx, and subsequently executes `get_json_value/3`. ## Testing recommendations ``` make eunit apps=couch_replicator suites=couch_replicator_parse ``` should show all lines of `rep_user_ctx/1` are covered. ## Related Issues or Pull Requests ## Checklist - [x] Code is written and works correctly - [x] Changes are covered by tests - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` - [ ] Documentation changes were made in the `src/docs` folder - [ ] Documentation changes were backported (separated PR) to affected branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson merged pull request #4343: fix undef when parsing replication doc body
rnewson merged PR #4343: URL: https://github.com/apache/couchdb/pull/4343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson closed issue #4344: Replicator {error, undef} after update to 3.3.0
rnewson closed issue #4344: Replicator {error, undef} after update to 3.3.0
URL: https://github.com/apache/couchdb/issues/4344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] rnewson commented on a diff in pull request #4343: fix undef when parsing replication doc body
rnewson commented on code in PR #4343: URL: https://github.com/apache/couchdb/pull/4343#discussion_r1061706584 ## src/couch_replicator/src/couch_replicator_parse.erl: ## @@ -490,7 +490,7 @@ get_json_value(Key, Obj) -> couch_replicator_utils:get_json_value(Key, Obj). get_json_value(Key, Obj, Default) -> -couch_replicator_util:get_json_value(Key, Obj, Default). +couch_replicator_utils:get_json_value(Key, Obj, Default). Review Comment: go right ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] jaydoane commented on a diff in pull request #4343: fix undef when parsing replication doc body
jaydoane commented on code in PR #4343: URL: https://github.com/apache/couchdb/pull/4343#discussion_r1061704641 ## src/couch_replicator/src/couch_replicator_parse.erl: ## @@ -490,7 +490,7 @@ get_json_value(Key, Obj) -> couch_replicator_utils:get_json_value(Key, Obj). get_json_value(Key, Obj, Default) -> -couch_replicator_util:get_json_value(Key, Obj, Default). +couch_replicator_utils:get_json_value(Key, Obj, Default). Review Comment: Can we add a test for this as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] burotica49 opened a new issue, #4344: Replicator {error, undef} after update to 3.3.0
burotica49 opened a new issue, #4344:
URL: https://github.com/apache/couchdb/issues/4344
Hello,
I updated my two couchDB servers from v3.2.2 to v3.3.0.
After the update, the replications no longer work
When I want to modify or redo them with Fauxton, I get an {error, undef}
message
Best regard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb-fauxton] rnewson commented on issue #1382: Replicator {error, undef} after update to 3.3.0
rnewson commented on issue #1382: URL: https://github.com/apache/couchdb-fauxton/issues/1382#issuecomment-1371187341 fixed by https://github.com/apache/couchdb/pull/4343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] rnewson opened a new pull request, #4343: fix undef when parsing replication doc body
rnewson opened a new pull request, #4343: URL: https://github.com/apache/couchdb/pull/4343 Closes https://github.com/apache/couchdb-fauxton/issues/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] rnewson commented on issue #1382: Replicator {error, undef} after update to 3.3.0
rnewson commented on issue #1382: URL: https://github.com/apache/couchdb-fauxton/issues/1382#issuecomment-1371186668 Not a fauxton issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] glynnbird commented on issue #1382: Replicator {error, undef} after update to 3.3.0
glynnbird commented on issue #1382:
URL:
https://github.com/apache/couchdb-fauxton/issues/1382#issuecomment-1371180369
I attempted to reproduce and creating a document using Fauxton in the
`_replicator` database, with a valid `source` and `target` worked just fine.
But using form (e.g. http://127.0.0.1:5984/_utils/#/replication/_create)
instead did fail with HTTP 403:
```
{"error":"forbidden","reason":"{error,undef}"}
```
(Mac M1 using Firefox)
In the logs, from the point when I submit the form I see:
```
[notice] 2023-01-04T16:54:43.991445Z couchdb@localhost <0.17434.0>
27974b6a26 127.0.0.1:5984 127.0.0.1 admin GET /_replicator/yyy 404 ok 2
[notice] 2023-01-04T16:54:44.012962Z couchdb@localhost <0.17818.0>
c91eb7297a 127.0.0.1:5984 127.0.0.1 admin GET / 200 ok 4
[notice] 2023-01-04T16:54:44.020925Z couchdb@localhost <0.17818.0>
8726111c37 127.0.0.1:5984 127.0.0.1 admin GET / 200 ok 4
[notice] 2023-01-04T16:54:44.036423Z couchdb@localhost <0.17434.0>
5af0cdfc7c 127.0.0.1:5984 127.0.0.1 admin POST /_replicator 403 ok 8
[notice] 2023-01-04T16:54:44.848812Z couchdb@localhost <0.407.0>
chttpd_auth_cache changes listener died because the _users database does not
exist. Create the database to silence this notice.
[error] 2023-01-04T16:54:44.848940Z couchdb@localhost emulator
Error in process <0.17848.0> on node couchdb@localhost with exit value:
{database_does_not_exist,[{mem3_shards,load_shards_from_db,"_users",[{file,"src/mem3_shards.erl"},{line,430}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,405}]},{mem3_shards,load_shards_from_disk,2,[{file,"src/mem3_shards.erl"},{line,434}]},{mem3_shards,for_docid,3,[{file,"src/mem3_shards.erl"},{line,100}]},{fabric_doc_open,go,3,[{file,"src/fabric_doc_open.erl"},{line,39}]},{chttpd_auth_cache,ensure_auth_ddoc_exists,2,[{file,"src/chttpd_auth_cache.erl"},{line,214}]},{chttpd_auth_cache,listen_for_changes,1,[{file,"src/chttpd_auth_cache.erl"},{line,160}]}]}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] janl commented on pull request #4342: Remove Spidermonkey 1.8.5
janl commented on PR #4342: URL: https://github.com/apache/couchdb/pull/4342#issuecomment-1371172172 let’s not remove support just yet. +1 for moving the default foward tho -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] rnewson commented on issue #1381: Replicator {error, undef} after update to 3.3.0
rnewson commented on issue #1381: URL: https://github.com/apache/couchdb-fauxton/issues/1381#issuecomment-1371141001 can you please grep your couch.log for 'undef' and report the full line with stacktrace if you find it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] rnewson commented on issue #1382: Replicator {error, undef} after update to 3.3.0
rnewson commented on issue #1382: URL: https://github.com/apache/couchdb-fauxton/issues/1382#issuecomment-1371140930 can you please grep your couch.log for 'undef' and report the full line with stacktrace if you find it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] big-r81 commented on issue #1382: Replicator {error, undef} after update to 3.3.0
big-r81 commented on issue #1382: URL: https://github.com/apache/couchdb-fauxton/issues/1382#issuecomment-1371114168 Moved the issue to the Fauxton repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] big-r81 commented on issue #1381: Replicator {error, undef} after update to 3.3.0
big-r81 commented on issue #1381: URL: https://github.com/apache/couchdb-fauxton/issues/1381#issuecomment-1371113392 Superseeded by #1382. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-fauxton] big-r81 closed issue #1381: Replicator {error, undef} after update to 3.3.0
big-r81 closed issue #1381: Replicator {error, undef} after update to 3.3.0
URL: https://github.com/apache/couchdb-fauxton/issues/1381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb-fauxton] burotica49 opened a new issue, #1382: Replicator {error, undef} after update to 3.3.0
burotica49 opened a new issue, #1382:
URL: https://github.com/apache/couchdb-fauxton/issues/1382
Hello,
I updated my two couchDB servers from v3.2.2 to v3.3.0.
After the update, the replications no longer work
When I want to modify or redo them with Fauxton, I get an {error, undef}
message
Best regard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] jcheger commented on issue #4341: Replicator {error, undef} after update to 3.3.0
jcheger commented on issue #4341: URL: https://github.com/apache/couchdb/issues/4341#issuecomment-1371004493 N.B. I did start on CouchDB few hours ago - I'm a total newbie Using Fauxton 3.3.0, here is how to reproduce the error (local sync): - create a brand new "test1" database - replication / New Replication - Source - Type: local database - Name: test1 - Authentication: Username and password - (user): *admin* - (pass): *admin* - Target - Type: New local database (or existing, it doesn't matter) - Name: test2 - Authentication: Username and password - (user): *admin* - (pass): *admin* It's enough to make it fail. The problem is beween Fauxton's replication wizard and the local server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] burotica49 commented on issue #4341: Replicator {error, undef} after update to 3.3.0
burotica49 commented on issue #4341:
URL: https://github.com/apache/couchdb/issues/4341#issuecomment-1370980250
If I create the replication not curl, it spins
If I try to create it with Fauxton in the replication part, I get the error
message {error, undef}
If I modify the document directly with this format in the base _replicator
it works and it turns :
```
{
"_id": "my_rep",
"source":
"url": "http://mysource.com:5984/bar;,
"auth": {
"basic": {
"username": "user",
"password": "pass"
}
}
"target": {
"url": "http://mytarget.com:5984/bar;,
"auth": {
"basic": {
"username": "user",
"password": "pass"
}
}
},
"create_target": false,
"continuous": true
}
```
I give credentials to both.
It's really the replication creation wizard that's buggy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on issue #4341: Replicator {error, undef} after update to 3.3.0
big-r81 commented on issue #4341:
URL: https://github.com/apache/couchdb/issues/4341#issuecomment-1370954158
Thanks to both of you.
To narrow down the problem:
1. If you create the same replication via `curl` or Postman, the replication
works?
2. If you create a replication via Fauxton, you get the `{error, undef}`
error?
3. In Fauxton you give the credentials to the source and target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] burotica49 commented on issue #4341: Replicator {error, undef} after update to 3.3.0
burotica49 commented on issue #4341:
URL: https://github.com/apache/couchdb/issues/4341#issuecomment-1370941041
By creating the rule by API with Postman it works with this format:
```
{
"_id": "my_rep",
"source": "http://myserver.com/foo;,
"target": {
"url": "http://localhost:5984/bar;,
"auth": {
"basic": {
"username": "user",
"password": "pass"
}
}
},
"create_target": true,
"continuous": true
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] jcheger commented on issue #4341: Replicator {error, undef} after update to 3.3.0
jcheger commented on issue #4341:
URL: https://github.com/apache/couchdb/issues/4341#issuecomment-1370934523
Same issue for me. No problem on 3.2.2, stuck on 3.3.0.
Using Fauxton, creating a replication (any kind) fails with error message
"{error, undef}".
On the browser, the complete response is:
- error: "forbidden"
- reason: "{error,undef}"
On the server, the only log is "POST /_replicator 403 ok 4"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb] big-r81 opened a new pull request, #4342: Remove Spidermonkey 1.8.5
big-r81 opened a new pull request, #4342: URL: https://github.com/apache/couchdb/pull/4342 Removes the old Spidermonkey 1.8.5 source code. Spidermonkey 91 is set as the new default version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 commented on issue #4341: Replicator {error, undef} after update to 3.3.0
big-r81 commented on issue #4341: URL: https://github.com/apache/couchdb/issues/4341#issuecomment-1370797477 Please provide some logs! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] burotica49 opened a new issue, #4341: Replicator {error, undef} after update to 3.3.0
burotica49 opened a new issue, #4341:
URL: https://github.com/apache/couchdb/issues/4341
Hello,
I updated my two couchDB servers from v3.2.2 to v3.3.0.
After the update, the replications no longer work
When I want to modify or redo them with Fauxton, I get an {error, undef}
message
Best regard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb-fauxton] burotica49 opened a new issue, #1381: Replicator {error, undef} after update to 3.3.0
burotica49 opened a new issue, #1381:
URL: https://github.com/apache/couchdb-fauxton/issues/1381
Hello,
I updated my two couchDB servers from v3.2.2 to v3.3.0.
After the update, the replications no longer work
When I want to modify or redo them, I get an {error, undef} message
Best regard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [couchdb-nano] divyanshshekhar commented on pull request #317: Changed datatype of update_seq and pure_seq to be `number | string`
divyanshshekhar commented on PR #317: URL: https://github.com/apache/couchdb-nano/pull/317#issuecomment-1370060341 Thank you @glynnbird. I can't tell you how happy I am that my first ever OSS PR got merged without issues! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-rebar] big-r81 opened a new pull request, #4: Move rebar.app out of ebin
big-r81 opened a new pull request, #4: URL: https://github.com/apache/couchdb-rebar/pull/4 Calling 'make clean' from CouchDB wipes all ebin-directories in the source tree. Afterwards it is not possible to build rebar again. Modifying the bootstrap script and moving 'rebar.app' one directory-level up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-docker] janl merged pull request #230: fix missing files
janl merged PR #230: URL: https://github.com/apache/couchdb-docker/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-docker] janl opened a new pull request, #230: fix missing files
janl opened a new pull request, #230: URL: https://github.com/apache/couchdb-docker/pull/230 ## Overview ## Testing recommendations ## GitHub issue number ## Related Pull Requests ## Checklist - [ ] Code is written and works correctly; - [ ] Changes are covered by tests; - [ ] Documentation reflects the changes; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-docker] janl merged pull request #229: release 3.3.0
janl merged PR #229: URL: https://github.com/apache/couchdb-docker/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-www] janl merged pull request #54: HNY
janl merged PR #54: URL: https://github.com/apache/couchdb-www/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-www] janl merged pull request #53: Draft 3.3.0 release
janl merged PR #53: URL: https://github.com/apache/couchdb-www/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-nano] glynnbird closed issue #316: `update_seq` and `purge_seq` are defined as number but in actual response they are string
glynnbird closed issue #316: `update_seq` and `purge_seq` are defined as number but in actual response they are string URL: https://github.com/apache/couchdb-nano/issues/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb-nano] glynnbird merged pull request #317: Changed datatype of update_seq and pure_seq to be `number | string`
glynnbird merged PR #317: URL: https://github.com/apache/couchdb-nano/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [couchdb] big-r81 merged pull request #4338: Update PR template
big-r81 merged PR #4338: URL: https://github.com/apache/couchdb/pull/4338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
