[GitHub] couchdb-config pull request #20: fix tests for #1602
GitHub user janl opened a pull request: https://github.com/apache/couchdb-config/pull/20 fix tests for #1602 Needed by https://github.com/apache/couchdb/pull/1602 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-config fix/conf Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-config/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit b9cb81e78f60d3f40ce0f162082908268af4071b Author: Jan Lehnardt Date: 2018-09-14T10:09:48Z fix tests for #1602 ---
[GitHub] couchdb-mochiweb issue #2: Merge upstream 2.17.0 release
Github user janl commented on the issue: https://github.com/apache/couchdb-mochiweb/pull/2 PR here: https://github.com/apache/couchdb/pull/1173 ---
[GitHub] couchdb-mochiweb issue #2: Merge upstream 2.17.0 release
Github user janl commented on the issue: https://github.com/apache/couchdb-mochiweb/pull/2 @rnewson figured it out, we already had all the commits and were missing the tag, so thatâs pushed now. ---
[GitHub] couchdb-mochiweb issue #2: Merge upstream 2.17.0 release
Github user janl commented on the issue: https://github.com/apache/couchdb-mochiweb/pull/2 works, woot. ---
[GitHub] couchdb-mochiweb issue #2: Merge upstream 2.17.0 release
Github user janl commented on the issue: https://github.com/apache/couchdb-mochiweb/pull/2 mochiweb master comes with its own `./rebar` script that is run on travis. This branch doesnât seem to have it. Iâve pushed a commit with that file onto this branch. We can mack it out if this doesnât help ---
[GitHub] couchdb-chttpd issue #65: Refactor test suite for httpd endpoints
Github user janl commented on the issue: https://github.com/apache/couchdb-chttpd/pull/65 @iilyak @davisp are you planning to bring this up to master, or can we close this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-ets-lru issue #4: Allow an ets_lru to be completely disabled
Github user janl commented on the issue: https://github.com/apache/couchdb-ets-lru/pull/4 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #92: remove documentation about couch_peruser ap...
Github user janl commented on the issue: https://github.com/apache/couchdb-documentation/pull/92 @KlausTrainer didnât you fix this for 2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb issue #448: Support pass command line arguments to couchdb when it i...
Github user janl commented on the issue: https://github.com/apache/couchdb/pull/448 nice one! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb issue #441: README.rst, README-DEV.rst: Code should be in double bac...
Github user janl commented on the issue: https://github.com/apache/couchdb/pull/441 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #71: Minor grammar fix, git → Git
Github user janl commented on the issue: https://github.com/apache/couchdb-documentation/pull/71 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #70: Fix some typos and style in intro and repli...
Github user janl commented on the issue: https://github.com/apache/couchdb-documentation/pull/70 this should go live in a couple of minutes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #70: Fix some typos and style in intro and repli...
Github user janl commented on the issue: https://github.com/apache/couchdb-documentation/pull/70 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #67: add _cluster_setup documentation
Github user janl commented on the issue: https://github.com/apache/couchdb-documentation/pull/67 you can leave out the initial PW setup, enable_cluster will do that for you otherwise +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch issue #195: Bypass couchdb_os_proc_pool tests on Windows
Github user janl commented on the issue: https://github.com/apache/couchdb-couch/pull/195 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb issue #439: Update default/local ini files with new settings
Github user janl commented on the issue: https://github.com/apache/couchdb/pull/439 way cool! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #766: fix: typos and dash-style
GitHub user janl opened a pull request: https://github.com/apache/couchdb-fauxton/pull/766 fix: typos and dash-style You can merge this pull request into a Git repository by running: $ git pull https://github.com/janl/couchdb-fauxton typos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/766.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #766 commit 700557539dc752b5fa6384b67b44cac256a0104c Author: Jan Lehnardt <j...@apache.org> Date: 2016-08-29T19:55:15Z fix: typos and dash-style --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request #432: fixes auth tests in JS suite.
GitHub user janl opened a pull request: https://github.com/apache/couchdb/pull/432 fixes auth tests in JS suite. Thanks to @sebastianrothbucher and @rnewson for their tireless effort in getting this going <3 This is the last major one before 2.0 RCs. Letâs get this shipped! You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb auth-tests-wip Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/432.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #432 commit 6411a40494f0e8f59a8852c17a7d9692b2a19ad9 Author: Jan Lehnardt <j...@apache.org> Date: 2016-05-16T17:30:19Z auth-tests wip *Get cookie-auth to pass \o/* Current remaining issues are with users_db.js and users_db_security.js. ./dev/run -n1 --with-admin-party-please Second terminal: ./tests/javascript/run users_db or ./tests/javascript/run users_db_security * * * users_db.js: JS test output: test/javascript/tests/users_db.js Error: function_clause Trace back (most recent call first): 546: test/javascript/couch.js CouchError([object Object]) 509: test/javascript/couch.js ([object CouchHTTP]) 58: test/javascript/couch.js ([object Object]) 71: test/javascript/tests/users_db.js # <<<<< place in users_db.js where the error is triggered testFun() 385: test/javascript/couch_test_runner.js run_on_modified_server([object Array],testFun) 181: test/javascript/tests/users_db.js () 37: test/javascript/cli_runner.js runTest() 48: test/javascript/cli_runner.js fail dev/logs/node1.log: 2016-05-16 14:34:31.903 [error] node1@127.0.0.1 <0.682.0> req_err(2080506428) unknown_error : function_clause[<<"chttpd_db:update_doc/4 L970">>,<<"chttpd_db:send_updated_doc/6 L934">>,<<"chttpd:process_request/1 L293">>,<<"chttpd:handle_request_int/1 L229">>,<<"mochiweb_http:headers/6 L122">>,<<"proc_lib:init_p_do_apply/3 L239">>] * * * users_db_security.js: JS test output: Error: expected 'true', got 'null' Trace back (most recent call first): 52: test/javascript/test_setup.js T(false,"expected 'true', got 'null'",(void 0)) 321: test/javascript/couch_test_runner.js TEquals(true,(void 0)) 186: test/javascript/tests/users_db_security.js # <<<<< place in users_db_security.js where () # the error is triggered 385: test/javascript/couch_test_runner.js run_on_modified_server([object Array],(function () {var res = usersDb. 114: test/javascript/tests/users_db_security.js () 385: test/javascript/couch_test_runner.js run_on_modified_server([object Array],(function () {var userDoc = {_id 419: test/javascript/tests/users_db_security.js () 37: test/javascript/cli_runner.js runTest() 48: test/javascript/cli_runner.js dev/logs/node1.log: 2016-05-16 19:46:20.092 [error] Undefined emulator Error in process <0.1938.0> on node 'node1@127.0.0.1' with exit value: {function_clause,[{fabric_doc_update,handle_message,[not_found,{shard,<<42 bytes>>,'node1@127.0.0.1',<<6 bytes>>,[3221225472,3758096383],#Ref<0.0.0.40541>},{1,1,1,[{{shard,<<42 bytes>>,'node1@127.0.0.1',<<6 bytes>>,[3221225472,3758096383],#Ref<0.0.0.40541>},[{doc,<<24 bytes>>,{1,[<<16 bytes>>]},{[{<<4 bytes>>,<<4 bytes>>},{<<4 bytes>>,<<7 bytes>>},{<<4 bytes>>,<<32 bytes>>},{<<5 bytes>>,[]},{<<15 bytes>>,<<6 bytes>>},{<<10 bytes>>,1},{<<11 bytes>>,<<40 bytes>>}]},[],false,[{ref,#Ref<0.0.0.40540>}]}]}],{dict,0,16,16,8,80,48,{[],[],[],[],[],[],[],[],[],[],[],[],... 2016-05-16 19:46:20.093 [error] node1@127.0.0.1 <0.1602.0> req_err(1320117845) badmatch : {function_clause, [{fabric_doc_update,handle_message, [not_found, {shard,<<"shards/c000-dfff/_users.1463420709">>, 'node1@127.0.0.1',<<"_users">>, [3221225472,3758096383], #Ref<0.0.0.40541>}, {1,1,1, [{{shar
[GitHub] couchdb issue #417: Auth tests wip
Github user janl commented on the issue: https://github.com/apache/couchdb/pull/417 hm, my bad, sorry, thanks for confirming it should work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb issue #417: Auth tests wip
Github user janl commented on the issue: https://github.com/apache/couchdb/pull/417 unfortunately this PR creates conflicts on the auth-tests-wip branch, can you rebase? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Plugin fixes
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/418#issuecomment-220011149 +! lgtm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: fix in logic that denies login with c...
GitHub user janl opened a pull request: https://github.com/apache/couchdb-chttpd/pull/122 fix in logic that denies login with conflicted user docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-chttpd fix-conflicted-user-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/122.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #122 commit dc0fa0a1383173bd87bc922332af1036f7352f49 Author: Jan Lehnardt <j...@apache.org> Date: 2016-05-16T12:13:46Z fix in logic that denies login with conflicted user docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x _users and _replicator be...
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/121#issuecomment-219402626 @kxepal Iâm currently looking at the JS tests that validate our auth behaviour, do you want to have a stab at making views admin-only here, too? Feel free to push on top of my branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x _users and _replicator be...
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/121#issuecomment-219402490 Since only admins can create views here, and we donât install any views ourselves, we are good here, but good thinking that *if* we want to encourage people to use custom views, we should make those admin only as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x _users and _replicator be...
GitHub user janl opened a pull request: https://github.com/apache/couchdb-chttpd/pull/121 restore 1.x _users and _replicator behaviour You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-chttpd 2991-restore-1x-users-behaviour Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/121.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #121 commit df264ad1fba5caa05d62165b6dc7b2fdb22c676d Author: Jan Lehnardt <j...@apache.org> Date: 2016-05-16T11:01:04Z restore 1.x _users and _replicator behaviour --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request:
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/commit/78f575ec2cac823605561f1b38e0761d8170ac5f#commitcomment-17481409 @eiri gotcha, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: Raise better exception on decompress o...
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/169#issuecomment-219293055 âtests pas locallyâ are not a great reason to ignore CI builds. I want to merge another thing and now I am blocked. We should never do this. This seemed to have happened here: https://github.com/apache/couchdb-couch/commit/78f575ec2cac823605561f1b38e0761d8170ac5f#commitcomment-17480742 so Iâm wondering how you manage to get no local build fails without this (unless you hadnât rebased against that before). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request:
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/commit/78f575ec2cac823605561f1b38e0761d8170ac5f#commitcomment-17480742 @eiri Why did this get merged despite travis throwing related errors? ``` =PROGRESS REPORT 28-Apr-2016::16:31:51 === application: couch started_at: nonode@nohost couchdb_views_tests:214: should_have_two_indexes_alive_before_deletion...ok undefined *** instantiation of subtests failed *** **in function couch_server:delete_file/3 called as delete_file("/home/travis/build/apache/couchdb-couch/couchdb/tmp/data","/home/travis/build/apache/couchdb-couch/couchdb/tmp/data/.eunit-test-db-146186822435_design/mrview/5398c9ad12cad56d2228cc89a2770ddf.view",[sync]) in call from lists:foreach/2 (lists.erl, line 1337) in call from couch_mrview_cleanup:run/1 (src/couch_mrview_cleanup.erl, line 42) in call from couchdb_views_tests:view_cleanup/1 (test/couchdb_views_tests.erl, line 526) in call from couchdb_views_tests:should_cleanup_index_file_after_ddoc_deletion/1 (test/couchdb_views_tests.erl, line 218) **error:undef undefined *** instantiation of subtests failed *** **in function couch_server:delete_file/3 called as delete_file("/home/travis/build/apache/couchdb-couch/couchdb/tmp/data","/home/travis/build/apache/couchdb-couch/couchdb/tmp/data/.eunit-test-db-146186867167_design/mrview/5398c9ad12cad56d2228cc89a2770ddf.view",[sync]) in call from lists:foreach/2 (lists.erl, line 1337) in call from couch_mrview_cleanup:run/1 (src/couch_mrview_cleanup.erl, line 42) in call from couchdb_views_tests:view_cleanup/1 (test/couchdb_views_tests.erl, line 526) in call from couchdb_views_tests:should_cleanup_all_index_files/1 (test/couchdb_views_tests.erl, line 224) **error:undef ``` https://s3.amazonaws.com/archive.travis-ci.org/jobs/126429390/log.txt via https://travis-ci.org/apache/couchdb-couch/jobs/126429390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Augment Javascript Test suite
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/400#issuecomment-219291483 @sebastianrothbucher can you close this PR too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Bring security validation back
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/401#issuecomment-219291471 @sebastianrothbucher can you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: Allow customisation of default securit...
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/171#issuecomment-219221693 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Document default_security property
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/412#issuecomment-219221630 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Document default_security property
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb/pull/412#discussion_r63276576 --- Diff: rel/overlay/etc/default.ini --- @@ -24,6 +24,10 @@ file_compression = snappy ; and/or more OS page cache hits, but they can also increase overall response ; time for writes when there are many attachment write requests in parallel. attachment_stream_buffer_size = 4096 +; Default security object for databases if not explicitly set +; open - same as couchdb 1.0, everyone can read/write +; admin_only - only admins can read/write +default_security = open --- End diff -- I like the naming, I think the natural opposites here are: - `open` / `closed` - `everyone` / `admin_only` and since âclosedâ isnât very descriptive I think `everyone` / `admin_only` is my preference --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: remove cassim from build until fixed
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb/pull/414#discussion_r63182601 --- Diff: rel/reltool.config --- @@ -87,8 +86,6 @@ %% couchdb {app, b64url, [{incl_cond, include}]}, {app, bear, [{incl_cond, include}]}, -{app, cassim, [{incl_cond, include}]}, -{app, chttpd, [{incl_cond, include}]}, --- End diff -- haha, editor key foobar :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: remove cassim from build until fixed
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb/pull/414#discussion_r63183348 --- Diff: rel/reltool.config --- @@ -87,8 +86,6 @@ %% couchdb {app, b64url, [{incl_cond, include}]}, {app, bear, [{incl_cond, include}]}, -{app, cassim, [{incl_cond, include}]}, -{app, chttpd, [{incl_cond, include}]}, --- End diff -- fixed in latest push --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: disable cassim until fixed
GitHub user janl opened a pull request: https://github.com/apache/couchdb-chttpd/pull/119 disable cassim until fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-chttpd no-cassim Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/119.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #119 commit 408d218e1516790d734997a5b1935a8fbf5d9779 Author: Jan Lehnardt <j...@apache.org> Date: 2016-05-13T10:55:38Z disable cassim until fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl closed the pull request at: https://github.com/apache/couchdb/pull/402 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-214683096 merged, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: support admin party after #d2665ce
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/117#issuecomment-214508549 commit ref: https://github.com/apache/couchdb-chttpd/commit/d2665cec222ab447e47cdceff950269553fb6c47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: support admin party after #d2665ce
GitHub user janl opened a pull request: https://github.com/apache/couchdb-chttpd/pull/117 support admin party after #d2665ce cc @iilyak You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-chttpd support-admin-party-after-d2665ce Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/117.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #117 commit 7cffe7edc5abe1a41103eae7f076e843222f429b Author: Jan Lehnardt <j...@apache.org> Date: 2016-04-25T20:19:52Z support admin party after d2665ce --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x behaviour: user docs in c...
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/116#issuecomment-214491286 thanks all! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: slew of js test improvements
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/410#issuecomment-214440530 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: slew of js test improvements
Github user janl closed the pull request at: https://github.com/apache/couchdb/pull/410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x behaviour: user docs in c...
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/116#issuecomment-214430334 latest version should fix travis issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x behaviour: user docs in c...
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/116#issuecomment-214329337 new version, uses `get_boolean`, added comment to clarify function behaviour skipped spec because of odd function sig. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: slew of js test improvements
GitHub user janl opened a pull request: https://github.com/apache/couchdb/pull/410 slew of js test improvements includes test for https://github.com/apache/couchdb-chttpd/pull/116 (sorry about the branch name) You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb test4th Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/410.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #410 commit 31a83b552c16524b4825f72f5c5d2789cef4f342 Author: sebastianro <sebastia...@apache.org> Date: 2016-04-15T12:49:25Z Bring show documents test back commit ca86e376677fec686230a90954f5def6c60bbe17 Author: sebastianro <sebastia...@apache.org> Date: 2016-04-15T13:43:34Z Bring users DB test back - unfortunately still work 2 do commit 0eac44c9d1dd92803a77bbb34a879b0e6b9b5982 Author: sebastianro <sebastia...@apache.org> Date: 2016-04-15T16:15:26Z Bring include docs back (and link jira to userdb sec) commit 6c4f3d9a841cc0f10c2235eb807461eda9497a6d Author: sebastianro <sebastia...@apache.org> Date: 2016-04-15T16:37:35Z Bring multi key design test back commit a87ac58e7103d59075dbcc4475baffe54b49abe5 Author: sebastianro <sebastia...@apache.org> Date: 2016-04-21T14:21:47Z Make sure we have random DB names all around including replication test and stabilize show_documents commit 33408d156c5f6c416161d9d13a60bc5c20c4 Author: sebastianro <sebastia...@apache.org> Date: 2016-04-21T16:57:56Z Make reader_acl more stable commit 1ae2c75bfc10e9fcca23ca995a7802414a39de39 Author: sebastianro <sebastia...@apache.org> Date: 2016-04-23T17:59:07Z Improve wait/retry commit 7bb5a8109ad913b9eb4652b0f55fbe83c83e4bf3 Author: sebastianro <sebastia...@apache.org> Date: 2016-04-24T11:27:19Z Test non-conflicting user doc commit 01edf892e76d50d78d4c89eca25cada0a6c3e7b9 Author: Jan Lehnardt <j...@apache.org> Date: 2016-04-25T11:51:18Z different attempt at making users_db test go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: slew of js test improvements
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/410#issuecomment-214304880 cc @sebastianrothbucher --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x behaviour: user docs in c...
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/116#issuecomment-214249138 New version without debugging statement and with config option --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x behaviour: user docs in c...
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/116#discussion_r60840233 --- Diff: src/chttpd_auth_cache.erl --- @@ -209,3 +206,18 @@ update_doc_ignoring_conflict(DbName, Doc, Options) -> throw:conflict -> ok end. + +validate_user_creds(nil) -> +nil; +validate_user_creds(UserCreds) -> +couch_log:info("~n~n validate_user_creds: ~p~n~n", [UserCreds]), --- End diff -- oh sorry, this is leftover debugging code, itâll go away completely --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x behaviour: user docs in c...
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/116#issuecomment-213852919 tests for this will be landing with https://github.com/apache/couchdb/pull/409 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: More test improvements and stabilization
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/409#issuecomment-213852770 this is relevant: https://github.com/apache/couchdb-chttpd/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: restore 1.x behaviour: user docs in c...
GitHub user janl opened a pull request: https://github.com/apache/couchdb-chttpd/pull/116 restore 1.x behaviour: user docs in conflict cannot login You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-chttpd fix-users-doc-in-conflict Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #116 commit 562e2b67065f47523f205b5b33af1be9dcd3592a Author: Jan Lehnardt <j...@apache.org> Date: 2016-04-23T23:28:32Z restore 1.x behaviour: user docs in conflict cannot login --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: More test improvements and stabilization
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/409#issuecomment-213715641 After applying #400 and #401 to master (nice work!) and rebasing the new master on top of this locally, I get reproducible test fails in `rewrite_js` and `show_documents`, and intermittent failures in `view_sandboxing` (sometimes it passes, sometimes not. These are the errors: ``` test/javascript/tests/rewrite_js.js Error: false Trace back (most recent call first): 52: test/javascript/test_setup.js T(false) 305: test/javascript/tests/rewrite_js.js () 37: test/javascript/cli_runner.js runTest() 48: test/javascript/cli_runner.js ``` ``` test/javascript/tests/show_documents.js Error: retry_part is not defined Trace back (most recent call first): 400: test/javascript/tests/show_documents.js () 37: test/javascript/cli_runner.js runTest() 48: test/javascript/cli_runner.js ``` ``` test/javascript/tests/view_sandboxing.js Error: expected '1', got 'null' Trace back (most recent call first): 52: test/javascript/test_setup.js T(false,"expected '1', got 'null'",(void 0)) 321: test/javascript/couch_test_runner.js TEquals(1,(void 0)) 129: test/javascript/tests/view_sandboxing.js () 37: test/javascript/cli_runner.js runTest() 48: test/javascript/cli_runner.js ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Bring security validation back
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/401#issuecomment-213714859 merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: conflict-solving: first pass on revi...
Github user janl commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/670#issuecomment-212068990 intro blog post including screenshots and video here: https://github.com/robertkowalski/couch-labs/blob/blog/blog/databases-are-not-boring/databases-are-not-boring.md this is really sweet. I canât comment on the code yet, but I just have a tiny feature request (that isnât blocking for this PR or anything): itâd be nice if the doc-compare view would still show the differences, kinda like GitHub split view: ![meta](https://cloud.githubusercontent.com/assets/11321/14651732/7459b69e-0671-11e6-9a73-2399d72f6c22.png) but yeah, excellent work, thanks so much! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Add recommended docs section
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/403#issuecomment-211743736 I also like this idea. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: headers specified in a JS rewrite can ...
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/163#issuecomment-211306569 merged, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: headers specified in a JS rewrite can ...
Github user janl closed the pull request at: https://github.com/apache/couchdb-couch/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-211303842 @kxepal https://pony-poc.apache.org/list.html?d...@couchdb.apache.org --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-211296364 `make install` doesnât exist :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: Add support for single_max_doc
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/114#issuecomment-211254601 I like the idea here, but am also weary about adding a new config parameter that appears to be close to what we already have. Looking forward to what you come up with @tonysun83! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-211247246 Renamed to `make build` and made `make install` print a notice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-211242739 confirmed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Upgrade fauxton to 1.1.2
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/404#issuecomment-211240822 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric pull request: Honor update_seq=true for map view re...
Github user janl commented on the pull request: https://github.com/apache/couchdb-fabric/pull/46#issuecomment-211077886 +1 tested locally, works as advertised --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch-mrview pull request: Render update_seq if number or ...
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/42#issuecomment-211077882 +1 tested locally, works as advertised --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric pull request: Honor update_seq=true for map view re...
Github user janl commented on the pull request: https://github.com/apache/couchdb-fabric/pull/46#issuecomment-211077035 Looks like this renders an update_seq regardless of whether it is requested: ``` > curl http://a:a@127.0.0.1:15984/t/_design/t/_view/t {"total_rows":0,"offset":0,"update_seq":"0-g1FDeJzLYWBg4MhgTmHgz8tPSTV0MDQy1zMAQsMcoARTIkOS_P___7MSGXAqSVIAkkn2hFQ5gFTFE1KVAFJVT0BVHguQZGgAUkCF8wmrXABRuZ-wygMQlfcJq3wAUQlyZxYAHlFWdg","rows":[ ]} jan@rose ~ > curl http://a:a@127.0.0.1:15984/t/_design/t/_view/t?update_seq=true {"total_rows":0,"offset":0,"update_seq":"0-g1FDeJzLYWBg4MhgTmHgz8tPSTV0MDQy1zMAQsMcoARTIkOS_P___7MSGXAqSVIAkkn2hFQ5gFTFE1KVAFJVT0BVHguQZGgAUkCF8wmrXABRuZ-wygMQlfcJq3wAUQlyZxYAHlFWdg","rows":[ ]} ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-mem3 pull request: for N > NodeCount db creation, warn, do...
Github user janl commented on the pull request: https://github.com/apache/couchdb-mem3/pull/20#issuecomment-211074708 no wait, that makes no sense, ignore me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-mem3 pull request: for N > NodeCount db creation, warn, do...
Github user janl commented on the pull request: https://github.com/apache/couchdb-mem3/pull/20#issuecomment-211074585 @kxepal not necessarily, I might want to run N>1 on a single node to e.g. get better CPU utilisation for view building on multi-core machines. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-mem3 pull request: don't warn on db creation
Github user janl commented on the pull request: https://github.com/apache/couchdb-mem3/pull/11#issuecomment-211073099 See https://github.com/apache/couchdb-mem3/pull/20 for new PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-mem3 pull request: for N > NodeCount db creation, warn, do...
GitHub user janl opened a pull request: https://github.com/apache/couchdb-mem3/pull/20 for N > NodeCount db creation, warn, dont error Closes COUCHDB-2594 Supercedes #11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-mem3 2594-single-node-warn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-mem3/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 4855450b8da5076e5de049b0718932f2087fc4fb Author: Jan Lehnardt <j...@apache.org> Date: 2016-04-17T18:02:21Z for N > NodeCount db creation, warn, dont error Closes COUCHDB-2594 Supercedes #11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-mem3 pull request: don't warn on db creation
Github user janl commented on the pull request: https://github.com/apache/couchdb-mem3/pull/11#issuecomment-211070071 How about this for a compromise? 1. make this a `warning` and not an `error` 2. add a clause about âif you run a single-node instance, ignore thisâ (wording TBD) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-210581103 I like build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request: copy dashboard.assets in release
Github user janl commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/704#issuecomment-210565144 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-210565097 @garrensmith @robertkowalski ignore me, I missed an update on `master`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/402#issuecomment-210565019 @kxepal yeah, like I said, naming is TBD, what should we make this? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: scrap make install, build full couch into re...
GitHub user janl opened a pull request: https://github.com/apache/couchdb/pull/402 scrap make install, build full couch into rel/couchdb As per dev@ discussion, this PR removes the more familiar behaviour of `make install` and creates a location independent directory `./rel/couchdb` that can be moved to anywhere on the system. This is a first draft, exact naming of make targets and messages TBD. cc @rnewson @kxepal @davisp I noticed this issue when building Fauxton: `grunt couchdb` installs `index.html` into `share/www/index.html`, and it tries to load js files from `./dashboard.assets/js/` but these are installed into `share/www/js/` Either `index.html` needs to not include the `dashboard.assets` path, or we need to install into that. I tried to fix it, but fauxton master doesnât have the subsequent copy lines, just the one for `index.html`, so Iâm not sure what to do. cc @garrensmith @robertkowalski You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb no-make-install Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/402.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #402 commit d642df3b5ee58b3f2414218eb4deb1068d07aee0 Author: Jan Lehnardt <j...@apache.org> Date: 2016-04-15T07:41:56Z scrap make install, build full couch into rel/couchdb --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fabric pull request: Avoid spamming logs with write_quorum...
Github user janl commented on the pull request: https://github.com/apache/couchdb-fabric/pull/41#issuecomment-192362534 ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch-replicator pull request: Fix view filtered replicati...
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/26#issuecomment-190817399 > Squashed, retested, merged Boom! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch-index pull request: Continue to reopen DB and enum c...
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch-index/pull/14#issuecomment-190815415 Doesnât this also change fundamentally how views work? And doesnât this introduce the same race condition we have for compaction, where heavy database writes can stall out the compaction swap? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Add pull request template
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/387#issuecomment-190327004 +100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: fix tarball build
Github user janl closed the pull request at: https://github.com/apache/couchdb/pull/385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: fix tarball build
Github user janl closed the pull request at: https://github.com/apache/couchdb-couch/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: fix tarball build
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/385#issuecomment-187325109 merged, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: fix tarball build
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/142#issuecomment-187156823 cool, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: fix tarball build
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/142#issuecomment-187139858 pushed new version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: fix tarball build
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/142#discussion_r53614755 --- Diff: rebar.config.script --- @@ -32,7 +32,15 @@ CouchJSName = case os:type() of "couchjs" end, CouchJSPath = filename:join(["priv", CouchJSName]), -Version = string:strip(os:cmd("git describe --always"), right, $\n), +Version0 = string:strip(os:cmd("git describe --always"), right, $\n), +% When we are not building from a git checkout, the above will fail. +% If that is the case, we use the COUCHDB_VERSION variable that has +% been set by the top level Makefile +Version = case Version0 of +"fatal:" ++ _Msg -> --- End diff -- > Hm...but how we'll transfer COUCHDB_VERSION value to the tarball in this case? It looks like I got fed up with trying to solve this programmatically, so I made this: https://github.com/apache/couchdb/blob/master/version.mk â e.g.: we have to maintain that file by hand. like we do with `acinclude.m4` in 1.x.x: https://github.com/apache/couchdb/blob/1.x.x/acinclude.m4.in#L19-L21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: fix tarball build
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/142#discussion_r53614920 --- Diff: rebar.config.script --- @@ -32,7 +32,15 @@ CouchJSName = case os:type() of "couchjs" end, CouchJSPath = filename:join(["priv", CouchJSName]), -Version = string:strip(os:cmd("git describe --always"), right, $\n), +Version0 = string:strip(os:cmd("git describe --always"), right, $\n), +% When we are not building from a git checkout, the above will fail. +% If that is the case, we use the COUCHDB_VERSION variable that has +% been set by the top level Makefile +Version = case Version0 of +"fatal:" ++ _Msg -> --- End diff -- > > hm, how do I get the exit status from os:cmd()? > I fear you have to open port for that. Turns to be complicated a bit. yeah, letâs ignore this for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: fix tarball build
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/142#discussion_r53614172 --- Diff: rebar.config.script --- @@ -32,7 +32,15 @@ CouchJSName = case os:type() of "couchjs" end, CouchJSPath = filename:join(["priv", CouchJSName]), -Version = string:strip(os:cmd("git describe --always"), right, $\n), +Version0 = string:strip(os:cmd("git describe --always"), right, $\n), +% When we are not building from a git checkout, the above will fail. +% If that is the case, we use the COUCHDB_VERSION variable that has +% been set by the top level Makefile +Version = case Version0 of +"fatal:" ++ _Msg -> --- End diff -- hm, how do I get the exit status from `os:cmd()`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: fix tarball build
GitHub user janl opened a pull request: https://github.com/apache/couchdb/pull/385 fix tarball build Prerequisite for https://github.com/apache/couchdb-couch/pull/142 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb fix-tarball-build Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb/pull/385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #385 commit 4d7749911debd35f8943ae55ba4f1e6367be316c Author: Jan Lehnardt <j...@apache.org> Date: 2016-02-22T11:23:10Z fix tarball build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-couch pull request: fix tarball build
GitHub user janl opened a pull request: https://github.com/apache/couchdb-couch/pull/142 fix tarball build seems to have no effect on clang-based systems, but should fix gcc builds. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-couch fix-tarball-build Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-couch/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 commit 882e4d1af427ad2ec27310f969834108ebfa484b Author: Jan Lehnardt <j...@apache.org> Date: 2016-02-22T11:22:57Z fix tarball build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request: suppress verbose LaTeX output
Github user janl commented on the pull request: https://github.com/apache/couchdb-documentation/pull/39#issuecomment-178794228 TexLive is fine, MacTex is based on TexLive IIRC. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request: suppress verbose LaTeX output
Github user janl commented on the pull request: https://github.com/apache/couchdb-documentation/pull/39#issuecomment-178797722 e.g. this is good, +1, feel free to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: 1.x compat
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/98#issuecomment-165745950 got a +1 from @rnewson on IRC, merging now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/377#issuecomment-165227757 Clean rebase here: https://github.com/apache/couchdb/pull/378 Closing this. Thanks all! <3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb/pull/377#discussion_r47433245 --- Diff: Makefile --- @@ -102,8 +102,17 @@ eunit: couch .PHONY: javascript # target: javascript - Run JavaScript test suites or specific ones defined by suites option -javascript: all share/www/script/test --- End diff -- @kxepal sorry I had to undo your cleanup here, because we are depending on different dirs, depending on whether we run the JS tests from the source tree or a release tarball. I donât know how to better formulate this in make. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd pull request: 1.x compat
GitHub user janl opened a pull request: https://github.com/apache/couchdb-chttpd/pull/98 1.x compat - fix form parsing for update functions and PUT requests (cc @kocolosk https://github.com/apache/couchdb-chttpd/commit/5845146dec0f66c1e8f2b629dde6a445ae16785b) - allow update funs to run on docs with a slash in their id (https://github.com/apache/couchdb/blob/1.x.x/share/www/script/test/update_documents.js#L197) You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb-chttpd 1.x-compat Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-chttpd/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit 6421adc5c200781f95b7bfdb66718bff35cb423c Author: Jan Lehnardt <j...@apache.org> Date: 2015-12-12T14:09:01Z 1.x compat: parse form data for externals on PUT in addtion ot POST commit 5d08f62f8aa3e858c2c707ade2b96a26d90e900c Author: Jan Lehnardt <j...@apache.org> Date: 2015-12-12T14:14:37Z 1.x compat: update fun: allow docs with slash in id --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/377#issuecomment-164164782 > Need to not forget cleanup history and some bits before merge. yeah, but how? :/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Github user janl commented on a diff in the pull request: https://github.com/apache/couchdb/pull/377#discussion_r47433411 --- Diff: Makefile --- @@ -102,8 +102,17 @@ eunit: couch .PHONY: javascript # target: javascript - Run JavaScript test suites or specific ones defined by suites option -javascript: all share/www/script/test - @dev/run -q --with-admin-party-please test/javascript/run $(suites) +javascript: all + @mkdir -p share/www/script/test +ifeq ($(IN_RELEASE), true) + @cp test/javascript/tests/lorem*.txt share/www/test/ +else + @mkdir -p src/fauxton/dist/release/test + @cp test/javascript/tests/lorem*.txt src/fauxton/dist/release/test/ +endif + @ulimit -n 10240 --- End diff -- the ulimit? why doesnât that work on FreeBSD? Different modifier? The reason is that we are now using random db names and during the course of the test runs we open many hundreds of fds and things fail with emfile when this isnât in here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb pull request: Allow server admins to retrieve an auth toke...
Github user janl commented on the pull request: https://github.com/apache/couchdb/pull/366#issuecomment-163687136 @kxepal nothing to wait for as far as I am concerned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---