[GitHub] couchdb-fauxton issue #843: fix encoding in views
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/843 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #825: 3192 - Rip and replace zeroclipboard with clipbo...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/825 good work ,+1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653925
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -14,180 +14,126 @@ import app from "../../app";
import FauxtonAPI from "../../core/api";
import React from "react";
import ReactDOM from "react-dom";
-import ZeroClipboard from "zeroclipboard";
import { Modal } from "react-bootstrap";
import "velocity-animate/velocity";
import "velocity-animate/velocity.ui";
-import "zeroclipboard/dist/ZeroClipboard.swf";
-
-function getZeroClipboardSwfPath () {
- return './dashboard.assets/ZeroClipboard.swf';
-}
-
-// super basic right now, but can be expanded later to handle all the
varieties of copy-to-clipboards
-// (target content element, custom label, classes, notifications, etc.)
-var Clipboard = React.createClass({
- propTypes: function () {
-return {
- text: React.PropTypes.string.isRequired,
- displayType: React.PropTypes.string.oneOf(['icon', 'text'])
-};
- },
+// formats a block of code and pretty-prints it in the page. Currently
uses the prettyPrint plugin
+var CodeFormat = React.createClass({
getDefaultProps: function () {
return {
- displayType: 'icon',
- textDisplay: 'Copy',
- onClipboardClick: function () { },
- title: 'Copy to clipboard'
+ lang: "js"
};
},
- componentWillMount: function () {
-ZeroClipboard.config({ swfPath: getZeroClipboardSwfPath() });
- },
+ getClasses: function () {
+// added for forward compatibility. This component defines an api via
it's props so you can pass lang="N" and
+// not the class that prettyprint requires for that lang. If (when,
hopefully!) we drop prettyprint we won't
+// have any change this component's props API and break things
+var classMap = {
+ js: 'lang-js'
+};
- getClipboardElement: function () {
-if (this.props.displayType === 'icon') {
- return ();
+var classNames = 'prettyprint';
+if (_.has(classMap, this.props.lang)) {
+ classNames += ' ' + classMap[this.props.lang];
}
-return this.props.textDisplay;
+return classNames;
},
componentDidMount: function () {
-var el = ReactDOM.findDOMNode(this);
- this.clipboard = new ZeroClipboard(el);
- this.clipboard.on('ready', function () {
-this.clipboard.on('copy', function () {
- this.props.onClipboardClick();
-}.bind(this));
- }.bind(this));
-
- this.clipboard.on('error', function (event) {
-console.log('ZeroClipboard error of type "' + event.name + '": ' +
event.message);
- });
- },
-
- onClick: function (event) {
-event.preventDefault();
+// this one function is all the lib offers. It parses the entire page
and pretty-prints anything with
+// a .prettyprint class; only executes on an element once
+prettyPrint();
},
render: function () {
+var code = JSON.stringify(this.props.code, null, " ");
return (
-
-{this.getClipboardElement()}
-
+ {code}
);
}
});
-// use like this:
-//
-//
-// pass in the text and a unique key, the key has to be unique or you'll
get a warning
-var ClipboardWithTextField = React.createClass({
+var _NextTrayInternalId = 0;
+var Tray = React.createClass({
+
propTypes: {
-onClipBoardClick: React.PropTypes.func.isRequired,
-textToCopy: React.PropTypes.string.isRequired,
-uniqueKey: React.PropTypes.string.isRequired,
-showCopyIcon: React.PropTypes.bool
+onAutoHide: React.PropTypes.func
},
getDefaultProps: function () {
return {
- showCopyIcon: true,
- text: 'Copy'
+ onAutoHide: function () { }
};
},
- componentWillMount: function () {
-ZeroClipboard.config({ swfPath: getZeroClipboardSwfPath() });
+ getInitialState: function () {
+return {
+ show: false,
+ internalid: (_NextTrayInternalId++)
+};
},
- componentDidMount: function () {
-var el = ReactDOM.findDOMNode(this.refs["copy-text-" +
this.props.uniqueKey]);
-this.clipboard = new ZeroClipboard(el);
-this.clipboard.on('ready', function () {
- this.clipboard.on('copy', function () {
-this.props.onClipBoardClick();
- }.bind(
[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653979
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -14,180 +14,126 @@ import app from "../../app";
import FauxtonAPI from "../../core/api";
import React from "react";
import ReactDOM from "react-dom";
-import ZeroClipboard from "zeroclipboard";
import { Modal } from "react-bootstrap";
import "velocity-animate/velocity";
import "velocity-animate/velocity.ui";
-import "zeroclipboard/dist/ZeroClipboard.swf";
-
-function getZeroClipboardSwfPath () {
- return './dashboard.assets/ZeroClipboard.swf';
-}
-
-// super basic right now, but can be expanded later to handle all the
varieties of copy-to-clipboards
-// (target content element, custom label, classes, notifications, etc.)
-var Clipboard = React.createClass({
- propTypes: function () {
-return {
- text: React.PropTypes.string.isRequired,
- displayType: React.PropTypes.string.oneOf(['icon', 'text'])
-};
- },
+// formats a block of code and pretty-prints it in the page. Currently
uses the prettyPrint plugin
+var CodeFormat = React.createClass({
getDefaultProps: function () {
return {
- displayType: 'icon',
- textDisplay: 'Copy',
- onClipboardClick: function () { },
- title: 'Copy to clipboard'
+ lang: "js"
};
},
- componentWillMount: function () {
-ZeroClipboard.config({ swfPath: getZeroClipboardSwfPath() });
- },
+ getClasses: function () {
+// added for forward compatibility. This component defines an api via
it's props so you can pass lang="N" and
+// not the class that prettyprint requires for that lang. If (when,
hopefully!) we drop prettyprint we won't
+// have any change this component's props API and break things
+var classMap = {
+ js: 'lang-js'
+};
- getClipboardElement: function () {
-if (this.props.displayType === 'icon') {
- return ();
+var classNames = 'prettyprint';
+if (_.has(classMap, this.props.lang)) {
+ classNames += ' ' + classMap[this.props.lang];
}
-return this.props.textDisplay;
+return classNames;
},
componentDidMount: function () {
-var el = ReactDOM.findDOMNode(this);
- this.clipboard = new ZeroClipboard(el);
- this.clipboard.on('ready', function () {
-this.clipboard.on('copy', function () {
- this.props.onClipboardClick();
-}.bind(this));
- }.bind(this));
-
- this.clipboard.on('error', function (event) {
-console.log('ZeroClipboard error of type "' + event.name + '": ' +
event.message);
- });
- },
-
- onClick: function (event) {
-event.preventDefault();
+// this one function is all the lib offers. It parses the entire page
and pretty-prints anything with
+// a .prettyprint class; only executes on an element once
+prettyPrint();
},
render: function () {
+var code = JSON.stringify(this.props.code, null, " ");
return (
-
-{this.getClipboardElement()}
-
+ {code}
);
}
});
-// use like this:
-//
-//
-// pass in the text and a unique key, the key has to be unique or you'll
get a warning
-var ClipboardWithTextField = React.createClass({
+var _NextTrayInternalId = 0;
+var Tray = React.createClass({
+
propTypes: {
-onClipBoardClick: React.PropTypes.func.isRequired,
-textToCopy: React.PropTypes.string.isRequired,
-uniqueKey: React.PropTypes.string.isRequired,
-showCopyIcon: React.PropTypes.bool
+onAutoHide: React.PropTypes.func
},
getDefaultProps: function () {
return {
- showCopyIcon: true,
- text: 'Copy'
+ onAutoHide: function () { }
};
},
- componentWillMount: function () {
-ZeroClipboard.config({ swfPath: getZeroClipboardSwfPath() });
+ getInitialState: function () {
+return {
+ show: false,
+ internalid: (_NextTrayInternalId++)
+};
},
- componentDidMount: function () {
-var el = ReactDOM.findDOMNode(this.refs["copy-text-" +
this.props.uniqueKey]);
-this.clipboard = new ZeroClipboard(el);
-this.clipboard.on('ready', function () {
- this.clipboard.on('copy', function () {
-this.props.onClipBoardClick();
- }.bind(
[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653495
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -14,180 +14,126 @@ import app from "../../app";
import FauxtonAPI from "../../core/api";
import React from "react";
import ReactDOM from "react-dom";
-import ZeroClipboard from "zeroclipboard";
import { Modal } from "react-bootstrap";
import "velocity-animate/velocity";
import "velocity-animate/velocity.ui";
-import "zeroclipboard/dist/ZeroClipboard.swf";
-
-function getZeroClipboardSwfPath () {
- return './dashboard.assets/ZeroClipboard.swf';
-}
-
-// super basic right now, but can be expanded later to handle all the
varieties of copy-to-clipboards
-// (target content element, custom label, classes, notifications, etc.)
-var Clipboard = React.createClass({
- propTypes: function () {
-return {
- text: React.PropTypes.string.isRequired,
- displayType: React.PropTypes.string.oneOf(['icon', 'text'])
-};
- },
+// formats a block of code and pretty-prints it in the page. Currently
uses the prettyPrint plugin
+var CodeFormat = React.createClass({
getDefaultProps: function () {
return {
- displayType: 'icon',
- textDisplay: 'Copy',
- onClipboardClick: function () { },
- title: 'Copy to clipboard'
+ lang: "js"
};
},
- componentWillMount: function () {
-ZeroClipboard.config({ swfPath: getZeroClipboardSwfPath() });
- },
+ getClasses: function () {
+// added for forward compatibility. This component defines an api via
it's props so you can pass lang="N" and
+// not the class that prettyprint requires for that lang. If (when,
hopefully!) we drop prettyprint we won't
+// have any change this component's props API and break things
+var classMap = {
+ js: 'lang-js'
+};
- getClipboardElement: function () {
-if (this.props.displayType === 'icon') {
- return ();
+var classNames = 'prettyprint';
+if (_.has(classMap, this.props.lang)) {
+ classNames += ' ' + classMap[this.props.lang];
}
-return this.props.textDisplay;
+return classNames;
},
componentDidMount: function () {
-var el = ReactDOM.findDOMNode(this);
- this.clipboard = new ZeroClipboard(el);
- this.clipboard.on('ready', function () {
-this.clipboard.on('copy', function () {
- this.props.onClipboardClick();
-}.bind(this));
- }.bind(this));
-
- this.clipboard.on('error', function (event) {
-console.log('ZeroClipboard error of type "' + event.name + '": ' +
event.message);
- });
- },
-
- onClick: function (event) {
-event.preventDefault();
+// this one function is all the lib offers. It parses the entire page
and pretty-prints anything with
+// a .prettyprint class; only executes on an element once
+prettyPrint();
},
render: function () {
+var code = JSON.stringify(this.props.code, null, " ");
--- End diff --
const
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93653242
--- Diff: app/addons/fauxton/assets/less/components.less ---
@@ -44,6 +40,7 @@
}
-a.clipboard-copy-element:hover {
- text-decoration: none;
-}
+button.clipboard-copy-element {
+ background: transparent;
+ border: 0;
+}
--- End diff --
trailing whitespace at EOF missing
you can set your editor to automatically add them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #825: 3192 - Rip and replace zeroclipboard with...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/825#discussion_r93654957
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -14,180 +14,126 @@ import app from "../../app";
import FauxtonAPI from "../../core/api";
import React from "react";
import ReactDOM from "react-dom";
-import ZeroClipboard from "zeroclipboard";
import { Modal } from "react-bootstrap";
import "velocity-animate/velocity";
import "velocity-animate/velocity.ui";
-import "zeroclipboard/dist/ZeroClipboard.swf";
-
-function getZeroClipboardSwfPath () {
- return './dashboard.assets/ZeroClipboard.swf';
-}
-
-// super basic right now, but can be expanded later to handle all the
varieties of copy-to-clipboards
-// (target content element, custom label, classes, notifications, etc.)
-var Clipboard = React.createClass({
- propTypes: function () {
-return {
- text: React.PropTypes.string.isRequired,
- displayType: React.PropTypes.string.oneOf(['icon', 'text'])
-};
- },
+// formats a block of code and pretty-prints it in the page. Currently
uses the prettyPrint plugin
+var CodeFormat = React.createClass({
getDefaultProps: function () {
return {
- displayType: 'icon',
- textDisplay: 'Copy',
- onClipboardClick: function () { },
- title: 'Copy to clipboard'
+ lang: "js"
};
},
- componentWillMount: function () {
-ZeroClipboard.config({ swfPath: getZeroClipboardSwfPath() });
- },
+ getClasses: function () {
+// added for forward compatibility. This component defines an api via
it's props so you can pass lang="N" and
+// not the class that prettyprint requires for that lang. If (when,
hopefully!) we drop prettyprint we won't
+// have any change this component's props API and break things
+var classMap = {
+ js: 'lang-js'
+};
- getClipboardElement: function () {
-if (this.props.displayType === 'icon') {
- return ();
+var classNames = 'prettyprint';
+if (_.has(classMap, this.props.lang)) {
+ classNames += ' ' + classMap[this.props.lang];
}
-return this.props.textDisplay;
+return classNames;
},
componentDidMount: function () {
-var el = ReactDOM.findDOMNode(this);
- this.clipboard = new ZeroClipboard(el);
- this.clipboard.on('ready', function () {
-this.clipboard.on('copy', function () {
- this.props.onClipboardClick();
-}.bind(this));
- }.bind(this));
-
- this.clipboard.on('error', function (event) {
-console.log('ZeroClipboard error of type "' + event.name + '": ' +
event.message);
- });
- },
-
- onClick: function (event) {
-event.preventDefault();
+// this one function is all the lib offers. It parses the entire page
and pretty-prints anything with
+// a .prettyprint class; only executes on an element once
+prettyPrint();
},
render: function () {
+var code = JSON.stringify(this.props.code, null, " ");
return (
-
-{this.getClipboardElement()}
-
+ {code}
);
}
});
-// use like this:
-//
-//
-// pass in the text and a unique key, the key has to be unique or you'll
get a warning
-var ClipboardWithTextField = React.createClass({
+var _NextTrayInternalId = 0;
+var Tray = React.createClass({
--- End diff --
tray? i think this is deleted code? maybe from a wrongly resolved conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #824: Replication: hotfix url parsing for inval...
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/824 Replication: hotfix url parsing for invalid urls See COUCHDB-3257: sometimes the replicator returns invalid urls which are not encoded. This makes standard conforming url parsers choke. This catches the exception, with the tradeoff of displaying the password in the cases where the url is invalid. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton fix-url-replicator Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/824.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #824 commit f3739e11e782dba9bae1d239461262ad8f603e2f Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-12-16T13:27:35Z Replication: hotfix url parsing for invalid urls See COUCHDB-3257: sometimes the replicator returns invalid urls which are not encoded. This makes standard conforming url parsers choke. This catches the exception, with the tradeoff of displaying the password in the cases where the url is invalid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #822: Redux: update & fix
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/822 green! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #822: Redux: update & fix
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/822 Redux: update & fix `getReducers` is mostly covered by our other tests. no additional test coverage as we would need to build a separate build process (one without permissions) to test, so the cost for the test is to high in relation to the usefulness. You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton redux-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/822.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #822 commit ce50dccd9f123084e1757423970db05d312853a2 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-12-14T14:15:06Z don't throw if permissions addon isn't loaded commit 664d54bcdb0e3ac173f8a32577302b50af1869fa Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-12-14T14:15:28Z update redux --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #818: Add / Use Redux
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/818 merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #818: Add / Use Redux
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/818 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #818: Add / Use Redux
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/818 got a second thumbs up from garren via chat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #818: Add / Use Redux
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/818 @garrensmith added the Selenium test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #821: some improvements to the new reactify setup
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/821 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #820: Reactify
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/820 merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #820: Reactify
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/820 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #820: Reactify
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91296286
--- Diff: app/core/router.js ---
@@ -48,32 +49,35 @@ export default Backbone.Router.extend({
},
addModuleRouteObject: function (RouteObject) {
-var that = this;
-var masterLayout = FauxtonAPI.masterLayout,
-routeUrls = RouteObject.prototype.getRouteUrls();
+const that = this;
+const routeUrls = RouteObject.prototype.getRouteUrls();
-_.each(routeUrls, function (route) {
- this.route(route, route.toString(), function () {
-var args = Array.prototype.slice.call(arguments),
-roles = RouteObject.prototype.getRouteRoles(route),
-authPromise = FauxtonAPI.auth.checkAccess(roles);
+routeUrls.forEach(route => {
+ this.route(route, route.toString(), (...args) => {
+//const args = Array.prototype.slice.call(arguments),
--- End diff --
delete comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #820: Reactify
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91296234
--- Diff: app/core/routeObject.js ---
@@ -14,325 +14,46 @@ import FauxtonAPI from "./base";
import React from "react";
import ReactDOM from "react-dom";
import Backbone from "backbone";
+import _ from "lodash";
var RouteObject = function (options) {
this._options = options;
this.reactComponents = {};
this._configure(options || {});
this.initialize.apply(this, arguments);
- this.addEvents();
-};
-
-var broadcaster = {};
-_.extend(broadcaster, Backbone.Events);
-
-RouteObject.on = function (eventName, fn) {
- broadcaster.on(eventName, fn);
};
/* How Route Object events work
- To listen to a specific route objects events:
-
- myRouteObject = FauxtonAPI.RouteObject.extend({
- events: {
-"beforeRender": "beforeRenderEvent"
- },
-
- beforeRenderEvent: function (view, selector) {
-console.log('Hey, beforeRenderEvent triggered',arguments);
- },
- });
-
- It is also possible to listen to events triggered from all Routeobjects.
- This is great for more general things like adding loaders, hooks.
-
- FauxtonAPI.RouteObject.on('beforeRender', function (routeObject, view,
selector) {
-console.log('hey, this will trigger when any routeobject renders a
view');
- });
- Current Events to subscribe to:
- * beforeFullRender -- before a full render is being done
- * beforeEstablish -- before the routeobject calls establish
- * afterEstablish -- after the routeobject has run establish
- * beforeRender -- before a view is rendered
- * afterRender -- a view is finished being rendered
- * renderComplete -- all rendering is complete
+Its now very simple. We don't want it to do much. It creates a list of
routes. Then each route callback must return
+a React component that will be rendered into the app
*/
// Piggy-back on Backbone's self-propagating extend function
RouteObject.extend = Backbone.Model.extend;
-var routeObjectOptions = ["views", "routes", "events", "roles", "crumbs",
"layout", "apiUrl", "establish"];
+var routeObjectOptions = ["routes", "roles"];
-_.extend(RouteObject.prototype, Backbone.Events, {
+_.extend(RouteObject.prototype, {
// Should these be default vals or empty funcs?
- views: {},
routes: {},
- events: {},
- crumbs: [],
- layout: "empty",
- apiUrl: null,
- hideNotificationPanel: null,
- loaderClassname: 'loader',
- renderedState: false,
- establish: function () {},
route: function () {},
roles: [],
- _promises: [],
initialize: function () {}
}, {
- renderWith: function (route, masterLayout, args) {
-
-// set the options for this render
-var options = {
- masterLayout: masterLayout,
- route: route,
- args: args
-};
-
-var promiseLayout = this.setTemplateOnFullRender(masterLayout);
-
-this.triggerBroadcast('beforeEstablish');
-
-var renderAllViews = _.bind(this.renderAllViews, this, options),
-establishError = _.bind(this.establishError, this),
-renderComplete = _.bind(this.renderComplete, this),
-callEstablish = _.bind(this.callEstablish, this),
-renderReactComponents = _.bind(this.renderReactComponents, this);
-
-const promise = this.establish();
-
-// Only start the view rendering process once the template has been
rendered
-// otherwise we get double renders
-promiseLayout.then(function () {
- renderReactComponents();
-
- callEstablish(promise)
-.then(renderAllViews, establishError)
-.then(renderComplete, (err) => {
- console.error('renderpipeline broke');
- console.error('check your establish method');
-
- console.log(this.establish.toString());
- console.error(err);
-});
-
-
-}.bind(this));
- },
-
- setTemplateOnFullRender: function (masterLayout) {
-
-var promise = $.Deferred();
-
-// Only want to redo the template if its a full render
-if (!this.renderedState) {
- this.triggerBroadcast('beforeFullRender');
- masterLayout.setTemplate(this.layout).then(promise.resolve,
promise.reject);
-} else {
- promise.resolve();
-}
-
-return promise;
- },
[GitHub] couchdb-fauxton pull request #820: Reactify
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91295992
--- Diff: app/addons/fauxton/navigation/tests/componentsSpec.react.jsx ---
@@ -19,26 +19,18 @@ import React from "react";
import ReactDOM from "react-dom";
import TestUtils from "react-addons-test-utils";
import sinon from "sinon";
+import {mount} from 'enzyme';
var assert = utils.assert;
describe('NavBar', function () {
describe('burger', function () {
-var container, burgerEl, toggleMenu;
-
-beforeEach(function () {
- toggleMenu = sinon.spy();
- container = document.createElement('div');
- burgerEl = TestUtils.renderIntoDocument(, container);
-});
-
-afterEach(function () {
- ReactDOM.unmountComponentAtNode(container);
-});
-
it('dispatch TOGGLE_NAVBAR_MENU on click', function () {
- TestUtils.Simulate.click(ReactDOM.findDOMNode(burgerEl));
+ const toggleMenu = sinon.spy();
+ const burgerEl = mount();
+ burgerEl.simulate('click');
+ //TestUtils.Simulate.click(ReactDOM.findDOMNode(burgerEl));
--- End diff --
delete
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #820: Reactify
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/820#discussion_r91296455
--- Diff: assets/index.underscore ---
@@ -47,23 +47,11 @@
-
-
-
-
-
-
-
-
-
+
- <% if (development) {%>
-
- <%}%>
-
--- End diff --
finally! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #818: RFC: Redux
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/818 RFC: Redux Here is my latest Redux work. It integrated redux into Fauxton and gets rid of the old Backbone.js Models Highlights: - Redux - Bluebird for Promises (goodbye jQuery deferreds) - Jest Testing - WHATWG fetch API - 1 file per component - Goodbye Backbone Collections and Models You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton redux Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/818.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #818 commit 3a190697bdef0139015f188c3b4ed9a1425f6153 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-03T14:09:51Z redux commit f698f37d933f2a331b498c7931bedf209131cc1f Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-22T23:01:50Z code drop commit 7dbe0fe47da25f35ace52b457948f695915bc8c5 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-25T14:46:48Z weip commit f3e316924db8dca21f7fe7e38658c689efbc5b54 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-29T18:32:35Z jest whoop commit 35eef5f273d102c7c0db277ac11a3a1e49c3d097 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-30T19:28:33Z quick cleanup commit 8fd449b8c4c9e1a8d20e361538a266a2c86e84db Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-30T19:31:08Z fix permissions commit a0512a48bf87132723c70b1992e1989777f13f66 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-30T19:44:03Z no promise needed commit ffbb86b60be434273dd971ac2ca9cb785f4c556d Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-12-01T14:23:13Z wip: fix issue with inconsistent results from api commit b6a4c0d6322eba91f77083fa85497d3630e06210 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-12-05T17:32:34Z cleanup, refactor & redux rendering commit 73de7ea0ba2e831376b062f60beaff934bb2af4c Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-12-05T17:36:17Z more cleanup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #817: Fix two small issues
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/817 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #91: clarify $db/_security section
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-documentation/pull/91 clarify $db/_security section - point out that values are optional - add curl example - language fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-documentation security Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/91.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #91 commit fcc3b52029a4bee8be15b9622867c5a9135306ac Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-12-01T02:08:08Z clarify $db/_security section - point out that values are optional - add curl example - language fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #81: Document stable and update query parameters
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/81 thank you will, merged as fec0893 you can close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #84: Fixing type error
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/84 merged as c58e360 -- you can close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #81: Document stable and update query parameters
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/81 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #84: Fixing type error
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/84 +1 thank you ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #85: Tiny 127 address fix
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/85 merged as 77b5d1d - thanks! please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #86: More command cleanup
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/86 merged as 4810d1c631728b0cf8fecedf7fa289ba9bc78304 please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #86: More command cleanup
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/86 LGTM, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #87: Fixed the transposition of the version or e...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/87 merged as 74da74bda7b4187f105cacaa848c7daaad19a179 you can close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #87: Fixed the transposition of the version or e...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/87 +1 thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/815 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #815: tests: add jest for testing
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/815 merged, thank you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #816: Another attempt at stabilising the replication t...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/816 merged as 57ad61ab20cd3aa9d71eea334ea27e37a0163a4f --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #816: Another attempt at stabilising the replication t...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/816 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #816: Another attempt at stabilising the replication t...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/816 green, but travis bot not reporting: https://travis-ci.org/apache/couchdb-fauxton/builds/180102049 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/815#discussion_r90231323 --- Diff: app/addons/replication/__tests__/helpers-tests.js --- @@ -0,0 +1,34 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may not +// use this file except in compliance with the License. You may obtain a copy of --- End diff -- btw there will be also the folder `__mocks__` -- used by jest for mocking --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/815#discussion_r90230595 --- Diff: app/addons/replication/__tests__/helpers-tests.js --- @@ -0,0 +1,34 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may not +// use this file except in compliance with the License. You may obtain a copy of --- End diff -- hmmm... i like the new folder `__test__` -- it is jest standard and it separates the old system clearly from the new --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #812: remove doc_editor template
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/812 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #815: tests: add jest for testing
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/815 tests: add jest for testing Adds Jest for testing. Right now it runs in parallel to our old test setup. The idea is that we can use the faster, simpler testing for all new stuff and all refactored elements. To run jest, simply run: `npm run jest` You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton jest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/815.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #815 commit 33db8f714d14aef3f3bff331dd4294301251f3ee Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-29T17:30:01Z tests: add jest for testing This add Jest for testing. Right now it runs in parallel to our old test setup. The idea is that we can use the faster, simpler testing for all new stuff and all refactored elements. To run jest, simply run: `npm run jest` commit ac4255cfc7fcd3f9f6a79e19561217fed9a42a41 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-29T17:31:05Z tests: port helperSpec to jest our first jest based tests :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #812: remove doc_editor template
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/812 ð heavy clean up and great refactorings. thanks so much! found some code issue, haven't run the code locally yet. seems there is a conflict, too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #812: remove doc_editor template
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90052494
--- Diff: app/addons/config/layout.js ---
@@ -0,0 +1,97 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+import React from 'react';
+import FauxtonAPI from "../../core/api";
+import {TabsSidebarHeader} from '../documents/layouts';
+import ConfigComponents from "./components.react";
+import CORSComponents from "../cors/components.react";
+import {Breadcrumbs} from '../components/header-breadcrumbs';
+import {NotificationCenterButton} from
'../fauxton/notifications/notifications.react';
+import {ApiBarWrapper} from '../components/layouts';
+
+// const sidebarItems = [
+// {
+// title: 'Main config',
+// typeSelect: 'main',
+// link: '_config/' + node
+// },
+// {
+// title: 'CORS',
+// typeSelect: 'cors',
+// link: '_config/' + node + '/cors'
+// }
+// ];
--- End diff --
remove?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #812: remove doc_editor template
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90052964
--- Diff: app/addons/documents/routes-documents.js ---
@@ -55,46 +49,39 @@ var DocumentsRouteObject = BaseRoute.extend({
this.initViews(options[0]);
},
- establish: function () {
-return [
- this.designDocs.fetch({ reset: true })
-];
- },
--- End diff --
<3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #812: remove doc_editor template
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053583
--- Diff: app/addons/fauxton/components.js ---
@@ -26,163 +26,163 @@ var Components = FauxtonAPI.addon();
* - showTray
* - toggleTray
*/
-Components.Tray = FauxtonAPI.View.extend({
-
- // populated dynamically
- events: {},
-
- initTray: function (opts) {
-this.toggleTrayBtnSelector = (_.has(opts, 'toggleTrayBtnSelector')) ?
opts.toggleTrayBtnSelector : null;
-this.onShowTray = (_.has(opts, 'onShowTray')) ? opts.onShowTray : null;
-
-// if the component extending this one passed along the selector of
the element that toggles the tray,
-// add the appropriate events
-if (!_.isNull(this.toggleTrayBtnSelector)) {
- this.events['click ' + this.toggleTrayBtnSelector] = 'toggleTray';
-}
-
-_.bind(this.toggleTray, this);
-_.bind(this.trayVisible, this);
-_.bind(this.hideTray, this);
-_.bind(this.showTray, this);
-
-// a unique identifier for this tray
-this.trayId = 'tray-' + this.cid;
-
-var that = this;
-$('body').on('click.' + this.trayId, function (e) {
- var $clickEl = $(e.target);
-
- if (!that.trayVisible()) {
-return;
- }
- if (!_.isNull(that.toggleTrayBtnSelector) &&
$clickEl.closest(that.toggleTrayBtnSelector).length) {
-return;
- }
- if (!$clickEl.closest('.tray').length) {
-that.hideTray();
- }
-});
-
-FauxtonAPI.Events.on(FauxtonAPI.constants.EVENTS.TRAY_OPENED,
this.onTrayOpenEvent, this);
- },
-
- cleanup: function () {
-$('body').off('click.' + this.trayId);
- },
-
- // all trays publish a EVENTS.TRAY_OPENED event containing their unique
ID. This listens for those events and
- // closes the current tray if it's already open
- onTrayOpenEvent: function (msg) {
-if (!_.has(msg, 'trayId')) {
- return;
-}
-if (msg.trayId !== this.trayId && this.trayVisible()) {
- this.hideTray();
-}
- },
-
- toggleTray: function (e) {
-e.preventDefault();
-
-if (this.trayVisible()) {
- this.hideTray();
-} else {
- this.showTray();
-}
- },
-
- hideTray: function () {
-var $tray = this.$('.tray');
-$tray.velocity('reverse', FauxtonAPI.constants.MISC.TRAY_TOGGLE_SPEED,
function () {
- $tray.hide();
-});
-
-if (!_.isNull(this.toggleTrayBtnSelector)) {
- this.$(this.toggleTrayBtnSelector).removeClass('enabled');
-}
- },
-
- showTray: function () {
-this.$('.tray').velocity('transition.slideDownIn',
FauxtonAPI.constants.MISC.TRAY_TOGGLE_SPEED);
-if (!_.isNull(this.toggleTrayBtnSelector)) {
- this.$(this.toggleTrayBtnSelector).addClass('enabled');
-}
-
-if (!_.isNull(this.onShowTray)) {
- this.onShowTray();
-}
-
-FauxtonAPI.Events.trigger(FauxtonAPI.constants.EVENTS.TRAY_OPENED, {
trayId: this.trayId });
- },
-
- trayVisible: function () {
-return this.$('.tray').is(':visible');
- }
-});
-
-Components.Typeahead = FauxtonAPI.View.extend({
-
- initialize: function (options) {
-this.source = options.source;
-this.onUpdateEventName = options.onUpdateEventName;
- },
-
- afterRender: function () {
-var onUpdateEventName = this.onUpdateEventName;
-
-this.$el.typeahead({
- source: this.source,
- updater: function (item) {
-FauxtonAPI.Events.trigger(onUpdateEventName, item);
-return item;
- }
-});
- }
-});
-
-Components.DbSearchTypeahead = Components.Typeahead.extend({
- initialize: function (options) {
-this.dbLimit = options.dbLimit || 30;
-if (options.filter) {
- this.resultFilter = options.resultFilter;
-}
-_.bindAll(this);
- },
-
- getURL: function (query, dbLimit) {
-query = encodeURIComponent(query);
-return [
- app.host,
- "/_all_dbs?startkey=%22",
- query,
- "%22=%22",
- query,
- encodeURIComponent("\u"),
- "%22=",
- dbLimit
-].join('');
- },
-
- source: function (query, process) {
-var url = this.getURL(query, this.dbLimit);
-var resultFilter = this.resultFilter;
-
-if (this.ajaxReq) { this.ajaxReq.abort(); }
-
-this.ajaxReq = $.ajax({
- cache: false,
- url: url,
-
[GitHub] couchdb-fauxton pull request #812: remove doc_editor template
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90052264 --- Diff: app/addons/components/assets/less/layouts.less --- @@ -19,3 +19,11 @@ flex-direction: row; height: 100%; } + +//yes !important!!! We have to overridde some styles I can't override any other way for now --- End diff -- wait a second... this css overrides it globally everywhere. why do we need to override then - instead of replacing the old CSS? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #812: remove doc_editor template
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053429
--- Diff: app/addons/fauxton/base.js ---
@@ -32,38 +32,6 @@ Fauxton.initialize = function () {
FauxtonAPI.RouteObject.on('beforeEstablish', function (routeObject) {
NavigationActions.setNavbarActiveLink(_.result(routeObject,
'selectedHeader'));
-
-if (!routeObject.hideApiBar) {
-// always attempt to render the API Bar. Even if it's hidden on
initial load, it may be enabled later
- routeObject.setComponent('#api-navbar',
ReactComponents.ApiBarController, {
-buttonVisible: true,
-contentVisible: false
- });
-
- const apiAndDocs = routeObject.get('apiUrl');
- if (apiAndDocs) {
-ComponentActions.updateAPIBar({
- buttonVisible: true,
- contentVisible: false,
- endpoint: apiAndDocs[0],
- docURL: apiAndDocs[1]
-});
- } else {
-ComponentActions.hideAPIBarButton();
- }
-}
-
-if (!routeObject.get('hideNotificationCenter')) {
- routeObject.setComponent('#notification-center-btn',
NotificationComponents.NotificationCenterButton);
-}
-
-const crumbs = routeObject.get('crumbs');
-
-if (!crumbs.length) {
- return;
-}
-
-routeObject.setComponent('#breadcrumbs', Breadcrumbs, {crumbs:
crumbs});
--- End diff --
haha :) ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #812: remove doc_editor template
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053369
--- Diff: app/addons/documents/shared-routes.js ---
@@ -88,13 +80,13 @@ var BaseRoute = FauxtonAPI.RouteObject.extend({
];
},
- ddocInfo: function (designDoc, designDocs, view) {
-return {
- id: "_design/" + designDoc,
- currView: view,
- designDocs: designDocs
-};
- },
+ // ddocInfo: function (designDoc, designDocs, view) {
+ // return {
+ // id: "_design/" + designDoc,
+ // currView: view,
+ // designDocs: designDocs
+ // };
+ // },
--- End diff --
huh?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #812: remove doc_editor template
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/812#discussion_r90053096
--- Diff: app/addons/documents/routes-documents.js ---
@@ -55,46 +49,39 @@ var DocumentsRouteObject = BaseRoute.extend({
this.initViews(options[0]);
},
- establish: function () {
-return [
- this.designDocs.fetch({ reset: true })
-];
- },
-
initViews: function (dbName) {
this.databaseName = dbName;
this.database = new Databases.Model({id: this.databaseName});
this.createDesignDocsCollection();
-this.setComponent("#right-header", RightAllDocsHeader, {
- database: this.database
-});
-
-this.addLeftHeader();
this.addSidebar();
},
designDocMetadata: function (database, ddoc) {
-this.removeComponent('#footer');
-this.removeComponent('#react-headerbar');
-this.removeComponent('#dashboard-upper-content');
-
var designDocInfo = new Resources.DdocInfo({ _id: "_design/" + ddoc },
{ database: this.database });
DesignDocInfoActions.fetchDesignDocInfo({
ddocName: ddoc,
designDocInfo: designDocInfo
});
-this.setComponent("#dashboard-lower-content",
DesignDocInfoComponents.DesignDocInfo);
SidebarActions.selectNavItem('designDoc', {
designDocName: ddoc,
designDocSection: 'metadata'
});
QueryOptionsActions.hideQueryOptions();
-
-this.apiUrl = [designDocInfo.url('apiurl'),
designDocInfo.documentation()];
+this.apiUrl = [, designDocInfo.documentation()];
--- End diff --
`[, designDocInfo.documentation()];` => typo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #808: Handle trailing params when building URLs for vi...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/808 @millayr thank you. you can close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #814: add more tests to replication activity
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/814 +1 when green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #813: encodeding url path for database name with speci...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/813 you can close the PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #813: encodeding url path for database name with speci...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/813 merged as e53deb5d90fa7d6751bb753415dda5274a2b2cb5 and 1aa4ca6f34a718c294a06a1301f39fe05f157a1c thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #813: encodeding url path for database name with speci...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/813 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #813: encodeding url path for database name wit...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/813#discussion_r89625412
--- Diff: app/addons/databases/tests/nightwatch/specialCharListLinks.js ---
@@ -18,16 +18,15 @@ const testDatabases = [
't/t-//t_f'
];
-const tests = {};
-
-testDatabases.forEach((db) => {
- return tests[`Db List works with special chars ${db}`] = createTest(db);
-});
+const tests = testDatabases.reduce((tests, db) => {
+ tests[`Db List works with special chars ${db}`] = createTest(db);
+ return tests;
+}, {});
--- End diff --
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #814: add more tests to replication activity
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/814#discussion_r90013925
--- Diff: app/addons/replication/tests/nightwatch/replicationactivity.js ---
@@ -32,18 +32,67 @@ module.exports = {
.url(baseUrl + '/#replication')
.waitForElementNotPresent('.load-lines', waitTime, true)
.waitForElementPresent('.replication__filter', waitTime, true)
- .click('a[title="Delete document existing-doc-id-2"]')
- .waitForElementPresent('.replication_delete-doc-modal', waitTime,
true)
- .click('.replication_delete-doc-modal button.save')
- .waitForElementNotPresent('.replication_delete-doc-modal', waitTime,
true)
- .waitForElementPresent('.global-notification .fonticon-cancel',
waitTime, false)
+ .click('a[href="#/database/_replicator/existing-doc-id-view-doc"]')
--- End diff --
change to `clickWhenVisible`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #814: add more tests to replication activity
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/814#discussion_r90013882
--- Diff: app/addons/replication/tests/nightwatch/replicationactivity.js ---
@@ -32,18 +32,67 @@ module.exports = {
.url(baseUrl + '/#replication')
.waitForElementNotPresent('.load-lines', waitTime, true)
.waitForElementPresent('.replication__filter', waitTime, true)
- .click('a[title="Delete document existing-doc-id-2"]')
- .waitForElementPresent('.replication_delete-doc-modal', waitTime,
true)
- .click('.replication_delete-doc-modal button.save')
- .waitForElementNotPresent('.replication_delete-doc-modal', waitTime,
true)
- .waitForElementPresent('.global-notification .fonticon-cancel',
waitTime, false)
+ .click('a[href="#/database/_replicator/existing-doc-id-view-doc"]')
+ .waitForElementNotPresent('.load-lines', waitTime, true)
+ .waitForElementPresent('#editor-container', waitTime, true)
+ .end();
+ },
+
+ 'Can edit doc': client => {
+const waitTime = client.globals.maxWaitTime;
+const baseUrl = client.globals.test_settings.launch_url;
+const password = client.globals.test_settings.password;
+
+const replicatorDoc = {
+ _id: 'existing-doc-id-edit-doc',
+ source: "http://source-db.com;,
+ target: "http://target-db.com;
+};
+client
+ .deleteDatabase('_replicator')
+ .createDatabase('_replicator')
+ .createDocument(replicatorDoc._id, '_replicator', replicatorDoc)
+ .loginToGUI()
+ .waitForElementNotPresent('.global-notification .fonticon-cancel',
waitTime, false)
+ .url(baseUrl + '/#replication')
+ .waitForElementNotPresent('.load-lines', waitTime, true)
+ .waitForElementPresent('.replication__filter', waitTime, true)
+ .click('a[title="Edit replication"]')
--- End diff --
change to `clickWhenVisible`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #808: Handle trailing params when building URLs for vi...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #810: Remove one pane
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/810 +1, merge it after removing the user/pass from the script :) ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #810: Remove one pane
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/810#discussion_r88891378 --- Diff: bin/create-animal-db --- @@ -16,7 +16,7 @@ // with conflicts for the zebra doc -const url = 'http://localhost:5984/'; +const url = 'http://tester:testerpass@localhost:5984/'; --- End diff -- debug issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #809: use latest docker
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/809 one test is failing: ``` â nightwatch/replicationactivity ``` is it flaky? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 @bebosudo you can close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 and landed as 2993ccb86f9ec685a183807a54f044d42fb18592 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 eh typo, i was wanting to say: "i was also super excited when i sent my first PRs. for most people it is exciting and it can be unpleasant." -- edited the comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 @bebosudo just saw your question. some parts of the docs are still outdated or even incomplete. it was a tradeoff, we had to ship 2.0 at some point. (with a 2 year delay) if you have time and enjoy contributing -- your contributions are always welcome! :) I'm waiting for travis to get green and merge this patch afterwards. thanks again! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 no worries, you are doing great! :) btw: i was also super excited when i sent my first PRs. most people are and it can be unpleasent. i'm still excited for new big projects or major changes, but a little less than in the beginning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #89: Spelling error fix: fauxuton to fauxton.
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-documentation/pull/89 awesome, thank you! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #802: COUCHDB-3224: Fixed view displaying for database...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 @sergey-safarov the PR looks good, it will be superseeded by https://github.com/apache/couchdb-fauxton/pull/807 which contains more fixes and changes our integration tests to default to database names with special chars. your commit will land seperately together with the other commits :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #807: Couchdb 3224
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/807 Couchdb 3224 You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton COUCHDB-3224 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/807.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #807 commit 4017154f096e99baf062cf4ca85d4a726b681d16 Author: Sergey Safarov <s.safa...@gmail.com> Date: 2016-11-06T10:04:42Z COUCHDB-3224: Fixed view displaying for database with "/" symbols in name commit cb3d45d86f98fcdda33ff18ba744624eb416bff0 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-15T15:59:43Z fix sidebar for databases with special chars COUCHDB-3229 commit fb30344302f199fdd06634c23b5be0c7bcaef427 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-15T16:04:19Z wip commit 2096dae28f13d149736ecd10acb1c3f524135c07 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-15T16:12:28Z fix issue for breadcrumbs and encoded db names COUCHDB-3146 commit 357180db7dbfa535f2a02ac62011e55ebe985a57 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-15T16:13:07Z encoding: fix cancel button in doc editor commit 0cf4b7485b2026f3af1eb142fb539bdd2e24671b Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-15T16:17:06Z tests: seed databases with slash in name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 wow @garrensmith and @justin-mcdavid-ibm that is really cool stuff i am super excited --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 +1 after fixing the typo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 update: discussed with garren, the validation shoudl happen on the serverside. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 https://cloud.githubusercontent.com/assets/298166/20309147/28b87920-ab47-11e6-8fcc-bcd9cf9aa2dd.png;> typo: Replcator DB Activity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 when i forget to add a database name to the url, it will still accept the url: remote target: ``` https://mypassw...@rockoartischocko.cloudant.com ``` expected: error that i have to specify a database name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #806: db-list: expose elements to make them reusable
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/806 merged :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #806: db-list: expose elements to make them reu...
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #806: db-list: expose elements to make them reusable
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/806 no tests, as already covered and no functionality was changed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #806: db-list: expose elements to make them reu...
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/806 db-list: expose elements to make them reusable You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton expose Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/806.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #806 commit 1566ede59c58fb8c1a4a363469ee9fbcac6f2f6f Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-11T15:57:42Z db-list: expose elements to make them reusable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #802: COUCHDB-3224: Fixed view displaying for database...
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/802 hey, thank you for your contribution -- i was on vacation, i'll check next week! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 issue 1 1) take a cloudant accoutn and database 2) put your cloudant account into the url field, e.g. "https://foo:b...@example.com/mydatabase 3) select target: local database enter name 4) click replicate 5) enter password 6) nothing happens - expected "password is wrong message" 7) i'm quite sure my password is right?  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #761: New replication
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87580975
--- Diff: app/addons/auth/components.react.jsx ---
@@ -302,9 +305,87 @@ var CreateAdminSidebar = React.createClass({
}
});
+
+class PasswordModal extends React.Component {
+ constructor (props) {
+super(props);
+this.state = {
+ password: ''
+};
+this.authenticate = this.authenticate.bind(this);
+this.onKeyPress = this.onKeyPress.bind(this);
+ }
+
+ // clicking should submit the form
+ onKeyPress (e) {
+if (e.key === 'Enter') {
+ this.authenticate();
+}
+ }
+
+ // default authentication function. This can be overridden via props if
you want to do something different
+ authenticate () {
+const username = app.session.get('userCtx').name; // yuck. But
simplest for now until logging in publishes the user data
--- End diff --
agreed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #761: New replication
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581714
--- Diff: app/addons/replication/tests/controllerSpec.js ---
@@ -0,0 +1,27 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+import React from "react";
+import TestUtils from "react-addons-test-utils";
+import utils from "../../../../test/mocha/testUtils";
+import { mount } from 'enzyme';
+import sinon from "sinon";
+import Stores from '../stores';
+import Controller from '../controller';
+import Constants from '../constants';
+
+const store = Stores.replicationStore;
+const assert = utils.assert;
+
+describe('Replication Controller', () => {
+
+
+});
--- End diff --
i think this can get deleted. i think the controler is coverd by selenium
tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #761: New replication
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581592
--- Diff: test/dev.js ---
@@ -13,7 +13,7 @@
// This will search for files ending in .test.js and require them
// so that they are added to the webpack bundle
-var context = require.context('../app/', true, /[Ss]pec/);
+var context = require.context('../app/addons/replication', true,
/[Ss]pec/);
--- End diff --
debug issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #761: New replication
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87580932
--- Diff: app/addons/auth/actions.js ---
@@ -28,88 +28,130 @@ var errorHandler = function (xhr, type, msg) {
};
-export default {
+function login (username, password, urlBack) {
+ var promise = FauxtonAPI.session.login(username, password);
+
+ promise.then(() => {
+FauxtonAPI.addNotification({ msg: FauxtonAPI.session.messages.loggedIn
});
+if (urlBack) {
+ return FauxtonAPI.navigate(urlBack);
+}
+FauxtonAPI.navigate('/');
+ }, errorHandler);
+}
+
+function changePassword (password, passwordConfirm) {
+ var nodes = nodesStore.getNodes();
+ var promise = FauxtonAPI.session.changePassword(password,
passwordConfirm, nodes[0].node);
+
+ promise.then(() => {
+FauxtonAPI.addNotification({ msg:
FauxtonAPI.session.messages.changePassword });
+FauxtonAPI.dispatch({ type: ActionTypes.AUTH_CLEAR_CHANGE_PWD_FIELDS
});
+ }, errorHandler);
+}
+
+function updateChangePasswordField (value) {
+ FauxtonAPI.dispatch({
+type: ActionTypes.AUTH_UPDATE_CHANGE_PWD_FIELD,
+value: value
+ });
+}
+
+function updateChangePasswordConfirmField (value) {
+ FauxtonAPI.dispatch({
+type: ActionTypes.AUTH_UPDATE_CHANGE_PWD_CONFIRM_FIELD,
+value: value
+ });
+}
- login: function (username, password, urlBack) {
-var promise = FauxtonAPI.session.login(username, password);
+function createAdmin (username, password, loginAfter) {
+ var nodes = nodesStore.getNodes();
+ var promise = FauxtonAPI.session.createAdmin(username, password,
loginAfter, nodes[0].node);
-promise.then(function () {
- FauxtonAPI.addNotification({ msg:
FauxtonAPI.session.messages.loggedIn });
- if (urlBack) {
-return FauxtonAPI.navigate(urlBack);
- }
+ promise.then(() => {
+FauxtonAPI.addNotification({ msg:
FauxtonAPI.session.messages.adminCreated });
+if (loginAfter) {
FauxtonAPI.navigate('/');
+} else {
+ FauxtonAPI.dispatch({ type:
ActionTypes.AUTH_CLEAR_CREATE_ADMIN_FIELDS });
+}
+ }, (xhr, type, msg) => {
+msg = xhr;
+if (arguments.length === 3) {
+ msg = xhr.responseJSON.reason;
+}
+errorHandler(FauxtonAPI.session.messages.adminCreationFailedPrefix + '
' + msg);
+ });
+}
+
+// simple authentication method - does nothing other than check creds
+function authenticate (username, password, onSuccess) {
+ $.ajax({
+cache: false,
+type: 'POST',
+url: '/_session',
+dataType: 'json',
+data: { name: username, password: password }
+ }).then(() => {
+FauxtonAPI.dispatch({
+ type: ActionTypes.AUTH_CREDS_VALID,
+ options: { username: username, password: password }
});
-promise.fail(errorHandler);
- },
-
- changePassword: function (password, passwordConfirm) {
-var nodes = nodesStore.getNodes();
-var promise = FauxtonAPI.session.changePassword(password,
passwordConfirm, nodes[0].node);
-
-promise.done(function () {
- FauxtonAPI.addNotification({ msg:
FauxtonAPI.session.messages.changePassword });
- FauxtonAPI.dispatch({ type: ActionTypes.AUTH_CLEAR_CHANGE_PWD_FIELDS
});
+hidePasswordModal();
+onSuccess(username, password);
+ }, () => {
+FauxtonAPI.addNotification({
+ msg: 'Your password is incorrect.',
+ type: 'error',
+ clear: true
});
-
-promise.fail(errorHandler);
- },
-
- updateChangePasswordField: function (value) {
FauxtonAPI.dispatch({
- type: ActionTypes.AUTH_UPDATE_CHANGE_PWD_FIELD,
- value: value
+ type: ActionTypes.AUTH_CREDS_INVALID,
+ options: { username: username, password: password }
});
- },
+ });
+}
- updateChangePasswordConfirmField: function (value) {
-FauxtonAPI.dispatch({
- type: ActionTypes.AUTH_UPDATE_CHANGE_PWD_CONFIRM_FIELD,
- value: value
-});
- },
-
- createAdmin: function (username, password, loginAfter) {
-var nodes = nodesStore.getNodes();
-var promise = FauxtonAPI.session.createAdmin(username, password,
loginAfter, nodes[0].node);
-
-promise.then(function () {
- FauxtonAPI.addNotification({ msg:
FauxtonAPI.session.messages.adminCreated });
- if (loginAfter) {
-FauxtonAPI.navigate('/');
- } else {
-FauxtonAPI.dispatch({ type:
ActionTypes.AUTH_CLEAR_CREATE_ADMIN_FIELDS });
- }
-
[GitHub] couchdb-fauxton pull request #761: New replication
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581396
--- Diff: app/addons/replication/tests/helpersSpec.js ---
@@ -0,0 +1,41 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use this file except in compliance with the License. You may obtain a
copy of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+import utils from "../../../../test/mocha/testUtils";
+import helpers from '../helpers';
+const assert = utils.assert;
+
+describe('Replication Helpers', () => {
+
+ describe('getDatabaseLabel', () => {
+
+it('returns database name for string', () => {
+ const db = 'http://tester:testerpass@127.0.0.1/fancy/db/name';
+
+ const dbName = helpers.getDatabaseLabel(db);
+ assert.deepEqual('fancy/db/name', dbName);
+
+});
+
+it('returns database name for object', () => {
+ const db = {
+url: 'http://tester:testerpass@127.0.0.1/fancy'
+ };
+
+ const dbName = helpers.getDatabaseLabel(db);
+ assert.deepEqual('fancy', dbName);
+
+});
+
+ });
+
+});
--- End diff --
nice testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #761: New replication
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87581878
--- Diff: app/addons/replication/route.js ---
@@ -10,48 +10,67 @@
// License for the specific language governing permissions and limitations
under
// the License.
-import app from "../../app";
-import FauxtonAPI from "../../core/api";
-import Replication from "./resources";
-import Views from "./views";
-var RepRouteObject = FauxtonAPI.RouteObject.extend({
- layout: 'one_pane',
+import FauxtonAPI from '../../core/api';
+import ReplicationController from './controller';
+import ComponentActions from '../components/actions';
+
+const ReplicationRouteObject = FauxtonAPI.RouteObject.extend({
+ layout: 'empty',
+ hideNotificationCenter: true,
+ hideApiBar: true,
+
routes: {
-"replication": 'defaultView',
-"replication/:dbname": 'defaultView'
+'replication/create': 'defaultView',
+'replication/:dbname': 'defaultView',
--- End diff --
it looks like you can't edit a database with the name `create` using this
routing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #761: New replication
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/761#discussion_r87582534
--- Diff: app/addons/replication/assets/less/replication.less ---
@@ -11,187 +11,288 @@
// the License.
@import "../../../../../assets/less/variables.less";
+@import "../../../../../assets/less/mixins.less";
-#replication {
- position: relative;
- max-width: none;
- width: auto;
-
- .form_set {
-width: 350px;
-display: inline-block;
-border: 1px solid @greyBrownLighter;
-padding: 15px 10px 0;
-margin-bottom: 20px;
-&.middle {
- width: 100px;
- border: none;
- position: relative;
- height: 100px;
- margin: 0;
-}
-input, select {
- margin: 0 0 16px 5px;
- height: 40px;
- width: 318px;
-}
-.btn-group {
- margin: 0 0 16px 5px;
- .btn {
-padding: 10px 57px;
- }
-}
-&.local {
- .local_option {
-display: block;
- }
- .remote_option {
-display: none;
- }
- .local-btn {
-background-color: @brandPrimary;
-color: #fff;
- }
- .remote-btn {
-background-color: #f5f5f5;
-color: @fontGrey;
- }
-}
-.local_option {
- display: none;
-}
-.remote-btn {
- background-color: @brandPrimary;
- color: #fff;
-}
- }
+div.replication-page {
+ padding-top: 25px !important;
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+}
+.replication-section {
+ display: flex;
+ flex-flow: row wrap;
+ justify-content: flex-start;
+}
- .options {
-position: relative;
-&:after {
- content: '';
- display: block;
- position: absolute;
- right: -16px;
- top: 9px;
- width: 0;
- height: 0;
- border-left: 5px solid transparent;
- border-right: 5px solid transparent;
- border-bottom: 5px solid black;
- border-top: none;
-}
-&.off {
- &:after {
- content: '';
- display: block;
- position: absolute;
- right: -16px;
- top: 9px;
- width: 0;
- height: 0;
- border-left: 5px solid transparent;
- border-right: 5px solid transparent;
- border-bottom: none;
- border-top: 5px solid black;
- }
-}
- }
- .control-group {
-label {
- float: left;
- min-height: 30px;
- vertical-align: top;
- padding-right: 5px;
- min-width: 130px;
- padding-left: 0px;
-}
-input[type=radio],
-input[type=checkbox] {
- margin: 0 0 2px 0;
-}
- }
+.replication-seperator {
--- End diff --
wouldn't it be `.replication__seperator` or am i missing someting?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton issue #761: New replication
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 tests are red --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #789: 3045 Replace safeURLName in code
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/789 tests are red @millayr - can you see why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #801: databases: show data_size instead of disk...
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/801 databases: show data_size instead of disk_size return to old default You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton data-size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/801.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #801 commit 0290732965e873600f944fbc829147248482c7f3 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-04T15:03:48Z databases: show data_size instead of disk_size return to old default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #798: break react components into individual fi...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/798#discussion_r86404825
--- Diff: app/addons/components/tests/paddedBorderedBoxSpec.react.jsx ---
@@ -37,6 +37,7 @@ describe('PaddedBorderedBox', function () {
,
container
);
+console.log(container);
--- End diff --
debug output
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request #798: break react components into individual fi...
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/798#discussion_r86404908
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -10,1615 +10,46 @@
// License for the specific language governing permissions and limitations
under
// the License.
-import app from "../../app";
-import FauxtonAPI from "../../core/api";
-import React from "react";
-import ReactDOM from "react-dom";
-import Stores from "./stores";
-import Actions from "./actions";
-import FauxtonComponents from "../fauxton/components.react";
-import Helpers from "../documents/helpers";
-import beautifyHelper from "../../../assets/js/plugins/beautify";
-import {Modal, Popover, OverlayTrigger} from "react-bootstrap";
-import ReactCSSTransitionGroup from "react-addons-css-transition-group";
-import ace from "brace";
-
-const { componentStore } = Stores;
-
-var BadgeList = React.createClass({
-
- propTypes: {
-elements: React.PropTypes.array.isRequired,
-removeBadge: React.PropTypes.func.isRequired
- },
-
- getDefaultProps: function () {
-return {
- getLabel: function (el) {
-return el;
- },
-
- getId: function (el) {
-return el;
- }
-
-};
- },
-
- getBadges: function () {
-return this.props.elements.map(function (el, i) {
- return ;
-}.bind(this));
- },
-
- removeBadge: function (label, el) {
-this.props.removeBadge(label, el);
- },
-
- render: function () {
-return (
-
-{this.getBadges()}
-
-);
- }
-});
-
-var Badge = React.createClass({
- propTypes: {
-label: React.PropTypes.string.isRequired,
-remove: React.PropTypes.func.isRequired
- },
-
- remove: function (e) {
-e.preventDefault();
-this.props.remove(this.props.label, this.props.id);
- },
-
- render: function () {
-return (
-
-{this.props.label}
-
-
-
-
-);
- }
-});
-
-var ToggleHeaderButton = React.createClass({
- getDefaultProps: function () {
-return {
- innerClasses: '',
- fonticon: '',
- containerClasses: '',
- selected: false,
- title: '',
- disabled: false,
- toggleCallback: null,
- text: '',
- iconDefaultClass: 'icon'
-};
- },
-
- render: function () {
-const { iconDefaultClass, fonticon, innerClasses, selected,
containerClasses, title, disabled, text, toggleCallback } = this.props;
-const selectedBtnClass = (selected) ?
'js-headerbar-togglebutton-selected' : '';
-
-return (
-
-{text}
-
-);
- }
-});
-
-
-var BulkActionComponent = React.createClass({
-
- propTypes: {
-hasSelectedItem: React.PropTypes.bool.isRequired,
-removeItem: React.PropTypes.func.isRequired,
-selectAll: React.PropTypes.func,
-toggleSelect: React.PropTypes.func.isRequired,
-isChecked: React.PropTypes.bool.isRequired,
-disabled: React.PropTypes.bool
- },
-
- getDefaultProps: function () {
-return {
- disabled: false,
- title: 'Select rows that can be...',
- bulkIcon: 'fonticon-trash',
- buttonTitle: 'Delete all selected',
- dropdownContentText: 'Deleted',
- enableOverlay: false
-};
- },
-
- render: function () {
-return (
-
-
- {this.getMasterSelector()}
- {this.getMultiSelectOptions()}
-
-
-);
- },
-
- getMultiSelectOptions: function () {
-if (!this.props.hasSelectedItem) {
- return null;
-}
-
-return (
-
-);
- },
-
- getPopupContent: function () {
-return (
-
-
-
{this.props.dropdownContentText}
-
-
-);
- },
-
- selectAll: function () {
-this.refs.bulkActionPopover.hide();
-this.props.selectAll();
- },
-
- getOverlay: function () {
-return (
-
-{this.getPopupContent()}
-
-}>
-
-
-
-
-);
- },
-
- getMasterSelector: function () {
-return (
-
-
-{this.props.enableOverlay ? :
null}
-
[GitHub] couchdb-fauxton issue #798: break react components into individual files
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/798 wow very cool! there is a conflict --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #799: redux: delete unused store
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #800: Fix jump to dbs
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/800 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #799: redux: delete unused store
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/799 redux: delete unused store i was just about to convert our first module to redux, turns out it doesn't need a store right now. so i deleted the store. http://i.giphy.com/CaC7ohk9tvN4c.gif /> You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton redux-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/799.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #799 commit 52a474aef540ee7852a4abbab7f0b6764babff06 Author: Robert Kowalski <robertkowal...@apache.org> Date: 2016-11-02T15:11:35Z redux: delete unused store i was just about to convert our first module to redux, turns out it doesn't need a store right now. so i deleted the store. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #796: Create React Layout
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/796 +1 great stuff! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #796: Create React Layout
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/796#discussion_r86157432 --- Diff: app/addons/activetasks/layout.js --- @@ -0,0 +1,39 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may not --- End diff -- nope, just tought it would be a convention we had. its not super important --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #797: mango: shorten overflowing text in breadc...
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/797 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
