[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-439353685 @nickva Thanks! Sure, I shall allocate some time in order to update related documentation and submit a PR for it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437447396 @nickva Thanks! Indeed it was some sporadic fail. All is good now. Let me know if I need to address something else before this can be merged into `master`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5 failed for some odd reason. All other ones are successful. I've checked the logs and I do believe this error has nothing to do with my functionality. Perhaps some configs are wrong: ``` ERROR: One or more eunit tests failed. ERROR: eunit failed while processing /home/travis/build/apache/couchdb/src/couch: rebar_abort make[1]: *** [eunit] Error 1 make[1]: Leaving directory `/home/travis/build/apache/couchdb' make: *** [check] Error 2 The command "make check" exited with 2. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437410621 Valid point. `meck:unload()` has been incorporated. As for failing test this failure is due to the fact `Options` list which is passed to the `fabric_doc_open_revs:go()` has to contain `user_ctx`. Fixed as well. Reran `chttpd` tests locally: `All 232 tests passed.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437357434 Hello @nickva Once again thank you for a thorough review and your comments. I've addressed all the requested changes as well as fixed formatting style for the whole multipart case clause. All the commits squashed into one, and branch is rebased onto `master` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-373302168 Hi @janl , thank you for your advice to stick to the `couch_doc:doc_to_multi_part_stream()` and `couch_httpd_db:encode_multipart_stream()`. I realised that I wrote a lot of duplicated code :) I pushed a revised implementation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-373302168 Hi @janl , thank you for your advice to stick to the `couch_doc:doc_to_multi_part_stream()` and `couch_httpd_db:encode_multipart_stream()` functions. I realised that I wrote a lot of duplicated code :) I pushed a revised implementation. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-371879574 Hi @janl , Thanks for a good question. Long story short: I tried to re-use `couch_doc:doc_to_multi_part_stream()` but it didn?t work out for me, because content headers wasn?t encoded properly. Hence I decided to write a custom function instead of modifying/breaking existing functionality. Now I understand that this happened for the reason that I didn?t use (didn?t know about) `couch_httpd_db:encode_multipart_stream()` existence. Function name looks like exactly what I needed at that point of time. If you don?t mind I can try to reimplement this functionality using suggested function and test whether this will work with Sync Gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-371879574 Hi @janl , thanks for a good question. Long story short: I tried to re-use `couch_doc:doc_to_multi_part_stream()` but it didn?t work out for me, because content headers wasn?t encoded properly. Hence I decided to write a custom function instead of modifying/breaking existing functionality. Now I understand that this happened for the reason that I didn?t use (didn?t know about) `couch_httpd_db:encode_multipart_stream()` existence. Function name looks like exactly what I needed at that point of time. If you don?t mind I can try to reimplement this functionality using suggested function and test whether this will work with Sync Gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-371879574 Hi @janl , Thanks for a good question. Long story short: I tried to re-use couch_doc:doc_to_multi_part_stream() but it didn?t work out for me, because content headers wasn?t encoded properly. Hence I decided to write a custom function instead of modifying/breaking existing functionality. Now I understand that this happened for the reason that I didn?t use (didn?t know about) couch_httpd_db:encode_multipart_stream(). Function name looks like exactly what I needed at that point of time. If you don?t mind I can try to reimplement this functionality using suggested function and test whether this will work with Sync Gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-371879574 Hi @janl , Thanks for a good question. Long story short: I tried to re-use couch_doc:doc_to_multi_part_stream() but it wasn?t working, because content headers wasn?t encoded properly. Hence I decided to write a custom one based on rcouch instead of modifying/breaking existing functionality. Now I understand that this was because I didn?t use (didn?t know) about couch_httpd_db:encode_multipart_stream(). Function name looks like exactly what I needed at that point of time... Unfortunately I still have a superficial knowledge of full CouchDB codebase and its hidden gems. If you don?t mind I can try to reimplement this functionality using mentioned functions instead of mine and test whether this will work with Sync Gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
