[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437447396 @nickva Thanks! Indeed it was some intermittent failure. All is good now. Let me know if I need to address something else before this can be merged into `master`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5 failed for some odd reason. All other ones are successful as well as `chttpd` for the failed one. I've skimmed through the logs of this job and I do believe this error has nothing to do with my functionality. Perhaps some configs are wrong: ``` Failed: 0. Skipped: 0. Passed: 1004. One or more tests were cancelled. ERROR: One or more eunit tests failed. ERROR: eunit failed while processing /home/travis/build/apache/couchdb/src/couch: rebar_abort make[1]: *** [eunit] Error 1 make[1]: Leaving directory `/home/travis/build/apache/couchdb' make: *** [check] Error 2 The command "make check" exited with 2. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5 failed for some odd reason. All other ones are successful. I've skimmed through the logs of this job and I do believe this error has nothing to do with my functionality. Perhaps some configs are wrong: ``` Failed: 0. Skipped: 0. Passed: 1004. One or more tests were cancelled. ERROR: One or more eunit tests failed. ERROR: eunit failed while processing /home/travis/build/apache/couchdb/src/couch: rebar_abort make[1]: *** [eunit] Error 1 make[1]: Leaving directory `/home/travis/build/apache/couchdb' make: *** [check] Error 2 The command "make check" exited with 2. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5 failed for some odd reason. All other ones are successful. I've skimmed through the logs of this job and I do believe this error has nothing to do with my functionality. Perhaps some configs are wrong: ``` ERROR: One or more eunit tests failed. ERROR: eunit failed while processing /home/travis/build/apache/couchdb/src/couch: rebar_abort make[1]: *** [eunit] Error 1 make[1]: Leaving directory `/home/travis/build/apache/couchdb' make: *** [check] Error 2 The command "make check" exited with 2. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5 failed for some odd reason. All other ones are successful. I've checked the logs of this job and I do believe this error has nothing to do with my functionality. Perhaps some configs are wrong: ``` ERROR: One or more eunit tests failed. ERROR: eunit failed while processing /home/travis/build/apache/couchdb/src/couch: rebar_abort make[1]: *** [eunit] Error 1 make[1]: Leaving directory `/home/travis/build/apache/couchdb' make: *** [check] Error 2 The command "make check" exited with 2. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437410621 Valid point. `meck:unload()` has been incorporated. As for failed test this failure is due to the fact `Options` list which is passed to the `fabric_doc_open_revs:go()` has to contain `user_ctx`. Fixed as well. Reran `chttpd` tests locally: `All 232 tests passed.` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"
AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-405902159 Hi, is there a small chance this PR might be reviewed before the 2.2.0 release? It would be nice to have this functionality in the CouchDB 2.2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services