[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

[kxepal]

Github user kxepal commented on the pull request:

https://github.com/apache/couchdb-chttpd/pull/95#issuecomment-159392693
  
Nice! +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/couchdb-chttpd/pull/95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

[iilyak]

GitHub user iilyak opened a pull request:

https://github.com/apache/couchdb-chttpd/pull/95

Handle errors from before_request/after_request

This refactoring fixes the handling of errors from before_request.
Unify how we deal with errors among before_request and handle_request.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloudant/couchdb-chttpd 
support-raise-from-before-requests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-chttpd/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #95


commit 6a1858f8b2604c4af96b7ca4d423ebacd2f98603
Author: ILYA Khlopotov 
Date:   2015-11-18T16:25:39Z

Handle errors from before_request/after_request

This refactoring fixes the handling of errors from before_request.
Unify how we deal with errors among before_request and handle_request.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

[kxepal]

Github user kxepal commented on a diff in the pull request:

https://github.com/apache/couchdb-chttpd/pull/95#discussion_r45228610
  
--- Diff: src/chttpd.erl ---
@@ -209,21 +204,58 @@ handle_request_int(MochiReq) ->
 || Part <- string:tokens(Path, "/")]
 },
 
-{ok, HttpReq} = chttpd_plugin:before_request(HttpReq0),
+% put small token on heap to keep requests synced to backend calls
+erlang:put(nonce, Nonce),
+
+% suppress duplicate log
+erlang:put(dont_log_request, true),
+
+Result0 = case before_request(HttpReq0) of
+{ok, HttpReq1} ->
+process_request(HttpReq1);
+{error, Response} ->
+{HttpReq0, Response}
+end,
+
+{HttpReq3, HttpResp0} = result(Result0, HttpReq0),
--- End diff --

The way how we form Result0 and how result/2 works very confusing. 
Especially for the case when before_request returns {error, Response}, because 
Response have to be {ok, #httpd{}}  or {aborted, MochiReq, Reason} or you'll 
get function_clause.

Is it possible to make it more friendly for this refactor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-chttpd pull request: Handle errors from before_request/aft...

[kxepal]

Github user kxepal commented on the pull request:

https://github.com/apache/couchdb-chttpd/pull/95#issuecomment-157782803
  
Looks good for me, need to check however.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---