[GitHub] couchdb-fauxton pull request: make dbs deletable from db list

[benkeen]

Github user benkeen commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/632#issuecomment-178193329
  
Great stuff! I having checked shared DBs, but I assume it's not added there 
since the feature wouldn't be applicable. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: make dbs deletable from db list

[robertkowalski]

Github user robertkowalski commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/632#issuecomment-177756386
  
thanks, good catch!

it should be fixed now @benkeen 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: make dbs deletable from db list

[benkeen]

Github user benkeen commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/632#issuecomment-176873475
  
LOVE this improvement.

Small bug though. To reproduce:
1. delete a database via the new modal on the Databases page.
2. Create a new database via the Create Database header item, then click 
the `<` icon to return to the database list.

Result: you see the delete database modal again when you shouldn't.

Looks like the visibility state for the modal just isn't being cleared or 
something. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: make dbs deletable from db list

[justin-mcdavid-ibm]

Github user justin-mcdavid-ibm commented on the pull request:

https://github.com/apache/couchdb-fauxton/pull/632#issuecomment-176282608
  
I recommend increasing spacing between the buttons (10px would be better).

Change the text for the warning modal to:

Delete Database

Warning: This action will permanently delete the  database.

To confirm the deletion of the database and all of the database's 
documents, you must enter the database's name.


Otherwise, looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: make dbs deletable from db list

[robertkowalski]

GitHub user robertkowalski opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/632

make dbs deletable from db list

offer a modal for comfortable deletion from the database list.

additionally factor out `isSystemDatabase` and test it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/robertkowalski/couchdb-fauxton 
db-modal-db-list

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/632.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #632


commit 6fcc862447eec33819e824186031171d38d78ba0
Author: Robert Kowalski 
Date:   2016-01-26T17:24:09Z

make dbs deletable from db list

offer a modal for comfortable deletion from the database list.

additionally factor out `isSystemDatabase` and test it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---