[GitHub] couchdb-fauxton pull request #813: encodeding url path for database name wit...

2016-11-29 Thread timmak
Github user timmak closed the pull request at:

https://github.com/apache/couchdb-fauxton/pull/813


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #813: encodeding url path for database name wit...

2016-11-29 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/813#discussion_r89625412
  
--- Diff: app/addons/databases/tests/nightwatch/specialCharListLinks.js ---
@@ -18,16 +18,15 @@ const testDatabases = [
   't/t-//t_f'
 ];
 
-const tests = {};
-
-testDatabases.forEach((db) => {
-  return tests[`Db List works with special chars ${db}`] = createTest(db);
-});
+const tests = testDatabases.reduce((tests, db) => {
+  tests[`Db List works with special chars ${db}`] = createTest(db);
+  return tests;
+}, {});
--- End diff --

👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] couchdb-fauxton pull request #813: encodeding url path for database name wit...

2016-11-23 Thread timmak
GitHub user timmak opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/813

encodeding url path for database name with special characters

Should resolve https://issues.apache.org/jira/browse/COUCHDB-3146


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/timmak/couchdb-fauxton COUCHDB-3146

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/813.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #813


commit efbd95427581aa5a5102fda6a017f53ad0ddf932
Author: Tim Pinington 
Date:   2016-11-24T00:16:46Z

encodeding url path for database name with special characters




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---