[GitHub] garrensmith commented on a change in pull request #1060: Remove all uses of JQuery from the verifyinstall addon

[GitBox]

garrensmith commented on a change in pull request #1060: Remove all uses of 
JQuery from the verifyinstall addon
URL: https://github.com/apache/couchdb-fauxton/pull/1060#discussion_r173098145
 
 

 ##
 File path: app/addons/verifyinstall/resources.js
 ##
 @@ -47,7 +48,10 @@ Verifyinstall.testProcess = {
   },
 
   saveDB: function () {
-return db.save();
+return FauxtonAPI.when([
 
 Review comment:
   Could you use `Fauxton.Promise.all` instead of FauxtonAPI.when.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] garrensmith commented on a change in pull request #1060: Remove all uses of JQuery from the verifyinstall addon

[GitBox]

garrensmith commented on a change in pull request #1060: Remove all uses of 
JQuery from the verifyinstall addon
URL: https://github.com/apache/couchdb-fauxton/pull/1060#discussion_r173098222
 
 

 ##
 File path: app/addons/verifyinstall/resources.js
 ##
 @@ -77,16 +81,21 @@ Verifyinstall.testProcess = {
   },
 
   testView: function () {
-var deferred = FauxtonAPI.Deferred();
-var promise = $.get(viewDoc.url() + '/_view/testview');
+const deferred = FauxtonAPI.Deferred();
 
 Review comment:
   Could we use a promise instead of a Deferred


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services