[GitHub] nickva commented on a change in pull request #1639: Switch to python 3
nickva commented on a change in pull request #1639: Switch to python 3 URL: https://github.com/apache/couchdb/pull/1639#discussion_r236422203 ## File path: src/couch/test/fixtures/os_daemon_bad_perm.sh ## @@ -15,3 +15,7 @@ # Please do not make this file executable as that's the error being tested. sleep 5 + Review comment: I modified then reverted it but it left whitespace changes. Will fix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva commented on a change in pull request #1639: Switch to python 3
nickva commented on a change in pull request #1639: Switch to python 3 URL: https://github.com/apache/couchdb/pull/1639#discussion_r236409563 ## File path: src/mango/Makefile ## @@ -39,7 +39,7 @@ help: .PHONY: test # target: test - Runs test suite test: - nosetests + ./venv/bin/nosetests Review comment: @wohali I made mango tests use virtualenvs and delete the Makefile in src/mango This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva commented on a change in pull request #1639: Switch to python 3
nickva commented on a change in pull request #1639: Switch to python 3 URL: https://github.com/apache/couchdb/pull/1639#discussion_r234079719 ## File path: src/mango/Makefile ## @@ -39,7 +39,7 @@ help: .PHONY: test # target: test - Runs test suite test: - nosetests + ./venv/bin/nosetests Review comment: I'll try to make it use a venv and remove this Makefile altogether. This was probably more useful when mango was a separate repo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nickva commented on a change in pull request #1639: Switch to python 3
nickva commented on a change in pull request #1639: Switch to python 3 URL: https://github.com/apache/couchdb/pull/1639#discussion_r234079656 ## File path: README-DEV.rst ## @@ -70,14 +67,14 @@ Gentoo-based Systems sudo emerge gnupg coreutils pkgconfig help2man sphinx python sudo pip install hypothesis requests nose -RedHat-based (Fedora, Centos, RHEL) Systems -~~~ +Centos 7 and RHEL 7 +~~~ :: sudo yum install help2man python-sphinx python-docutils \ -python-pygments gnupg nodejs npm python-nose python-requests \ -python-hypothesis +python-pygments gnupg nodejs npm python34-pip python-virtualenv Review comment: Yeah that's why I think it would be good to move to venvs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
