[GitHub] nickva commented on issue #1682: Feature flags

2018-11-01 Thread GitBox 
nickva commented on issue #1682: Feature flags
URL: https://github.com/apache/couchdb/pull/1682#issuecomment-435056243
 
 
   @garrensmith I didn't review the PR contents in detail so as far as that I 
am +0 so if you reviewed and looks good, go ahead and merge. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva commented on issue #1682: Feature flags

2018-10-25 Thread GitBox 
nickva commented on issue #1682: Feature flags
URL: https://github.com/apache/couchdb/pull/1682#issuecomment-433209009
 
 
   Ah you're right. It was mostly a capabilities thing.  I just wanted to call 
it out in the PR so it's visible. As the old thing has the (confusing) 
"features" name.
   
   Maybe it would be good to replace the old thing with this?  The "config" 
capabilities thing was a quick adhock thing, this seems better designed.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nickva commented on issue #1682: Feature flags

2018-10-25 Thread GitBox 
nickva commented on issue #1682: Feature flags
URL: https://github.com/apache/couchdb/pull/1682#issuecomment-433082365
 
 
   FYI: There is already a similar config-based "features" feature 
implementation: 
   
   
https://github.com/apache/couchdb-config/commit/f62d553b337ce975edb0fb68772d22bdd3bf6490
   
   That's used by various components to indicated their presence and then those 
features are bubbled up to the top level API. 
   
   
https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd_misc.erl#L53
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services