[GitHub] wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup URL: https://github.com/apache/couchdb-documentation/pull/219#discussion_r175499567 ## File path: src/cluster/setup.rst ## @@ -163,9 +163,17 @@ then to add nodes by IP address. To get more nodes, go through the same install procedure on other machines. Be sure to specify the total number of nodes you expect to add to the cluster before adding nodes. -Before you can add nodes to form a cluster, you have to have them -listen on a public IP address and set up an admin user. Do this, once -per node: +Before you can add nodes to form a cluster, you must have them listening on an +IP address accessible from the other nodes in the cluster. +Do this once per node: + +In file etc/vm.args to -name couchdb@ for each node. +For clustered setup, each node in the system must have a unique name. Review comment: @raghavtan can you check this comment from @flimzy before I squash and merge? thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup URL: https://github.com/apache/couchdb-documentation/pull/219#discussion_r173535590 ## File path: src/cluster/setup.rst ## @@ -167,6 +167,10 @@ Before you can add nodes to form a cluster, you have to have them listen on a public IP address and set up an admin user. Do this, once per node: +Change line ``-name couchdb@127.0.0.1`` in file /Couch-Home/etc/vm.args on +each node for clustered setup, each node in system must have a unique name. +eg. ``-name couchdb@couch1`` | ``-name couchdb@couch2`` Review comment: The `couch1`, `couch2` hostnames must be fully qualified domain names (FQDNs) with valid DNS entries, see [the comment in vm.args](https://github.com/apache/couchdb/blob/master/rel/overlay/etc/vm.args#L13-L28) for more detail. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup URL: https://github.com/apache/couchdb-documentation/pull/219#discussion_r173535209 ## File path: src/cluster/setup.rst ## @@ -167,6 +167,10 @@ Before you can add nodes to form a cluster, you have to have them listen on a public IP address and set up an admin user. Do this, once per node: +Change line ``-name couchdb@127.0.0.1`` in file /Couch-Home/etc/vm.args on Review comment: Just specify the path here as `etc/vm.args`, please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
wohali commented on a change in pull request #219: Fix _cluster_setup api |
couchdb node name changes | verify cluster setup
URL:
https://github.com/apache/couchdb-documentation/pull/219#discussion_r173536483
##
File path: src/cluster/setup.rst
##
@@ -211,12 +215,11 @@ requires all other nodes to be able to see it and vice
versa.
Set up will not work with unavailable nodes.
The notion of "setup coordination node" will be gone once the setup is
finished.
From then on, the cluster will no longer have a "setup coordination node".
-To add a node run these two commands:
+To add a node run this commands for each node you want to add:
.. code-block:: bash
-curl -X POST -H "Content-Type: application/json"
http://admin:password@127.0.0.1:5984/_cluster_setup -d '{"action":
"enable_cluster", "bind_address":"0.0.0.0", "username": "admin",
"password":"password", "port": 15984, "node_count": "3", "remote_node":
"", "remote_current_user": "",
"remote_current_password": "" }'
-curl -X POST -H "Content-Type: application/json"
http://admin:password@127.0.0.1:5984/_cluster_setup -d '{"action": "add_node",
"host":"", "port": "", "username": "admin",
"password":"password"}'
+curl -X POST -H "Content-Type: application/json"
http://admin:password@127.0.0.1:5984/_cluster_setup -d '{"action": "add_node",
"host":"", "port": , "username": "admin",
"password":"password"}'
Review comment:
You're also missing a quote mark here. The original line was correct.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
wohali commented on a change in pull request #219: Fix _cluster_setup api |
couchdb node name changes | verify cluster setup
URL:
https://github.com/apache/couchdb-documentation/pull/219#discussion_r173536538
##
File path: src/cluster/setup.rst
##
@@ -227,6 +230,39 @@ following command to complete the setup and add the
missing databases:
curl -X POST -H "Content-Type: application/json"
http://admin:password@127.0.0.1:5984/_cluster_setup -d '{"action":
"finish_cluster"}'
+Verify install:
+
+.. code-block:: bash
+
+curl http://admin:password@127.0.0.1:5984/_cluster_setup
+
+Response:
+
+.. code-block:: bash
+
+{"state":"cluster_finished"}
+
+Verify cluster nodes:
+
+.. code-block:: bash
+
+curl http://admin:password@127.0.0.1:5984/_membership
+
+Response:
+
+.. code-block:: bash
+
+{
+"all_nodes": [
+"couchdb@couch1",
+"couchdb@couch2",
+],
+"cluster_nodes": [
+"couchdb@couch1",
+"couchdb@couch2",
+]
+}
+
Review comment:
This is a useful thing to add, thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wohali commented on a change in pull request #219: Fix _cluster_setup api | couchdb node name changes | verify cluster setup
wohali commented on a change in pull request #219: Fix _cluster_setup api |
couchdb node name changes | verify cluster setup
URL:
https://github.com/apache/couchdb-documentation/pull/219#discussion_r173536379
##
File path: src/cluster/setup.rst
##
@@ -211,12 +215,11 @@ requires all other nodes to be able to see it and vice
versa.
Set up will not work with unavailable nodes.
The notion of "setup coordination node" will be gone once the setup is
finished.
From then on, the cluster will no longer have a "setup coordination node".
-To add a node run these two commands:
+To add a node run this commands for each node you want to add:
.. code-block:: bash
-curl -X POST -H "Content-Type: application/json"
http://admin:password@127.0.0.1:5984/_cluster_setup -d '{"action":
"enable_cluster", "bind_address":"0.0.0.0", "username": "admin",
"password":"password", "port": 15984, "node_count": "3", "remote_node":
"", "remote_current_user": "",
"remote_current_password": "" }'
Review comment:
No, actually, you need this first statement too. This sets the bind address,
bind port, admin username and admin password on the remote node. The node_count
parameter is also critical.
You can see a test cluster being set up in the test case for the
`couch_setup` application
[here](https://github.com/apache/couchdb-setup/blob/master/test/t-frontend-setup.sh)
and [here](https://github.com/apache/couchdb-setup/blob/master/test/t.sh).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
