[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928151#comment-15928151
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
@sergey-safarov I will take a look next week. The PR has quite wide 
reaching effects. So I need to take a look at it. Leave it as is for now.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928146#comment-15928146
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
@garrensmith I updated PR but exist two issues:
1) tests is looped
2) two tests is failed.

I can revert back last changes.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927954#comment-15927954
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/802#discussion_r106408017
  
--- Diff: app/addons/databases/actions.js ---
@@ -155,7 +155,7 @@ export default {
   type: 'success',
   clear: true
 });
-var route = FauxtonAPI.urls('allDocs', 'app', 
app.utils.safeURLName(databaseName), '?limit=' + Resources.DocLimit);
+var route = FauxtonAPI.urls('allDocs', 'app', 
encodeURIComponent(databaseName), '?limit=' + Resources.DocLimit);
--- End diff --

Could you rather use this function 
https://github.com/apache/couchdb-fauxton/blob/master/app/addons/documents/base.js#L40
 and then you don't need to encodeURIComponent


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927953#comment-15927953
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/802#discussion_r106408073
  
--- Diff: app/addons/databases/actions.js ---
@@ -176,7 +176,7 @@ export default {
 
 databaseName = databaseName.trim();
 
-const url = FauxtonAPI.urls('allDocs', 'app', 
app.utils.safeURLName(databaseName), '');
+const url = FauxtonAPI.urls('allDocs', 'app', 
encodeURIComponent(databaseName), '');
--- End diff --

Same as aboce it seems its better to use `allDocsSantized` then you don't 
need to encodeURIComponent


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927946#comment-15927946
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
@sergey-safarov seems it was a travis issue. Could you fix the lint issues 
and try again.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926942#comment-15926942
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
Hello @garrensmith 
Could you look error present in build log.
Think some dependency cannot be installed.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896575#comment-15896575
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
Is may be removed "safeURLName" function from app.utils?

View name displaying is fixed view not work properly. I not know how to fix.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896574#comment-15896574
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/802#discussion_r104326088
  
--- Diff: app/addons/documents/index-editor/stores.js ---
@@ -186,7 +186,7 @@ Stores.IndexEditorStore = FauxtonAPI.Store.extend({
   getSaveDesignDoc: function () {
 if (this._designDocId === 'new-doc') {
   var doc = {
-_id: '_design/' + this._newDesignDocName,
+_id: '_design/' + encodeURIComponent(this._newDesignDocName),
--- End diff --

Is may be removed "safeURLName" function from app.utils?


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896571#comment-15896571
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/802#discussion_r104326008
  
--- Diff: app/addons/documents/components/jumptodoc.react.jsx ---
@@ -28,7 +28,7 @@ const JumpToDoc = ({database, loadOptions}) => {
 ignoreCase={false}
 cache={false}
 onChange={({value: docId}) => {
-  const url = FauxtonAPI.urls('document', 'app', 
encodeURIComponent(database.id), app.utils.safeURLName(docId));
+  const url = FauxtonAPI.urls('document', 'app', 
encodeURIComponent(database.id), encodeURIComponent(docId));
--- End diff --

Is may be removed "safeURLName" function from app.utils?


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896567#comment-15896567
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/802#discussion_r104325765
  
--- Diff: app/addons/documents/index-editor/stores.js ---
@@ -186,7 +186,7 @@ Stores.IndexEditorStore = FauxtonAPI.Store.extend({
   getSaveDesignDoc: function () {
 if (this._designDocId === 'new-doc') {
   var doc = {
-_id: '_design/' + this._newDesignDocName,
+_id: '_design/' + encodeURIComponent(this._newDesignDocName),
--- End diff --

Here is encoded DesignDoc name in POST request to CouchDB
Where is may be encoded viewname in  POST request to CouchDB?


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886206#comment-15886206
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on a diff in the pull request:

https://github.com/apache/couchdb-fauxton/pull/802#discussion_r103267380
  
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -227,7 +227,7 @@ var AttachmentsPanelButton = React.createClass({
 var doc = this.props.doc.get('_id');
 
 return _.map(this.props.doc.get('_attachments'), function (item, 
filename) {
-  var url = FauxtonAPI.urls('document', 'attachment', db, doc, 
app.utils.safeURLName(filename));
+  var url = FauxtonAPI.urls('document', 'attachment', 
encodeURIComponent(db), doc, app.utils.safeURLName(filename));
--- End diff --

Could you remove `safeURLName` we don't need it if we use the 
encodeURIComponent.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886096#comment-15886096
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
@garrensmith I update pull request.

Please look at replication dialog. Generated POST with content

{"user_ctx":{"name":null,"roles":["_admin","_reader","_writer"]},"source":{"headers":{},"url":"http://217.12.247.220:5984/account%2F9b%2F44%2F9289fc701376b87ac2ad5ee78571"},"target":{"headers":{},"url":"http://217.12.247.220:5984/asdfsad"},"create_target":true,"continuous":false}

But replication is failed. This is CouchDB  issue?


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886038#comment-15886038
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
Pull request is updated.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885984#comment-15885984
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
Thanks for testing, would you be able to make a fix for the bug you found?

All misspelling thanks to my iPhone.




On Mon, Feb 27, 2017 at 5:31 PM +0200, "sergey-safarov" 
 wrote:












@garrensmith thank you for update

I tested current fauxton master all fine except one "Cancel" button.

To reproduce required start editing of view or create new view and press 
cancel.



—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


  
  












> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885956#comment-15885956
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
@garrensmith thank you for update
I tested current fauxton master all fine except one "Cancel" button.
To reproduce required start editing of view or create new view and press 
cancel.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853961#comment-15853961
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
@sergey-safarov thanks for trying to help us with this. We have decided to 
rather solve this with `encodeURIComponent`. I've just merged a PR that should 
fix the view section. 

Unfortunately we won't need this PR. But it would be great if you could 
test fauxton master and make sure we have now fixed all the encoding issues.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15667555#comment-15667555
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user robertkowalski commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
@sergey-safarov the PR looks good, it will be superseeded by 
https://github.com/apache/couchdb-fauxton/pull/807 which contains more fixes 
and changes our integration tests to default to database names with special 
chars.

your commit will land seperately together with the other commits :)


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657257#comment-15657257
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user robertkowalski commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
hey, thank you for your contribution -- i was on vacation, i'll check next 
week!


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644039#comment-15644039
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
Ok. @robertkowalski needs to review this before we can merge.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15644030#comment-15644030
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
About test cases. I can make hotfix but test case creation is to complex 
task for me.


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643865#comment-15643865
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user sergey-safarov commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
Hello @garrensmith error is fixed


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643478#comment-15643478
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

Github user garrensmith commented on the issue:

https://github.com/apache/couchdb-fauxton/pull/802
  
Thanks @sergey-safarov this is great. The tests are failing. Could you see 
why. And could you maybe add a test or two to prove this improves and fixes the 
`/` issues


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[Sergey Safarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641539#comment-15641539
 ] 

Sergey Safarov commented on COUCHDB-3224:
-

create PR 802 - fixed view displaying for databases with "/" symbols in 
database name
https://github.com/apache/couchdb-fauxton/pull/802


> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641526#comment-15641526
 ] 

ASF GitHub Bot commented on COUCHDB-3224:
-

GitHub user sergey-safarov opened a pull request:

https://github.com/apache/couchdb-fauxton/pull/802

COUCHDB-3224: Fixed view displaying for database with "/" symbols in name



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sergey-safarov/couchdb-fauxton COUCHDB-3224

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/couchdb-fauxton/pull/802.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #802


commit 9d5d8d335d6dc0b9faeb3db8f1052a66aaaf3331
Author: Sergey Safarov 
Date:   2016-11-06T10:04:42Z

COUCHDB-3224: Fixed view displaying for database with "/" symbols in name




> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (COUCHDB-3224) Fauxton not correctly display database with "-" and "/" symbol in name

[Sergey Safarov (JIRA)]

[ 
https://issues.apache.org/jira/browse/COUCHDB-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641519#comment-15641519
 ] 

Sergey Safarov commented on COUCHDB-3224:
-

This issue is partially resolved in commit 
"ef1ecc8b16c8e7e20228138a6384af21800bbe4f" but CouchDB rebar file is use old 
fauxton verion
https://github.com/apache/couchdb/blob/master/rebar.config.script#L45 and error 
is still exists.

 

> Fauxton not correctly display database with "-" and "/" symbol in name
> --
>
> Key: COUCHDB-3224
> URL: https://issues.apache.org/jira/browse/COUCHDB-3224
> Project: CouchDB
>  Issue Type: Bug
>  Components: Fauxton
>Reporter: Sergey Safarov
>
> Fauxton cannot display database with "-" symbol in name and cannot display 
> view with "/" simbol in database name.
> Tu reproduce execute "curl -X PUT 
> http://127.0.0.1:5984/mytest%2Fdata%2Fbase-201609; ant try open this database 
> via fauxton.
> Also if you create view for this database then this view wont work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)