[GitHub] [couchdb-docker] lag-linaro commented on issue #85: Provide and publish arm64 images

2019-08-28 Thread GitBox
lag-linaro commented on issue #85: Provide and publish arm64 images
URL: https://github.com/apache/couchdb-docker/issues/85#issuecomment-525621431
 
 
   > Can anyone give it a go?
   
   I'd be happy to try, but I'd need instruction.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-docker] willholley commented on a change in pull request #151: allow running as arbitrary uid

2019-08-28 Thread GitBox
willholley commented on a change in pull request #151: allow running as 
arbitrary uid
URL: https://github.com/apache/couchdb-docker/pull/151#discussion_r318467202
 
 

 ##
 File path: 2.3.1/Dockerfile
 ##
 @@ -121,8 +121,17 @@ COPY docker-entrypoint.sh /usr/local/bin
 RUN ln -s usr/local/bin/docker-entrypoint.sh /docker-entrypoint.sh # backwards 
compat
 ENTRYPOINT ["tini", "--", "/docker-entrypoint.sh"]
 
-# Setup directories and permissions
-RUN find /opt/couchdb \! \( -user couchdb -group couchdb \) -exec chown -f 
couchdb:couchdb '{}' +
+
+RUN set -xe; \
+# Check we own everything in /opt/couchdb. Matches the command in 
dockerfile_entrypoint.sh
+find /opt/couchdb \! \( -user couchdb -group couchdb \) -exec chown -f 
couchdb:couchdb '{}' +; \
+# Setup directories and permissions for config. Technically these could be 555 
and 444 respectively
+# but we keep them as 755 and 644 for consistency with CouchDB defaults and 
the dockerfile_entrypoint.sh.
+find /opt/couchdb/etc -type d ! -perm 0755 -exec chmod -f 0755 '{}' +; \
+find /opt/couchdb/etc -type f ! -perm 0644 -exec chmod -f 0644 '{}' +; \
+# only local.d needs to be writable for the docker_entrypoint.sh
+chmod -f 0777 /opt/couchdb/etc/local.d
 
 Review comment:
   ok - suggested change has been pushed


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] big-r81 opened a new issue #2151: The startup script couchdb doesn't follow symlinks

2019-08-28 Thread GitBox
big-r81 opened a new issue #2151: The startup script couchdb doesn't follow 
symlinks
URL: https://github.com/apache/couchdb/issues/2151
 
 
   ## Description
   
   If the startup script is symlinked (e.g ` /usr/local/bin/couchdb -> 
../path/to/couchdb/2.3.1/bin/couchdb`), then CouchDB will fail to start. It 
doesn't matter if the symlink is an absolute or a relative link.
   
   ## Steps to Reproduce
   
   `./configure`
   `make release`
   `ln -s /path/to/couchdb/rel/couchdb/bin/couchdb /usr/local/bin/couchdb`
   
   `test@debian:~$ couchdb`
   `cat: /usr/local/bin/../releases/start_erl.data: No such file or directory
   /usr/local/bin/couchdb: 46: exec: /usr/local/bin/../erts-/bin/erlexec: not 
found`
   
   ## Expected Behaviour
   
   CouchDB should start from a symlink.
   
   ## Your Environment
   
   - macOS 10.13.6
   - Debian 10
   
   * CouchDB Version used: 2.3.1
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] sarveshtamba commented on issue #2127: Fix for CompactTest failure

2019-08-28 Thread GitBox
sarveshtamba commented on issue #2127: Fix for CompactTest failure
URL: https://github.com/apache/couchdb/pull/2127#issuecomment-525684289
 
 
   > @sansato I'd say `info["sizes.active"]` is the best option here, it's a 
size of "live" data in bytes, so it should go down when doc deleted and db then 
compacted.
   > 
   > But I agree with @iilyak, the fact that in your trace finale data and disk 
sizes bigger than the originals indicates that compaction not finished at the 
time of final test assertion, i.e. it's not the question of _what_ to compare, 
but more of a question _when_ to compare.
   
   @iilyak @eiri @sansato I have run this compaction test with increased 
timeouts of  ms (~27 hours), yet the compaction doesn't complete and 
the test fails/times out.
   
   > I appreciate it's not a simple task, sizes calculation, especially in 
combination with compaction is convoluted, so maybe someone more proficient 
than me in elixir suite can disable this test for time being and we'll get back 
to it in version 3.x
   
   @eiri I agree with you on this, I myself am quite new to 
couchdb/elixir/erlang and it was a challenging task, though I could figure 
above details with the limited amount of knowledge I could gather.
   Could we somehow disable this test for now and revisit it later, so that we 
can build the entire couchdb & the test suites off top of the tree/latest 
master branch without having to make any changes at the users end?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] big-r81 opened a new pull request #2152: Fixes #2151 - start CouchDB from symlinks

2019-08-28 Thread GitBox
big-r81 opened a new pull request #2152: Fixes #2151 - start CouchDB from 
symlinks
URL: https://github.com/apache/couchdb/pull/2152
 
 
   
   
   ## Overview
   
   Fixes #2151 
   CouchDB should start from symlinks.
   
   ## Testing recommendations
   
   `./configure`
   `make release`
   `ln -s /path/to/couchdb/rel/couchdb/couchdb /usr/local/bin/couchdb`
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in 
`rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in 
https://github.com/apache/couchdb-documentation
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] wohali commented on issue #2150: Request to make the database explorer side panel re-sizable to show the long view names

2019-08-28 Thread GitBox
wohali commented on issue #2150: Request to make the database explorer side 
panel re-sizable to show the long view names
URL: https://github.com/apache/couchdb/issues/2150#issuecomment-525854741
 
 
   This is a Fauxton issue - I'll move the issue for you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-fauxton] wohali opened a new issue #1219: Make side panel resizeable

2019-08-28 Thread GitBox
wohali opened a new issue #1219: Make side panel resizeable
URL: https://github.com/apache/couchdb-fauxton/issues/1219
 
 
   Comes from https://github.com/apache/couchdb/issues/2150
   
   -
   
   ## Summary
   Request to make the database explorer side panel re-sizable to show the long 
view names.
   
   ## Desired Behaviour
   To display full long view names on the database explorer side panel.
   
   ## Possible Solution
   Make the database explorer side panel re-sizable so that user can see the 
entire view names, especially for the scenario when view names are very long.
   
   Refer the screenshot:
   
![image](https://user-images.githubusercontent.com/25045937/63822748-761e6100-c9a5-11e9-9edf-3d7640d28fa2.png)
   
   
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] wohali closed issue #2150: Request to make the database explorer side panel re-sizable to show the long view names

2019-08-28 Thread GitBox
wohali closed issue #2150: Request to make the database explorer side panel 
re-sizable to show the long view names
URL: https://github.com/apache/couchdb/issues/2150
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-documentation] wohali merged pull request #434: Improve UNIX binary install even more

2019-08-28 Thread GitBox
wohali merged pull request #434: Improve UNIX binary install even more
URL: https://github.com/apache/couchdb-documentation/pull/434
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-fauxton] iamgollum commented on issue #1219: Make side panel resizeable

2019-08-28 Thread GitBox
iamgollum commented on issue #1219: Make side panel resizeable
URL: 
https://github.com/apache/couchdb-fauxton/issues/1219#issuecomment-525889270
 
 
   @wohali I can take a crack at it, if no one is working on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] eiri commented on issue #2149: Handle badmatch timeout in all_docs query

2019-08-28 Thread GitBox
eiri commented on issue #2149: Handle badmatch timeout in all_docs query
URL: https://github.com/apache/couchdb/pull/2149#issuecomment-525944926
 
 
   Found it, finally! Both my change and my theory on incorrectly set 
`update_seq` turned out to be red herrings, becuase I should've been checking 
line 105 in source [at time of 2.3 
release](https://github.com/apache/couchdb/blob/99825820d12d992c30caad007de3942761bf457e/src/fabric/src/fabric_view_all_docs.erl#L105)
   
   It's pretty straight forward case where in query for `_all_docs` with keys 
array, `doc_receive_loop` timing out and returns `timeout` atom to clash with 
expected `{ok, Acc}`.
   
   PR with patch shortly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] eiri opened a new pull request #2153: Fix badmatch in fabric_view_all_docs

2019-08-28 Thread GitBox
eiri opened a new pull request #2153: Fix badmatch in fabric_view_all_docs
URL: https://github.com/apache/couchdb/pull/2153
 
 
   ## Overview
   
   In query for `all_docs` with passed `keys` array it is possible for 
`doc_receive_loop/6` to timeout and trigger `badmatch` exception.
   
   The fix changes code to accept `timeout` as a possible response and passes 
it to Callback to process.
   
   ## Testing recommendations
   
   It's kind of hard to induce timeout on that all_docs read without actual 
code tweaking, so base tests just need to pass.
   
   ## Related Issues or Pull Requests
   
   Described in #2149 
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in 
`rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in 
https://github.com/apache/couchdb-documentation


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-fauxton] wohali commented on issue #1219: Make side panel resizeable

2019-08-28 Thread GitBox
wohali commented on issue #1219: Make side panel resizeable
URL: 
https://github.com/apache/couchdb-fauxton/issues/1219#issuecomment-525908468
 
 
   @iamgollum Sure!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-fauxton] iamgollum edited a comment on issue #1219: Make side panel resizeable

2019-08-28 Thread GitBox
iamgollum edited a comment on issue #1219: Make side panel resizeable
URL: 
https://github.com/apache/couchdb-fauxton/issues/1219#issuecomment-525889270
 
 
   @wohali I can take a crack at it later today, if no one else is working on 
it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb] eiri merged pull request #2153: Fix badmatch in fabric_view_all_docs

2019-08-28 Thread GitBox
eiri merged pull request #2153: Fix badmatch in fabric_view_all_docs
URL: https://github.com/apache/couchdb/pull/2153
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-documentation] gr2m commented on a change in pull request #424: rfc(per-doc-access): first draft

2019-08-28 Thread GitBox
gr2m commented on a change in pull request #424: rfc(per-doc-access): first 
draft
URL: 
https://github.com/apache/couchdb-documentation/pull/424#discussion_r318869425
 
 

 ##
 File path: rfcs/010-per-document-access-control.md
 ##
 @@ -0,0 +1,418 @@
+---
+name: Per-Document Access Control
+about: Make the db-per-user pattern obsolete.
+title: 'Per-Document Access Control'
+labels: rfc, discussion, access control, security
+assignees: '@janl'
+
+---
+
+# Introduction
+
+Up until now (version 2.3.1), CouchDB could not serve mutually
+untrusting users accessing the same database. If a user has access to
+one document in a database, they have access to all other documents in
+the database. Some restrictions can be added about writing documents
+(designs docs are db-admin only, validate doc update (VDU) functions
+could restrict write access based on the writing user and/or the target
+document). For the remainder of this document, “db-admin” SHALL include
+server admins as well.
+
+## Abstract
+
+This led to CouchDB developers making use of a pattern called
+db-per-user, where all documents belonging to one user are kept in a
+separate database. This is a decent enough workaround, but has the
+following downsides:
+
+- queries across all databases are not possible. An additional
+  workaround exists where all per-user databases are replicated
+  continuously into a central, admin-only database that can be used for
+  querying the entire data set, but that adds latency and uses
+  significant CPU resources. Successful systems have been built where
+  increased latency could be traded for fewer CPU resources, but
+  overall, this is not an optimal design.
+
+- handling many small databases, say >1 (depending on hardware) can
+  become a challenge, if most of them are active concurrently. It
+  forces dbs to be set to `q=1`, migrating off `q!=1` requires
+  downtime, 10k bidirectional replications are going to need A LOT of
+  CPU and RAM. sharing documents among two or more users requires the
+  creation of yet more databases.
+
+Per-user document access aims to solve many of the above problems.
+Predominantly, that multiple users can use a single database without
+being able to see each other’s documents. A first iteration is not
+going to solve sharing of documents across multiple users and/or groups.
+
+Goals for this iteration of this feature:
+
+* allow developers to build apps wihtout having to resort to using the
+  db-per-user pattern. Specifically PouchDB applications and CouchDB
+  setups with a central server/cluster and many independent satellite
+  installations with replication should be supported.
+
+Non-goals for now:
+
+* per-access views
+* differentiation between read and write access for documents
+* sharing individual documents between multiple users or groups.
+
+However, the design of this iteration aims to allow turning these
+non-goals into actual goals later.
+
+## Dramatis Personae
+
+*user*: a CouchDB-user, a record defined in the _users db identified by
+a username and password, has associated roles.
+
+*developer*: creator of an application built on top of CouchDB
+
+## Requirements Language
+
+[NOTE]: # ( Do not alter the section below. Follow its instructions. )
+
+The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT",
+"SHOULD", "SHOULD NOT", "RECOMMENDED",  "MAY", and "OPTIONAL" in this
+document are to be interpreted as described in
+[RFC 2119](https://www.rfc-editor.org/rfc/rfc2119.txt).
+
+---
+
+# Detailed Description
+
+You will be able to create databases with the “access” feature enabled
+via an option passed at database creation time. If you create a
+database without that option, it works like any database in CouchDB
+today.
+
+This is how you create an access-enabled database:
+
+```
+PUT /database?access=true
+```
+
+This option can be set only at database creation time, it can’t be
+turned off and on while the database exists.
+
+An access-enabled database behaves like this:
+
+* only admin users can read or write to the database (as per 3.x
+  defaults)
+
+* admins can grant individual users and groups access to a database
+  using the database’s `_security` object. A special new role `_users`
+  can be used to say “all users defined in the `_users` database”.
+
+* documents created without an `_access` field are accessible to
+  db-admins only
+
+   * this allows existing databases to be replicated into an
+ access-enabled database, but granting access of individual docs to
+ specific users needs to be an explicit step handled by developers.
+
+* documents created with an `_access` field are only accessible by
+  admins and the user named inside `_access`.
+
+   * `_access: ["shirley"]`
+
+  * later iterations of this could allow for `["shirley"]` being
+shorthand for `[{"read": "shirley", "write": "shirley"}]` for
+more fine-grained access control, but that is out of scope for
+this RFC.
+
+   

[GitHub] [couchdb] iamgollum commented on issue #2150: Request to make the database explorer side panel re-sizable to show the long view names

2019-08-28 Thread GitBox
iamgollum commented on issue #2150: Request to make the database explorer side 
panel re-sizable to show the long view names
URL: https://github.com/apache/couchdb/issues/2150#issuecomment-526005030
 
 
   @nsthakur7 which browser and version are you using? Microsoft Edge?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-fauxton] iamgollum commented on issue #1219: Make side panel resizeable

2019-08-28 Thread GitBox
iamgollum commented on issue #1219: Make side panel resizeable
URL: 
https://github.com/apache/couchdb-fauxton/issues/1219#issuecomment-526005185
 
 
   @wohali This appears to be fixed in the latest version of the project. 
   It is possible this is a browser specific issue. I contacted the original 
author to ask him the browser and the version. I am using chrome latest and it 
looks fine:
   
   https://user-images.githubusercontent.com/1408766/63907877-1185f500-c9eb-11e9-9756-4e42c540bfed.png;>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-fauxton] iamgollum opened a new issue #1220: Consider applying title attributes on icons for built in tooltips as its hard to tell what some icons do

2019-08-28 Thread GitBox
iamgollum opened a new issue #1220: Consider applying title attributes on icons 
for built in tooltips as its hard to tell what some icons do
URL: https://github.com/apache/couchdb-fauxton/issues/1220
 
 
   Title attributes will trigger a tooltip on hover:
   
   [W3 
Schools](https://www.w3schools.com/html/tryit.asp?filename=tryhtml_attributes_title)
   
   All icons seem to not have any identification on what they mean. No 
millennial or generation z-er will know all the icon stereotypes - 
unfortunately. 
   
   https://user-images.githubusercontent.com/1408766/63906789-282a4d00-c9e7-11e9-926d-102dffa85ccd.png;>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [couchdb-fauxton] wohali commented on issue #1219: Make side panel resizeable

2019-08-28 Thread GitBox
wohali commented on issue #1219: Make side panel resizeable
URL: 
https://github.com/apache/couchdb-fauxton/issues/1219#issuecomment-526006115
 
 
   @iamgollum Data point: it doesn't work for me on latest Firefox against the 
2.3.1 build of CouchDB on Windows.
   
   I can try other builds tomorrow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services